1. 23 Nov, 2015 40 commits
    • halliwell's avatar
      Fix flags for Chromecast browser test on internal infrastructure · 146527ab
      halliwell authored
      The media playback test was recently added:
      https://codereview.chromium.org/1431193005/
      
      and requires specific switches:
      * local file access required to load test media
      * cma pipeline explicitly enabled in order to test that
      * cast ozone platform enabled in order to test overlay frames
      
      These tests have been failing on internal infrastructure (tot build)
      because the switches were only configured in testing/buildbot (for
      running on Chromium bots).
      
      BUG=
      
      Review URL: https://codereview.chromium.org/1466633004
      
      Cr-Commit-Position: refs/heads/master@{#361134}
      146527ab
    • bshe's avatar
      Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now · b21a4e02
      bshe authored
      BUG=557285
      
      Review URL: https://codereview.chromium.org/1465953003
      
      Cr-Commit-Position: refs/heads/master@{#361133}
      b21a4e02
    • pkotwicz's avatar
      Refactor FaviconDriver::OnFaviconAvailable() · 7e8e8932
      pkotwicz authored
      This CL:
      - Removes weird OnFaviconAvailable() behavior if gfx::Image is empty.
      - Merges: FaviconDriver::SetActiveFaviconValidity()
                FaviconDriver::SetActiveFaviconURL()
                FaviconDriver::SetActiveFaviconImage()
      - Merges FaviconDriverObserver::OnFaviconAvailable() and
               FaviconDriverObserver::OnFaviconUpdated().
      
      BUG=542057
      
      Review URL: https://codereview.chromium.org/1407353012
      
      Cr-Commit-Position: refs/heads/master@{#361132}
      7e8e8932
    • sdefresne's avatar
      Provider API for UpdatableConfig. · e102ab8c
      sdefresne authored
      BUG=475442
      
      Review URL: https://codereview.chromium.org/1471783002
      
      Cr-Commit-Position: refs/heads/master@{#361131}
      e102ab8c
    • mef's avatar
      [Cronet] Continue UrlRequest with NULL certificate if Client cert is requested. · abc0bae3
      mef authored
      TEST=CronetUrlRequestTest.testMockClientCertificateRequested
      BUG=558420
      
      Review URL: https://codereview.chromium.org/1459993003
      
      Cr-Commit-Position: refs/heads/master@{#361130}
      abc0bae3
    • sbc's avatar
      Update linux sysroot image · 24634402
      sbc authored
      This adds libffi-dev and libdrm-dev to the image
      which were recently added with:
      https://codereview.chromium.org/1464123002
      
      R=thestig@chromium.org
      BUG=559062
      
      Review URL: https://codereview.chromium.org/1466383002
      
      Cr-Commit-Position: refs/heads/master@{#361129}
      24634402
    • fs's avatar
      SVGPath object "mutability" cleanup · 3bb121da
      fs authored
      Move addToSVGPathByteStream to SVGPath.cpp (the only place using it),
      rename it to addPathByteStreams. Move the "regular" blending out into a
      helper(blendPathByteStreams), and eliminate the redundant copy. Make the
      functions more "functional" (return the result.)
      
      Add a (private) setter for byte-stream data and use that to ensure
      invalidation of the cached path. Also add an SVGPath::create(...)
      accepting a SVGPathByteStream and use that in PathSVGInterpolation.
      
      Inline mutableByteStream into the remaining user.
      
      Review URL: https://codereview.chromium.org/1460253002
      
      Cr-Commit-Position: refs/heads/master@{#361128}
      3bb121da
    • mark's avatar
      Sign Mac diff patcher tools: goobspatch, xzdec, liblzma_decompress.dylib · 72ee18e7
      mark authored
      BUG=559322
      
      Review URL: https://codereview.chromium.org/1470503002
      
      Cr-Commit-Position: refs/heads/master@{#361127}
      72ee18e7
    • ssid's avatar
      Fix regression in memory-infra bots due to change in dump order · ef89c2a5
      ssid authored
      crrev.com/1427963002 introduced a new memory-infra thread which runs
      after all dump providers are finished. This measures the process total
      memory usages. This was previously running at the start of a memory
      dump. This means that the memory used while taking memory dump of other
      providers will be included in the totals now and this metric has
      regressed. This CL is a temporary change that reverts this behaviour so
      that the perf bots are happy. Better fix for the problem will follow up
      soon.
      
      BUG=555584
      
      Review URL: https://codereview.chromium.org/1466293002
      
      Cr-Commit-Position: refs/heads/master@{#361126}
      ef89c2a5
    • bungeman's avatar
      Remove SkFontConfigInterface race suppression. · a8c01b56
      bungeman authored
      The race was fixed with https://codereview.chromium.org/355573006 ,
      committed as
      https://skia.googlesource.com/skia/+/e438ddbc7451ec80f953266409fea4695e78c8c2
      
      This is effectively a revert of https://codereview.chromium.org/273523002 .
      
      BUG=chromium:369257
      
      Review URL: https://codereview.chromium.org/1467313002
      
      Cr-Commit-Position: refs/heads/master@{#361125}
      a8c01b56
    • xidachen's avatar
      Reland of: Make Imagebitmap Transferable · 33126b69
      xidachen authored
      This CL including a layout test that does 2 things:
      1. transfer an ImageBitmap to the worker and let worker transfer back to
         main, the main thread exam the transfered-back ImageBitmap to make
         sure the data is the same as the original ImageBitmap.
      2. When worker receives the ImageBitmap from main, worker calls
         createImageBitmap() to create a new ImageBitmap and send it back to
         main
      
      BUG=532142
      
      Review URL: https://codereview.chromium.org/1423513005
      
      Cr-Commit-Position: refs/heads/master@{#361124}
      33126b69
    • rune's avatar
      Remove extraneous SubtreeStyleChange for min/maxlength changes. · 81fb8abc
      rune authored
      Validation already takes care of :valid/:invalid changes through
      invalidation sets. This reduces the number of elements being recalculated
      and gets rid of a SubtreeStyleChange which relies on sibling tree recalcs.
      
      R=tkent@chromium.org
      BUG=557440
      
      Review URL: https://codereview.chromium.org/1458363003
      
      Cr-Commit-Position: refs/heads/master@{#361123}
      81fb8abc
    • sdefresne's avatar
      Remove minor fork in ios/web/public/web_state/ui/crw_web_delegate.h. · 774a62a2
      sdefresne authored
      BUG=None
      
      Review URL: https://codereview.chromium.org/1472853004
      
      Cr-Commit-Position: refs/heads/master@{#361122}
      774a62a2
    • rune's avatar
      Use invalidation sets for visited link updates. · 038590ac
      rune authored
      We did use invalidation sets when adding/removing href from an anchor tag,
      while the code that notifies that the visited state of a given url has
      changed, use SubtreeStyleChange. This change gets rid of SubtreeStyleChange
      which relies on sibling tree recalcs.
      
      R=tkent@chromium.org
      BUG=557440
      
      Review URL: https://codereview.chromium.org/1459063004
      
      Cr-Commit-Position: refs/heads/master@{#361121}
      038590ac
    • sdefresne's avatar
      Upstream downstream forks of ios_chrome_browsing_data_remover.h. · 905c171b
      sdefresne authored
      BUG=None
      
      Review URL: https://codereview.chromium.org/1472863002
      
      Cr-Commit-Position: refs/heads/master@{#361120}
      905c171b
    • rego's avatar
      [css-grid] Refactor GridSpan to avoid pointers · 1ac0ca97
      rego authored
      Add new boolean to know if a GridSpan is definite or indefinite.
      That way we don't need to use pointers and we can always have two
      GridSpans in GridCoordinate, if the position is "auto" the GridSpan will
      be marked as indefinite. This will allow in a follow-up patch to avoid
      repeated calls to methods that resolve positions.
      
      Most operations in GridSpan are restricted to definite GridSpans (access
      to positions, iterator, etc.). For indefinite GridSpans we only need to
      know that they're indefinite we shouldn't use the rest of the data.
      
      No new tests, no change of behavior.
      
      BUG=444011
      
      Review URL: https://codereview.chromium.org/1459373002
      
      Cr-Commit-Position: refs/heads/master@{#361119}
      1ac0ca97
    • limasdf's avatar
      ScopedPtrMap -> std::map from /component · cdc9400e
      limasdf authored
      C++ 11 enables containers that contain move-only type, scoped_ptr.
      So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.
      
      BUG=554291
      TBR=raymes@chromium.org
      
      Review URL: https://codereview.chromium.org/1468013002
      
      Cr-Commit-Position: refs/heads/master@{#361118}
      cdc9400e
    • Nico Weber's avatar
      Make SerialIoHandlerWin::UiThreadHelper final. · db730725
      Nico Weber authored
      Fixes the clang/win build after https://codereview.chromium.org/1439443002/
      clang rightfully complains that UiThreadHelper has virtual methods, is
      deleted polymorphically, and doesn't have a virtual destructor:
      
      ..\..\base/sequenced_task_runner_helpers.h(40,5) :  error: delete called on 'const device::SerialIoHandlerWin::UiThreadHelper' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
          delete reinterpret_cast<const T*>(object);
          ^
      ..\..\base/sequenced_task_runner_helpers.h(86,38) :  note: in instantiation of member function 'base::DeleteHelper<device::SerialIoHandlerWin::UiThreadHelper>::DoDelete' requested here
              from_here, &DeleteHelper<T>::DoDelete, object);
                                           ^
      ..\..\base/sequenced_task_runner.h(126,48) :  note: in instantiation of function template specialization 'base::subtle::DeleteHelperInternal<device::SerialIoHandlerWin::UiThreadHelper, bool>::DeleteViaSequencedTaskRunner<base::SequencedTaskRunner>' requested here
              subtle::DeleteHelperInternal<T, bool>::DeleteViaSequencedTaskRunner(
                                                     ^
      ..\..\device\serial\serial_io_handler_win.cc(374,28) :  note: in instantiation of function template specialization 'base::SequencedTaskRunner::DeleteSoon<device::SerialIoHandlerWin::UiThreadHelper>' requested here
        ui_thread_task_runner()->DeleteSoon(FROM_HERE, helper_);
                                 ^
      
      Making the class final fixes this as it makes sure that nobody adds
      a subclass of UiThreadHelper.
      
      Also don't mix initializer styles for the different fields of this
      class.
      
      No intended behavior change.
      
      BUG=82385
      TBR=juncai
      
      Review URL: https://codereview.chromium.org/1470983002 .
      
      Cr-Commit-Position: refs/heads/master@{#361117}
      db730725
    • v8-autoroll's avatar
      Update V8 to version 4.9.49. · 7c6424ea
      v8-autoroll authored
      Summary of changes available at:
      https://chromium.googlesource.com/v8/v8/+log/76efc8f2..a40b4f5c
      
      Please follow these instructions for assigning/CC'ing issues:
      https://code.google.com/p/v8-wiki/wiki/TriagingIssues
      
      Please close rolling in case of a roll revert:
      https://v8-roll.appspot.com/
      This only works with a Google account.
      
      TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
      
      Review URL: https://codereview.chromium.org/1472873002
      
      Cr-Commit-Position: refs/heads/master@{#361116}
      7c6424ea
    • svaldez's avatar
      Adding User Certificate (.crt) Import to Certificate Manager · 3e98a71a
      svaldez authored
      BUG=514767
      
      Review URL: https://codereview.chromium.org/1423333006
      
      Cr-Commit-Position: refs/heads/master@{#361115}
      3e98a71a
    • j.isorce's avatar
      On Linux desktop, when "use_virtualized_gl_context" is true · 5ade848c
      j.isorce authored
      and when --use-gl=egl then the browser is showing garbage.
      
      Indeed in GpuCommandBufferStub::OnInitialize the call to
      context->Initialize(surface_.get(), gpu_preference_)" fails.
      The error actually comes from eglMakeContext which returns
      EGL_BAD_MATCH. Because surface config is not compatible with
      context config.
      
      Problem is that EGL_BUFFER_SIZE is always 32 for off screen
      surfaces (see gl_surface_egl.cc::InitializeOneOff). Whereas
      for on screen surfaces EGL_BUFFER_SIZE is the window depth.
      This depth is by default 24 unless --enable-transparent-visuals
      is passed to the command line.
      
      When using mesa the error is raised here:
      /* If the context has a config then it must match that of the two
      * surfaces */
      if (ctx->Config) {
      if ((draw && draw->Config != ctx->Config) ||
        (read && read->Config != ctx->Config))
      return _eglError(EGL_BAD_MATCH, "eglMakeCurrent");
      from:
      cgit.freedesktop.org/mesa/mesa/tree/src/egl/main/eglcontext.c#n630
      
      This patch pass the main window depth from browser to gpu process
      though a new switch kWindowDepth.
      This allow GLSurfaceEGL::InitializeOneOff to select an EGLConfig
      that matches with future ON screen surfaces's EGLConfig.
      
      Also note that long term plan is to always enable transparent visual,
      see http://crbug.com/369209.
      
      This patch also move the kEnableTransparentVisuals switch from view
      to x11 switches as it is defined to x11 only.
      
      BUG=557389
      
      R=jbauman@chromium.org, hendrikw@chromium.org, piman@chromium.org, sadrul@chromium.org, cwallez1@chromium.org, kbr@chromium.org
      
      Review URL: https://codereview.chromium.org/1429083002
      
      TEST= chrome --use-gl=egl --use_virtualized_gl_contexts
      
      Review URL: https://codereview.chromium.org/1429083002
      
      Cr-Commit-Position: refs/heads/master@{#361114}
      5ade848c
    • sdefresne's avatar
      Upstream //ios/ios.gyp. · bc354d2a
      sdefresne authored
      BUG=None
      
      Review URL: https://codereview.chromium.org/1466343002
      
      Cr-Commit-Position: refs/heads/master@{#361113}
      bc354d2a
    • skia-deps-roller's avatar
      Roll src/third_party/skia/ 593192299..8e8eda9d4 (2 commits). · 8fcdd459
      skia-deps-roller authored
      https://chromium.googlesource.com/skia.git/+log/5931922997b8..8e8eda9d4d2e
      
      $ git log 593192299..8e8eda9d4 --date=short --no-merges --format='%ad %ae %s'
      2015-11-23 msarett Switch Skia's libjpeg-turbo to 1.4.2
      2015-11-23 kkinnunen Fix GLInterfaceValidation test after "Remove GrContextFactory::getGLContext"
      
      CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
      TBR=jvanverth@google.com
      
      Review URL: https://codereview.chromium.org/1470953002
      
      Cr-Commit-Position: refs/heads/master@{#361112}
      8fcdd459
    • sdefresne's avatar
      Introduce IOSChromeProfileInvalidationProviderFactory (iOS) · fe80c298
      sdefresne authored
      BUG=553320
      
      Review URL: https://codereview.chromium.org/1466363002
      
      Cr-Commit-Position: refs/heads/master@{#361111}
      fe80c298
    • wnwen's avatar
      Add stats to distinguish android renderer crashes. · 587e7058
      wnwen authored
      This CL is a precursor to expanding Clank stability scope
      to all OOM protected renderers that crash while Chrome is
      in the foreground.
      
      The difference in scope is effectively
      the number of renderers that crash as its corresponding
      tabs are all backgrounded. This transition time is one second before the OOM protection is dropped. Most,
      if not all, such renderer crashes are due to the Android OOM
      killer. Overall difference in proposed stability stats will
      not be much different, and will be easily seen with the new
      histogram.
      
      Expanding scope allows us to have native record which of
      the renderer crashes actually results in a minidump file
      being generated, thus demystifying whether the renderer
      was OOM killed or actually crashed. This native stat can
      be made more robust in the future, but this CL paves the
      foundation, assuming Tab.RendererExitStatus is comparable
      to Tab.RendererCrashStatus.
      
      Review URL: https://codereview.chromium.org/1447213002
      
      Cr-Commit-Position: refs/heads/master@{#361110}
      587e7058
    • sdefresne's avatar
      Fix unrecoverable SSL interstitials. · cea915b5
      sdefresne authored
      Unrecoverable SSL errors were broken in 	Merge 229993, by the upstream CL:
      https://codereview.chromium.org/23965003/.
      This fix removes the iOS specific interstitial.mm and uses interstitial_page_impl
      instead.
      It also adds support for unrecoverable errors, by returning a DENIED judgment
      to some errors.
      
      BUG=310607
      TEST=Go to https://test-sspev.verisign.com/. Clicking on "Revoked" should trigger an unrecoverable error, clicking on "Expired" should trigger a recoverable error (with a "proceed anyway" button)
      
      Review URL: https://chromereviews.googleplex.com/12347017
      
      Review URL: https://codereview.chromium.org/1469063002
      
      Cr-Commit-Position: refs/heads/master@{#361109}
      cea915b5
    • jyquinn's avatar
      Remove ServiceIsNullForTesting override for FaviconServiceFactory · 19acda1b
      jyquinn authored
      Removes ServiceIsNullForTesting override in FaviconServiceFactory
      to enable use of FaviconServiceFactory in tests.
      
      BUG=557415
      
      Review URL: https://codereview.chromium.org/1458703009
      
      Cr-Commit-Position: refs/heads/master@{#361108}
      19acda1b
    • ulan's avatar
      Oort Online benchmark based on TBM. · c2da6320
      ulan authored
      BUG=551798
      CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
      
      Review URL: https://codereview.chromium.org/1424213006
      
      Cr-Commit-Position: refs/heads/master@{#361107}
      c2da6320
    • sdefresne's avatar
      Upstream changes made downstream to infobar_manager_impl.{cc,h}. · 980b9671
      sdefresne authored
      BUG=None
      
      Review URL: https://codereview.chromium.org/1471763004
      
      Cr-Commit-Position: refs/heads/master@{#361106}
      980b9671
    • sdefresne's avatar
      Move OnKillFocus() from OmniboxEditController to WebOmniboxEditController · 454ee821
      sdefresne authored
      The only usage of this method is in iOS-specific code that knows that it's
      talking to a WebOmniboxEditController, so it's unnecessary to fork
      omnibox_edit_controller.h to expose this method.
      
      BUG=305330
      
      Review URL: https://codereview.chromium.org/1465253002
      
      Cr-Commit-Position: refs/heads/master@{#361105}
      454ee821
    • sdefresne's avatar
      Upstream changes made downstream to ios_chrome_network_delegate.h. · 070a8676
      sdefresne authored
      BUG=None
      
      Review URL: https://codereview.chromium.org/1469053002
      
      Cr-Commit-Position: refs/heads/master@{#361104}
      070a8676
    • sdefresne's avatar
      Decouple iOS port from ChromeMetricsServiceClient · ffd40bde
      sdefresne authored
      This CL changes the iOS port to use IOSChromeMetricsServiceClient rather than
      its forked version of ChromeMetricsServiceClient. There is one intended
      functional change in that
      ChromeMetricsServiceClient::RecordCommandLineMetrics() was not ported to
      IOSChromeMetricsServiceClient; see crbug.com/375794 for details.  Other than
      that, there should be no functional changes.
      
      BUG=512421, 375794
      
      Review URL: https://codereview.chromium.org/1470963002
      
      Cr-Commit-Position: refs/heads/master@{#361103}
      ffd40bde
    • sdefresne's avatar
      Let the MainController dismiss presented modals. · bca988af
      sdefresne authored
      Prior to this CL, when the ESC key was pressed, only the state presented by the
      BVC was dismissed. Moreover, the BVC dismissed blindly all presented view
      controller, such as the settings. It is the MainController responsibility to
      close the settings, as it is the presenter.
      This CL adds a new Chrome command that asks to dismiss all modals.
      
      BUG=none
      R=rohitrao@google.com
      
      Review URL: https://chromereviews.googleplex.com/265777013
      
      Review URL: https://codereview.chromium.org/1469903002
      
      Cr-Commit-Position: refs/heads/master@{#361102}
      bca988af
    • mvanouwerkerk's avatar
      PushMessagingNotificationManager: extract IsTabVisible and test it. · 0035b7af
      mvanouwerkerk authored
      BUG=558402
      
      Review URL: https://codereview.chromium.org/1467573003
      
      Cr-Commit-Position: refs/heads/master@{#361101}
      0035b7af
    • peter's avatar
      Address two minor FIXMEs in Push Messaging layout tests. · af6b1818
      peter authored
      BUG=
      
      Review URL: https://codereview.chromium.org/1469813004
      
      Cr-Commit-Position: refs/heads/master@{#361100}
      af6b1818
    • ccameron's avatar
      Mac: Move IOSurface token initialization earlier · 51fdb858
      ccameron authored
      Move from RenderProcessHostImpl::OnChannelEstablished to
      RenderProcessHostImpl::OnProcessLaunched, so that it comes in before
      the first burst of IPCs to the renderer.
      
      Change token DCHECKs to CHECKs, because they will crash the renderer
      later on.
      
      BUG=554541
      
      Review URL: https://codereview.chromium.org/1463853002
      
      Cr-Commit-Position: refs/heads/master@{#361099}
      51fdb858
    • v8-autoroll's avatar
      Update V8 to version 4.9.47. · 6605dcfd
      v8-autoroll authored
      Summary of changes available at:
      https://chromium.googlesource.com/v8/v8/+log/e6029096..76efc8f2
      
      Please follow these instructions for assigning/CC'ing issues:
      https://code.google.com/p/v8-wiki/wiki/TriagingIssues
      
      Please close rolling in case of a roll revert:
      https://v8-roll.appspot.com/
      This only works with a Google account.
      
      TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
      
      Review URL: https://codereview.chromium.org/1469033002
      
      Cr-Commit-Position: refs/heads/master@{#361098}
      6605dcfd
    • magjed's avatar
      Reland of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #1 id:1... · 13c44925
      magjed authored
      Reland of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #1 id:1 of https://codereview.chromium.org/1472713003/ )
      
      Reason for revert:
      Mac Builder (dbg) does not even compile now...
      
      Original issue's description:
      > Revert of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #2 id:20001 of https://codereview.chromium.org/1460063003/ )
      >
      > Reason for revert:
      > I'm speculatively reverting this CL as the cause for the failing Mac10.6 Tests nacl_integration test. The whole test fails with this output:
      > scons: done reading SConscript files.
      > scons: Building targets ...
      > Install file: "src/untrusted/pthread/pthread.h" as "scons-out/nacl-x86-64/include/pthread.h"
      > Install file: "src/untrusted/pthread/semaphore.h" as "scons-out/nacl-x86-64/include/semaphore.h"
      > Install file: "src/untrusted/stubs/crt1.x" as "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o"
      > Func(["scons-out/nacl-x86-64/obj/tests/breakpad_crash_test/breakpad_untrusted_crash_test.out.tmp/crash_test.nmf"], [])
      > Install file: "src/untrusted/nacl/nacl_random.h" as "scons-out/nacl-x86-64/include/nacl/nacl_random.h"
      > Install file: "src/untrusted/nacl/nacl_dyncode.h" as "scons-out/nacl-x86-64/include/nacl/nacl_dyncode.h"
      > WriteManifestList(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner_nmf_test_list.js"], [])
      > Func(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner.out.tmp/random_test.nmf"], [])
      > Install file: "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" as "scons-out/nacl-x86-64/lib/crt1.o"
      > /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o src/untrusted/nacl/sigprocmask.c
      > dyld: Library not loaded: /usr/lib/libedit.3.dylib
      >   Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang
      >   Reason: image not found
      >
      > I'm thinking this might be caused by "Fix PNaCl toolchain build on Mac" https://codereview.chromium.org/1458713003
      > that e.g. includes this change:
      > # Required SDK version and target version for Mac builds.
      > # See MAC_SDK_FLAGS, below.
      > MAC_SDK_MIN = '10.10'
      > MAC_DEPLOYMENT_TARGET = '10.6'
      >
      > Original issue's description:
      > > NaCl: Update revision in DEPS, 546ef11 -> b6ec17d
      > >
      > > This pulls in the following Native Client changes:
      > >
      > > 1a71811: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
      > > 26a11d1: (stichnot@chromium.org) Update revision for PNaCl
      > > 3658d8e: (phosek@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
      > > 7a60f36: (mcgrathr@chromium.org) Remove an unused variable from src/shared/imc/win/nacl_imc.cc
      > > 1b746e8: (mcgrathr@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
      > > 0f0cb21: (mcgrathr@chromium.org) pnacl-strip: Handle --strip-unneeded switch
      > > 9d811a5: (mcgrathr@chromium.org) toolchain_build: Disable gold build for Mac host
      > > 7f130ff: (erikchen@chromium.org) Suppress Clang warning for dirfd() on OSX.
      > > 18e2d27: (erikchen@chromium.org) Add code to check for the OS X version.
      > > bad8503: (erikchen@chromium.org) Fix an invocation to find_sdk.py.
      > > 079650c: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
      > > 4dbae34: (mcgrathr@chromium.org) Fix PNaCl toolchain build on Mac
      > > db88d57: (mcgrathr@chromium.org) Fix build/update_pnacl_tool_revisions.py for @-less user names
      > > d5112f1: (mcgrathr@chromium.org) Update revision for PNaCl
      > > b6ec17d: (erikchen@chromium.org) Make a NaCl descriptor for Mach-based shared memory.
      > >
      > > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/546ef11ffcbedf8c33bfa12643408c1182b6839e..b6ec17db8c2958f3455043e29000f17354336fb8
      > >
      > > BUG=none
      > > TEST=browser_tests and nacl_integration
      > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build
      > >
      > > Committed: https://crrev.com/910bd999c1fed7f0211b636184072f35a506023f
      > > Cr-Commit-Position: refs/heads/master@{#360958}
      >
      > TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > BUG=none
      >
      > Committed: https://crrev.com/a503d57f1c4ec0f07b064247ee82c3e7d4ecd9dc
      > Cr-Commit-Position: refs/heads/master@{#361096}
      
      TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=none
      
      Review URL: https://codereview.chromium.org/1472853002
      
      Cr-Commit-Position: refs/heads/master@{#361097}
      13c44925
    • magjed's avatar
      Revert of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #2... · a503d57f
      magjed authored
      Revert of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #2 id:20001 of https://codereview.chromium.org/1460063003/ )
      
      Reason for revert:
      I'm speculatively reverting this CL as the cause for the failing Mac10.6 Tests nacl_integration test. The whole test fails with this output:
      scons: done reading SConscript files.
      scons: Building targets ...
      Install file: "src/untrusted/pthread/pthread.h" as "scons-out/nacl-x86-64/include/pthread.h"
      Install file: "src/untrusted/pthread/semaphore.h" as "scons-out/nacl-x86-64/include/semaphore.h"
      Install file: "src/untrusted/stubs/crt1.x" as "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o"
      Func(["scons-out/nacl-x86-64/obj/tests/breakpad_crash_test/breakpad_untrusted_crash_test.out.tmp/crash_test.nmf"], [])
      Install file: "src/untrusted/nacl/nacl_random.h" as "scons-out/nacl-x86-64/include/nacl/nacl_random.h"
      Install file: "src/untrusted/nacl/nacl_dyncode.h" as "scons-out/nacl-x86-64/include/nacl/nacl_dyncode.h"
      WriteManifestList(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner_nmf_test_list.js"], [])
      Func(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner.out.tmp/random_test.nmf"], [])
      Install file: "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" as "scons-out/nacl-x86-64/lib/crt1.o"
      /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o src/untrusted/nacl/sigprocmask.c
      dyld: Library not loaded: /usr/lib/libedit.3.dylib
        Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang
        Reason: image not found
      
      I'm thinking this might be caused by "Fix PNaCl toolchain build on Mac" https://codereview.chromium.org/1458713003
      that e.g. includes this change:
      # Required SDK version and target version for Mac builds.
      # See MAC_SDK_FLAGS, below.
      MAC_SDK_MIN = '10.10'
      MAC_DEPLOYMENT_TARGET = '10.6'
      
      Original issue's description:
      > NaCl: Update revision in DEPS, 546ef11 -> b6ec17d
      >
      > This pulls in the following Native Client changes:
      >
      > 1a71811: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
      > 26a11d1: (stichnot@chromium.org) Update revision for PNaCl
      > 3658d8e: (phosek@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
      > 7a60f36: (mcgrathr@chromium.org) Remove an unused variable from src/shared/imc/win/nacl_imc.cc
      > 1b746e8: (mcgrathr@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
      > 0f0cb21: (mcgrathr@chromium.org) pnacl-strip: Handle --strip-unneeded switch
      > 9d811a5: (mcgrathr@chromium.org) toolchain_build: Disable gold build for Mac host
      > 7f130ff: (erikchen@chromium.org) Suppress Clang warning for dirfd() on OSX.
      > 18e2d27: (erikchen@chromium.org) Add code to check for the OS X version.
      > bad8503: (erikchen@chromium.org) Fix an invocation to find_sdk.py.
      > 079650c: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
      > 4dbae34: (mcgrathr@chromium.org) Fix PNaCl toolchain build on Mac
      > db88d57: (mcgrathr@chromium.org) Fix build/update_pnacl_tool_revisions.py for @-less user names
      > d5112f1: (mcgrathr@chromium.org) Update revision for PNaCl
      > b6ec17d: (erikchen@chromium.org) Make a NaCl descriptor for Mach-based shared memory.
      >
      > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/546ef11ffcbedf8c33bfa12643408c1182b6839e..b6ec17db8c2958f3455043e29000f17354336fb8
      >
      > BUG=none
      > TEST=browser_tests and nacl_integration
      > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build
      >
      > Committed: https://crrev.com/910bd999c1fed7f0211b636184072f35a506023f
      > Cr-Commit-Position: refs/heads/master@{#360958}
      
      TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      BUG=none
      
      Review URL: https://codereview.chromium.org/1472713003
      
      Cr-Commit-Position: refs/heads/master@{#361096}
      a503d57f
    • stkhapugin's avatar
      Fixes document type detection on iOS 9. · 704def3b
      stkhapugin authored
      On iOS 9, evaluating '' + document always results in [object
      HTMLDocument], even for PDFs. This introduces another way of checking
      document type on iOS 9. Unfortunately, it doesn't work on iOS 8, so the
      old implementation needs to stay too.
      
      BUG=549604
      
      Review URL: https://codereview.chromium.org/1458703004
      
      Cr-Commit-Position: refs/heads/master@{#361095}
      704def3b