- 18 Sep, 2018 40 commits
-
-
Devlin Cronin authored
When the user selects "On specific sites" from the dropdown in the chrome://extensions page, automatically bring up the dialog to add an allowed site. This makes it clear to the user that they need to specify a site for this setting to work, and also fixes an issue where selecting "On specific sites" and then refreshing the page (or having the data model otherwise update) reset the value to "on click". Bug: 884222 Change-Id: Ie89757f7fba2409774e5fcc2f4a8028aff31f7ba Reviewed-on: https://chromium-review.googlesource.com/1226017Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592118}
-
rbpotter authored
Match the Print Preview elevation shadow styling to the styling used in other Web UI surfaces (extensions, settings). Bug: 883583 Change-Id: Ida1c4427e401de30c540c5109eb5b45e6b67f79f Reviewed-on: https://chromium-review.googlesource.com/1227395Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592117}
-
Nate Chapin authored
This allows us to hide the HashSet of all current WorkerThreads, which is valuable since the callers outside WorkerThread don't have access to the necessary mutex to access it safely. Convert TimeZoneMonitorClient to use this helper. Change-Id: I5aa743a1fa0c789a8f9496a05d7cfecde9238004 Reviewed-on: https://chromium-review.googlesource.com/1228950Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#592116}
-
Richard Townsend authored
When colgroups are modified via Javascript, Blink uses a stale computed logical width, resulting in incorrect sizing of auto columns if layout was previously done. This patch forces a fresh layout of the affected cells, which corrects this behaviour. Bug: 870296 Change-Id: I4a12d5a8db689ba1457c6c9960ae8ea9c1dd40d9 Reviewed-on: https://chromium-review.googlesource.com/1162224 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592115}
-
Ehsan Karamad authored
This is a second attempt at fixing the crash linked in the bug. It appears that PluginResourceThrottle's lifetime is tied with WebURLLoaderImpl does not synchronously go away with the container. When an <embed> element is removed during a resource request, the MHVCBase (aka WebAssociatedURLLoaderClient in this context) is destroyed immediately. The WebURLLoaderImpl, OTH, goes away when the cancel timer on the ResourceClient is fired. To avoid any potential UaF, this CL changes the raw pointer refernece to MHVCBase in PluginResourceThrottle to a WeakPtr. This also serves as a potential fix for the crashes in the linked bug. Bug: 878359 Change-Id: If8b21f9366bb57394819946e891f9288028dde2c Reviewed-on: https://chromium-review.googlesource.com/1230576Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592114}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/debba6d2124e..6fc8d877d745 git log debba6d2124e..6fc8d877d745 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 hnakashima@chromium.org Encode mark names when writing to file. Created with: gclient setdep -r src/third_party/pdfium@6fc8d877d745 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I83b30a33d09b95a8b76523c2a5f455670d30dd66 Reviewed-on: https://chromium-review.googlesource.com/1231413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592113}
-
Nico Weber authored
win: Remove two exit-time destructors from pdf_child_init and enable -Wexit-time-destructors for chrome/child. The PDF setup code patches up two GDI functions. There's no need to undo that patching at process exit, so use a function-local static base::NoDestructor<> instead of a global. Bug: 404525 Change-Id: I9cb06b857a8b95ba5cbac74be60f8225fbb6f72a Reviewed-on: https://chromium-review.googlesource.com/1231073Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592112}
-
Nico Weber authored
No need to undo 5 IAT patches at process shutdown, and no need to call a ThreadLocalBoolean dtor either. Bug: 404525 Change-Id: I95e4cc24d7b6ca7171457a0da8dd6b3231fe45a8 Reviewed-on: https://chromium-review.googlesource.com/1231153Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592111}
-
Michael Spang authored
Fuchsia platform windows are initially 0x0 and this causes vulkan surface creation to crash. Defer creating a renderer until we have a nonempty size. Bug: 861853 Test: run_ozone_demo --ozone-platform=scenic --enable-vulkan Change-Id: I74e14ed07ab47ebc22730b40cf36217e9ae4873a Reviewed-on: https://chromium-review.googlesource.com/1229162 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592110}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d89bb9de..345f5513 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f2c4436587c174c0640ad366c7439cc5a5b98ad Reviewed-on: https://chromium-review.googlesource.com/1231293Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592109}
-
edchin authored
This CL simply adds the flag so that it can be used in a future CL. This flag controls whether the WKWebView snapshotting API is used to take snapshots for web pages (not native pages) on iOS 11+. The crbug to remove the flag is crbug.com/885003. Bug: 739840 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id00c4da93f5046e4a2b2af179abe3794a99a248e Reviewed-on: https://chromium-review.googlesource.com/1229703 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592108}
-
Mike Wasserman authored
Track in-flight key events separately from others in WindowTree. (client may ack key events out-of-order from others, for async IME) Add a simple test of OnWindowInputEventAck behavior. Bug: 884368 Test: Moving a mouse while pressing an accelerator with KSV window focused. Change-Id: I7d76ce1aec2ef311f5e721903d40e1b3819e2953 Reviewed-on: https://chromium-review.googlesource.com/1229074 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592107}
-
Zhenyao Mo authored
The original sample is outdated so replace with a newer one. BUG=838970 Change-Id: Id257239e3fdb6424bd7bb9b3bdaea563dd1743dc Reviewed-on: https://chromium-review.googlesource.com/1228783 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592106}
-
S. Ganesh authored
Since the tests introduced in install_service_work_item_unittest.cc could interfere with one another, I am also changing the setup unittests to tests in series rather than in parallel by switching to LaunchUnitTestsSerially in run_all_unittests.cc. Bug: 833687 Change-Id: I215feac65799c0278bf3503e929f3415e6d0ff36 Reviewed-on: https://chromium-review.googlesource.com/1137532 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592105}
-
Tommy Steimel authored
This CL removes the double-tap AnimatedArrows from the overlay play button and adds them into a new MediaControlAnimatedArrowContainer element. This is the first step of a refactoring of the overlay play button to remove non-play-button-related logic and elements. Bug: 884770 Change-Id: I4d247a0178fd353b294d70c510b9b5b230220c68 Reviewed-on: https://chromium-review.googlesource.com/1228984Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592104}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0639cbc44de0..804797362e1d git log 0639cbc44de0..804797362e1d --date=short --no-merges --format='%ad %ae %s' 2018-09-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@804797362e1d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0894a56fb702f036390a51ba3db0dc8f3fdfabf8 Reviewed-on: https://chromium-review.googlesource.com/1230640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592103}
-
Theresa authored
Default enable the simplified NTP ablation experiment that removes the bookmarks/downlaods sections on the NTP without replacing them with short buttons. BUG=865216 Change-Id: Ia77dd888db8541f0946788c8c4fc6c4763da6874 Reviewed-on: https://chromium-review.googlesource.com/1229313 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592102}
-
Saman Sami authored
Resetting the fallback is no longer necessary and might even result in surfaces outside of the desired range being shown. Bug: 857575 Change-Id: Ib66ad50d0297f2c93e3e9815a3ec2349fde4289b Reviewed-on: https://chromium-review.googlesource.com/1231034Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#592101}
-
Lei Zhang authored
Rename the static method to CreateUniqueId(). Mark more parts of CupsPrintJob as const as well. Change-Id: Ifd4cd5d27c71245aa9ad251addf915853b48f6a2 Reviewed-on: https://chromium-review.googlesource.com/1229369Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#592100}
-
Robbie McElrath authored
This is a follow up from a post-merge comment on crrev.com/c/1214081 which moves the SetUp code to the constructor. Bug: 868015 Change-Id: Ied0bd568560c49858eeb5261c5d89352f8b1d787 Reviewed-on: https://chromium-review.googlesource.com/1229356Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#592099}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1d6281d4bb47..0191ed8e87dc git log 1d6281d4bb47..0191ed8e87dc --date=short --no-merges --format='%ad %ae %s' 2018-09-18 mtklein@google.com Make listener lists threadsafe with a mutex. 2018-09-18 bsalomon@google.com Fix image_from_yuv_textures with --preAbandonContext Created with: gclient setdep -r src/third_party/skia@0191ed8e87dc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ia9c7909443e6e1be2a567f0fb6de73a525569fe2 Reviewed-on: https://chromium-review.googlesource.com/1231275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592098}
-
liberato@chromium.org authored
This addresses the CFI failures that caused the original revert. This reverts commit 45cb1008. Change-Id: I05fa7fbb8628c992639e960d9d3f41c6ad5fec2b Reviewed-on: https://chromium-review.googlesource.com/1228493 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592097}
-
Martin Robinson authored
This allows accessibility clients to have access to the links available in the text provided by the AtkText interface. Implementing this interface also allows us to write a fully-fleshed out text for the contents provided by the AtkText interface. Bug: 866337 Change-Id: I38e200512a835014922b51df677203e853d6ef4b Reviewed-on: https://chromium-review.googlesource.com/1227942 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592096}
-
Asanka Herath authored
Test is flaky. Bug: 884140 Change-Id: I41f4f3eb084edd56867ffecc437817be8f1bcc1b Reviewed-on: https://chromium-review.googlesource.com/1231037Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592095}
-
Etienne Pierre-Doray authored
This CL creates a feature kCookieStorePriorityBoost that changes SQLitePersistentCookieStore background_task_runner sequence priority to USER_BLOCKING. A CANARY_DEV_50 experiment will be launch and used to compare SessionRestore.ForegroundTabFirstPaint3. Bug: 878222 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I22bbd5b90cf4d36d3a858adbe94eff96f280a5a0 Reviewed-on: https://chromium-review.googlesource.com/1224671 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592094}
-
Xiaohui Chen authored
Bug: b:115918259 Test: locally build Change-Id: Ie1da988afddfbe446cb5860ceb799a9814927116 Reviewed-on: https://chromium-review.googlesource.com/1229184 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592093}
-
Elly Fong-Jones authored
This reverts commit 2065e9fc. Reason for revert: hangs Flash context menus in fullscreen, https://crbug.com/884158 Original change's description: > content: don't show context menus for invisible WebContents > > Bug: 855127 > Change-Id: I2942e122373c210bd0bceaa59791e2619186f79b > Reviewed-on: https://chromium-review.googlesource.com/1175935 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583317} TBR=ellyjones@chromium.org,avi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855127 Change-Id: Ic1f62597bfbebe43cd5002ec12f05e36562e8c96 Reviewed-on: https://chromium-review.googlesource.com/1230439Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592092}
-
Andrey Kosyakov authored
This removes DebugDevToolsInterceptor and supports DEBUG_DEVTOOLS layout as part of regular DevToolsDataSource. Change-Id: I06d5a805ff8b6b324127b131bb87801d3595311f Reviewed-on: https://chromium-review.googlesource.com/1229198Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592091}
-
Oystein Eftevaag authored
This bundles multiple events into the same higher-level message and adds a string table implementation for frequently repeated strings, on a per-thread basis; specifically the event name, category name, and the name of its arguments. Requires https://android-review.googlesource.com/c/platform/external/perfetto/+/755290 to roll into //third_party/perfetto before landing. R=primiano@chromium.org,skyostil@chromium.org Bug: 839116 Change-Id: Id2681970db5b7ea5cadf0ee9bbcbbc1ebbba08c3 Reviewed-on: https://chromium-review.googlesource.com/1225306 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#592090}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/95277a300f52..0fdb956d9c24 git log 95277a300f52..0fdb956d9c24 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 jmadill@chromium.org Re-land "Inline and micro-optimize more for perf tests."" Created with: gclient setdep -r src/third_party/angle@0fdb956d9c24 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iab9b61a4693af205a33d004a1a1a6685f9fb9a61 Reviewed-on: https://chromium-review.googlesource.com/1231213Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592089}
-
Chris Lu authored
Cookie clearing is asynchronous operation, which can be interrupted by the app shutdown. Blocking shutdown should allow the app more time for cookie clearing. Bug: 857199 Change-Id: I53b3c34e3cb4af77e576bbc65a37b09489b675a4 Reviewed-on: https://chromium-review.googlesource.com/1228880 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592088}
-
Christian Fremerey authored
Adds an optional field yuv_strites for Mojo struct VideoFrameInfo. This field can be used to express that YUV frames use padding for row-by-row memory alignment. This information is carried through the video capture stack from virtual device to the Renderer in class VideoCaptureImpl, where it is then translated to a media::VideoFrame. Design Doc: https://docs.google.com/document/d/1ne5eQrkzAINzoHWSxEEy6N2nEVhnpCll6DF9dcQXAmI/edit?usp=sharing Bug: 879264 Change-Id: I23ba97c2a075a4d55b75bf7c5171e4bb117197ec Reviewed-on: https://chromium-review.googlesource.com/1208825Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592087}
-
Eugene But authored
.exe and .apk could be dangerous downloads and it would be useful to know if Chrome should use Safe Browsing for blacklisting these downloads. .zip is probably the most common downloaded format, so logging it can make "other" bucket smaller. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Icbd76954c57756169ef942cfddfce29d8a34861c Reviewed-on: https://chromium-review.googlesource.com/1227132 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#592086}
-
Asanka Herath authored
Both virtual/video-surface-layer/external/wpt/feature-policy/feature-policy-nested-header-policy-disallowed-for-all.https.sub.html and virtual/unified-autoplay/external/wpt/feature-policy/feature-policy-nested-header-policy-disallowed-for-all.https.sub.html are timing out in a flaky manner. They were added in https://chromium-review.googlesource.com/887324 around February of 2018. Started flaking out (as far as the dashboard knows) June 6, 2018. The most recent and more frequent flakes started around September 12, 2018. No clear culprit found. Bug: 884445 Change-Id: Ib26f9c51eaa41224aa964156e5b26c0174739008 Reviewed-on: https://chromium-review.googlesource.com/1231074Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592085}
-
Misha Efimov authored
- Avoid bug in iOS 10.0 and 10.1: http://www.openradar.me/28301343 Bug: 878589 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet Change-Id: Ifef1c2c6fa35023a947d53c77a9910a6726b55a6 Reviewed-on: https://chromium-review.googlesource.com/1231133 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592084}
-
Matt Menke authored
Some consumers want to be able to set socket properties, but they're not guaranteed to be set at all when called on a live socket. Existing code gets around this limitation by using TcpSocket directly, but that class doesn't support being mocked out for tests. This CL resolves the issue. Bug: 1204852 Change-Id: Ibd3d33261c90f02285c3160468d39eca64eed259 Reviewed-on: https://chromium-review.googlesource.com/1228839Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#592083}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6003ae575d57..c42c66b2dd05 git log 6003ae575d57..c42c66b2dd05 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 lalitm@google.com Revert "trace_processor: collapse sched slice table to a flat table" Created with: gclient setdep -r src/third_party/perfetto@c42c66b2dd05 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7cab2e34b39484c21cedca6e176d47f0b7ae399a Reviewed-on: https://chromium-review.googlesource.com/1230556Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592082}
-
Eric Seckler authored
This delays initialization of MockMediaRouters in the test until the browser's task executor is initialized. This is required for the upcoming move of BrowserThread::GetTaskRunnerForThread to base::Create*TaskRunnerWithTraits. In the future, TaskRunners can only be obtained after thread initialization. Since MockMediaRouter obtains a TaskRunner in its constructor, this patch moves its creation. Bug: 878356 Change-Id: Idd599d23246d42427d35bccd3c027f0a24427cfa Reviewed-on: https://chromium-review.googlesource.com/1230024 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592081}
-
Anders Hartvoll Ruud authored
This adds a new CSSCustomListInterpolationType, which is to be used for all custom property lists, regardless of their syntax. CSSCustomListInterpolationType takes an inner CSSInterpolationType, which handles the operations on the items inside the list. R=flackr@chromium.org Bug: 868959 Change-Id: I9e77e6c2332569e3cbafa492022144850b5d11db Reviewed-on: https://chromium-review.googlesource.com/1165546 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592080}
-
Justin Cohen authored
Migrates IncognitoViewController and ContentSuggestionsCoordinator into CRWNativeContent. - This will change again when removing NTP from native content. Removes NTPHeaderViewAdapter from content suggestions. Removes all references to unreachable NTP code, such as NewTabPagePanelProtocol, tab bar related items, ntp view, the shadow logic, etc. Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I714b56b9a8db10462488f5542e14ba6318e8235f Reviewed-on: https://chromium-review.googlesource.com/1228853Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592079}
-