- 13 Mar, 2020 40 commits
-
-
Fredrik Söderqvist authored
Change-Id: Ie215b673d393b799ed51b669959b19e94b075e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102728 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750228}
-
Mario Sanchez Prada authored
This CL converts the message that notifies the browser process of changes in the location of accessibility objects in Blink's accessibility tree. Bug: 1010831 Change-Id: I220a005183012b8a509948711b5766f384cced4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078914 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#750227}
-
Ayu Ishii authored
This change removes the previous iteration of WebOTP, SMS Receiver API, which we ran for Origin Trial. This is now being removed in favor of the credential management version, WebOTP API [1]. WebOTP API Explainer: https://github.com/WICG/WebOTP I2E ending in M80: https://groups.google.com/a/chromium.org/d/topic/blink-dev/-bdqHhCyBwM/discussion Bug: 1045526 Change-Id: I1e73bed5018c814770fa34edcf64daafd234a543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097041Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#750226}
-
Yilkal Abe authored
This reverts commit 79024af7. Reason for revert: This revert is required because there are scenarios where the profile becomes supervised user after the navigation observer is supposed to be created. i.e. When SupervisedUserNaivgationObserver::MaybeCreateForWebContents is called the user profile is not marked as supervised hence the navigation observer is not created. This resulted in the crashes reported in the bug below. Bug: 1061427 Original change's description: > Only use SupervisedUserNavigationObserver for child accounts. > > This CL makes sure that SupervisedUserNavigationObserver is > created only for supervised user accounts. This saves memory > and processing time. > > Bug: 1043232 > Change-Id: I5d13ce0261d07c29384f5ba5dc83e420ed3138dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008315 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dan S <danan@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733750} TBR=sky@chromium.org,danan@chromium.org,yilkal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043232 Change-Id: I1767afe66b32f34736af2497793d59f598cb61b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102764Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#750225}
-
Danyao Wang authored
The new test is a regression test to make sure the manifest icon download is only subject to the CSP policy of the initiator frame. Bug: 1055360 Change-Id: I0efd8b7532b1d6c6174b95d6dacea0bef8a20767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097535 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750224}
-
Dave Tapuska authored
In an effort to move compositing layer tree ownership into blink change the way rAF aligned input works. Previously the content layer captured the begin frame dispatched input then let blink know about the main frame. Tell blink now and let blink ask content layer to dispatch rAF aligned input. Eventually all this will go away when blink does everything. Change-Id: I86abe4da3e9005c6973acc8b554c6a87bb9fa485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101295Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#750223}
-
Xiaocheng Hu authored
FontPreloadManagerTest.OptionalFontFastPreloading is flaky, which might be caused by a race between a timeout firing and a ResourceFinishObserver notification. This patch disables the timeout as a tentative fix. Bug: 1060821 Change-Id: I450b9783c20525a407bc8e3cac19be7b18927b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101245Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750222}
-
Pavel Feldman authored
Permission overrides were implemented for the automation purposes (WebDriver, Puppeteer, Playwright, etc). Before this change, protocol required concrete |origin| to be specified in order to override the permissions. This change makes this |origin| input parameter optional and allows global permission override within the given browser context. TBR=mlamouri for updating chrome/ due to changes in content/ semantics. Change-Id: I35e78307643b179a46e296d81f261e5b596c6252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095668 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#750221}
-
Sahel Sharify authored
After this cl payment sheets on Desktop and Android will show "Continue" rather than "Pay" when a 3rd party(i.e. non-autofill) payment app is selected. Bug: 1055557 Change-Id: I1717703d50e33df5cdc4a3f0e900b29072df19c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101690 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750220}
-
Anatoliy Potapchuk authored
Bug: 1061418 Change-Id: I063b863e61b1c788a83c213eef41603e3ad71b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093223 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#750219}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dba14f0f51b4..4d806b9daa24 git log dba14f0f51b4..4d806b9daa24 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 aerotwist@chromium.org Updates npm_test to work on Windows Created with: gclient setdep -r src/third_party/devtools-frontend/src@4d806b9daa24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I61401ae15a6ecdc7574b16d8c08a1dec6ab10fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750218}
-
yilkal authored
This Cl ensures that app activity values will not be reported if app activity data reporting toggle is set to false in PerAppTimeLimits policy. Bug: 1042477 Change-Id: Id400aebd71be7a2eac5c35f1b59c4c70dc7f6f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096914 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#750217}
-
John Budorick authored
Follow-up to crrev.com/c/2101384 to account for crrev.com/c/2093536 Bug: 1061198 Change-Id: I3085da3365052e5f0f9384f76bc1511fd27ffad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102774 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#750216}
-
Nina Satragno authored
Some older authenticators support internal user verification but not UV token or getting UV retries. Before this patch, if internal user verification failed for one of these authenticators we would either drop the request or show an error to the user. With this change, when an authenticator supports falling back to PIN, chrome will show the PIN dialog and alert the user. Some authenticators will immediately fail when sent a uv = required request if their internal uv is locked. To mitigate this behaviour, a touch is requested from devices that return a response too quickly. Bug: 999153 Change-Id: Icffccf208951cd33227fd532b6a569dcc8d93c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097121 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#750215}
-
Rainhard Findling authored
* Remove ability to focus text-only non-actionable safety check elements and their additional aria labels, as the text in the elements on its own is sufficient for a11y and can be reached by screen readers. * Hide non-essential elements (icons) from aria. Bug: 1060779 Change-Id: Id4bf41f461412d2aa433e051d3518de390fcb63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100823Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#750214}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/27402f3ffd34..8926292ad6bb git log 27402f3ffd34..8926292ad6bb --date=short --first-parent --format='%ad %ae %s' 2020-03-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-13 lamontjones@chromium.org api: add UNVERIFIED_CHROME_BENCHMARK_PERF_FILE 2020-03-13 lamontjones@chromium.org api: compile protos. 2020-03-13 engeg@google.com chromite: add dev-libs/icu to OTHER_CHROME_PACKAGES 2020-03-13 engeg@google.com api service: remove 'quick hack for testing' 2020-03-12 gredelston@google.com Set up pytest 2020-03-12 morg@google.com Enable RVC Android PFQ configs (VM and container) 2020-03-12 sanikak@chromium.org auto_updater: update GetPayloadPropsFile method to ssh into devserver 2020-03-12 tcwang@google.com afdo: Remove indirect calls from AFDO profiles 2020-03-12 vapier@chromium.org licensing: delete unused debug constant 2020-03-12 ayatane@chromium.org metrics: Handle cases where system clock jumps backward Created with: gclient setdep -r src/third_party/chromite@8926292ad6bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ia64a72ee748ff0c63e5585d3f9649d3f8da37fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102754Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750213}
-
Clark DuVall authored
This is a reland of 9ced8b0f Changes from patch set 1 on. We no longer prepend "/." to paths for L/M where it's not needed since L adds /vendor/lib to all class loaders which breaks the test. Original change's description: > Reland "[WebLayer] Use crazy linker for M- and "/." trick for N+" > > This is a reland of 9b660407 > > Original change's description: > > [WebLayer] Use crazy linker for M- and "/." trick for N+ > > > > Instead of copying libraries on M-, this changes to using the crazy > > linker, which loads the library without any knowledge of what libraries > > have been loaded by the system linker. This requires manual JNI > > registration. To make sure we only register WebLayer JNI when needed, > > a minimal set of JNI methods is registered, and the full set is > > registered later if we require WebView compatibility. > > > > In N+, we switch to prepending "/." to library paths instead of using > > symlinks, which allows us to avoid writing any files to the apps data > > directory. This simplifies the interface quite a bit, allowing > > initializeWebViewCompatibilityMode() to be sync instead of async. I will > > follow up with the Android team to make sure we have a better solution > > for future versions of Android. > > > > The API has not been used in the client app yet, so it should be safe > > to remove M- support for the copy library approach in the > > implementation. The old version of initializeWebViewCompatibilityMode() > > was kept so the WebLayer API version compat tests would still pass. > > > > TBR=agrieve@chromium.org > > > > Bug: 1051358 > > Change-Id: I2cd5ae0e025feaeb5c41cf9ddfafc91cd09fbad7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090024 > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#749973} > > TBR=torne@chromium.org,agrieve@chromium.org > > Bug: 1051358 > Change-Id: Iecccefbbfdaa14c91a8d8b1a50543f4929912704 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101978 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750056} TBR=torne@chromium.org,agrieve@chromium.org Bug: 1051358 Change-Id: If9eb267c6e33cb76370bb19783d8cbf4b1834429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102772Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#750212}
-
Daniel Cheng authored
Allowing arbitrary amounts of shared memory to be mapped can make it easier for an attacker to bypass ASLR as documented in https://googleprojectzero.blogspot.com/2019/04/virtually-unlimited-memory-escaping.html Bug: 1056572 Change-Id: I812542e2b3d9e7842a7ae54bdd837fa956a99177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083447 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#750211}
-
Garrett Beaty authored
Bug: 1024644, 1061482 Change-Id: I0b523d9b8b0cd1f73de084190236f1b968772736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098857 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#750210}
-
Yao Xiao authored
LGTMs to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/JdAQ6HNoZvk/m/B1aMS33oAAAJ whatwg/html spec: https://github.com/whatwg/html/pull/4293 Bug: 539938 Change-Id: Ib875fe971ff8ab93ed733f6a0c1d4dd3ee5c7489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095602Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#750209}
-
Peter Qiu authored
Bug: b/149794488 Test: Build Change-Id: I93b96001ba9b0b5f539a1799c29e15b22c13465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101828Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Auto-Submit: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750208}
-
Ulan Degenbaev authored
This fixes a mistake in crrev.com/747632 where the flag was added as a runtime-enabled feature that is not visible to Finch. The flag now is moved to blink/public/common/features.h Bug: 1049132 Change-Id: I2d13e6cb97fd57535861379ae5fc80dba9dc252d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102547Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750207}
-
Elly Fong-Jones authored
This change renames: * set_default_button -> SetDefaultButton * set_buttons -> SetButtons * set_button_label -> SetButtonLabel * set_accept_callback -> SetAcceptCallback * set_cancel_callback -> SetCancelCallback * set_close_callback -> SetCloseCallback so that these methods can start having side-effects (specifically, some consistency DCHECKs). This change was generated by this shell script: #!/bin/sh DD=DialogDelegate find . -type f -name '*.cc' -o -name '*.h' -o -name '*.mm' | \ xargs sed -i \ -e "s/$DD::set_default_button/$DD::SetDefaultButton/g" \ -e "s/$DD::set_buttons/$DD::SetButtons/g" \ -e "s/$DD::set_button_label/$DD::SetButtonLabel/g" \ -e "s/$DD::set_accept_callback/$DD::SetAcceptCallback/g" \ -e "s/$DD::set_cancel_callback/$DD::SetCancelCallback/g" \ -e "s/$DD::set_close_callback/$DD::SetCloseCallback/g" with a tiny amount of manual fixing-up afterwards. Bug: 1011446 Change-Id: Ic9d34ac05c759e9bcb0bd2ce3d26d2fc0dd2f611 Tbr: joedow@chromium.org,avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099084 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#750206}
-
Andrew Grieve authored
GN recently gained a filter_exclude() function, which is much more readable than set_sources_assignment_filter(). This changes uses of set_sources_assignment_filter() to use the new function in places where it was currently being used to perform explicit filtering (as opposed to the implicit filtering it was designed for). Bug: 1018739 Change-Id: I68eff058a6250f49b0adda2b4c5958bcfa2431e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102771Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#750205}
-
Garrett Beaty authored
Phase D migrates all of the try builders that are not includable-only. Migrate the try builders and the builders that they mirror to the versioned subdirectory. bucketed_triggers is set to False for the ci builders since there are not yet multiple builders with the same name to result in a different scheduler job name. They will be removed on branch day. Bug: 1024644 Change-Id: I68f05c82b631b0ae56200f62599a440ecb02d70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098274 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#750204}
-
Sorin Jianu authored
This CL provides the COM client code to call when --ua runs. The code is not working yet since the query interface for IUpdater returns "type libraries not registered (0x8002801d). It seems that the server also does not get activated by COM and it needs to be manually started with --server for now. Bug: 1053729 Change-Id: Iaafd96ad81617537ee693cf702274b68cf3b374a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101938Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750203}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a115a24bfd7..ef7ec269b5b5 Created with: gclient setdep -r src-internal@ef7ec269b5b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058993 Tbr: jbudorick@google.com Change-Id: I4e69fb93d147319a5e0165721c3333758a939eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750202}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c9ba12998fd2..658be97b1940 git log c9ba12998fd2..658be97b1940 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 lalitm@google.com Merge "ui: switch process summary tracks to use track_ids" 2020-03-13 skyostil@google.com Merge "docs: Add documentation for recording traces programmatically" 2020-03-13 hjd@google.com ui: Use experimental_counter_dur Created with: gclient setdep -r src/third_party/perfetto@658be97b1940 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2e25049af14942ce643517ac4c55846d575e0f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750201}
-
yilkal authored
This Cl ensures that system notifications for a particular application are delayed until AppActivityRegistry receives a signal from AppService that an application has been installed. Bug: 1056469 Change-Id: Ifb38093ee04f17ee88787e6f2824b6840822e4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101709 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#750200}
-
Raymond Toy authored
Change GetClosure() in test_helpers.h to return a OnceClosure instead of Closure. This remaining changes are knock-on effects of the GetClosure() change. Basically need to call RunOnceClosure() instead of RunClosure() and need to update some class members to be OnceClosure instead of Closure. Bug: 1007799 Change-Id: I53024573f6e3cca94787a8213b00c069cb7c3aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095858Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#750199}
-
David Maunder authored
This is causing the app to crash for frozen Tabs Bug: 1059153 Change-Id: If5c10f629fd6e4396cdf34421dc02b80224006cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095396 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#750198}
-
Nico Weber authored
No behavior change. Bug: 346399 Change-Id: Ie643a6cba6607ba333bad7fc35601b9d43856dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102632 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#750197}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c5ee8e0342d1..b1b6a171ee02 git log c5ee8e0342d1..b1b6a171ee02 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 courtneygo@google.com Vulkan: Disable robustness support Created with: gclient setdep -r src/third_party/angle@b1b6a171ee02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I842cff5f7033aa779dd0158425ed22efb9597e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102749Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750196}
-
Arthur Eubanks authored
If I currently have a branch with commits checked out, upload_revision.py will create a branch from that. The "-r" flag doesn't work for me, omitting it does work. Given that the new branch is directly branched off of origin/master, `git cl try` should work without the "-r" flag. Change-Id: I54e66b3318a8d0548cda63b2906d206db0d02987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101533 Auto-Submit: Arthur Eubanks <aeubanks@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750195}
-
Mario Sanchez Prada authored
This CL converts the message that requests a one-time snapshot of the accessibility tree from the renderer along with the response message that should be sent back to the browser process once the message has been handled. Note on android-binary-size increase (+17,454 bytes): the reason for this size increase is the need to use the new mojo typemappings for structs AXContentTreeUpdate, AXContentTreeData and AXContentNodeData, added in CL2050270[1], to efficiently migrate this legacy IPC message to mojo. This shouldn't have been a problem in itself but those new typemappings rely on other typemappings (AXTreeUpdate, AXTreeData and AXNodeData) that were already present in the codebase before [1] even though they were not used, meaning that this CL is pulling new symbols related to all those 6 structs at once, increasing the binary size a bit over the limit of 16,384 bytes. [1] https://crrev.com/c/2050270 Bug: 1010831 Binary-Size: Size increase is unavoidable (see above). Change-Id: I6a89974b485b9fd845126d31ad4216f0ea20133f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050272 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#750194}
-
Majid Valipour authored
This is a reland of da0cc146 Original change's description: > Prepare CSSOMViewScrollCoordinates for finch trial > > Following best practice advice from go/finch-blink: > - Update testing config variation to enable the flag > - Update file_manager test to expect the new behavior > > Bug:721759 > > Change-Id: I727eef6b50cf09027945bcd645335b39ee83ba2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087422 > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749856} TBR: flackr@chromium,noel@chromium.org Bug: 721759 Change-Id: Iaf9d9803e2baa2032de9335432fb5442cc8be4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101188Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#750193}
-
Jeffrey Cohen authored
Bug: 1025362 Change-Id: Ib30fcca4826d7102deabf0589958fab7dd853a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101293Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#750192}
-
Stepan Khapugin authored
Fixes the test. Bug: 1060699 Change-Id: Id487a1a01f8adae811c501c95193f7fa4dd983e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102488 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#750191}
-
Himanshu Jaju authored
WebRTC service is only available on Desktop but the sender is enabled by default on all OS. This can cause sending for shared clipboard to fail if a user is trying to send text from Android to Desktop if the Desktop client falls under the experimentation. Bug: 1061393 Change-Id: I3804e784b3dc72d90bb673d22a9d57ebbe76d99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100858 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750190}
-
Chong Gu authored
Fix fuchsia_telemetry_gpu_integration_test DEPS. Add fuchsia_telemetry_gpu_integration_test to gn_isolate_map. Add fuchsia_gpu_telemetry_tests test suite. Bug: 1058255 Change-Id: Iaaccc6d165ebf8e1c928eca032224a11a043fe95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099022Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#750189}
-