- 05 Sep, 2019 40 commits
-
-
Dave Tapuska authored
Remove a nested RequestContext that didn't do anything. Rename or reuse variable on stack for remaining shadowed errors. BUG=794619 Change-Id: I12f61d5528d62ee64d82104d190eecb6ccd65a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784973Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693682}
-
David Staessens authored
This CL changes the video_decode_accelerator_(perf_)tests to not read data beyond the end of the test video file, by adding proper bounds checking. TEST=./video_decode_accelerator_tests \ vda_sanity-vp90_2_17_show_existing_frame_20190109.vp9 BUG=None Change-Id: I486eb6eb89fd13d9985ee518178b65dadf158e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775944Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693681}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d29c5b184087..79401df82ffb Created with: gclient setdep -r src-internal@79401df82ffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I062d39eaaf367b47886776eb0af4ebfe40aedb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693680}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/24b945d60526..f3f61591146b git log 24b945d60526..f3f61591146b --date=short --no-merges --format='%ad %ae %s' 2019-09-05 saza@webrtc.org Rename VectorBuffer->SpectrumBuffer, MatrixBuffer->BlockBuffer, BlockBuffer->Aec2BlockBuffer 2019-09-05 jakobi@webrtc.org Make relative arrival delay mode default in NetEq delay manager. 2019-09-05 saza@webrtc.org Make VectorBuffer in AEC3 multi-channel 2019-09-05 danilchap@webrtc.org Delete deprecated rtc_event_log_factory_interface.h Created with: gclient setdep -r src/third_party/webrtc@f3f61591146b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Iae086e6532ba46cc65761a7913e0e76dc7b3b06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787837Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693679}
-
David Roger authored
These metrics were introduced for investigation of bug 876306. Enough data has been collected for the investigation, there is no point in collecting more data. This CL removes all the metrics except ListAccounts.NetErrorCodes because this metric can be used to monitor the health of the signin component and help diagnosing problems. Bug: 986524, 986518, 986513, 876306 Change-Id: I032e6fe181d91982a6a1811d91883bea6dce810e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784613 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693678}
-
Rayan Kanso authored
Record whether the fired sync events upon completion originated from a wakeup task. This metric can be used with the BackgroundSync.WakeupTaskFiredEvents metric to figure out how common it is to wake up the browser to fire events without actually completing them. To make the metrics accurate, delayed tasks are allowed to reschedule now. Bug: 991326 Change-Id: Icf3922995230b15e867574bb7b348e1627268ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781589 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#693677}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/component_updater. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=waffles@chromium.org Bug: 891670 Change-Id: I4f3806776673850e73bd3d6966d1ae50b0b5e43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786752 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#693676}
-
Miyoung Shin authored
This CL converts WakeLockProviderPtr in chrome, chromeos, components, content, extensions and services and WakeLockProviderRequest in services to the new Mojo types. Bug: 955171 Change-Id: I5e95a88fc154fee57930e37871ca670d547c42d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768611 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#693675}
-
Gabriel Charette authored
Backport some tests in /ui/views/cocoa/bridged_native_widget_unittest.mm to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/views/cocoa/bridged_native_widget_unittest.mm. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=ellyjones@chromium.org Bug: 891670 Change-Id: I849eac5a74cdb4436db995a38d4be4133b0d6381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786745 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#693674}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ios/net. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=ellyjones@chromium.org Bug: 891670 Change-Id: I06b784de2f3374bcf57a1b0a39a9df200e67e953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786969 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/99431375c8b5..ca5ee4c937cc git log 99431375c8b5..ca5ee4c937cc --date=short --no-merges --format='%ad %ae %s' 2019-09-05 lalitm@google.com Merge "trace_processor: expose gpu tables to SQLite" Created with: gclient setdep -r src/third_party/perfetto@ca5ee4c937cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I7ed59b33d6a4bb7bc075255c4307f30758e901aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787522Reviewed-by:
-
Jérôme Lebel authored
Removing unified consent from ios/chrome/browser/signin. Bug: 951313 Change-Id: Iccf5a419b752b3ab9bbb2b6fb18324bfbdcb813c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785057 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#693671}
-
Chih-Yu Huang authored
In the next CL (CL:1777446), we will create a new interface inside VideoDecoderPipeline, and let Vaapi/V4L2 depend on it. To avoid circular dependency, this CL makes VideoDecoderPipeline not depend on Vaapi/V4L2 target. BUG=chromium:998413 TEST=run video_decode_accelerator_tests on Kevin Change-Id: I894420cbc64045e984ac89e90c8e6e891b040f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786894 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#693670}
-
Peter Beverloo authored
Change-Id: I746b37d04263b9b73226095d2a346bb730b360ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771907 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d838a8c279f..60a0dc7071fd git log 4d838a8c279f..60a0dc7071fd --date=short --no-merges --format='%ad %ae %s' 2019-09-05 swiftshader.regress@gmail.com Regres: Update test lists @ 4d838a8c Created with: gclient setdep -r src/third_party/swiftshader@60a0dc7071fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I8dc142229936817ebf45c030eb5bb0f6f701446a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787677Reviewed-by:
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/3bcb567d8f69..a900ccebcf42 $ git log 3bcb567d8..a900ccebc --date=short --no-merges --format='%ad %ae %s' 2019-09-05 cwallez Remove indirection for computeStage 2019-09-05 cwallez Match WebGPU's TextureViewDescriptor.dimension defaults. 2019-09-05 cwallez Remove indirection for vertexStage 2019-09-05 cwallez Make TextureFormat/ViewDimension::None Undefined and value 0. Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org BUG-dawn: 22 Change-Id: Ia4dfc08fe718bc7f70779e9557b72f5cac7b5a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787777Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#693667}
-
Matt Falkenhagen authored
List specific examples for clarity. In particular, I couldn't find "platform-specific |Pre/Post...()| methods" and think it's referring to embedder-provided methods. Change-Id: I92a33523609076d54d00ee397f2523be068f23a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786887Reviewed-by:
-
Takashi Toyoshima authored
This patch creates a new fyi bot, linux-oor-cors-rel, to run oor_cors_gtests. Currently, the OutOfBlinkCors flag is enabled by default, and only a few tests run as parameter tests to run with both mode. Once this bot start running with OutOfBlinkCors enabled, we will flip the flag back to Disabled so that tests run with disabled mode in other bots, and move the parameter tests back to the normal test. We will maintain both running mode until the enterprise escape hatch period for the OOR-CORS finishes. Bug: 1000554 Change-Id: I609124f63297d051795f81e67471ca6be6814e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787480 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#693665}
-
Himanshu Jaju authored
Bug: 996661 Change-Id: I1114a70fb91fb4d7890fd100109683adc06943af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787639Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#693664}
-
Andrei Chulkov authored
This change was requested by UX for the password manager onboarding and leak detection dialog. It also makes sense to use a filled button in a few currently existing dialogs. The change mostly modifies the theme which is set for the modal dialog. Attributes that are not related to the style of the buttons were left in the old theme. Two new themes were created that inherit from the latter, which set the correct styles for the buttons and the right sizes for the button bar paddings. For this additional attributes had to be added for the DualControlLayout, to make setting the paddings in the style possible. The style used is chosen based on a readonly property, which can be set once on the dialog and is only read once before inflating it. The ViewBinder enforces that a filled button is not used as the only button. This CL changes the style of the button for the password manager onboarding and leak detection dialogs. Bug: 983445 Change-Id: Ib2fa8d95bd009d697d11f579757ce2ebd886dff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778763 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#693663}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/065dd27357bc..24b945d60526 git log 065dd27357bc..24b945d60526 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 henrika@webrtc.org Add support of AudioRecord.Builder in the ADM for Android Created with: gclient setdep -r src/third_party/webrtc@24b945d60526 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I517f977780ccf7b52e265c7ca03cf48f6ccca71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787443Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 895b067e. With Chromium commits locally applied on WPT: e7387117 "[sms] Allow SMS Receiver for same origin iframes" 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." afac3266 "Set `Sec-Fetch-Mode` from the network service." 851ab8fb "[WPT/referrer-policy] Regenerate attr-referrer tests" 6facce4a "[WPT/referrer-policy] Regenerate img-tag meta-referrer tests" 9d98088f "[WPT/referrer-policy] Regenerate a-tag tests" c5326d3f "[WPT/referrer-policy] Regenerate img-tag http-rp tests" bb9c94d9 "Simplify fetch-event-within-sw.https.html using async/await" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic15bc082f5b39427877e5720f133e210b7bbe53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786831Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693661}
-
Xida Chen authored
Right now when a custom property is not registered, off-thread paint worklet would fall back to the main thread. This is because a non-registered custom property is treated as a CSSUnparsedValue which is then converted into a CrossThreadUnknownType and thus is not supported by off-thread paint. This CL creates a CrossThreadUnparsedValue which contains a string only. After this, we can pass the CrossThreadUnparsedValue cross thread boundaries and make off-thread paint worklet support it. Bug: 996723 Change-Id: Iefed16ad6106570e4a4a62ed718e6b6e4feeca14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778806Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#693660}
-
Joel Hockey authored
Change-Id: I4ea3cc88c4c2c4aacfa6c5993b233c43fc43c88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786884 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#693659}
-
Alexander Hendrich authored
This CL upgrades all permissions whitelisted for the Imprivata extensions from dev to stable. Bug: 956540, 945345, 957573, 980171, 980460, 940401, 996125 Change-Id: Ife8b3f37e8e1775275bc3316a52985dfd77f94b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782898Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#693658}
-
Richard Knoll authored
This adds remote devices to the ChromeOS external protocol dialog so users can select devices or installed apps. This preserves any stored preference if users have previously stored a default handler. TBR=dominickn@chromium.org Bug: 993309 Change-Id: Ibcc31a6dfac0fe9f2b3467429edb0a4a8c5dce12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774923 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#693657}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63283689f1bf..d29c5b184087 Created with: gclient setdep -r src-internal@d29c5b184087 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I4bd21b7094b4eb314ed256a544c5dd39d2326bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786580Reviewed-by:
-
Olga Sharonova authored
This reverts commit 67e6ba1c. Reason for revert: Multiple WebSocket* tests failing on MSAN, see https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/15008 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/1909 Original change's description: > [WebSocket] Reduce memcpy at websocket_frame_parser.cc > > This patch removes memcpy at WebSocketFrameParser::Decode to > WebSocketFrameChunk. > To share memory, this changes WebSocketFrame and WebSocketFrameChunk > member type from `scoped_refptr<IOBuffer>` to `char*` referencing > WebSocketStream memory in most cases. > That change needs all users of the classes taking care of reference > life cycle. > WebSocketBasicStream and WebSocketDeflateStream keeps the memory > until next ReadFrames(). > Most tests just copy and hold the memory. > > ToT: 196 MB/s > Patch: 212 MB/s (+8%) > Also this work is accelerated upon more memory consuming flag. > See comments for detail. > > Bug: 865001 > Change-Id: If97651eb61e44805f413fdb7469a5dead5300d21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774420 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693542} TBR=ricea@chromium.org,yhirano@chromium.org,yoichio@chromium.org,crouleau@chromium.org,johnchen@chromium.org Change-Id: I2ad89a78465984491e394ad8881a62efcc9bc9d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787604Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693655}
-
Thomas Tangl authored
This is part of the profile menu revamp. Bug: 995720 Change-Id: Ia81eb5b18c7f8d29e7c14ec42df1e46171afecf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786443Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#693654}
-
Kai Hsien Boo authored
This CL adds an option to save an image's metadata. The design doc is here: go/cca-expert-mode Bug: b:134636934 Test: tast run DUT camera.CCAUIExpert camera.CCAUISettings Change-Id: I2300ba781945e22bbb6217d8c30efa8e1bc4bbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743874 Commit-Queue: Boo Kai Hsien <kaihsien@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#693653}
-
Himanshu Jaju authored
Implements different error messages to be shown on Android based on result of trying to share content with other device. Try Again button is in WIP in a follow up CL. Bug: 996322 Change-Id: I8f9e24257202eb76d5431504dbc172ba21c60e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787638Reviewed-by:
-
Yutaka Hirano authored
We're planning to use it to measure the memory impact of the feature. Bug: 1000994 Change-Id: I64406765ab57e11aeb92bead2c50298fecca85db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787029 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0c35e0f44dbd..ecac2f8fe9bb git log 0c35e0f44dbd..ecac2f8fe9bb --date=short --no-merges --format='%ad %ae %s' 2019-09-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 9b3cc3e05337..19b256616d96 (3 commits) Created with: gclient setdep -r src/third_party/angle@ecac2f8fe9bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: I62ca26376fb66e2636bdd61da51e182d5f6966d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786925Reviewed-by:
-
Gauthier Ambard authored
This CL removes some code that was added as a temporary patch to solve a ReadingList bug. The real fix was added in crrev.com/c/1768324. Bug: 988909 Change-Id: I7d85bdfd941d81c9936a127015fc89f399da9107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787321 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#693649}
-
Shik Chen authored
Bug: None Test: Open Hangout and check the capture intent is not unknown. Change-Id: I8659edd9c4b9b5cd3a8964712ef53e00c76d1b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786373Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#693648}
-
Alexander Hendrich authored
This CL upgrades the 'signin_screen' behaviors whitelisted for the Imprivata extensions from dev to stable. Bug: 956540, 945345, 986266 Change-Id: Ib2cd9a28990deb84f83be76358b4d97f5626a542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783139Reviewed-by:
-
Friedrich Horschig authored
This CL (re-)introduces the modern_blue_700 color which could ensure that text on selected chips meet the proper contrast ratio. (screenshot of this very subtle change in the bug) Bug: 999142 Change-Id: I25ebdfba23abd192e943a09551ba0ac8b62e6585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776049Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#693646}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ebac3a0234ee..dc5858f0a40a git log ebac3a0234ee..dc5858f0a40a --date=short --no-merges --format='%ad %ae %s' 2019-09-05 tcwang@google.com afdo: Publish the changes to kernel metadata as a CL. Created with: gclient setdep -r src/third_party/chromite@dc5858f0a40a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I78830d2bc3abbab1eb3a0a2517a59aaaa1b8c931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786579Reviewed-by:
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled. This CL makes browsing_data test utils aware of the core thread instead of assuming the IO thread. Bug: 824858 Change-Id: Idd9d32610776c9b7c48003564dc5e9407a467e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786458Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#693644}
-
Dominic Farolino authored
This reverts commit 95fc19d5. Reason for revert: (To be extra safe for branch point) This CL changes the semantics of SecurityPolicy::GenerateReferrer. Similar logic in the net layer (URLRequestJob::ComputeReferrerForPolicy) must also be updated alongside the SecurityPolicy changes. At the time of writing this CL I was not aware of the URLRequestJob method. Not updating this method alongside my changes caused issues seen in http://crbug.com/1000614. The next step is to introduce the URLRequestJob alongside this CL, as well as a web-platform-test ensuring the issues in the crbug do not crop up. This CL will be re-landed as soon as this is finished, and after the branch point. Original change's description: > Fix `Referer` for descendant module scripts and worklets > > This CL addresses a problem with SecurityPolicy::GenerateReferrer > when it comes to checking the same-origin-ness of a request. The > WebAppSec Referrer Policy Standard defines a same-origin request [1] as > one where the request's origin and current URL are same-origin with > each other. This comparison is done in "determine a request's referrer" > algorithm. > > The analogous place in our implementation is > SecurityPolicy::GenerateReferrer. Before this CL, GenerateReferrer would > determine a request's same-origin-ness by comparing the origin of the > request's referrer string and the origin of the request's current URL. > Most of the time this was sufficient, as the request's referrer string > is almost always same-origin with the request's origin (initiator > in Blink). With descendant module scripts and worklets however, the > origin of the request's referrer string and request's origin (initiator) > could be different, which breaks the correctness of our GenerateReferrer > method. > > This CL introduces a blink::SecurityOrigin parameter to the > GenerateReferrer method, so that correct same-origin comparisons can be > carried out. In all GenerateReferrer call-sites, an appropriate origin > is passed in. > > [1]: https://www.w3.org/TR/referrer-policy/#same-origin-request > > Bug: 786862 > Change-Id: I8cd9ff62790c3b4387ba2dff337e489c5f10da58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768501 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692554} TBR=kinuko@chromium.org,yhirano@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,nhiroki@chromium.org,dom@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 786862 Change-Id: I7edc6b7ac235a620b3939184883dcfaa6d209403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787482Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#693643}
-
