- 03 Jul, 2018 40 commits
-
-
Dominic Battre authored
If a user focuses a field for which password generation is promoted, a popup is shown. http://crrev.com/288935 introduced that this popup remains visible until the user has typed 5 characters, hypothesizing that users look at their keyboard while typing and therefore not notice the popup. Our new hypothesis is that this a) may not be true, and b) may bother users because the popup occludes part of the website, in particular it can occlude password requirements for users who chose to invent their own password. This CL introduces a Finch experiement such that we can test whether keeping the popup visible until the user has typed >5 characters produces a statistically significant higher number of generated passwords. If not, we can just hide the password generation popup as soon as the user has typed a key. The default configuration sticks to the 5 character threshold. Bug: 859472 Change-Id: I1d2a82ce90f696dc32d97633ac29ba15f3ea9bbd Reviewed-on: https://chromium-review.googlesource.com/1122399 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572131}
-
Bill Orr authored
The page encodes a frame id into the clear color, clears the texture, then submits it. The test then reads the frame id, and validates that the pose used was the expected pose used. The test found an issue where frames would be submitted after getting the next frame's pose, causing extra latency and worse reprojection. This is fixed as part of the change so the test passes. BUG: 854309, 850165, 801034 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0f891e9929d4a0427c74ae137ed2a9c31d7744cd Reviewed-on: https://chromium-review.googlesource.com/1123228 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572130}
-
Gauthier Ambard authored
This CL changes the background color of the infobars to be more aligned with the UI Refresh look. Bug: 817753 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I06db3d63b619fc63bf381d936f4c59cab4afaa28 Reviewed-on: https://chromium-review.googlesource.com/1122860Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#572129}
-
Jinsuk Kim authored
Fixes bugs reported after landing: - Android CFI test failures https://crbug.com/854611 WebContentsViewAndroid::SetFocus should have null checks as well, and should not have run in the tests that use TestRenderViewHost. The tests failed due to invalid cast (TestRenderWidgetHostView -> RenderWidgetHostViewAndroid), which was caught by CFI config. And even in real situation ::SetFocus should run only when the RenderWidgetHostViewAndroid is not null. These two issues are addressed by calling the method when current RWHVA is non-null. - Amazon app not getting key input https://crbug.com/854499 WebContentsViewAndroid::RenderViewSwappedIn and WebContentsObserver::RenderViewHostchanged were not always called together. This caused the WebView not to get the updated after the change. This CL deletes RenderViewSwappedIn and defines RenderFrameSwappedIn, and invokes it from WebContentsImpl::NotifyFrameSwapped to ensure native view tree update + focus change occurs in response to the main render frame host swapping. Bug: 598880, 854611, 854499 This reverts commit efb24e49. Change-Id: Ieaa3d43029583a17560dc83b5009416e71e89f13 Reviewed-on: https://chromium-review.googlesource.com/1112950 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#572128}
-
Luciano Pacheco authored
These 3 tests have been failing a lot, passing only 60% of time according to findit-for-me. Tbr: xiyuan@chromium.org Bug: 859715 Change-Id: I45f89d626cccad4d1aac55184e7aac11fc862bc9 Reviewed-on: https://chromium-review.googlesource.com/1124001Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572127}
-
Kyle Milka authored
Add a new EmbeddedSearch API for allowing users to select a local file for the NTP background image. After a file is selected copy it to the Profile directory. Set the background url preference to the new endpoint, chrome-search://local-ntp/background.jpg, which serves the file. Bug: 839152 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I90e9768f468748f7c072d36c71c2a9a859cba490 Reviewed-on: https://chromium-review.googlesource.com/1101639 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#572126}
-
Darren Shen authored
In 1119610, there were some comments that were addressed, but the updated patch was not uploaded by mistake. This patch just addresses those comments. TBR=yhanada@chromium.org, jamescook@chromium.org Bug: 849980 Change-Id: Ida53707785789fda4b8ee687198932dd266477fb Reviewed-on: https://chromium-review.googlesource.com/1124074 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#572125}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I8dfa0e2421a7c9142bc0a0381be714acfe2faab0 Reviewed-on: https://chromium-review.googlesource.com/1124101Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572124}
-
Oscar Johansson authored
When building using jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variable kDefaultNumConnections in: net/third_party/quic/core/congestion_control/cubic_bytes.cc net/third_party/quic/core/congestion_control/tcp_cubic_sender_bytes.cc This commit solves the issue by moving the variable definition to net/third_party/quic/core/quic_constants.h. Bug: 772146 Change-Id: Ib7c961511823a8ecbc996775485a5fe23649e65e Reviewed-on: https://chromium-review.googlesource.com/1120169Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#572123}
-
Kuo-Hsin Yang authored
BUG=852906 Change-Id: I6a5c7624bca5ad803047247f668014c84d866b91 Reviewed-on: https://chromium-review.googlesource.com/1119732 Commit-Queue: Vovo Yang <vovoy@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#572122}
-
Xianzhu Wang authored
Now we get paint_offset from FragmentData::PaintOffset() which is calculated during PrePaint. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic8bf17e7eec4c32a8f0cd6aa683c7f956f74e06f Reviewed-on: https://chromium-review.googlesource.com/1121282 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572121}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43033409f481..5484b866dc93 git log 43033409f481..5484b866dc93 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 tandrii@chromium.org bot_update: use buildbucket's gitiles_commit as repo/revision input. Created with: gclient setdep -r src/third_party/depot_tools@5484b866dc93 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id730c487b63dbd9b5c690519d09fb15efb92bd8f Reviewed-on: https://chromium-review.googlesource.com/1123942Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572120}
-
Hiroki Nakagawa authored
For cleanup, this CL... - moves BaseFetchContext::PrintAccessDeniedMessage() from 'protected' to 'private', and - inlines BaseFetchContext::AddCSPHeaderIfNecessary() in FrameFetchContext::PopulateResourceRequest(). Bug: 845285 Change-Id: Id16a9210cef284ddb814cf1ee4a2da81bb12f030 Reviewed-on: https://chromium-review.googlesource.com/1123978Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#572119}
-
Darren Shen authored
ShowImeIfNeeded shows the virtual keyboard, not IME. Also fix some presubmit issues. TBR=sky@chromium.org, sammc@chromium.org Bug: 737306 Change-Id: I45630beb927af24157681ce2929f6cfd7fe8bf3f Reviewed-on: https://chromium-review.googlesource.com/1121938 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#572118}
-
Ramin Halavati authored
A new content settings provider for ephemeral permissions is added and flash permissions are moved to it. This provider keeps the permissions as long as the current session is not closed. Bug: 850062 Change-Id: Ib0825eeb39dbf7a341ac47a537f0f0bdfaf7848d Reviewed-on: https://chromium-review.googlesource.com/1107988Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#572117}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e01683e81de0..37774c911e68 git log e01683e81de0..37774c911e68 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@37774c911e68 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ia596a4bdf6588c5ad4159615d6f11cde0663f513 Reviewed-on: https://chromium-review.googlesource.com/1124019Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572116}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3166e28a..ff8c49dd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I61f3776dbd2a218208aaf3d30b5ded88045f9684 Reviewed-on: https://chromium-review.googlesource.com/1123879Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572115}
-
Alan Cutter authored
This CL moves the ZoomView icon from LocationBarView to PageActionIconContainerView for reusability in the HostedAppButtonContainer. The user visible effect of this is the zoom icon can be seen in hosted app window title bars, see screenshots below. As part of this generalisation: - The PageActionIconView::Delegate class now reads an SkColor instead of an OmniboxTint for consistency with other title bar icons, see screenshots below. - The size of the zoom icon (and other page action icons that get migrated in the future) is reduced in touch optimised mode for the HostedAppButtonContainer to avoid stretching the title bar region vertically when shown. Native icon colours: https://bugs.chromium.org/p/chromium/issues/attachment?aid=339750&signed_aid=0n6nlPPzzcaH-Xc58twlyA==&inline=1 Light theme icon colours: https://bugs.chromium.org/p/chromium/issues/attachment?aid=339751&signed_aid=Rg4OpeJyhj-_-5vGILuzYw==&inline=1 Dark theme icon colours: https://bugs.chromium.org/p/chromium/issues/attachment?aid=339752&signed_aid=EbybLy_ZlxoIfr2cKOjqzw==&inline=1 Bug: 788051 Change-Id: I8b761f1efbce8cdb62c6501327fdfcfe7ba7d912 Reviewed-on: https://chromium-review.googlesource.com/1051141 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#572114}
-
Luciano Pacheco authored
Test marked flaky by Try-Flakes. Tbr: fsamuel@chromium.org Bug: 859478 Change-Id: Ifa599ff89261cec4fa056f6868d8a544f5ec94fb Reviewed-on: https://chromium-review.googlesource.com/1124039Reviewed-by:
-
Matt Falkenhagen authored
These are obsolete by the ServiceWorker.StartTiming.* ones. The motivation is to make further code changes easier, like removing some of the IPC messages. Bug: 855952 Change-Id: I8ed8266fdef1641f74011c2fa6889908c889fa0f Reviewed-on: https://chromium-review.googlesource.com/1122676Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#572112}
-
Yoshifumi Inoue authored
This patch changes "childNodes-reverse-iteration.html" to utilize w3c test harness for ease of maintenance. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Change-Id: Ie4f834134639bd2b21838764c032183319d62a73 Reviewed-on: https://chromium-review.googlesource.com/1122073Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572111}
-
Luciano Pacheco authored
Fully disabled now since it started failing on linux_chromium_rel_ng too. Tbr: pfeldman@chromium.org Bug: 859382 Change-Id: Ic5dc2df56629d32b4ac76b3a8f6607cfa32db92d Reviewed-on: https://chromium-review.googlesource.com/1124000Reviewed-by:
-
Wez authored
This is a partial reland of b035cfda, which was reviewed on https://chromium-review.googlesource.com/1082980 TBR: gab, thakis Bug: 844016 Change-Id: I56847225b6eec13f182d03de5cf831b7c5362ad7 Reviewed-on: https://chromium-review.googlesource.com/1123888Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572109}
-
Luciano Pacheco authored
Test has been marked as flaky by Try-Flakes for different builders. Tbr: nasko@chromium.org, alexmos@chromium.org Bug: 859487 Change-Id: I39a8fd525a91b8bf6b6e4ab1b1c5c56ee0e38756 Reviewed-on: https://chromium-review.googlesource.com/1123999Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a72f400c5ff3..92da844eb754 git log a72f400c5ff3..92da844eb754 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 jgilbert@mozilla.com More includes missing from sources. Created with: gclient setdep -r src/third_party/angle@92da844eb754 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I2b2ce54510ea4002d4684fa1089b5e4a207cd78e Reviewed-on: https://chromium-review.googlesource.com/1123941Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572107}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/90cac980d26c..43033409f481 git log 90cac980d26c..43033409f481 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 tandrii@chromium.org bot_update: remove legacy Gerrit patch property support. 2018-07-03 ehmaldonado@chromium.org gclient setdep: Add support for CIPD versions 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@43033409f481 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:858978 TBR=agable@chromium.org Change-Id: Ia92beb7992aba3123410dfa8ea295b95bec46f52 Reviewed-on: https://chromium-review.googlesource.com/1123940Reviewed-by:
-
Hayato Ito authored
Format renderer/core/dom/README.md by prettier. BUG: 742715 TBR=kochi NOTRY=true Change-Id: Ib67571d3490a64681ef32f2bfcc47578e7282012 Reviewed-on: https://chromium-review.googlesource.com/1123975 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#572105}
-
tzik authored
LifecycleObserver construction used to hit a CFI check failure under the Oilpan incremental marking. This CL adds a test to confirm it's fixed and it's not broken again. Bug: 854639 Change-Id: If2990658921168fe83053facbc3c780607bbff07 Reviewed-on: https://chromium-review.googlesource.com/1123661Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#572104}
-
tzik authored
This CL fixes a CFI check failure on the Oilpan incremental marking. The initialization of ContextLifecycleObserver is done as: 1. Allocate sufficient memory for the instance 2. Call GCM constructor 3. Update the vptr to point LifecycleObserver's vtable 4. Call the body of LifecycleObserver constructor. 5. Update the vptr to point ContextLifecycleObserver's vtable 6. Call the body of ContextLifecycleObserver constructor. In the step 4, the constructor calls SetContext, which casts the instance from LO to CLO and stores it to LifecycleNotifier, and that causes Trace() or GetTraceDescriptor() call on CLO, rather than LO. Note that the instance is ready as an LO instance, but not ready as an CLO instance at the moment. While a virtual method of CLO is being dispatched, CFI checks if the vtable of the receiver is for CLO or its subclass, but that was not true as the vptr points LO's vtable until the step 5. After this CL, LO::Trace() or LO:GetTraceDescriptor() will be called in SetContext(), rather than CLO::Trace() or CLO::GetTraceDescriptor(), that should be ready to call before the step 5. Bug: 854639 Change-Id: Ib27f147099ccb416d5f357fccd401d003de2dcaa Reviewed-on: https://chromium-review.googlesource.com/1122140 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#572103}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/54fd491d8bee..e01683e81de0 git log 54fd491d8bee..e01683e81de0 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e01683e81de0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I8c9396838cdc2f3437ec467027932353b175ad9e Reviewed-on: https://chromium-review.googlesource.com/1123939Reviewed-by:
-
Xianzhu Wang authored
This CL doesn't actually remove the paint_offset parameter, but lets all objects use FragmentData::PaintOffset(), and checks if the new paint offset equals to the old paint offset. Also add workarounds for 2 existing bugs to make the new paint offset correct: - crbug.com/858843: Modify PaintPropertyTreeBuilder to workaround the bug to produce correct paint offset for floating objects in RTL container with scrollbar on the left. - crbug.com/856802: We have to generate paint offset of LayoutScrollbarPart during painting because of the bug. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id7c891ef05ec02ab93a17a3ddc6001e916ff2400 Reviewed-on: https://chromium-review.googlesource.com/1114297 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Emily Stark authored
This CL deprecates UnsafelyTreatInsecureOriginAsSecure in favor of an equivalent policy named OverrideSecurityRestrictionsOnInsecureOrigin, which we think will be more clear to admins. Bug: 844885 Change-Id: I80fb2488b5495aff4f1b3308d96248fbe2221af9 Reviewed-on: https://chromium-review.googlesource.com/1107849 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#572100}
-
Ned Nguyen authored
Bug:859524 Change-Id: I7152a82888004508b21ec9d5a2d020019782f33f This is blocked on catapult roll to roll https://chromium-review.googlesource.com/c/catapult/+/1122957 Change-Id: I7152a82888004508b21ec9d5a2d020019782f33f Reviewed-on: https://chromium-review.googlesource.com/1122960 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572099}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/153acbd707c0..cbfa46069e2b git log 153acbd707c0..cbfa46069e2b --date=short --no-merges --format='%ad %ae %s' 2018-07-03 nednguyen@google.com Only output the total histogram format if there is at least a single page that succeed Created with: gclient setdep -r src/third_party/catapult@cbfa46069e2b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859073 TBR=sullivan@chromium.org Change-Id: I36cf6a327e921f83587cd3188f85f7e9d83e5e2f Reviewed-on: https://chromium-review.googlesource.com/1123781Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572098}
-
Aaron Leventhal authored
The layout bugs test runner uses an altered code path to post a11y notifications, that allows a listener to delete the very object that is firing the notifications. Do not attempt to further process a11y notifications for objects that are detached. Bug: 843960 Change-Id: I1e10ee014855c1d8f6fbf06c29c5a51c19fe1330 Reviewed-on: https://chromium-review.googlesource.com/1122714Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#572097}
-
John Budorick authored
Bug: 857001 Change-Id: I24219576e71cf636da916ed5119c32c37d5e5394 Reviewed-on: https://chromium-review.googlesource.com/1123268 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#572096}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/605dd3126a6c..90cac980d26c git log 605dd3126a6c..90cac980d26c --date=short --no-merges --format='%ad %ae %s' 2018-07-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@90cac980d26c The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie97eede695215f4a8fca4aa631d80dd32f300b38 Reviewed-on: https://chromium-review.googlesource.com/1123779Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I58b05780e046fcda2cf44ee54c85fdfce6422989 Reviewed-on: https://chromium-review.googlesource.com/1123922Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#572094}
-
rajendrant authored
Report resource type in DidStartResponse. This will be used by MetricsRenderFrameObserver to distinguish frame requests. Bug: 836029 Change-Id: I9e5cc9ec220286dd15b110114c624c81afe60e13 Reviewed-on: https://chromium-review.googlesource.com/1123374 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This cl increases build parallelism for * android_arm64_dbg_recipe * android_clang_dbg_recipe These builders have slow compile step time like below builds. * android_arm64_dbg_recipe 5935s https://ci.chromium.org/b/8942150764225931712 5163s https://ci.chromium.org/b/8942367352394832112 4696s https://ci.chromium.org/b/8942146814412549072 * android_clang_dbg_recipe 4257s https://ci.chromium.org/b/8942150764225931424 4102s https://ci.chromium.org/b/8942346357249144704 3984s https://ci.chromium.org/b/8942146814412548848 Bug: 804251 Change-Id: I2daa9d8e86bbee4c990e3518a7c0300754d42859 Reviewed-on: https://chromium-review.googlesource.com/1122062 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572092}
-
