- 14 Aug, 2018 40 commits
-
-
Ivan Sandrk authored
New strings are available @ https://docs.google.com/document/d/1cVwZrMVUwOWUCdHFJ2bRe0nVzam4xFNSozmObaKs2Tg Bug: 865947 Change-Id: I163605c3c82230a3a8b0dd9d96fd9eda038fe29b Reviewed-on: https://chromium-review.googlesource.com/1172686Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#582872}
-
Alexandr Ilin authored
This reverts commit bc740b07. Reason for revert: this commit causes compile errors on several internal.client.clank builders, particularly on "monochrome_bundle" target. Failed build: https://ci.chromium.org/buildbot/internal.client.clank/arm-builder-rel/20238 Original change's description: > [build:android] Add a module for AR in Monochrome > > Add an AR Dynamic Feature Module (DFM) and bundle it into the public > Monochrome bundle. > > + Add loadable modules to the build config so that their paths can be > passed to the module create target. > > + Add option to bundle targets to specify the Android SDK target for > synchronized proguarding. This was necessary because the Monochrome > base module uses a different Android SDK than the AR module, which > made proguard sad. Also pass the Android SDK Jar as a dedicated > classpath Jar to proguard and don't mix it with the other classpath > Jars. > > Bug: 863063 > Change-Id: I024d05dd99136c069e510995657ac7236f6b6e5e > Reviewed-on: https://chromium-review.googlesource.com/1165533 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582765} TBR=vollick@chromium.org,yfriedman@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: I87ab63c3153018390f4018527d760bbd10cdcd16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863063 Reviewed-on: https://chromium-review.googlesource.com/1174271Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582871}
-
Hayato Ito authored
Add Event path and Event Retargeting section. TBR=rakina Bug: 742715 Change-Id: I969f020cc0a762a6cc8695c4e5dc7cd03fcb32e0 Reviewed-on: https://chromium-review.googlesource.com/1174196 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#582870}
-
Elad Alon authored
When a profile is loaded for the first time, if the policy controlling remote-bound WebRTC event logs is disabled, clear any pending logs from previous times the profile was loaded, when the policy might have been enabled. Bug: 775415 Change-Id: If20928ba660f0be5a73c52a11ae521c5246c174a Reviewed-on: https://chromium-review.googlesource.com/1162322 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#582869}
-
Rayan Kanso authored
Bug: 780025 Change-Id: Ia8bb5d2667c4b9132cccbea5cfe5f6ce53e919a2 Reviewed-on: https://chromium-review.googlesource.com/1170829Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582868}
-
Kent Tamura authored
This simplifies the code slightly. This is a preparation to mojoify FileChooser IPCs [1]. [1] https://chromium-review.googlesource.com/1170454 Change-Id: I52058bedda4508991f88e1c45a09151be02d40e9 Reviewed-on: https://chromium-review.googlesource.com/1174081 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582867}
-
Alexander Alekseev authored
This CL increases OOBE startup sound delay to 4 seconds, and adds UMA metric on it. Bug: 848485 Change-Id: I5401a2625634315760906789fcd69afe04d2972c Reviewed-on: https://chromium-review.googlesource.com/1173014Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#582866}
-
Achuith Bhandarkar authored
Bug=chromium:871600 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I09f909050620f8d2e2e9a1fdedbe2c7091732128 Reviewed-on: https://chromium-review.googlesource.com/1173138Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#582865}
-
Dan Elphick authored
Remove uses of deprecated functions in file_browser_handler_custom_bindings.cc, replacing ToObject() on a known Object with .As<v8::Object>() and use the Context form of ToBoolean along with FromMaybe(false) Bug: v8:7786 Change-Id: Ib4726f5ae77797c736e35d36ae0ca25f50808a0a Reviewed-on: https://chromium-review.googlesource.com/1172436Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#582864}
-
Tetsui Ohkubo authored
OnMessageCenterScrolled should be fired when it's scrolled by fling. Otherwise, stacking notification counter https://crrev.com/c/1168945 and notification corners https://crrev.com/c/1161710 might show invalid state with touch screen. TEST=manual BUG=none Change-Id: I0a647bdd5af979775ef4ef4e8c470a96cbfd299a Reviewed-on: https://chromium-review.googlesource.com/1172233Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#582863}
-
Makoto Shimazu authored
This reverts commit fef811c5. Reason for revert: SaveType/SavePageOriginalVsSavedComparisonTest.Style becomes flaky and findit suggested this is the culprit. Let me revert this speculatively and see if it'll be fixed. Original change's description: > Mojoify FindInPage::Find > > We are mojoifying browser<->renderer communication of Find-in-page. > In this CL, we are converting the Find function to mojo. Find replies > are now separated into two functions, one to update the number of > found matches (SetNumberOfMatches) and the other is to update which > match is active right now (SetActiveMatch). > > This is the final function to be mojoified for FindInPage. > Mojoifying doc: https://goo.gl/JenyGm > > Bug: 819919 > Change-Id: I990160f973b29d7620214d7d58a16ece033adf3f > Reviewed-on: https://chromium-review.googlesource.com/1086950 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582841} TBR=dcheng@chromium.org,yosin@chromium.org,alexmos@chromium.org,rakina@chromium.org Change-Id: I0c48b0aed588049147f8cc49addaf1686fa67621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819919, 873965 Reviewed-on: https://chromium-review.googlesource.com/1173892Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582862}
-
Yuki Yamada authored
I am planning to replace V8AbstractEventListener and its subclasses by new classes I will implement for redesigning EventListener/EventHandler in https://crbug.com/872138, so it is better to remove unnecessary dependencies on the classes which inherits blink::EventListener before addressing that. Basically, we should not use blink::V8AbstractEventListener or other classes which inherits EventListener unless we have to use the methods implemented only in child class, but there are some cases that uses child classes without any need. Therefore this CL replaced child classes by blink::EventListener if possible. Bug: 872138 Change-Id: Idc82f93fdc850f532092cc021f6aa458803dcd7b Reviewed-on: https://chromium-review.googlesource.com/1170714 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582861}
-
Tetsui Ohkubo authored
According to UX, when the user drags the slider down to 0, it does not become muted. See the bug for the detail of the behavior. TEST=manual BUG=863488 Change-Id: Ie3e65fb3dd80c37773640e677ccf1ec12faabb03 Reviewed-on: https://chromium-review.googlesource.com/1172240Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3f2c0c03. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22699 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifd879bbc7d3c4057287aa7caec3b3eb72a3d21e7 Reviewed-on: https://chromium-review.googlesource.com/1174091 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582859}
-
Tetsui Ohkubo authored
According to UX, background color opacity of UnifiedSystemTray was dropped from 70% to 60%. TEST=manual BUG=863232 Change-Id: Idea912340d91e245cd6ca854b970c4d91e376057 Reviewed-on: https://chromium-review.googlesource.com/1173932Reviewed-by:
-
Adam Rice authored
This reverts commit f3d0a2f2. Reason for revert: The revert was not effective at mitigating https://crbug.com/864351, so reverting the revert as the original CL was effective against https://crbug.com/788890. Original change's description: > Revert "WS: Delete FileReaderLoader in BlobLoader" > > This reverts commit 530f6487. > > Reason for revert: Temporary revert to mitigate https://crbug.com/864351. This CL appears to have fixed https://crbug.com/788890, but that was a render process crash. 864351 is a browser process crash so preventing it is more important. > > Original change's description: > > WS: Delete FileReaderLoader in BlobLoader > > > > Delete the FileReaderLoader member of WebSocketChannelImpl::BlobLoader > > as soon as we are done with it. This moves the lifetime semantics closer > > to what they were before Oilpan, and saves a bit of memory. > > > > Also remove some obsolete pre-Oilpan comments, since > > WebSocketChannelImpl and BlobLoader are garbage collected rather than > > explicitly deleted now. > > > > BUG=788890 > > > > Change-Id: I815e53a3271a91dbeb779b6f386004b454d1db92 > > Reviewed-on: https://chromium-review.googlesource.com/1128837 > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Commit-Queue: Adam Rice <ricea@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#573647} > > TBR=ricea@chromium.org,yhirano@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 788890 > Change-Id: I71bdac66189d284637aabcb56998218a925aa01c > Reviewed-on: https://chromium-review.googlesource.com/1166303 > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581461} TBR=ricea@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 788890 Change-Id: If38f2acb5d20293c3dc3a1763464b823576d5767 Reviewed-on: https://chromium-review.googlesource.com/1170522Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#582857}
-
Makoto Shimazu authored
TBR=robertma@chromium.org NOTRY=true Bug: 856601 Change-Id: Iad0f3b236494cc6d1f14af0fc03518ebf3e0671a Reviewed-on: https://chromium-review.googlesource.com/1174144Reviewed-by:
-
tzik authored
NULL blocks scoped_refptr to support nullptr, and eventually blocks the removal of its implicit raw-pointer-to-scoped_refptr conversion. This CL replaces all relevant NULL in //gpu with nullptr. Tbr: bbudge@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6009249763ed14961bd5a725534419d2d0bf71f0 Reviewed-on: https://chromium-review.googlesource.com/1168960 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582855}
-
Mark Pearson authored
Change-Id: I4535fd202076e24efb6dc9d2e11be88a7fa023db Reviewed-on: https://chromium-review.googlesource.com/1173320Reviewed-by:
-
Jan Wilken Doerrie authored
This change implements BluetoothDevice::IsPaired() by querying the underlying device information. Furthermore, a test is added, which is currently only enabled for Windows. Bug: 821766 Change-Id: Idaed73fe544f115c1a0fc2157f477b009f4c26a6 Reviewed-on: https://chromium-review.googlesource.com/1172971Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#582853}
-
Lei Zhang authored
Change-Id: Ieaabe95f426ef5ebb5846108fde3227efd1c3113 Reviewed-on: https://chromium-review.googlesource.com/1173759Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582852}
-
file:///Naoki Fukino authored
The root directory for Android files (the user's "emulated external storage", which is accessible from Android file picker) is mounted on a fixed path on Chrome OS side: /run/arc/sdcard/write/emulated/0. We need to whitelist the path so that Chrome can open Android files using file:// protocol. Bug: 863515 Test: Manually tested on ARC-enabled Kevin device. Change-Id: Ic48e46b5a55d75630c6e6b06467ab4597345e6e7 Reviewed-on: https://chromium-review.googlesource.com/1170151 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582851}
-
Peter Boström authored
Replaces CONTEXT_DEPRECATED_SMALL with CONTEXT_BODY_TEXT_SMALL as CONTEXT_DEPRECATED_SMALL isn't supported under Harmony and only a few uses of it remained. The replacement font is usually 1pt larger than the deprecated one. Updates LayoutProviderTest.FontRelativeToBase to use the current layout provider. Also makes use of ChromeLayoutProvider::CreateLayoutProvider in ChromeTestViewsDelegate to keep it in sync with chrome. Also updates test expectations as ChromeTestViewsDelegate gets updated to make use of the ChromeLayoutProvider factory, which provides HarmonyLayoutProvider in most cases instead of the legacy ChromeLayoutProvider. Bug: chromium:867557 Change-Id: I202757cc05854e1e3054b9f97220a5c99f025b30 Reviewed-on: https://chromium-review.googlesource.com/1171661Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#582850}
-
Tarun Bansal authored
The NetInfo network quality attributes have been enabled since M-61. NetInfo saveData attribute has been enabled since M-65. Change-Id: Ie4b005834e92180d080391ea7d00f4e57c8c5df3 Bug: 723068,772566 Reviewed-on: https://chromium-review.googlesource.com/1172087Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#582849}
-
Makoto Shimazu authored
TBR=sahel@chromium.org NOTRY=true Bug: 873435 Change-Id: I1c063da5ac84b6c50c61fdc24cd976e9059dc4f4 Reviewed-on: https://chromium-review.googlesource.com/1174074Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ed176992eb7d..692aeadfe32d git log ed176992eb7d..692aeadfe32d --date=short --no-merges --format='%ad %ae %s' 2018-08-14 thestig@chromium.org Remove |bTakeOver| parameter from CFX_MemoryStream ctor. Created with: gclient setdep -r src/third_party/pdfium@692aeadfe32d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I56c1905661c8d9817f99f0e127819f102329a8c1 Reviewed-on: https://chromium-review.googlesource.com/1173911Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582847}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b26e129bfd2a..6febc356717c git log b26e129bfd2a..6febc356717c --date=short --no-merges --format='%ad %ae %s' 2018-08-14 tikuta@chromium.org lddtree: keep relativeness of invoked compiler in elf wrapper 2018-08-14 dgarrett@google.com cros_mark_as_stable: Add --overlay-type option. Created with: gclient setdep -r src/third_party/chromite@6febc356717c The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie8a674e76cb31d492a5b6e7a55090b782f240461 Reviewed-on: https://chromium-review.googlesource.com/1173991Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582846}
-
Amos Lim authored
Fix invalid charset detection when a meta contains both a "charset" and a "content" attribute. The encoding specified in the "charset" attribute should have precedence over the one in the "content" attribute. https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inhead Bug: 855047 Change-Id: I79306fc0bff8f094800a989d8d548bd94b96b5eb Reviewed-on: https://chromium-review.googlesource.com/1172462Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#582845}
-
Noel Gordon authored
Bug 873915 notes flakey time-outs on the Mash bots for keyboard delete on Drive tests. The test LOG says the tests are in waitAndAcceptDialog waiting for the .cr-dialog-ok button to appear. waitAndAcceptDialog() looks ok-ish (so problem is somewhere else), but while here, write the promise/then chain per ES6 normality. Test: browser_tests --gtest_filter="KeyboardOperations/FilesApp*" Bug: 873915 Change-Id: I5292584a0436e19878eb57730370fd8941c389f6 Reviewed-on: https://chromium-review.googlesource.com/1173942 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#582844}
-
Yuki Shiino authored
Web IDL type Function (= any (any...)) is a sort of "arbitrary function", and used very widely in the web standards. Its return value is often discarded, as if its return type is void. So, this patch supports InvokeAndReportException for type Function. Bug: 871208 Change-Id: Icbe56560585c402271363e7c8294d3b0c96b1562 Reviewed-on: https://chromium-review.googlesource.com/1173931Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59100433. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22698 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ia78f28ac1385e24237069f7298c14c93e6279415 Reviewed-on: https://chromium-review.googlesource.com/1173763 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the Find function to mojo. Find replies are now separated into two functions, one to update the number of found matches (SetNumberOfMatches) and the other is to update which match is active right now (SetActiveMatch). This is the final function to be mojoified for FindInPage. Mojoifying doc: https://goo.gl/JenyGm Bug: 819919 Change-Id: I990160f973b29d7620214d7d58a16ece033adf3f Reviewed-on: https://chromium-review.googlesource.com/1086950 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
sangwoo.ko authored
Replace old API with new API. In order to do this, changed the API a little bit. * Notify before deleting web conents when tabs are closed. * Pass TabStripModel* in OnTabStripModelChanged(). This CL has no intended behavior change. Reordered methods definitions so that they match with declarartion order. Change-Id: I704cfb3418d06a7539096307aefab916338c65e9 Bug: 842194 Reviewed-on: https://chromium-review.googlesource.com/1171963 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
David Tseng authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3b6ba12c94c77f969f891485731a0b40e038fdcd Reviewed-on: https://chromium-review.googlesource.com/1173438Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#582839}
-
Emircan Uysaler authored
This CL handles MEDIA_DISPLAY_VIDEO_CAPTURE cases specifically in browser-side MediaStreamManager and renderer-side UserMediaProcessor. This allows us to link these specific calls from blink to MediaAccessHandler. Bug: 326740 Change-Id: If12f9fe92a8b0ed7b30b0cad4c3c7ab140537566 Reviewed-on: https://chromium-review.googlesource.com/1170344 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
-
Tarun Bansal authored
It seems that the current minimum timeout value of 10 seconds is too low. UMA shows that on 2G connections, of all succeeded probes, only 88% of them succeed on the first attempt. 9% succeed on second attempt when the timeout is doubled, and 3% on third attempt when timeout is further doubled. This CL experiments with increasing the minimum timeout value to increase the chances of success. Bug: 760294 Change-Id: I79eb5addf2258641032b3a92053228d3f15763eb Reviewed-on: https://chromium-review.googlesource.com/1173157Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#582837}
-
tzik authored
After this CL, zero-to-one transition of the ref count causes CHECK failure on subclasses of base::RefCountedThreadSafe that have REQUIRE_ADOPTION_FOR_REFCOUNTED_TYPE(). RefCountedThreadSafe classes with custom deletion traits may keeps alive for awhile after its ref count gets to zero, the custom traits may hop to another thread to delete the instance on it. However, if another reference is created for the instance before the instance is destroyed, that eventually causes UAF. This CL is a mitigation for the UAF by converting it to an early CHECK failure. This CL increases the stripped binary size of chrome on Linux by 36kB, and no measurable size growth on non-x86 arch. Change-Id: I37aefbdac5577f2dc227b55f27330b50ccdec90f Reviewed-on: https://chromium-review.googlesource.com/1166757Reviewed-by:
-
Emircan Uysaler authored
This CL adds a new permission handler for getDisplayMedia(). It uses DesktopMediaPickerFactoryImpl as common implementation to trigger the same picker UI as extensions. It also adds unit test that exercises the new code path. Bug: 326740 Change-Id: I3007124226d2b017ba06877a1bbcc87f3bc2f9a3 Reviewed-on: https://chromium-review.googlesource.com/1163533Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582835}
-
Ramin Halavati authored
To update traffic annotation checker binaries one needs access to chromium-tools-traffic_annotation bucket. To find access owners easier, an OWNERS file is added to the folder. Change-Id: I0f8dbdc6b599b0b5b159855a3e9d3e72cdb95e6f Reviewed-on: https://chromium-review.googlesource.com/1168484Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582834}
-
Xiaocheng Hu authored
FormatBlock command requires valid paragraph range to operate on, but fails to obtain it in some edge scenarios. This patch makes the command abort so that it doesn't crash the renderer. Bug: 873084 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iccfc83be7bc2db950e9fad00974ab6a5e67f9548 Reviewed-on: https://chromium-review.googlesource.com/1173432Reviewed-by:
-
