GitLab

(I still have to write tests and convert some uses. I also want to add
more logic to the async destruction, so that the |Channel| knows that
it's about to be torn down.)

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/466563002

Cr-Commit-Position: refs/heads/master@{#289015}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289015 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289014}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289014 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/465903003

Cr-Commit-Position: refs/heads/master@{#289013}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393486
TEST=Tree is open more of the time
TBR=horo
NOTRY=TRUE

Review URL: https://codereview.chromium.org/463143002

Cr-Commit-Position: refs/heads/master@{#289012}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289012 0039d316-1c4b-4281-b951-d872f2087c98

Created safe alternative which is called GetProfileByUser.
The plan is to investigate all usages of GetProfileByUserUnsafe one by one and
replace them with a safe version, if possible.
Also warning message added for cases when GetProfileByUserUnsafe returns profile
of a wrong user or signin profile. That will help us to detect suspicious calls
to GetProfileByUserUnsafe while work in progress.

BUG=361528
TBR=yoz,dcheng,agl,dewittj,skuhne,derat

Review URL: https://codereview.chromium.org/445353004

Cr-Commit-Position: refs/heads/master@{#289011}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289011 0039d316-1c4b-4281-b951-d872f2087c98

These nits were noted when a new storage type was added in
crrev.com/394063003 and this CL applies those style changes and other
suggestions to the other files. Standardize on DCHECK(!x), use
DCHECK_CURRENTLY_ON() where possible, use empty() rather than !size(),
all the trivial cpplint.py findings, and add/use ASSERTs in mock
classes (vs. CHECK/DCHECKs)

No functional changes.

R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/459233002

Cr-Commit-Position: refs/heads/master@{#289010}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289010 0039d316-1c4b-4281-b951-d872f2087c98

Screenshots https://drive.google.com/a/google.com/folderview?id=0B0Pq_70XQgc1YzAxUWVXV2JyWkE&usp=sharing

BUG=398880
NOTRY=true

Review URL: https://codereview.chromium.org/461943002

Cr-Commit-Position: refs/heads/master@{#289009}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289009 0039d316-1c4b-4281-b951-d872f2087c98

This is a fix for a latent bug.

Tentatively, this is also causing http://crbug.com/394315.

BUG=380463, 394315

Review URL: https://codereview.chromium.org/464853002

Cr-Commit-Position: refs/heads/master@{#289008}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289008 0039d316-1c4b-4281-b951-d872f2087c98

Except for webrtc, this produces content_shell and webkit_unit_tests
binaries that link and run successfully on linux.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/462983002

Cr-Commit-Position: refs/heads/master@{#289007}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289007 0039d316-1c4b-4281-b951-d872f2087c98

This maintains the fixes for the mac isolate files, and switches around
the targets used in the gyp files to fix the unit tests in component builds.

BUG=386799
First Review URL: https://codereview.chromium.org/413303002
Second Review URL: https://codereview.chromium.org/448873002

Review URL: https://codereview.chromium.org/460743002

Cr-Commit-Position: refs/heads/master@{#289006}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289006 0039d316-1c4b-4281-b951-d872f2087c98

- remove the profile preference that used to keep track of showing the
tutorial any time the user manager was shown for a particular profile.

- show the upgrade bubble for local profiles as well (so that local profiles
have a chance to see the tutorial)

- for the local profiles upgrade bubble, don't show the "Not you?" link as
it doesn't really make sense.

BUG=399679
TBR=rpetterson@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288817

Review URL: https://codereview.chromium.org/454153002

Cr-Commit-Position: refs/heads/master@{#289005}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402766
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/463933002

Cr-Commit-Position: refs/heads/master@{#289003}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372381

Review URL: https://codereview.chromium.org/460383002

Cr-Commit-Position: refs/heads/master@{#289002}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289002 0039d316-1c4b-4281-b951-d872f2087c98

Fetches the list of EV certificate hashes using the component updater.
Once this is in, we could gather data on how many EV certificates do
not appear in any Certificate Transparency log.

BUG=339128

Review URL: https://codereview.chromium.org/465443002

Cr-Commit-Position: refs/heads/master@{#289001}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372381

Review URL: https://codereview.chromium.org/466723003

Cr-Commit-Position: refs/heads/master@{#288999}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288999 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mgiuca
BUG=171450

Review URL: https://codereview.chromium.org/460833004

Cr-Commit-Position: refs/heads/master@{#288998}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/465933002

Cr-Commit-Position: refs/heads/master@{#288997}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288997 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288996}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/459903002

Cr-Commit-Position: refs/heads/master@{#288995}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288995 0039d316-1c4b-4281-b951-d872f2087c98

As per spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#unregister-algorithm

Unregister shouldn't doom the active worker or delete the registration until
the active worker no longer controls a document. This means that if register()
is called before that happens, the unregistration is effectively canceled.

BUG=388095
TEST=https://codereview.chromium.org/416003003/

Review URL: https://codereview.chromium.org/413063004

Cr-Commit-Position: refs/heads/master@{#288994}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288994 0039d316-1c4b-4281-b951-d872f2087c98

Fix an issue with view manager init service where you had to retain a connection to the init service until the window tree host was created otherwise embed calls would be dropped.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/463523003

Cr-Commit-Position: refs/heads/master@{#288993}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288993 0039d316-1c4b-4281-b951-d872f2087c98

This changes the webview implementation of wrap_contents mode
from custom code explicitly calculating the layout size to a
pair of settings: "ignore viewport tag" (for older apps) and
"set layout size height to 0".

This means this code gets simpler and means we don't have to
fix a bunch of races present in the current version of the
code.

BUG=392460, 398445
TBR=cevans@chromium.org

Review URL: https://codereview.chromium.org/418883002

Cr-Commit-Position: refs/heads/master@{#288992}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288992 0039d316-1c4b-4281-b951-d872f2087c98

After running Delete() method, the iterator is expected to index
the next entry, if exists.


BUG=347425
TEST=./unit_tests --gtest_filter="LevelDBWrapper*"

Review URL: https://codereview.chromium.org/461823002

Cr-Commit-Position: refs/heads/master@{#288991}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288991 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288990}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288990 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/459373002

Cr-Commit-Position: refs/heads/master@{#288989}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288989 0039d316-1c4b-4281-b951-d872f2087c98

This matches the gyp build and is important for parts of the code that
guard their API with UNIT_TEST. For instance,
chrome/browser/ui/views/omnibox/omnibox_view_views.h has a GetRenderText
function guarded by #if UNIT_TEST that shadows a protected function
GetRenderText from its parent class views::Textfield, but with different
const-ness. If c/b/u/v/o/omnibox_view_views.cc is compiled with UNIT_TEST
set, it attempts to use the guarded member function instead of the base
class which fails to compile.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/464503003

Cr-Commit-Position: refs/heads/master@{#288988}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288988 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org

BUG=

Review URL: https://codereview.chromium.org/460863002

Cr-Commit-Position: refs/heads/master@{#288987}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288987 0039d316-1c4b-4281-b951-d872f2087c98

CL 435583003 adds usage of std::numeric_limits without including the
required header "limits" header.  Let's fix that.

BUG=398712
NOTRY=true

Review URL: https://codereview.chromium.org/454413002

Cr-Commit-Position: refs/heads/master@{#288986}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402319
TEST=manually and run browser_tests gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/458103002

Cr-Commit-Position: refs/heads/master@{#288985}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288985 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes V8DOMWindowShell.createContext.IsolatedWorld
and V8DOMWindowShell.createContext.MainWorld.
They are already dead.

Review URL: https://codereview.chromium.org/461523002

Cr-Commit-Position: refs/heads/master@{#288984}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288984 0039d316-1c4b-4281-b951-d872f2087c98

Rename transparentBackground -> alphaEnabled (per the spec).

Add app.window.alphaEnabled permission to control which apps are allowed to use alphaEnabled when creating windows.

Add browsertests to verify that the API is only available when permission had been granted and Beta channel or newer.

Add a whitelist (only used in Stable) for this API that defaults to the same set of apps as for app.window.shape.

BUG=260810

Review URL: https://codereview.chromium.org/190533006

Cr-Commit-Position: refs/heads/master@{#288983}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288983 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/463743002

Cr-Commit-Position: refs/heads/master@{#288982}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288982 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288981}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288981 0039d316-1c4b-4281-b951-d872f2087c98

This roll contains following change:

r1960: Guard against configurations without 'xcode_settings'
r1961: Pull in relevant targets when using xcode-ninja
r1962: Currently I've special cased gyp* file modifications higher...
r1963: Style changes for analyzer
r1964: Provide a way to suppress implicit MIDL generation rules for actions

TBR=scottmg@chromium.org
BUG=321462

Review URL: https://codereview.chromium.org/467483002

Cr-Commit-Position: refs/heads/master@{#288980}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288980 0039d316-1c4b-4281-b951-d872f2087c98

ComponentExtensionIMEManager::FindEngineEntry() only needs to find for extension.

BUG=402222
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/457943002

Cr-Commit-Position: refs/heads/master@{#288979}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288979 0039d316-1c4b-4281-b951-d872f2087c98

We always pass false to it, so we will never load the common resources.

The benefit of doing this is that it allow us to remove a call to LoadCommonResources(), which we are trying to remove.

BUG=176960
TEST=None
R=tony@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/451283002

Cr-Commit-Position: refs/heads/master@{#288978}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288978 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a DisplayType property to app list SearchResult properties
which will be used to determine where the results should be displayed
in the experimental app list.

BUG=349727

Review URL: https://codereview.chromium.org/455323003

Cr-Commit-Position: refs/heads/master@{#288976}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288976 0039d316-1c4b-4281-b951-d872f2087c98

AppListTestViewDelegate::CreateCustomPageWebViews now returns a vector
of views, not a single view. AppListViewDelegate is now able to generate
multiple custom launcher pages which will all be inserted into the
launcher (but currently only ever produces a single one, from the
--custom-launcher-page switch).

BUG=399131

Review URL: https://codereview.chromium.org/441873004

Cr-Commit-Position: refs/heads/master@{#288975}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288975 0039d316-1c4b-4281-b951-d872f2087c98

Previously, nothing would happen. Now there is a transition, everything slides away to the bottom of the screen and the rest is loaded.

BUG=402017
TEST=manual
R=huangs@chromium.org, pedrosimonetti@chromium.org

Review URL: https://codereview.chromium.org/456833003

Cr-Commit-Position: refs/heads/master@{#288974}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288974 0039d316-1c4b-4281-b951-d872f2087c98

Remove redundant calls to canPaste() in PastePopupMenu. Inhibit calls to show
PastePopupMenu if clipboard is empty. Removed unwanted layout attributes to
fix the greying of the PastePopupMenu when diplayed beside the insertion
handler.

BUG=400705

Review URL: https://codereview.chromium.org/449033002

Cr-Commit-Position: refs/heads/master@{#288973}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288973 0039d316-1c4b-4281-b951-d872f2087c98