- 13 Aug, 2019 40 commits
-
-
Andrew Grieve authored
Since we enabled r8, this variable is ignored. Stop setting it. Bug: 908988 Change-Id: I0aa9e3e0a0a6133be81916bf36126bed86aab116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752292 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686539}
-
Pavol Marko authored
Allow ONC policy to specify a Scope for policy-provided certificates. Currently, all consumers only use certificates with profile-wide scope (no Scope specified in ONC). Using extension-scoped certificates will be done in a follow-up CL. Bug: 939344 Test: chromeos_unittests --gtest_filter=*OncParsedCertificates* Change-Id: Ic5b824d3d7fc36b89a2695f5ec0d1099a1600171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702308Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686538}
-
Robert Sesek authored
Swiftshader now passes MAP_JIT when allocating its code pages, so this entitlement can be locked down. Bug: 985816 Change-Id: Id71cca3ed7300da7990085a19652bbba5b6c92c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742835Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#686537}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/12c357b447a4..5e97d0125fd9 git log 12c357b447a4..5e97d0125fd9 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 tsepez@chromium.org Remove dependence on fxfa/parser on fx_barcode. 2019-08-13 tsepez@chromium.org Remove xfa/fxfa dependence on fpdfapi/font Created with: gclient setdep -r src/third_party/pdfium@5e97d0125fd9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I02b09ea85cd34f4d2f64e1140366a6a61c62c419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686536}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7741db7456bc..f9fbd0f9b5e9 Created with: gclient setdep -r src-internal@f9fbd0f9b5e9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I84e9d3119aac0c67dcdc1d45636cd06b532b5934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752248Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686535}
-
Andrew Grieve authored
Guessing this was an IDE mistake :P. Came across this when doing proguard testing. Change-Id: Ib3ed490ff65635f6f6f8c725f522ed66ac0d5697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752586Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#686534}
-
Rayan Kanso authored
Also updates related metrics around it to include more than one owner and expiration dates. Bug: 984282 Change-Id: I25f3804b47d2d7ce2d0185c99c81139956d57a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751204 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686533}
-
Michael Thiessen authored
The test was launching the NTP from the wrong thread. Change-Id: I99f72187c2ce8d129ed388f7f712795c95aa364e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752553 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686532}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/827c26f6435e..5c7d9733468d git log 827c26f6435e..5c7d9733468d --date=short --no-merges --format='%ad %ae %s' 2019-08-13 treehugger-gerrit@google.com Merge "trace buffer: Clear kChunkNeedsPatchingFlag for incomplete chunks" 2019-08-13 treehugger-gerrit@google.com Merge "proto/processor: Add TrackEvent type for instant events" 2019-08-13 taylori@google.com perfetto-ui: Tickmark panel Created with: gclient setdep -r src/third_party/perfetto@5c7d9733468d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:111169965 Change-Id: I782bf23a8104b85164a59ffceaec44879aff8fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751753Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686531}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/34c59c9b88b7..5e4e8b0af5fa git log 34c59c9b88b7..5e4e8b0af5fa --date=short --no-merges --format='%ad %ae %s' 2019-08-13 bclayton@google.com Add Visual Studio CMakeSettings.json file 2019-08-13 bclayton@google.com Reactor: Add self() method to LValue<T> and Array<T> Created with: gclient setdep -r src/third_party/swiftshader@5e4e8b0af5fa The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139189696,chromium:b/133213304 Change-Id: Ib842c1ab0b88bd73aa0da91edf7fd79b1e36775b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751749Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686530}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b6d7c5370888..35670f183a73 git log b6d7c5370888..35670f183a73 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 shaobo.yan@intel.com Skip InheritDynamicOffsetsComputePipeline test on Windows Created with: gclient setdep -r src/third_party/dawn@35670f183a73 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I3ce5f3276512ed8818a9dcb32269521fadec4099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752250Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686529}
-
Matt Mueller authored
Allow SupportsUserData to be used by subclasses which can be "reset", by letting the subclass clear all associated user-data if required. (e.g. CertVerifyResult has a Reset method, so if it subclass SupportsUserData, it also needs a way to clear any attached user data when Reset is called.) Bug: 991247 Change-Id: I3b3edaa58b2e70daac453edd28e4aa37eee17bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738628 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686528}
-
sczs authored
Screenshots: iPhoneX Portrait: https://drive.google.com/open?id=1EuSPpb_-7yGjbxSaz5bOkWWWKmq74zq8 iPhoneX Landscape: https://drive.google.com/open?id=1sfpAppZAvrMp3k20527vxXbu7WG8ZiPi iPadPro Portrait: https://drive.google.com/open?id=1EuL2t9yWlU4IpIERGMHxxlYBYKoLYA5M iPadPro Landscape: https://drive.google.com/open?id=1nBDidl8oYXjrx9_NOtF-trfts_0x7Ea5 iPadPro Portrait DynamicType: https://drive.google.com/open?id=1k5pwO0agJ5uf-pmOVeFf4frmHOR25W8W Bug: 979201 Change-Id: I97a59a5ac32f9f45a091f32fe73e90d8cfd8ec61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709650Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686527}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ef31815a694..e73aa7573279 git log 6ef31815a694..e73aa7573279 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 halcanary@google.com experimental/editor: up,down preserves x-coordinate 2019-08-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-13 bsalomon@google.com Add tolerance to ProcessorCloneTest and dump images on failure. 2019-08-13 csmartdalton@google.com Return kNearest from GrSkFilterQualityToGrFilterMode for 1x1 images 2019-08-13 benjaminwagner@google.com [gn] Don't use cc_wrapper for link steps 2019-08-13 senorblanco@chromium.org SkSL: implement full support for separate textures and samplers. 2019-08-13 bungeman@google.com Clean up some gm factory use. 2019-08-13 mtklein@google.com less clever skipMoveTo logic 2019-08-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-13 ethannicholas@google.com added error check for invalid 'in' variables 2019-08-13 mtklein@google.com rewrite SkDashPath.cpp's cull_path() logic 2019-08-13 halcanary@google.com experimental/editor/application: pre-shape text before showing window 2019-08-13 halcanary@google.com experimental/editor: README.md multilingual example Created with: gclient setdep -r src/third_party/skia@e73aa7573279 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: I04546731e364989ebf8547ddda5501ce4fd5017c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686526}
-
Antonio Gomes authored
BUG=704136 R=haraken@chromium.org Change-Id: I87cd65f441fd8da7cc54ed824ae7a647a696da33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752064 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#686525}
-
Jun Cai authored
This CL refactors SmsDialog to use event handler. An enum SmsDialogEvent is added to SmsDialog class and can be used by both C++ and Java code. Bug: 985441 Change-Id: I1ecc4e70609479124c80a7166a9551ffa77566a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737875 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#686524}
-
Antonio Gomes authored
... and use the WTF counterparts, Vector and String. BUG=704136 R=haraken@chromium.org Change-Id: I99adf8785525376a47b1a5e52cfee345f5618d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752063Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#686523}
-
lgcheng authored
Re-center opt in dialog upon launching when no resizing is needed. Bug: b/132199704 Change-Id: I2cbfd157c7b1be2428e3f76e82b8f389aa7a6976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752173Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#686522}
-
Rakib M. Hasan authored
In the build found at https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/82258 the benchmark is causing one of the shards to time out. Bug: chromium:992837 Change-Id: Ib0110a8bb379e89fd94389ed6a7d68fa2cf812e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750802 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#686521}
-
Richard Knoll authored
As part of the Click to Call feature, we open the dialer with a prefilled phone number. We want to track how many times an actual call is made shortly after that to measure an end to end user journey. Bug: 976311 Change-Id: If966f2fd87f7e7c3675805bac31e547774349989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746466 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#686520}
-
Nate Fischer authored
WebView currently has no UMA records. One possible explanation is if the client_id is always a consistent value. It's hard to check if it's always a consistent value, but we can check for a few classes of invalid values (incorrect length, invalid characters). Tentatively add CHECK()s so we can look for crash data. We'll remove these CHECK()s when we know the root cause. Bug: 992250 Test: None Change-Id: I920061f973a8320bb5b6df14cf2a3a193751e82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750346Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686519}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d37448e..83ed3059 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I708b4d67c5b3a6778a885acc34123fb6193f1519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751702Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686518}
-
Ian Kilpatrick authored
This may not be strictly better, as now we have to initialize, and directly compare these flags. However this harmonizes everything to be similar in the constraint space now. Initially we had this enum to save us from manually copying all of the flags from the builder to the final space. However we changed the builder to directly mutate a space at a later date making this less needed. We then also started to move flags out of this enum, e.g. "size constraints" which go through a different set of checks. Change-Id: I662f2eaf03ebe64bf6d9b51ccc4d1f7de263091b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751923Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686517}
-
Jenna Himawan authored
Bug: 993074 Change-Id: I0e43376a89cdb1d5d199309209c118b85a4f44c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746653Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jenna Himawan <jhimawan@google.com> Cr-Commit-Position: refs/heads/master@{#686516}
-
Bret Sepulveda authored
In an unrelated patch I discovered that there was no difference between the two Param variables in TabStripTest. is_touch was unexpectedly still false inside GetLayoutConstants even though it should have been overridden to true by TabStripTest::test_api_ . Because ViewsTestBase was calling MaterialDesignController::Initialize() inside SetUp, the value set by TabStripTest::test_api_ was being overwritten. To fix this, the ViewsTestBase call is moved to its constructor, so that it will always happen first. This caused TabCloseButtonVisibilityWhenNotStacked/1 to fail, which was because FakeBaseTabStripController was calling TabStrip::SetSelection before TabStrip::RemoveTabAt, which seems wrong (the tab at active_index_ isn't removed yet). In non-test code, TabStripModel will call RemoveTabAt first, so this patch switches the order and fixes the test. It is unknown why TabCloseButtonVisibilityWhenNotStacked/0 was not failing. This patch also adds a test to ensure the layout is different when switching from touch UI to normal UI and vice versa. Change-Id: I447ffe0ebd99cb56ab77c23e60fa67cf09ba98f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747175Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#686515}
-
Caitlin Fischer authored
(Googlers only) go/owners-expansion-verification-for-components Bug: 989112 Change-Id: Idbbbc3fb8d7da9102a186fd87daf2ccd96b255a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751502 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#686514}
-
Mike Frysinger authored
Python 3 has dropped the types module, so switch to six for the types that still make sense. For basic types (like tuple), we can just use the builtin instead. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I9d1fffdcf38c5550dffb9e946bf5890930399280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700507Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686513}
-
John Budorick authored
Bug: 922145 Change-Id: I0cf46ce3601794c07abd0bb4bc56d0474e8d4f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752530Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686512}
-
Shimi Zhang authored
Since both Java and JavaScript uses UTF16 strings, makes it more compatible to use base::string16 in C++. Per comment from http://crrev/c/1719453. Bug: 918065 Change-Id: Ie979c0e400604ec2230bd7cb8319dc74f39616e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750093 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686511}
-
Maksim Ivanov authored
Replace strings hardcoded into the Ash user pod views implementation with the proper i18n calls. Bug: 983103 Change-Id: I975652541e294eba02df2085a12b76ab89b8e175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751326 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#686510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9fc459b69c78..e765f652958c git log 9fc459b69c78..e765f652958c --date=short --no-merges --format='%ad %ae %s' 2019-08-13 mmoss@google.com [depot_tools] Set "is_luci=False" for buildbot tests. 2019-08-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e765f652958c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:993137 Change-Id: I617964a8b75cd546bd131b0ecf0cad82aad6ad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686509}
-
Devlin Cronin authored
The downloads.drag API has exceedingly low usage, and has other issues. Remove it. Bug: 986043 Change-Id: I3f0f41fba02a8d729feee9af036a1f383a0e1b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742547Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686508}
-
Malay Keshav authored
This patch adds the posting of important messages to the parent thread. The messages are send when: - a lottie animation is initialized. - a lottie animation has started playing. - a lottie animation has resized its canvas. This patch also fixes the lint for the wrapper code to be closer to chromium's style guide. Change-Id: Ibf27da53ec4bba6ec696041e312c7fb317a64833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747195 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#686507}
-
David Benjamin authored
It is now only set in tests, where it is a largely a no-op because False Start since acquired an ALPN requirement. When False Start is triggered, we do need to worry about post-Connect() handshake data and sessions being established late, but TLS 1.3 has the same problem unavoidably. Abstract the ticket-forcing logic behind a new helper so we can easily add it as needed in the future. (Firefox actually no longer requires ALPN for False Start. This may be worth considering, in which case we may need to revisit some more of these tests. Additionally, SpawnedTestServer doesn't support TLS 1.3 and most of these tests haven't moved to EmbeddedTestServer, which may also require fixing up tests.) Bug: none Change-Id: I444ee12b66aed88898d1492ee0df29817c155348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708675 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#686506}
-
Michael Spang authored
Audio only devices have no display and no GPU. Disable swiftshader so we don't see an error on startup trying to load it. Bug: b/139101843 Change-Id: Ib15d38a1da17e8a5057390879fd684a8b2b9bd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752167Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686505}
-
Xianzhu Wang authored
This is like what we do for paint properties in the document. Bug: 984881 Change-Id: Ib799e852017642d31de2616a5ebab554cbeb3770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752502Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686504}
-
Justin Cohen authored
These tests are also failing on iPhone now. Bug: 989550 Change-Id: If673678464e4c1158a859a1adfafa118bbfc3698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752080Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#686503}
-
Irina Yatsenko authored
The current integration of crash keys into v8 got the dependencies wrong: it introduced into v8 a dependency on components and base. This change is the second half of fixing the design to keep the dependencies in the embedder. The change depends on https://chromium-review.googlesource.com/c/v8/v8/+/1699102. Bug: v8:9323 Change-Id: Ib5b497a50718c451ab38b2bf32c4d68f5a9e22e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690003 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#686502}
-
Danton Vu authored
The items eat the events aimed for the controller than shifts the grid left and right, we need to change so window drags on begin on long presses. Test: manual, added tests Bug: 991346 Change-Id: I387fa0a4acff17e4b9673f1d042cf8ae8d4b1eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749710 Commit-Queue: Danton Vu <dantonvu@google.com> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#686501}
-
George Steel authored
Update devtools to no longer require the id property as identifying the animation name or transition property and instead use the proper IDL hierarchy and properties. Bug: 849927 Change-Id: I85a1c6eda7f176ce23906ee64b4c9c2d3374c57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740647 Auto-Submit: George Steel <gtsteel@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#686500}
-