GitLab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Idb55f2410f440addd41543cfb2483f7b7dec7347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994257Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730101}

This is a reland of d35a5b72, which
includes a fix to prevent the issue of the BookmarkModel being modified
while iterated, which can invalidate iterators due to how GUID
reassignment is implemented.

Original change's description:
> Bookmark sync: use GUID as temporary server ID during commit
>
> This patch effectively relands the logic reverted in
> https://chromium-review.googlesource.com/c/chromium/src/+/1864800 which
> caused crashes in the past (CHECK failures).
>
> In this new form, the underlying issue is addressed: for users that
> don't use GUID-based merging of bookmarks, local GUIDs are reassigned
> randomly to avoid GUID collisions in the local bookmark model.
>
> Bug: 978430,1004205
> Change-Id: I812d1cfe1c12b766799e6c5ec238f95fd16139ad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983231
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#729405}

Bug: 978430, 1004205
Change-Id: Ie86f42a1d8985e325fca5741d43aefc6ef0955c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993295
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730100}

Bug: 1040450
Change-Id: I80fa1ff683706760207e37c00e22b66375cce23e
No-Try: true
Tbr: vasilii@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995104Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730099}

This histogram expired:
* Worker.TopLevelScript.OriginType.RequestUrl.DedicatedWorker

Bug: 867302, 960042
Change-Id: If44ab380b6da4ad61b5343182294e4c400406b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686861
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730098}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70b009b0f1e..fb2e819819ef

git log e70b009b0f1e..fb2e819819ef --date=short --first-parent --format='%ad %ae %s'
2020-01-08 dneto@google.com Fix GN build for OpenCL.DebugInfo.100 update (#3134)
2020-01-08 bclayton@google.com Fix bad parameter names in error message (#3129)
2020-01-07 alanbaker@google.com Revert PR #3093 (#3131)
2020-01-07 alanbaker@google.com Disallow forward references in arrays (#3093)
2020-01-07 afdx@google.com spirv-fuzz: Add fuzzer pass to perform module donation (#3117)
2020-01-06 dneto@google.com GetOperandConstants operand can be const (#3126)
2019-12-27 dneto@google.com Avoid pessimizing std::move (#3124)
2019-12-27 kburjack@googlemail.com Fix typo in validation message (#3122)
2019-12-27 greg@lunarg.com Change default version for CreatInstBindlessCheckPass to 2 (#3119)
2019-12-21 greg@lunarg.com Fix convert-relax-to-half invalid code (#3099) (#3106)
2019-12-19 dneto@google.com Support OpenCL.DebugInfo.100 extended instruction set (#3080)
2019-12-19 afdx@google.com spirv-fuzz: Always add new globals to entry point interfaces (#3113)
2019-12-19 afdx@google.com spirv-fuzz: Transformation to add a new function to a module (#3114)
2019-12-19 afdx@google.com spirv-fuzz: Avoid passing access chains as parameters (#3112)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@fb2e819819ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com
Change-Id: I832222314f0eaf0dd778311e48bc7921dee3baee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994255Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730097}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d41d8be6..c83d5e24

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9b2cef40998e4d159581b2b91ca27bcecbb483c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994901Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730096}

This CL cleans a bit more the collection view.

Bug: 894800
Change-Id: I3211f9afa8af578323bec1a2a13ca8842d91c42c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991449
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730095}

Utility services are now started in a slightly different way by
UtilityThreadImpl. In the past, their TraceLog process names were set
in UtilityServiceFactory, which is no longer involved for most services.

So, also set the process name in the new service binder.

Bug: 1040525
Change-Id: Ib8900350460ee2711303519d705de3de361fb3f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993349Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730094}

Defines an almost empty class.


Bug: 839389
Change-Id: Ide0536992f1247d7e53aa8109083519d41db7892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990894
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730093}

Bug: 1040054
Change-Id: Iea5bfbcec4710b766b4b5117c188aa870869266e
No-Try: true
Tbr: vasilii@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995081Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730092}

Currently, it is necessary to guarantee request references are valid
before creating decode surfaces, apply the controls, apply the buffers
or submit a request.
Since the requests queue only can create request references, it is
assured only valid requests can be returned.
Also, since only valid request references are returned, it is assured
controls and buffers are applied to a valid request.
Instead of returning an invalid request reference when a request
creation or submission fails, use base::Optional and return empty
optional argument.

BUG=chromium:1009921
TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.vp8 on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.h264 on veyron_minnie.
TEST=ran tast with video.DecodeAccel.vp8 on veyron_minnie.
TEST=ran tast with video.DecodeAccel.h264 on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on kevin.
TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on kevin.
TEST=ran tast with video.DecodeAccelVD.vp8 on kevin.
TEST=ran tast with video.DecodeAccelVD.h264 on kevin.
TEST=ran tast with video.DecodeAccel.vp8 on kevin.
TEST=ran tast with video.DecodeAccel.h264 on kevin.
Signed-off-by: Francois Buergisser <fbuergisser@chromium.org>
Change-Id: Ia7c8a25a335a6f49ca121aa1766d094d62e29176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982330
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730091}

Subject alternative name match is used by the WPA Supplicant to be
matched against the alternative subject name of the authentication
server certificate. It is sent from chrome to shill to WPA supplicant.
It is sent to shill in a serialized form to be able to store it
permanently on disk. Because StoreInterface used in chromeOS to save EAP
data permanently doesn't support saving dictionaries.
Shill implementation that uses this CL:1897535
System API implementation that uses this CL:1893872

chromeos-base/shill and chromium on my chromebook and checked the flow
of the subject alternative name match and found that it is serialized
correctly, transferred to shill, translated to WPA Supplicant format
correctly.

Tests: chromeos_unittests and built and deployed chromeos-base/system-api as well as
Bug: 1004261
Cq-Depend: chromium:1897535
Change-Id: I8226e18591db89e783c450863ab6691be0ea0470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892955
Commit-Queue: Omar Morsi <omorsi@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730090}

Currently, the same number of requests as the number of input buffers
are created before starting to decode surfaces.
To manage resources more efficiently, this patch creates requests only
when there are no free requests available in the requests queue.

BUG=chromium:1009921
TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.vp8 on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.h264 on veyron_minnie.
TEST=ran tast with video.DecodeAccel.vp8 on veyron_minnie.
TEST=ran tast with video.DecodeAccel.h264 on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on kevin.
TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on kevin.
TEST=ran tast with video.DecodeAccelVD.vp8 on kevin.
TEST=ran tast with video.DecodeAccelVD.h264 on kevin.
TEST=ran tast with video.DecodeAccel.vp8 on kevin.
TEST=ran tast with video.DecodeAccel.h264 on kevin.
Signed-off-by: Francois Buergisser <fbuergisser@chromium.org>
Change-Id: I8e4f277c64d22a6e7318cfa7a03e0141c6ac9360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981524
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730089}

This CL changes CHECK to DCHECK back in ServiceWorkerVersion::
RestoreControlleeFromBackForwardCacheMap, as the fix is verified now.

Bug: 1021718,1034141
Change-Id: I18b3a46e0dade359f34389eabddf6473e2f0775e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994029
Auto-Submit: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730088}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d253f41e17e2..172e39f0398b

$ git log d253f41e1..172e39f03 --date=short --no-merges --format='%ad %ae %s'
2020-01-09 post HLSL: Add a resource remapping API similar to MSL.
2020-01-09 post MSL: Deal with sign on wave min/max.
2020-01-09 post HLSL: Deal with casting for WaveActiveMin/Max.
2020-01-09 post GLSL: Deal with sign in subgroup Min/Max operations.
2020-01-08 post Run format_all.sh.
2020-01-08 post HLSL: Fix bug when reading and writing structs from SSBO.
2020-01-08 post HLSL: Implement stores for complex composites in ByteAddressBuffers.
2020-01-08 post HLSL: Support loading complex composites from ByteAddressBuffer.
2020-01-08 post Run format_all.sh.
2020-01-07 post MSL: Deal with padded fragment output + Component decoration.
2020-01-07 post MSL: Explicitly don't support component packing for tessellation.
2020-01-07 post MSL: Don't set OrigID when emitting component packed vectors.
2020-01-07 post MSL: Deal with packing vectors for vertex input/fragment output.
2020-01-07 post MSL: Add trivial tests for Component decoration.
2020-01-06 post Fix Clang warnings.
2020-01-06 post Roll custom versions of isalpha/isalnum.
2020-01-06 post Add test shader for OpCopyLogical with packing/unpacking.
2020-01-06 post Go through access chain path for OpCopyLogical.
2020-01-06 post Basic implementation of OpCopyLogical.
2019-12-21 dm86.jang Add debug prefix on Windows
2019-12-10 post GLSL: Fix array of input patch variables.
2019-12-09 post GLSL: Fix EmitStreamVertex/Primitive.
2019-12-04 post Remove obsolete use of AtomicCounterMemoryMask.
2019-12-04 post Don't emit memoryBarrierShared() in workgroup control barriers.
2019-12-03 dsinclair Update graphics robust access results
2019-12-03 post Fix MSVC warnings when building without exceptions.
2019-12-03 dsinclair Share test shader script
2019-12-03 post Update update_test_shaders.sh as well.
2019-12-02 dsinclair Roll SPIRV-Tools, SPIRV-Headers and GLSLang
2019-12-02 post Fix uninitialized memory issue.
2019-12-02 post MSL: Support ClipDistance as an input stage variable.
2019-11-28 post Fix sign handling for S/UToF.
2019-11-28 post MSL: Fix automatic binding allocation for image atomic buffers.
2019-11-27 agaule Added --msl-decoration-binding command line argument to enable binding decoration for Metal.
2019-11-26 sarahmashay Add licensing header to test_shaders.py
2019-11-26 post Mark loop headers as complex as early as possible.
2019-11-25 bill.hollings Expose as public Compiler::update_active_builtins() and has_active_builtin().
2019-11-12 post CMake: Clarify some warning messages.
2019-11-12 post HLSL: Add CLI support for --hlsl-auto-binding.
2019-11-11 post HLSL: Add support to remove register() bindings.
2019-11-07 post MSL: Remove dubious workaround code in unpack_expression.
2019-11-07 post MSL: Fix unpack_expression from column of padded matrix.
2019-11-06 post HLSL: Report more explicitly which member failed validation.
2019-11-06 post HLSL: Report which cbuffer failed validation.
2019-11-06 post Move .invalid. test shaders to the more appropriate subfolders.
2019-11-05 dsinclair Move all .invalid shaders into no-opt folders.
2019-11-05 dsinclair Remove old reference shaders
2019-11-05 dsinclair Only run spirv-opt if the spirv is valid.
2019-11-05 dsinclair Roll GLSLang and SPIRV-Tools
2019-11-04 post Add spvc_type_get_base_type_id.
2019-11-04 post C API: Add missing boolean options.
2019-11-04 post GLSL: Fix issue with array-of-array inputs in tess.
2019-11-01 dmalyshau Avoid including stdexcept in no-exception environment

Created with:
  roll-dep src/third_party/spirv-cross/spirv-cross

Bug: dawn:33
Change-Id: I5a50b5e5a73ca01818333ee43e5cdb65d63c109a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994669
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730087}

For the upcoming integration of the bad clock interstitial in WebLayer,
we will need to have a NetworkTimeTracker instance. In //chrome, that
object is owned by and accessible via the BrowserProcess global.

This CL adds a BrowserProcess object to //weblayer and populates it
with a NetworkTimeTracker instance and its dependencies, local state
and the system-level URLLoaderFactory. Both of the latter will shortly
be needed for metrics as well (and presumably for other use cases in
the fullness of time). The architecture of BrowserProcess is adapted
from that in //chrome.

system_network_context_manager.* was originally written by
alexclarke@chromium.org; it is an adaptation of //chromecast's
cast_network_contexts.*.

Finally, we note that the implementation of the PrefService in this CL
is deliberately as simple as possible for the initial purpose of the
bad clock interstitial. This can be extended as other use cases find
necessary, including the introduction of a FeatureListCreator if that
proves to be useful.

Bug: 1025059
Change-Id: I54f90551343b34e813fc5e6c97f0421926a30b43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985761Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730086}

This adds WebSchedulerTrackedFeature::kWakeLock and registers its use
from WakeLock constructor.

Bug: 1039569
Change-Id: I493b3a142ffc51af9820ef3ad4cfda367868ad76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989288
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730085}

This patch introduced a subset class of ResourceRequest for test
checking.
This is a preparation to make ResourceRequest non-copyable.

Bug: 787704
Change-Id: I0d0f52533c00078a9955a24eb16b3d9d552ab591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994840Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730084}

- Union.components was empty if no member types are user defined.
- Union.debug_info._location were not set
- Fix behavior of PathManager with Union
- Fix Location constructor with None filepath


Bug: 839389
Change-Id: Id115f6fd26b387ba6bc594a74f907ca0738b78f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990887Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730083}

Chromium switched to PEP8 for new code. Reformatted with the new config,
and rename function from CamelCase to snake_case.
https://chromium.googlesource.com/chromium/src/+/master/styleguide/python/python.md

Bug: 1019581
Test: yapf utils/cca.py
Tricium: disable
Change-Id: I9607653182cd28c6df137bf9b4d2fc07b23aa438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994851Reviewed-by: Wei Lee <wtlee@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730082}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fe5c3f7d1da4..5a8f4d89e1e6

git log fe5c3f7d1da4..5a8f4d89e1e6 --date=short --first-parent --format='%ad %ae %s'
2020-01-10 szuend@chromium.org Revert "Migrate accessibility/ to ESM internally"
2020-01-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-01-10 Rob.Paveza@microsoft.com Defensive null check in StylesSidebarPane
2020-01-09 aerotwist@chromium.org Migrates audits/ to ESM internally
2020-01-09 aerotwist@chromium.org Check for self.X = self.X || {} in migration script
2020-01-09 szuend@chromium.org Prepare CoverageDecorationManager.js for source map asyncification
2020-01-09 aerotwist@chromium.org Migrate accessibility/ to ESM internally

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@5a8f4d89e1e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1032016
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iad74b17593c03cbf22117c75d3d0fe273092020b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994250Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730081}

const_ref_t provides a type similar to ref_t with its constantness.


Bug: 839389
Change-Id: I4d654a483401fba5885da2cf3214bbe9674a869d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994549
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730080}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1dacd66f..d41d8be6

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia29191d51c7eddd51bf2e3195d0b8ad943eb83ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994900Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730079}

For debugging and future feature development, the web should be allowed
to pass a key version in addition to key material. If multiple keys are
involved, only the version of the newest is relevant, so the API is kept
as simple as possible by plumbing a single integer.

Bug: 1032485
Change-Id: I0e53c54176e92c1dfa6ffcb496611ae53c8c113f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991432Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730078}

Change-Id: I92c88d9e681c11dc90a4b8a66f93280924b7bdf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994032
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730077}

https://skia.googlesource.com/skia.git/+log/9eb28ddf2481..f72e48dd2ff0

git log 9eb28ddf2481..f72e48dd2ff0 --date=short --first-parent --format='%ad %ae %s'
2020-01-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5d178c93..e8ce929a (425 commits)
2020-01-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c431d59626e1..12ce8f687d23 (8 commits)

Created with:
  gclient setdep -r src/third_party/skia@f72e48dd2ff0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jvanverth@google.com
Change-Id: I572bdf841d046dcc3b3c393d3410cd49a6ddd242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994248Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730076}

- Remove the START_DOWNLOADING state in the UI code.
- Rename START_DOWNLOADING_DLC to STARTING and fix the initial state to
be that. While we logically start installation immediately upon opening
the dialog, we actually wait for AddedToWidget() to be called first, so
retaining this state allows us to avoid confusion of being in an active
state without having started the installation.
- Remove the OnDlcDownloadStarted and OnDownloadStarted callbacks, the
installer UI doesn't need these.
- Add TODO suggesting further improvements regarding cancellation.

Change-Id: I83575155047665139f0c1aa2af6b958b52df0b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994846
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#730075}

When a Discovery Session is first started it can get into a state where
it is pending another action to finish. If that action stops the
discovery then the new session will get deactivated before it even
begins.  This change adds a status to the session so that we can count
the discovery sessions which are scanning to see if we need to
deactivate a session.

Bug: 1039451
Change-Id: I86c0ae99b2546f57352e98c3b5b648d8144d0f7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988752
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730074}

There is no driver actually generating events with this flag set.
Since this is just downstream technical debt, which apparently isn't
really needed and makes it impossible to compile Chromium with V4L2JDA
enabled with upstream kernel headers, it's probably better to remove
this flag.

Bug: 942415
Test: Compile tested only (removing dead code).
Change-Id: I3803d622d384e8e3831c201812a14c919e5bb4dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981412Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Auto-Submit: Sergey Senozhatsky <senozhatsky@chromium.org>
Commit-Queue: Sergey Senozhatsky <senozhatsky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730073}

This reverts commit 733e2fb1.

Reason for revert: This CL caused a CHECK failure in the following
browser_tests:

LazyLoadDisabledBrowserTest.LazyLoadFrame_DisabledInBackgroundTab
LazyLoadDisabledBrowserTest.LazyLoadFrame_DisabledInIncognito

Sample run: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/85969

CHECK failure log:
> [67654:67654:0110/151505.705450:FATAL:embedded_test_server.cc(389)]
> Check failed: !io_thread_.get(). Handlers must be registered before
> starting the server.

Original change's description:
> Report save-data savings to LiteMode site-breakdown
> 
> This CL gets the estimated data savings due to SaveData and updates as
> LiteMode savings. The savings are retrieved from field trial as json.
> 
> Bug: 923551
> Change-Id: Ia7c5518edfeaedce33e957c19224f6a2350df6c2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990989
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#729972}

TBR=tbansal@chromium.org,rajendrant@chromium.org,ryansturm@chromium.org

Change-Id: I79ebf0d0a25d218ddbe644d708ba65d57061c92a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 923551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994850Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730072}

This is a mechanical patch that turns uses of these methods in unittests
into the newly added ScrollUpdate (which delegates to either of these
under the hood)

Bug: 1016229
Change-Id: Ie65dd5c5b702c625159e239ee0e5b7fc0552e3d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982236
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730071}

Disable the "Install <PWA>" and "Create Shortcut" menu items when
installing the current page would replace an externally-installed app.

Fixed: 992312
Bug: 992312
Change-Id: Iaf8ebfdd0ddd0787b43211affd918c9a0c3a5e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897398Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730070}

https://chromium.googlesource.com/angle/angle.git/+log/7a37d3acf532..12ce8f687d23

git log 7a37d3acf532..12ce8f687d23 --date=short --first-parent --format='%ad %ae %s'
2020-01-10 kbr@chromium.org Upstream WebKit's iOS port of ANGLE.

Created with:
  gclient setdep -r src/third_party/angle@12ce8f687d23

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I408ae5acdd357c0dcb2b62e6aef17612b17951bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994244Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730069}

https://chromium.googlesource.com/catapult.git/+log/0319809c5c5a..9dbcda838560

git log 0319809c5c5a..9dbcda838560 --date=short --first-parent --format='%ad %ae %s'
2020-01-10 dberris@chromium.org Add dispatch.yaml and upload-processing.yaml to dashboard files

Created with:
  gclient setdep -r src/third_party/catapult@9dbcda838560

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1035930
Tbr: oysteine@google.com
Change-Id: I9ec8ea87af22970ec6619d45c642e8481a02781a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994246Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730068}

This changes the type for std::vector arguments passed in wrapper class
constructors and setters from reference to value (i.e. from
const std::vector<>& in_param to std::vector<> in_param), so that

std::move() that we invoke in the bodies of constructors and setters
are actually effective.

The effect of the change on generated files can be seen here:
https://paste.googleplex.com/5618555812839424?raw

Change-Id: Id9cfd3bf23257d2418d462f52a39f3b01e1de96c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990446Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730067}

https://skia.googlesource.com/skia.git/+log/1386c58de710..9eb28ddf2481

git log 1386c58de710..9eb28ddf2481 --date=short --first-parent --format='%ad %ae %s'
2020-01-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 77c89ff847b6..110236f3ce70 (5 commits)

Created with:
  gclient setdep -r src/third_party/skia@9eb28ddf2481

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jvanverth@google.com
Change-Id: I7a1f12b5a8788d944f84b2c39bf524c704102052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994245Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730066}

The writable buffer references are passing their buffers to
the decode surface to set the controls, requests or config store
settings which is making the writable buffer references aware of the
decoded surface.
This patch removes references to the decode surfaces in the writable
buffer reference and at the same time simplifies to the decode surface
submission.

BUG=chromium:1009921
TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.vp8 on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.h264 on veyron_minnie.
TEST=ran tast with video.DecodeAccel.vp8 on veyron_minnie.
TEST=ran tast with video.DecodeAccel.h264 on veyron_minnie.
TEST=ran tast with video.DecodeAccelVD.vp8_resolution_switch on kevin.
TEST=ran tast with video.DecodeAccelVD.h264_resolution_switch on kevin.
TEST=ran tast with video.DecodeAccelVD.vp8 on kevin.
TEST=ran tast with video.DecodeAccelVD.h264 on kevin.
TEST=ran tast with video.DecodeAccel.vp8 on kevin.
TEST=ran tast with video.DecodeAccel.h264 on kevin.
Signed-off-by: Francois Buergisser <fbuergisser@chromium.org>
Change-Id: I5097a2bb9b2ce1ede7e7ad573d37a47d15dfaf26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969411Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730065}

Bug: 907380
Change-Id: I3d8c4d1c4457b6ee9a11d58fe23ce6402e4d6805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994022
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730064}

Following bot results are included.
890 891 892 893 896 897 898

3 lines were removed and 5 lines were deflaked by consecutive
results since 877.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: I39807e59713191698b85fbf8498c264016cd9a33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993074Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730063}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aed6b2e7fbd5..079a14224dd1


Created with:
  gclient setdep -r src-internal@079a14224dd1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1039966
Tbr: jbudorick@google.com
Change-Id: I00873da03898fe4fe02f45beb29126b276e15e51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994664Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#730062}