GitLab

Previous revision is 333. Revision 334 fixes a clang warning about
writing timestamps into strings with "%ld" on systems that use 64-bit
time. The fix is a static cast of the timestamp into long. This will be
fine until 2037.

TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/503383003

Cr-Commit-Position: refs/heads/master@{#291946}

BUG=403813
R=sadrul@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/502583002

Cr-Commit-Position: refs/heads/master@{#291945}

Avoids unnecessarily downloading data which will be unused.

BUG=400788
TEST=none

Review URL: https://codereview.chromium.org/485023003

Cr-Commit-Position: refs/heads/master@{#291944}

* Prevent accessing more arguments than provided.
* Fix application of vertex divisor for non-instanced draws in D3D9
* Fix swizzle formats being assigned incorrectly.
* MANGLE refactorings.

BUG=390111, 398337, angle:721

Review URL: https://codereview.chromium.org/493053006

Cr-Commit-Position: refs/heads/master@{#291943}

BUG=

Review URL: https://codereview.chromium.org/474013006

Cr-Commit-Position: refs/heads/master@{#291942}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/508683002

Cr-Commit-Position: refs/heads/master@{#291941}

This CL repairs a linker error which prevented us from checking in the full copresence implementation under Windows.

BUG=407466

Review URL: https://codereview.chromium.org/503253002

Cr-Commit-Position: refs/heads/master@{#291940}

I can't determine why we are seeing crashes in 	AppListItemList::AddItem
from inspection, so I am adding some more rigorous CHECKs in Release to
help track down the root cause. This shouldn't make the code crash more
often, just sooner and hopefully someplace where we can identify the
problem.

BUG=402357

Review URL: https://codereview.chromium.org/487853003

Cr-Commit-Position: refs/heads/master@{#291939}

Imagine the following:
(1) A user types a username, which matches saved credentials, so the password is autofilled.
(2) The user overwrites the suggested password in the password field.
(3) The user enters the username field again, but leaves it without changes.

Currently, the autofilled password after step 3 replaces the user-typed password from step 2.

This CL makes sure, that the password from step 2 stays.

BUG=385619

Review URL: https://codereview.chromium.org/414013003

Cr-Commit-Position: refs/heads/master@{#291938}

R=tbreisacher@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/490773005

Cr-Commit-Position: refs/heads/master@{#291937}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/509553002

Cr-Commit-Position: refs/heads/master@{#291936}

 (there was no leak reported because they're deleted upon shutdown)

A few minor cleanup/improvements
* Added shortcut to close athena. This doesn't update overview/split view mode.
  I'll address it in separate CL.
* Delete unnecessary athena_content_support_lib target. (I somehow missed this in review)
* Separate app_shell specific impl in extensions_delegate  (this is prep for athena+chrome)
* Remove ActivityWidget wrapper and use views::Widget instead, as it seems to be unnecessary. This is also prep for athena+chrome, where AppActivity should use NativeAppWindowViews.

BUG=None
TEST=coverted by unittests.
TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/498023003

Cr-Commit-Position: refs/heads/master@{#291935}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/501413003

Cr-Commit-Position: refs/heads/master@{#291934}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/505213002

Cr-Commit-Position: refs/heads/master@{#291933}

It's flaking with the same error that causes it to be disabled on other platforms.

TBR=bajones@chromium.org
BUG=373812

Review URL: https://codereview.chromium.org/502133006

Cr-Commit-Position: refs/heads/master@{#291932}

BUG=407342

Review URL: https://codereview.chromium.org/471763009

Cr-Commit-Position: refs/heads/master@{#291931}

App Store rules require shipping armv7s with arm64, so this is required
for the "both" configuration.

Also adds it to the 32-bit configuration so that local testing will
better match actual builds, but we can revisit if that turns out to be
onerous in practice.

BUG=407295

Review URL: https://codereview.chromium.org/489713003

Cr-Commit-Position: refs/heads/master@{#291930}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/501033003

Cr-Commit-Position: refs/heads/master@{#291929}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506633004

Cr-Commit-Position: refs/heads/master@{#291928}

Previously it put all toolchains' main link output into the root build directory, which doesn't work when there are multiple toolchains generating the same targets.

BUG=405686
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/502163002

Cr-Commit-Position: refs/heads/master@{#291927}

The revision reported by getos is now a string rather
than an integer (since we use git shas now).

The behavior was changes in
https://codereview.chromium.org/502883002 but
unfortunately the NaCl SDK bot are still not part
of the CQ so it slipped through.

BUG=406993
R=binji@chromium.org

Review URL: https://codereview.chromium.org/507673003

Cr-Commit-Position: refs/heads/master@{#291926}

Revert of Add support for codepen to form_based_credentials_background (patchset #9 of https://codereview.chromium.org/485743002/)

Reason for revert:
The test change is causing flakiness on trybots even with retries, see

telemetry/core/backends/google_credentials_backend_unittest/TestGoogleCredentialsBackend/testLoginUsingMock:

http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5713
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5703
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6959
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/9980
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/9973
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/2974
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/2966
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6950

Original issue's description:
> Add support for codepen to form_based_credentials_background
>
> Fix google credentials support.
>
> Migrate to action_runner when possible.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a64e885edb85f66035f35a848c0add3726a663af

TBR=tonyg@chromium.org,sullivan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/502533003

Cr-Commit-Position: refs/heads/master@{#291925}

These would cause DCHECK failures later in the system.

BUG=403518

Review URL: https://codereview.chromium.org/499343004

Cr-Commit-Position: refs/heads/master@{#291924}

BUG=403322
NOTRY=true

Review URL: https://codereview.chromium.org/471433007

Cr-Commit-Position: refs/heads/master@{#291923}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503933002

Cr-Commit-Position: refs/heads/master@{#291922}

BUG=328847

Review URL: https://codereview.chromium.org/446073002

Cr-Commit-Position: refs/heads/master@{#291921}

We're trying to kill off notifications, and this one's no
different.
Also, move the logic for notifying the location bar of
page actions being updated to ExtensionActionAPI.

BUG=406590

Review URL: https://codereview.chromium.org/496403003

Cr-Commit-Position: refs/heads/master@{#291920}

(Also convert the existing convenience constructor to a static factor function.)

This avoids everyone having to know about
LocalMessagePipeEndpoint/RemoteMessagePipeEndpoint.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/505863002

Cr-Commit-Position: refs/heads/master@{#291919}

This patch sets ppi@ as owner of histograms tracking the child process
launch time (important as this is a significant performance factor on
some platforms) and number of renderer processes kept around.

BUG=401821

Review URL: https://codereview.chromium.org/500403002

Cr-Commit-Position: refs/heads/master@{#291918}

Currently only available on android.
BUG=383630
NOTRY=true
R=cjhopman@chromium.org, isherman@chromium.org, nyquist@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/498403002

Cr-Commit-Position: refs/heads/master@{#291917}

Cr-Commit-Position: refs/heads/master@{#291916}

BUG=407292
R=oshima@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/503113002

Cr-Commit-Position: refs/heads/master@{#291915}

This patch should be reverted when it is fixed along with a unittest to
guard against regression.

BUG=402885
NOTRY=True
TBR=epenner@chromium.org

Review URL: https://codereview.chromium.org/504163003

Cr-Commit-Position: refs/heads/master@{#291914}

Revert of Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable. (patchset #1 of https://codereview.chromium.org/492623003/)

Reason for revert:
Causing huge amounts of flake even with retries, see these jobs that failed on the CQ.

Please don't renable without watching the trybots closely to make sure it's not causing a lot of failures: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming?numbuilds=200

http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5716
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5716
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5696
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5688
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5685
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5680
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5678
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5675
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5673
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5671
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5667
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5666
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5665
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5663
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5661
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5661
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5660
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5647
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5644
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5643
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5637
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5639

Original issue's description:
> Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable.
>
> This test was flaky because it modified system properties. Moving it to
> interactive_ui_tests should allow it the system control guarantees it
> needs to complete successfully.
>
> BUG=396344
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4d5d5d700a104f5e6bec47a8891fc5a54a4f242b

TBR=sky@chromium.org,calamity@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396344

Review URL: https://codereview.chromium.org/504253002

Cr-Commit-Position: refs/heads/master@{#291913}

- Use UrlRequestContext.CreateRequest.
- Expect GIT revision in HttpUrlRequestFactoryTest.
- Prevent getAllHeaders from being removed by proguard.

BUG=390267

Review URL: https://codereview.chromium.org/500193002

Cr-Commit-Position: refs/heads/master@{#291912}

This makes the test pass.

BUG=none

Review URL: https://codereview.chromium.org/500223002

Cr-Commit-Position: refs/heads/master@{#291911}

- Moved RasterBuffer from ResourceProvider to its own file.
It's now the public interface used by raster tasks.
- Added Acquire/ReleaseSkCanvas() interface into
RasterBuffer.
- Bitmap conversion is now done in raster worker thread
through RasterBuffer interface.

BUG=None

Review URL: https://codereview.chromium.org/454843002

Cr-Commit-Position: refs/heads/master@{#291910}

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/503283002

Cr-Commit-Position: refs/heads/master@{#291909}

BUG=405784

Review URL: https://codereview.chromium.org/502103003

Cr-Commit-Position: refs/heads/master@{#291908}

Revert of Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds. (patchset #1 of https://codereview.chromium.org/502183003/)

Reason for revert:
https://codereview.chromium.org/480723006/ fixed this.

Original issue's description:
> Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds.
>
> BUG=407467
> TBR=bshe@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1598e5ab15e3c24f6d17e2214e61185d1098c915

TBR=bshe@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407467

Review URL: https://codereview.chromium.org/506953002

Cr-Commit-Position: refs/heads/master@{#291907}