- 16 May, 2018 40 commits
-
-
https://pdfium.googlesource.com/pdfium.git/+log/c3aa483e1325..a68ee04cfdeb $ git log c3aa483e1..a68ee04cf --date=short --no-merges --format='%ad %ae %s' 2018-05-16 dsinclair Verify bidi pos is within range before accessing Created with: roll-dep src/third_party/pdfium BUG=chromium:843100 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I538af2faea53bef08fc016efdb5eb33f10759520 Reviewed-on: https://chromium-review.googlesource.com/1061577 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559105}
-
Christopher Thompson authored
This implements the first phase of https://crbug.com/542484, to start having the omnibox suggest HTTPS URLs directly if there is a redirect from HTTP to HTTPS. This handles initial setup and db migration. A follow up CL will make the user-visible changes about scoring. A second follow up CL will change the terminology of "typed_count" to "omnibox_typed_score" throughout the rest of the codebase. This CL does the following: (1) Move the logic that determines the typed_increment based on transition type from HistoryBackend::AddPageVisit() to a helper. (2) Adds a migration for the visits database to add a new |incremented_omnibox_typed_score| boolean column, using that helper function. (3) Updates the history expiration logic to use the new column to decide when/how to decrement typed counts. Bug: 542484 Change-Id: I8b42c5b0e234703ad73537aa63373f240e66cc13 Reviewed-on: https://chromium-review.googlesource.com/1002890Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559104}
-
kylechar authored
Empty once callbacks can't be run, so pass DoNothing callback instead. Bug: 843458 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I657e750efba2d12fea9f89d3617cfeebbaed78e3 Reviewed-on: https://chromium-review.googlesource.com/1061576Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#559103}
-
Lucas Gadani authored
This reverts commit 7a5a390d. Reason for revert: Windows bots aren't happy. Original change's description: > Remove CacheStorage mojom typemaps. > > This CL removes the typemaps for CacheStorage and converts the browser usage of > CacheStorage types to mojo types. > > Bug: 612287 > Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1 > Reviewed-on: https://chromium-review.googlesource.com/1058334 > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559058} TBR=jsbell@chromium.org,kinuko@chromium.org,lfg@chromium.org Change-Id: I3fc714c0984587beaed5cd4d21a7786e2288c662 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 612287 Reviewed-on: https://chromium-review.googlesource.com/1061965Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#559102}
-
Łukasz Anforowicz authored
This reverts commit 14b1861d. Reason for revert: This CL introduced a layout test that seems to be consistently failing on Win10 starting in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35033 in http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html: FAIL Synchronous CORS XHR after redirect on worker assert_equals: expected "PASS: Cross-domain access allowed.\n" but got "PASS: Cross-domain access allowed.\r\n" Original change's description: > Revive WorkerThreadableLoader for sync XHR again > > The cl "5e1b52dd" which made ThreadableLoader > use DocumentThreadableLoader for sync loading from worker thread had broken > existing site. https://crbug.com/840348 > > This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't > support CORS after redirect. > > It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously() > support it. So This CL revives WorkerThreadableLoader for sync XHR. > > Bug: 840348, 706331 > Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537 > Reviewed-on: https://chromium-review.googlesource.com/1060793 > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559023} TBR=horo@chromium.org,kinuko@chromium.org Change-Id: I1605a0b591d59737fa09951e6f8d5f3d907d52b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840348, 706331 Reviewed-on: https://chromium-review.googlesource.com/1061894Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#559101}
-
Yuki Shiino authored
Annotates EventListenerMap class as final. Change-Id: Ifa70b4ac0ada0f73533817035e1abca5a5233299 Reviewed-on: https://chromium-review.googlesource.com/1061633Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559100}
-
Gabriel Charette authored
We recently found a major handle leak. Adding the handle count as a field will help identify spurious crashes that were caused by this and avoid 100 owners looking into the same thing and cursing Windows + crash. R=siggi@chromium.org Bug: 841565 Change-Id: Ife9126450397df0bb736860141a28888143062f2 Reviewed-on: https://chromium-review.googlesource.com/1053806Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#559099}
-
Alexandr Ilin authored
Change-Id: I4c7aed23d680d70283f68124a7b7883b246cd0d9 Reviewed-on: https://chromium-review.googlesource.com/1061465Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559098}
-
Ben Wagner authored
This adds the SK_IGNORE_SKIMAGE_ONREFENCODED_CHANGE flag to hold off a Skia API change to use smart pointers for SkData returned from SkImage. After the Skia change rolls into Chromium, Chromium implementations of this API will be updated and the flag removed. Change-Id: I66649e7eb6ce25b51b8467337a8216e8acfd2e17 Reviewed-on: https://chromium-review.googlesource.com/1059731Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#559097}
-
Hayato Ito authored
This is a tentative fix for several crashes cluster fuzzer reported. It looks HTMLSlotElement::DetachLayoutTree is touching dirty assigned_nodes. It's still hard to have a minimized test case, so I'll work on that later to investigate further. I've added TODO comment there. Bug: 776656,843069,843261 Change-Id: I9093e170e3c851b89612f40e764bfdbdc1532d4f Reviewed-on: https://chromium-review.googlesource.com/1061274 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559096}
-
Mark Pilgrim authored
Bug: 714018 Change-Id: If7b20cee715746e7d97b557f79ca1c9e5ffaca6d Reviewed-on: https://chromium-review.googlesource.com/1061596Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559095}
-
Benoit Lize authored
This is currently the third largest symbol in Chrome on Android, yet is out of the orderfile (as it's not instrumented). Bug: 758566 Change-Id: Id4b3cfcc74bbf5c2202ae4ed1eff2e385ef4c7b7 Reviewed-on: https://chromium-review.googlesource.com/1061521Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559094}
-
Vaclav Brozek authored
The HTML based username detector first computes an ordered list of potential usernames out of all form fields, and then tries to identify the front-most of that list which is also on a list of plausible username fields computed by other parts of Chrome. This bundling may become a source of trouble once most of the parsing code, including the one which produces the plausible username fields, gets moved to a different process (renderer -> browser) and will get run after the HTML classifier. To solve this problem, this CL keeps the first part within html_based_username_detector.cc, but moves the latter to the callsite, the password_form_conversion_utils.cc. This way the HTML based detector only needs the list of all form fields and loses its dependency on the code computing the plausible fields. Bug: 833838 Change-Id: I66eef8098cd523c52fc54d02197a46382ada2fc6 Reviewed-on: https://chromium-review.googlesource.com/1032738Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559093}
-
Marc Treib authored
This includes adopting OnceCallback, using the newer (value-based instead of unique_ptr-based) API for base::Value, and simpler handling of the "!engine_initialized_" case. Bug: none Change-Id: Id3ab8b48e7a12bca4f3945f959a2b493f407bfc1 Reviewed-on: https://chromium-review.googlesource.com/1060994 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559092}
-
Christos Froussios authored
Our current matchers fail the test if they don't match. This is against the formal definition of matchers, which are supposed to be side-effect- free. It also prevents us form setting multiple expectations per test, which will be needed for crbug.com/840384. I've refactored the matchers to not fail the test. I've also split the matchers and added matching result messages, to keep the explanatory value of error messages. Bug: 840384 Change-Id: Ie96af6230e9c165b2ce21d1d6930f3a0b3f3b68b Reviewed-on: https://chromium-review.googlesource.com/1055393 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#559091}
-
Kevin Bailey authored
We were adding padding both in the call to, and within the Omnibox tab switch button class. This CL moves all the padding to the class, which removes the need for the constant in the parent class, Omnibox result view. Bug: 780835 Change-Id: I1c5255752625b08904c356369989073063a3e904 Reviewed-on: https://chromium-review.googlesource.com/1059706Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559090}
-
John Abd-El-Malek authored
The problem, while not specific to these tests, manifested in the download tests sometimes hanging. The cause was that the initial reading of DNS configuration was cancelling in-progress host resolver queries. This showed up in these particular tests because they loaded requests immediately (e.g. without going through the renderer) on startup and were using the (mock) host resolver. Other tests usually spin up a renderer, which would delay requests through the network and this bug would be masked. This was solved previously for Android in http://crbug.com/470897. This change fixes it for all platforms. It also simplifies the previous fix, since later in r391799 the code stopped using time comparisons and just used a boolean to store whether it was the first dns setting or not. Bug: 841557, 470897 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3b0a081098a3e3400881c88e64a7f2ce2797f728 Reviewed-on: https://chromium-review.googlesource.com/1055111Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#559089}
-
Mike Klein authored
This lets us set Chromium-specific defines and cflags directly, as an alternative to the injected chromium_specific_config_for_skcms. (We'd rather skcms not have to think about Chromium if possible.) Change-Id: I9e13df7b5210645b2a77a0f2157b2cbe654f11ea Reviewed-on: https://chromium-review.googlesource.com/1059450Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#559088}
-
Rayan Kanso authored
Bug: 843545 Change-Id: I744c4d15cf9a44846342b9ec23d3406937ebb973 Reviewed-on: https://chromium-review.googlesource.com/1061695Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559087}
-
Max Morin authored
There lines were accidentally readded after being removed, so re-remove them. Change-Id: I2ec3ab7114afd1a563cc5cf43e4611ddb55f01ca Reviewed-on: https://chromium-review.googlesource.com/1061462Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#559086}
-
Quinten Yearsley authored
Bug: 731983 Change-Id: Ic40dc83011157ea7f6d23d7be52c2b8571074334 Reviewed-on: https://chromium-review.googlesource.com/1058310Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#559085}
-
Luke Zielinski authored
We now wait until both cache and redirect collection completes. This fixes an issue where duplicate resource IDs could appear in the report because trimming removed elements and then redirects URLs would overlap with IDs that were not trimmed. Change-Id: I788c515b45f0bb5949d52040c82cd57ee134cc19 Reviewed-on: https://chromium-review.googlesource.com/1060157Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559084}
-
Thomas Tangl authored
When unified-consent is enabled, the syncSetup page title is now "Sync and personalization". Bug: 836034 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6832f4c64f6b30bd17e271cffa35cf85785a3076 Reviewed-on: https://chromium-review.googlesource.com/1027837 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559083}
-
Mathieu Perreault authored
Cleaning up a Feature which has been launched for some time now. Bug: 841772 Test: existing Change-Id: I1edd1bf91d31f89021530f0b70adafb6081e17e2 Reviewed-on: https://chromium-review.googlesource.com/1061477Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559082}
-
Kush Sinha authored
Bug: 820046 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I7c32e459c310741fdfb830acfededbda832f5506 Reviewed-on: https://chromium-review.googlesource.com/1057622Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#559081}
-
Noel Gordon authored
Remove FileManagerBrowserTestWithLegacyEventDispatch [1], and re-group the tabindex tests into one test fixture. The old fixtures go away and the Flakiness Dashboard will no longer get data from them. [1] FileManagerBrowserTest handles legacy event dispatch for any tests that contain "tabindex", see ShouldEnableLegacyEventDispatch. Mash: remove old TabIndex test exclusions from the Mash bot filter and add exclusion for the new TabIndex/FileManagerBrowserTest. Bug: 843030 Change-Id: I5aa45996ede4eccdc39ec2ba04d945e7b7f5032f Reviewed-on: https://chromium-review.googlesource.com/1061133 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559080}
-
Fady Samuel authored
Bug: none Change-Id: I5dc0b8be17f8d88fb4650c1c564d7f295dc5c1fe Reviewed-on: https://chromium-review.googlesource.com/1061575Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559079}
-
Fady Samuel authored
We need to always update DelegatedFrameHost and call RenderWidgetHostImpl::SynchronizeVisualProperties when we receive a viz::LocalSurfaceId from the child renderer as auto-resize is no longer the only case for child allocated LocalSurfaceIds. Change-Id: I9fcd6b9b6fe2efcaf8bfb2c9eda988fb9f8cc67c Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1058445Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559078}
-
Max Morin authored
Bug: 843103 Change-Id: I1040b014620079865b1141c52ac8ec90fec26ab7 Reviewed-on: https://chromium-review.googlesource.com/1061293Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559077}
-
Emily Hanley authored
Bug: 840427 Change-Id: I44364a9c3954b14118c77c51cfd454be3919c1f2 Reviewed-on: https://chromium-review.googlesource.com/1055776Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559076}
-
danakj authored
This makes every method in WebLayer match the method name in cc::Layer, with exception of the constructor and the CcLayer() unwrapping methods. It also includes web_layer.h instead of forward delcaring it everywhere so when we change it to an alias, these files will know that, instead of having to change them all to also alias. We'll later change them back to cc::Layer forward declarations. R=pdr@chromium.org TBR=piman, dalecurtis Bug: 838693 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0b353da350326d57aeac03191dc88a775442d47f Reviewed-on: https://chromium-review.googlesource.com/1056067 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559075}
-
Justin Cohen authored
This reverts commit 8326d5f3. Reason for revert: Tests are still failing after this rolled in. Original change's description: > [ios] Revert smarter CellWithMatcher change for pre-Refresh > > Speculative fix for pre-Refresh content test failures. > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I743bb7e99a702ea300f0505d6d64a87b906db383 > Reviewed-on: https://chromium-review.googlesource.com/1057460 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558308} TBR=justincohen@chromium.org,gambard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idbbbb285dd8e53e3984b2314cb03775b872c25b6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1060173Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559074}
-
Christian Dullweber authored
All cookie and localstorage tests for BrowsingDataRemover have been moved to StoragePartitionTest in 2013 (https://crrev.com/37843003) and replaced with testing a StoragePartitionMock. This code isn't needed anymore. Change-Id: I7b4278b8a926a2930a69430288c7ab560d162f46 Reviewed-on: https://chromium-review.googlesource.com/1061500Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#559073}
-
W. James MacLean authored
A test that should detect if invoking a tooltip on Android crashes the browser. This test requires that https://chromium-review.googlesource.com/c/chromium/src/+/1057993 is submitted first. Bug: 842410 Change-Id: Ib80b6f76355423b843fbcfa8a51440197b3bc78d Reviewed-on: https://chromium-review.googlesource.com/1059703 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559072}
-
Andrew Grieve authored
Change-Id: Ibf12b63c3651a41e45e80db477bee362b18eb081 Reviewed-on: https://chromium-review.googlesource.com/1060620Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559071}
-
Chris Nardi authored
The upstream version of this test is already imported into Chromium at external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects.html. Our copy doesn't appear to have diverged from upstream, so remove the outdated duplicate copy of this test. Bug: 723826 Change-Id: I580dbbaa8e88a90b96c5a34eccffa95b62596b21 Reviewed-on: https://chromium-review.googlesource.com/1060283Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559070}
-
Fredrik Söderquist authored
Sink the update of intrinsic_size_ out of the if-else in ComputeIntrinsicSizingInfoForReplacedContent, and then push GetNestedIntrinsicSizingInfo down into subclasses, folding it away to use the "local" constructs of the relevant subclasses. This leaves subclasses to deal with issues such as if whether to apply zoom or not et.c, and will with some additional tweaks allow for more succinct interfaces in the "nested" cases. It also makes LayoutReplaced much simpler. Bug: 722055 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie8493ffa89ffb34d2591d6a7ecdc8ebc20c6264f Reviewed-on: https://chromium-review.googlesource.com/1059776Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#559069}
-
Peter E Conn authored
Bug: 843092 Change-Id: I6e077e6a9db1cc6b36427fdd1238e141c158caeb Reviewed-on: https://chromium-review.googlesource.com/1061314 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559068}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d8600ccc2dde..9795ca36af56 $ git log d8600ccc2..9795ca36a --date=short --no-merges --format='%ad %ae %s' 2018-05-16 simonhatch Dashboard - Move logging statement up a bit. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iee1e309d58f9bc821a9f7a7c3f593e10b8a177ea Reviewed-on: https://chromium-review.googlesource.com/1061573Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559067}
-
Chris Harrelson authored
Bug:795549 Change-Id: If7c933158b924800515cd09837ed16537adc8b45 Reviewed-on: https://chromium-review.googlesource.com/1060607 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#559066}
-