GitLab

fix these two problems:
1. dragging out of the window makes the tab drag representation jump to (0,0)
2. dragging onto a second NTP window results in the tab drag representation appearing in the source window

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6992009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86366 0039d316-1c4b-4281-b951-d872f2087c98

dom-ui sync: Eliminate jank when customizing sync settings. Also, tweak chrome.send message identifiers to that they are less likely to conflict.

BUG=80477
TEST=Invoke 'Customize' sync setings, dialog should fade-in smoothly.
Review URL: http://codereview.chromium.org/7057038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86365 0039d316-1c4b-4281-b951-d872f2087c98

R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7066011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86364 0039d316-1c4b-4281-b951-d872f2087c98

now the chrome logo should always show, but the attribution only shows if the theme has one. I also moved the attribution to the right side because it looks more balanced over there (this didn't break horribly for any of the handful of themes I tested on). Leaving it on the left side, right next to the chrome logo, looks cluttered.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6966022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86363 0039d316-1c4b-4281-b951-d872f2087c98

function "spdy_settings_.Clear()" to the function "void SpdySessionPool::OnIPAddressChanged()".

BUG=55868
TEST="./net_unittests --gtest_filter=SpdySessionTest.ClearSettingsStorage" and "./net_unittests --gtest_filter=SpdySessionTest.ClearOnIPAddressChanged".

Review URL: http://codereview.chromium.org/7046016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86362 0039d316-1c4b-4281-b951-d872f2087c98

Change for preparation for reference-build for PerfBot. PerfBot will be downloading binaries (pyauto.py and its library) for particular build and compare it with current build. This change is preparation for that. It enables media_perf tests to use different binary if reference build option (-a) is used. When the option is set, media_perf_runner runs the test with current build and then reference build (specified by REFERENCE_BUILD_DIR in pyauto_media.py), which I set bogus directory for now.



Review URL: http://codereview.chromium.org/7031020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86361 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zea@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86360 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zea@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86359 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r86333.  Apparently it doesn't work on x64 either.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76232
TEST=Everything sync.

Review URL: http://codereview.chromium.org/6995008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86357 0039d316-1c4b-4281-b951-d872f2087c98

TEST= See https://sites.google.com/a/chromium.org/dev/developers/design-documents/pepper-plugin-implementation for running in Chrome.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=1671
Review URL: http://codereview.chromium.org/7049021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Check that Me2Mom still works.

Review URL: http://codereview.chromium.org/7065009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83640
TEST=Manual

Review URL: http://codereview.chromium.org/6992007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Host plugin doesn't crash when started.

Review URL: http://codereview.chromium.org/6961043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86353 0039d316-1c4b-4281-b951-d872f2087c98

Final gyp patch to make use of the new cross-platform POSIX defines toolkit_uses_gtk, os_posix, and use_x11. For lists of source files that use a mix of POSIX and Gtk APIs, toolkit_uses_gtk was given precedence.  Solaris was made to use ALSA also, as libasound has been ported to FreeBSD and Solaris as a wrapper around the native OSS.

Review URL: http://codereview.chromium.org/7055003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86352 0039d316-1c4b-4281-b951-d872f2087c98

Integrated obfuscation with quota; all unit tests now pass with or without the flag that turns on obfuscation.

BUG=none
TEST=unit tests


Review URL: http://codereview.chromium.org/7057032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86351 0039d316-1c4b-4281-b951-d872f2087c98

It is accessed from the io thread after the fetcher is destroyed on the ui thread.

BUG=none
TEST=Reliability bots.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86340

Review URL: http://codereview.chromium.org/7065008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86350 0039d316-1c4b-4281-b951-d872f2087c98

- rewrite the mapping from PP_FileOpenFlags_Dev to PlatformFileFlags.
- let ppb_flash_file_impl and ppb_file_io_impl use the same mapping logic.
- CreatePlatformFile: resolve the conflict between the win and posix implementation. Before this change, the win implementation didn't allow PLATFORM_FILE_TRUNCATE to be used with any of the (OPEN|CREATE)(_ALWAYS)? flags; while the posix implementation required it to be used with them.
- add more test cases to test the behavior of different PP_FileOpenFlags_Dev combinations.
- also unify the conversion from PlatformFileError to Pepper error.

BUG=68489
TEST=New test cases in test_file_io.cc

Review URL: http://codereview.chromium.org/7038032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=chrome builds with touchui and chromeos

Review URL: http://codereview.chromium.org/6966020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86348 0039d316-1c4b-4281-b951-d872f2087c98

(base::internal::lockimpl::lock___extensioncontentsettingsstore::geteffectivecontentsetting___content_settings::extensionprovider::getcontentsetting)

BUG=83657
TEST=reliability bots

Review URL: http://codereview.chromium.org/7064007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86347 0039d316-1c4b-4281-b951-d872f2087c98

Note that this code only affects users (developers) who turn on the NaCl flag, and it's temporary code until NaCL is turned on by default.

BUG=81010
TEST=about_flags_unittest

Review URL: http://codereview.chromium.org/7049012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86346 0039d316-1c4b-4281-b951-d872f2087c98

It is accessed from the io thread after the fetcher is destroyed on the ui thread.

BUG=none
TEST=Reliability bots.

Review URL: http://codereview.chromium.org/7065008

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/6966021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65874
TEST=Added API test.

Review URL: http://codereview.chromium.org/7042021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86343 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7038012/.

BUG=83062
TEST=PrerenderStatusManagerTests, PrerenderBrowserTests

Review URL: http://codereview.chromium.org/7060012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86342 0039d316-1c4b-4281-b951-d872f2087c98

It is accessed from the io thread after the fetcher is destroyed on the ui thread.

BUG=none
TEST=Reliability bots.

Review URL: http://codereview.chromium.org/7065008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86340 0039d316-1c4b-4281-b951-d872f2087c98

PrerenderContents::Destroy() is called in response to
TabContents destruction.

Re-enables PrerenderBrowserTest.PrerenderHttpAuthentication,
which ran into the issue on ChromeOS.

BUG=82835,82913
TEST=PrerenderBrowserTest.PrerenderHttpAuthentication on ChromeOS

Review URL: http://codereview.chromium.org/7017014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86339 0039d316-1c4b-4281-b951-d872f2087c98

Reverting due to regression of Autofill preferences pane.  See bug 83629.

BUG=82868, 83629

Review URL: http://codereview.chromium.org/7038024

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/7063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83638
TEST=none
Review URL: http://codereview.chromium.org/7063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Connections still work.

Review URL: http://codereview.chromium.org/7067002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7045020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83438
TEST=none

Review URL: http://codereview.chromium.org/7038045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86334 0039d316-1c4b-4281-b951-d872f2087c98

I had been concerned that this wouldn't work with our -fPIC
bits we build internally, but the difference is actually a
performance once, not a correctness one.

(Retry of r85286, with ARM and ia32 disabled.)

BUG=57908

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85437

Review URL: http://codereview.chromium.org/6973032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86333 0039d316-1c4b-4281-b951-d872f2087c98

This is part of an ongoing effort to treat GL contexts and GL surfaces as independent entities.

TEST=run WebGL on mac, windows and linux, trybots
BUG=none
Review URL: http://codereview.chromium.org/7021014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86332 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83622
TEST=Run chrome with --enabled-sync-typed-urls, bring up customize sync dialog, verify typed-urls checkbox is enabled and checked state persists across browser restart.

Review URL: http://codereview.chromium.org/7065001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83638
TEST=Heapchecker goes green.
TBR=ahendrickson
Review URL: http://codereview.chromium.org/7063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86330 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=None
TBR=ukai
Review URL: http://codereview.chromium.org/6990042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86329 0039d316-1c4b-4281-b951-d872f2087c98

This makes some substantial changes to

1) The ownership model needed to change slightly; Global{Bookmark,History}Menu needed to own its GtkMenu due to timing issues. (The other possible way to do this (use gtk_widget_destroyed to NULL out the reference) was discussed and rejected in a similar recent code review).

2) The first connection to the TabRestoreService needs to happen lazily. While this doesn't appear to have any affect during normal startup, it breaks the majority of browser, ui and unit tests that depend on the TabRestoreService because they all depend on controlling the loading state. We can't use the OnShow/PostTask method (see previous CL) so connect to the GtkMenuItem's activate signal.

BUG=30213
TEST=ui_tests and browser_tests pass

Review URL: http://codereview.chromium.org/7017028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86328 0039d316-1c4b-4281-b951-d872f2087c98

Note: I can do this 2 ways. I can either make it call it truly
direclty as in

  gles2_implementation_->BindBuffer(args)

or I can do as I have using CALL_GL_API in which case it's

  CALL_GL_API(BindBuffer)(args)

The only advantage to the second format is a macro changes
it back to the way it was. On the other hand the class is
called WebGraphics3DCommandBufferImpl so maybe I should
change it to the first style.

TEST=try-bots and ran chrome myself
BUG=none

Review URL: http://codereview.chromium.org/7056020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86325 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of url_request_tracking.*.  The only other place that used it other than ResourceDispatcherHost was the plugin installer.  It doesn't really matter which process the request for downloading a plugin (which is very infrequent) shows up for, and arguably, it's better to show up under the browser process.

BUG=76697
Review URL: http://codereview.chromium.org/7054023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86324 0039d316-1c4b-4281-b951-d872f2087c98

Adds support for user certificates, sending their PKCS#11 certificate ID down to flimflam.  Note this does not send the certificate slot - flimflam will have to look in the TPM slot.  This is similar to what we do for 802.1X Wi-Fi connection certificates.

BUG=chromium-os:14111
TEST=Start with no certificates installed.  Go to network menu > Private networks > Add private network.  Select "L2TPIPSec + User cert".  Verify connect button does not enable (because you have no certs available).  Cancel, then install a user cert with certificate manager.  Verify the cert appears in the Add private network dialog.  Verify connect button is enabled.  Verify you can connect to a VPN that requires certs.

Review URL: http://codereview.chromium.org/7038038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86323 0039d316-1c4b-4281-b951-d872f2087c98