- 26 Nov, 2018 40 commits
-
-
Nico Weber authored
TBR=hans Bug: 899438 Change-Id: I790c63caa60a56fa5102c46ac10ff57aa22e535b Reviewed-on: https://chromium-review.googlesource.com/c/1351375Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610869}
-
Dan Elphick authored
Use MaybeLocal version of GetFunction in GinJavaBridgeObject as original function is deprecated. Since the original code seems to react to other failures by returning an empty Local<>, I've used the same pattern rather than ToLocalChecked. Bug: v8:7295, v8:8238 Change-Id: I634b4d7ec51c4874f9628f05fbf5106f10c0990c Reviewed-on: https://chromium-review.googlesource.com/c/1348045Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610868}
-
Dominik Röttsches authored
Now that HarfBuzz AAT landed, enable more HarfBuzzShaper tests on Mac. Bug: 894354 Change-Id: I2d3cdf721187f4366c964bcd982f3954ccd61429 Reviewed-on: https://chromium-review.googlesource.com/c/1350810 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#610867}
-
Florian Uunk authored
The browsertests used to rely on the save manager being hardcoded to upload to Google if the observer_for_testing was set. This makes it impossible to test that the logic for showing the upload prompt works properly. BUG=906630, 859761 Change-Id: Id7352a869388aac4ff36e1284750e22ac68c91b3 Reviewed-on: https://chromium-review.googlesource.com/c/1348335 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610866}
-
Stephane Zermatten authored
Before this change, the tab controls were not accessible while the overlay was enabled. This is because the touch event filter covers the whole screen, even though only a part of the screen is grayed out. The controls were only accessible while an area of the screen was touchable. With this change, the tab controls are always accessible, no matter the state of the touch event filter. Bug: 806868 Change-Id: Ia3e2e8b3c78758f92027afb73cebe4d703bbfb1c Reviewed-on: https://chromium-review.googlesource.com/c/1350951Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610865}
-
Elly Fong-Jones authored
This change drops uses of GTMSMJobRemove and GTMSMJobSubmit, and replaces themm with uses of new functions in the mac::services namespace. Bug: 903800 Change-Id: I0e38ddf3532274bd8ff0ea861f14707a183cd3ff Reviewed-on: https://chromium-review.googlesource.com/c/1337823Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
Jeremy Roman authored
Bug: 565837 Change-Id: Ifc6fc164cd3587d6f3ffb996074878a34014fc00 Reviewed-on: https://chromium-review.googlesource.com/c/1347571Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610863}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e71de132fbc..d543f7dfed9b git log 9e71de132fbc..d543f7dfed9b --date=short --no-merges --format='%ad %ae %s' 2018-11-26 janisozaur@users.noreply.github.com Don't use CMake's own property as variable name (#2112) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d543f7dfed9b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I26099ad7fa39368237ecee7624e13026f3c974e6 Reviewed-on: https://chromium-review.googlesource.com/c/1351229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610862}
-
Tarun Bansal authored
Currently, the render process sends the statistics of only the anchor elements that are in the viewport to the browser. This CL changes it to also include the anchor elements whose target URL is one digit different from the document URL. Note that there is still a limit of 40 on the count of anchor elements that are sent from the render to the browser process. Bug: 850624 Change-Id: I25443e44959c768b869f5b852a28baf5b0271034 Reviewed-on: https://chromium-review.googlesource.com/c/1344268Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610861}
-
Tien Mai authored
- Checks the current thread preferred UI language and pass it onto Chrome so that it presents itself with a language that matches the logon screen. Bug: 908451 Change-Id: I8f40a1501baabfe592cde6eea2c74bd19d47e9df Reviewed-on: https://chromium-review.googlesource.com/c/1351249Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#610860}
-
kyle Ju authored
Change-Id: I80c5bea68c43493acb0b6cb95b9263adf51f856a Reviewed-on: https://chromium-review.googlesource.com/c/1351209 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#610859}
-
Sebastien Marchand authored
Change-Id: I15bd9474339a26f05cd3972e04ce3a40f50d3f27 Reviewed-on: https://chromium-review.googlesource.com/c/1343017Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Nico Weber authored
Also remove a few entries that haven't been used since we made the bots use filelists from .isolate files for comparison. TBR=hans Bug: 899438 Change-Id: Iba9e3d111063c352552a5af51cc14ba3d8219a29 Reviewed-on: https://chromium-review.googlesource.com/c/1351370Reviewed-by:
-
Steve Kobes authored
Mark disable-threaded-scrolling non-expiring as it is a useful debugging control when investigating scrolling issues. Smooth scrolling was discussed on input-dev in https://goo.gl/qZ68P2 and crbug.com/817814 tracks adding an accessibility setting for it, which we should do before the flag expires. Change-Id: I54fe4c4ff49b340af9b49d087e634f97d452a433 Reviewed-on: https://chromium-review.googlesource.com/c/1348868 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610856}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9d7a25e1240..1b1a6401f31b Created with: gclient setdep -r src-internal@1b1a6401f31b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If0f28e9ac4db453192d486de21df988122d034e2 Reviewed-on: https://chromium-review.googlesource.com/c/1351069Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610855}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia05958c388696be00b9ce8dbbedc2a3202fbc065 Reviewed-on: https://chromium-review.googlesource.com/c/1350293Reviewed-by:
-
Avi Drissman authored
Apple’s documentation on menus is incorrect (see the linked bug) so the test we were doing was wrong. And anyway, why double-check the shortcut key? We're in -applicationShouldTerminate: so the user *did* give a quit command. Just assume that the system did the right thing and match on the fact that we're processing a key down. Also do some cleanup of comments and names that are just wrong. BUG=142944 Change-Id: I797a97d3675e67e2426cc296e7c8642e08b91504 Reviewed-on: https://chromium-review.googlesource.com/c/1345030Reviewed-by:
-
Charlie Harrison authored
ContentSettingBubbleContents owns the underlying bubble model. It is also a WebContentsObserver. This CL destroys the bubble model in WebContentsDestroyed, which allows the model to avoid paranoid null checking throughout the code. In the process, we also remove: 1. Notification observation about profile / web contents destruction. The profile should be alive as long as the web contents. 2. Storing the profile directly and accessing the raw ptr. Instead, just pull it off the web contents. One subtle thing about this patch. On WebContentsDestroyed, we do not synchronously destroy the underlying ContentSettingBubbleContents, instead, we synchronously hide it and post a task which actually deletes it. This means we need to be careful about properly null checking the content_setting_bubble_model_. Thankfully, we can assume that event listeners are not invoked on hidden widgets. Bug: None Change-Id: I0a1ff38a705ace8a9898a4c89f81d51d8474b4da Reviewed-on: https://chromium-review.googlesource.com/c/1334097 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#610852}
-
Vadym Doroshenko authored
The final state of the new password form parser is that it works without any help of the old one. This CL introduces feature and flag for this (implementation will be in the subsequent CL). Bug: 831123 Change-Id: I03fa707f3efdc4a7be46454b72b41ef629bceeef Reviewed-on: https://chromium-review.googlesource.com/c/1348059Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#610851}
-
Andy Paicu authored
Spec PR: https://github.com/w3c/webappsec-csp/pull/358 Bug: 905301, 894228, 836148 Change-Id: I43ada2266d42d1cd56dbe3c6dd89d115e878a83a Reviewed-on: https://chromium-review.googlesource.com/c/1314633 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#610850}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc97432f4f93..9a061a5c2b22 git log bc97432f4f93..9a061a5c2b22 --date=short --no-merges --format='%ad %ae %s' 2018-11-26 caryclark@skia.org fix pathops fuzz Created with: gclient setdep -r src/third_party/skia@9a061a5c2b22 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:907844 TBR=borenet@chromium.org Change-Id: I610db74ac84a8aeb531c8d0a3fbab536f902f89f Reviewed-on: https://chromium-review.googlesource.com/c/1350233Reviewed-by:
-
Justin Cohen authored
Bug: 907467 Change-Id: I508359926472d5bfcda2c7564fc3d550f77e8a2b Reviewed-on: https://chromium-review.googlesource.com/c/1350204Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610848}
-
Nico Weber authored
The browser_console_module.js is apparently no longer needed. Add 'nacl_irt_x86_32.nexe', 'nacl_irt_x86_32.nexe.debug', which started misbehaving over the weekend. Bug: 899438 Change-Id: I14a69aa7ff43203cc0dae4aef2db566db5d6cc12 Reviewed-on: https://chromium-review.googlesource.com/c/1351089Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610847}
-
Rune Lillesveen authored
This reverts commit 05522106. Reason for revert: FindIt claims this is the reason for a failing SuggestAppDialog/FilesAppBrowserTest.Test/suggestAppDialog on CROS MSAN: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/9831 Original change's description: > Re-land "Don't unmount zip files when canceling password input." > > The original change didn't handle the case where the injected code to > click "Cancel" button was run after the dialog page has fully loaded. In > this case, the DOMContentLoaded event has already fired. > > BUG=808300 > > No-try: true > Change-Id: Ibf8408a7a44ef8bc8029764d31bc9a5171119cc8 > Reviewed-on: https://chromium-review.googlesource.com/c/1350444 > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610812} TBR=noel@chromium.org,amistry@chromium.org Change-Id: I1cd48d0aaf953cc3a635a016de129b20bad865f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808300 Reviewed-on: https://chromium-review.googlesource.com/c/1350912Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610846}
-
Henrik Boström authored
The responsibility of modules/peerconnection OWNERS should be no different than platform/peerconnection. Making the platform OWNERS file point to the modules OWNERS file. NOTRY=True Bug: none Change-Id: I5054ba2f86bdae2f50991a3ad0b2eb315381c5fd Reviewed-on: https://chromium-review.googlesource.com/c/1350871Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610845}
-
Antonio Gomes authored
This bug is a follow up of [1] and [2], where production code (//c/b/extensions/api/identity/identity_api.cc) is migrated away from using PO2TS in favor of IdentityManager, and the API is extended to accommodate the needs of this migration, respectively. [1] https://crrev.com/b/1340890 [2] https://crrev.com/b/1346609 BUG=906615 Change-Id: Ib41f99f08b7d181bbcff28be97c8b55993aa8c04 Reviewed-on: https://chromium-review.googlesource.com/c/1343019 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#610844}
-
Antonio Gomes authored
IdentityManager currently wraps other signin APIs including SigninManager and PO2TS. This CL migrates ArcPlayStoreEnabledPreferenceHandlerTest and IdentityManager's testing facility IdentityTestEnvironment, and hides the test internals from SigninManager APIs. This is part of the servicification effort. BUG=907484 Change-Id: I85f764f3477ee8e974298c0b41e22ac6277f61c5 Reviewed-on: https://chromium-review.googlesource.com/c/1349589 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610843}
-
Jan Krcal authored
This CL adds more integration tests; it also fixes a bug that stopped local changes of billing address and local changes of has_converted to get propagated to sync. Compared to the original CL (patch set 1 here), patch set 2 in this CL fixes (a) the fixture to make sure PDM converts addresses (a bug introduced after landing the original CL) and (b) the Checker to wait until PDM converts remote addresses to local ones (the reason for the flakiness). Bug: 894001 Change-Id: Idf4e87ae36f7ed6348250a5d69bcd66b1f16ec54 Reviewed-on: https://chromium-review.googlesource.com/c/1350614 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/500be6dd..89124cf9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60cf7e0d767315867e6a141430444e947ebb0ebb Reviewed-on: https://chromium-review.googlesource.com/c/1350651Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610841}
-
Kevin Bailey authored
Add/remove recent experiments from field trial experiment list. Only updated desktop, per the Finch warning. Bug: 726769 Change-Id: I5ad8b113d60b703f3c61e24f1dd17ae9b3d2a2b7 Reviewed-on: https://chromium-review.googlesource.com/c/1342758 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610840}
-
Sam Zackrisson authored
Client-side cleanup: https://webrtc-review.googlesource.com/c/src/+/111506 Bug: webrtc:7882 Change-Id: I7985e72c4455c39b54ce87e1ca56bce995d1b494 Reviewed-on: https://chromium-review.googlesource.com/c/1344141Reviewed-by:
-
Mikel Astiz authored
We've seen reports (in non-pseudo-USS datatypes, e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=902203) that suggest proto-parsing can take noticeable time if executed on the UI thread. Since this will be a common situation for most sync datatypes, let's add a convenience function in ModelTypeStore itself and adopt it for pseudo-USS types (SyncableServiceBasedBridge). Bug: 870624 Change-Id: Id9cee20c7f384ac51d4f5353b4aae831b5e74749 Reviewed-on: https://chromium-review.googlesource.com/c/1349313Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610838}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c40fe7c74edc..f9d7a25e1240 Created with: gclient setdep -r src-internal@f9d7a25e1240 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0180488b2a2b0596fe2d58128cef0769b2c29788 Reviewed-on: https://chromium-review.googlesource.com/c/1350711Reviewed-by:
-
Antonio Gomes authored
This CL extends IdentityTestEnvironment{Profile,ChromeBrowserState}Adaptor classes with a handful set of APIs needed for identity_apitest.cc, and possibly some other conversions. In summary: - It adds a method that allows setting the testing factories that identity::IdentityTestEnvironment requires explicitly on a Profile that is passed to it. - It extends all methods that (in)directly call GetIdentityTestEnvironmentFactories with the possibility to use or not the "fake URL fetcher" for Gaia's Cookie Manager factory. BUG=906618 Change-Id: I54985c0743ed0ae2528140fac655fcf1baeb9531 Reviewed-on: https://chromium-review.googlesource.com/c/1346609 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: -
Benoît Lizé authored
Don't post delayed tasks that would (1) do nothing (ParkAllIfrendererBackgrounded) and (2) record meaningless statistics (DropStringsWithCompressedDataAndRecordStatistics()) when the feature is not enabled. This is not an issue to interpret finch trial results, just creates unnecessary work. Bug: 877044 Change-Id: I39ed2f787b171334d4e8fc7822599894cd9a4310 Reviewed-on: https://chromium-review.googlesource.com/c/1349650Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610835}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46505d3c656f..df4ad0d1e00a git log 46505d3c656f..df4ad0d1e00a --date=short --no-merges --format='%ad %ae %s' 2018-11-26 lalitm@google.com trace_processor: fix bug with scoped slices in Chrome traces Created with: gclient setdep -r src/third_party/perfetto@df4ad0d1e00a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:119806420 TBR=perfetto-bugs@google.com Change-Id: I5a2ce1d8d3fae3e760f4ba5ffb37f2f2d9beb2aa Reviewed-on: https://chromium-review.googlesource.com/c/1350232Reviewed-by:
-
Manuel Rego Casasnovas authored
Layout containment elements are treated as having no baseline, when that's applied to table cells, flex or grid items that are baseline aligned that means that they should use their synthesized baseline. The patch adds simple check in LayoutBlockFlow::FirstLineBoxBaseline() similar to what we have in other methods. If the element has layout containment it has no baseline (it returns -1). The same thing is done in LayoutNGMixin<Base>::FragmentBaseline() for LayoutNG. Two tests from the WPT suite has been modified in order to avoid baseline alignment as they are not checking that feature of layout containment but something else. BUG=907709 TEST=external/wpt/css/css-contain/contain-layout-baseline-002.html TEST=external/wpt/css/css-contain/contain-layout-baseline-003.html TEST=external/wpt/css/css-contain/contain-layout-baseline-004.html Change-Id: Id393787dd24bf3e34aaf73476e446fb9d0a4e593 Reviewed-on: https://chromium-review.googlesource.com/c/1348892 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610833}
-
Colin Blundell authored
When tests set the refresh token for a given account, IdentityManager must already know about the account (i.e., the account must be seeded in AccountTrackerService). However, the error that occurs if tests invoke SetRefreshTokenForAccount() rather than MakeAccountAvailable() is cryptic and hard to debug. This CL adds a DCHECK to make the error more transparent and give instructions on the proper invocation. Change-Id: I26e38bbccfd16e3e9b0e5c45931edb26ea0e4f0d Bug: 798699 Reviewed-on: https://chromium-review.googlesource.com/c/1350610Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610832}
-
Sergiy Byelozyorov authored
R=tandrii@chromium.org Change-Id: I6900c75a96f1cd7d7c49240de4409d1bc7dde028 Reviewed-on: https://chromium-review.googlesource.com/c/1349693Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610831}
-
Marc Treib authored
See documentation at https://sites.google.com/a/chromium.org/dev/developers/contributing-code/flag-ownership Bug: none Change-Id: I0a985d8f2cfbc991aef90b5ae1077f1f0de0f0af Reviewed-on: https://chromium-review.googlesource.com/c/1348110Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610830}
-
