GitLab

(originally broken by r141977)

Review URL: https://chromiumcodereview.appspot.com/10855105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151109 0039d316-1c4b-4281-b951-d872f2087c98

1 - fix a crash
2 - remove an ifdef that's no longer required

BUG=134929

Review URL: https://chromiumcodereview.appspot.com/10855087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151108 0039d316-1c4b-4281-b951-d872f2087c98

Add RegisterHandler() and UnregisterHandler(), which should be called before and after calls to UpdateRegisteredIds().  Use UnregisterHandler() on
shutdown instead of UpdateRegisteredIds(_, ObjectIdSet()).

Make SyncNotifierHelper non-thread-safe.  Fix test breakages that this revealed.  Also add GetAllRegisteredIds() instead of making it the return value of UpdateRegisteredIds().

Propagate UpdateRegisteredIds()/RegisterHandler()/UnregisterHandler() all
the way up to ProfileSyncService.

Make FakeSyncManager be created on the sync thread.

Clean up SyncBackendHost startup/shutdown behavior a bit.

BUG=140325

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150990

Review URL: https://chromiumcodereview.appspot.com/10824161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=nacl mono buildbots
Review URL: https://chromiumcodereview.appspot.com/10825287

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151106 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/125937

TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/133762
TBR=sky@chromium.org
TEST=
http://build.chromium.org/f/chromium/perf/mac-release-10.6/intl1/report.html?history=150&rev=-1
Review URL: https://chromiumcodereview.appspot.com/10831267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151104 0039d316-1c4b-4281-b951-d872f2087c98

It should be prohibited to copy list observer object because otherwise
it would be impossible to guarantee that network monitor resource
is destroyed when the list observer is destroyed. Also the copied
list observer would not work properly anyway.

Review URL: https://chromiumcodereview.appspot.com/10832229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151103 0039d316-1c4b-4281-b951-d872f2087c98

Added a new kUserRemovedLoginItem pref that is used to track if the user has
previously removed a login item for chrome. This is so we don't keep re-creating
the login item every time the user enables/installs a background app if they
have indicated that they don't want chrome to open at login.

BUG=140017
TEST=Install background app on mac, uncheck "Open at Login" checkbox in dock menu, disable and re-enable the app via Tools->Extension, make sure Open at Login checkbox does not get re-enabled.


Review URL: https://chromiumcodereview.appspot.com/10823221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151102 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ivankr@chromium.org
BUG=141916
Review URL: https://chromiumcodereview.appspot.com/10826252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118511


Review URL: https://chromiumcodereview.appspot.com/10823244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151100 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yoz@chromium.org
BUG=141913
Review URL: https://chromiumcodereview.appspot.com/10855108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151099 0039d316-1c4b-4281-b951-d872f2087c98

[Chromoting] Moving common logic responsible for launching child processes to WorkerProcessLauncher class. Launches processes are expected to connect back via a Chromium IPC channel (and their identify can be verified at this point). The class also monitors lifetime of the launched process invoking the normal shutdown sequence in case of premature death of the worker process.

BUG=134694

Review URL: https://chromiumcodereview.appspot.com/10828181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151096 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100356
Test=Unit tests

Review URL: https://chromiumcodereview.appspot.com/10802060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151095 0039d316-1c4b-4281-b951-d872f2087c98

It moved from browser->content and should be in the right registrar.


Review URL: https://chromiumcodereview.appspot.com/10834268

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151094 0039d316-1c4b-4281-b951-d872f2087c98

added while the Window is in the process of notifying observers. I
need this for the new worskpace code that can end up attaching new
observers during a notification (happens when a state change triggers
moving to a different window). If the new observers are also notified
of the change they get confused.

BUG=136919
TEST=none
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10832228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10823274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151092 0039d316-1c4b-4281-b951-d872f2087c98

Sharing shell_util_unittest code to verify shortcuts for creation of profile shortcuts for Windows. profile_manager_unittest needs to be able to verify shortcuts created as well. 

BUG=NONE
TEST=installer_util_unittests --gtest_filter=ShellUtilTest*

Review URL: https://chromiumcodereview.appspot.com/10826188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151091 0039d316-1c4b-4281-b951-d872f2087c98

Bug=141522
Test=No more Arm crash reports

Review URL: https://chromiumcodereview.appspot.com/10854074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151090 0039d316-1c4b-4281-b951-d872f2087c98

gl textures in the DXVA decoder on windows. 

This fixes the problem with flashing in HTML5 videos with gpu compositing turned on.

BUG=141233
R=fischman
Review URL: https://chromiumcodereview.appspot.com/10826238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139631,98716
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827282

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151087 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151085 0039d316-1c4b-4281-b951-d872f2087c98

Should help with GAIA frame loading timeouts that lead to captive portal error message.

TBR=ygorshenin@chromium.org
BUG=128781

Review URL: https://chromiumcodereview.appspot.com/10825299

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141474
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10829263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151083 0039d316-1c4b-4281-b951-d872f2087c98

control: http://codereview.chromium.org/10824254/
Review URL: https://chromiumcodereview.appspot.com/10825298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151082 0039d316-1c4b-4281-b951-d872f2087c98

The USB extension binding code introduced in r134423 is excluded from
the build when OS==android, but still calls the excluded code. None of
the other bindings are excluded on Android currently, and the files do
actually build, so just reinclude them for now. More extension code may
be excluded from android in future, but in a less piecemeal way.

Review URL: https://chromiumcodereview.appspot.com/10855047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10828242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151080 0039d316-1c4b-4281-b951-d872f2087c98

All the FileSystem implementations now handle missing files the same way (by
throwing a FileNotFoundError).

BUG=141664

Review URL: https://chromiumcodereview.appspot.com/10830252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151078 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151077 0039d316-1c4b-4281-b951-d872f2087c98

As a bonus we now get coverage on stopping-while-initializing!

Review URL: https://chromiumcodereview.appspot.com/10834266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/10832250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151074 0039d316-1c4b-4281-b951-d872f2087c98

While dragging a window, show a semi-transparent aura window instead of the standard gray phantom window.

BUG=136816
TEST=new unit tests passed on try


Review URL: https://chromiumcodereview.appspot.com/10823199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138163
TEST=Verify whitespace query string does not trigger search results UI.

R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10832232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141867


Review URL: https://chromiumcodereview.appspot.com/10830259

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151071 0039d316-1c4b-4281-b951-d872f2087c98

Remove the suppression for Valgrind checks against WebFilterOperations, as the leak should be resolved now.

BUG=138231
TBR=zhaoquin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151069 0039d316-1c4b-4281-b951-d872f2087c98

The conversion script will now not generate templates for APIs marked as nodoc.
The server also handles them gracefully if they slip in and 404s.

BUG=141279

Review URL: https://chromiumcodereview.appspot.com/10854054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/10824259

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151067 0039d316-1c4b-4281-b951-d872f2087c98

Supersedes CL 10825003 (owner change).

BUG=138118
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/10833056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151065 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151064 0039d316-1c4b-4281-b951-d872f2087c98

In the course of writing
http://src.chromium.org/viewvc/chrome?view=rev&revision=150463
I noticed that there was getting to be quite a bit of gesture
event related code in RenderWidgetHostImpl. This change gathers
this code together in an external helper class so that some
restructuring needed prior to completing 137555 is easier. This
CL should not change any functionality -- only moves code.

BUG=137555
TBR=jam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10823262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151063 0039d316-1c4b-4281-b951-d872f2087c98