- 09 Oct, 2020 40 commits
-
-
Olivier Robin authored
In side by side mode, it is possible to switch the keyboard focus between 2 applications. In that case, no notification is sent to Chrome. But the keyboardView is recreated on getting the focus back, and it is possible to use this signal to retrigger accessory view. Bug: 1125095 Change-Id: I06e8301ab6aec8fa58a78fed2c94516a1d2fa3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445410 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#815638}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I13561748b18f77d6040bdf1256e3dd003a1b8b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461381Reviewed-by:
Rob Buis <rbuis@igalia.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815637}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: Ia27612e37a3d5c944a0d8ef3bf3af5250cf508ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462263Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815636}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I0f52a7aeba36f13a2cb20018888c049303edc0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459346 Auto-Submit: George Burgess <gbiv@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#815635}
-
Alice Wang authored
This CL hides the incognito row when incognito mode is disabled by the policy IncognitoModeAvailability. Bug: 1136777 Change-Id: I44c004870d6cd51b67951bbcbd853a8b11636c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461319 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815634}
-
Mehran Mahmoudi authored
This CL cleans up the player integeration logic with Chrome, which mostly lived in TabbedPaintPreviewPlayer. That class is now divided in two: One is responsible of showing a paint preview in a tab, and the other controls the logic related to the show-on-startup experiment. This CL also gets rid of most of the logic related to the demo mode. Demo mode now also uses the TabbedPaintPreview for displaying a paint preview. Finally, this CL organizes the various callbacks that PlayerManager needs into one interface. Bug: 1132451 Change-Id: I748b6bb43d78d174c1a4f79ce8f4325cd2970e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432752 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#815633}
-
Mihai Sardarescu authored
This CL removes some Android-only logic that avoided downloading the account info when the account info was invalid. This ensures that the account info is correctly updated when the user signs in to Chrome. This CL also fixes a subtle bug that lead to the avatar image not being downloaded on start-up if the previous attempt to download the avatar image failed. Bug: 1135958 Change-Id: Ia31993f969aac2fc6b7c6f1ed325eb012ad33dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461310 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815632}
-
David Bienvenu authored
This reverts commit bb86e3cd. Reason for revert: <crbug.com/1135885> Original change's description: > Ensure that devtools stays visible when window is made smaller. > > Original CL - https://chromium-review.googlesource.com/c/chromium/src/+/1665550 > > Bug: 974178 > Change-Id: I5792cbd065d1437de2fa44d43407eb70e7b22960 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447094 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814196} TBR=caseq@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974178 Change-Id: Idbfcdf1170a60d940d3989d2b0f9bc8e84f74129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462639Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815631}
-
Jeroen Dhollander authored
These methods (IsSettingSupported and SupportsModifySettings) are not called by Libassistant anymore, and are removed from the API altogether in 1.50 Bug: b/170170824 Change-Id: Ic9bbbfd06661ba8cfe128850bd07a6dc5a395508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451401Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#815630}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/11158c21..07b0b1dc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b48a3d89a2f0bcfe73d6bc14db2c5a44a10ca77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815629}
-
Elly Fong-Jones authored
After this change, ShellView is only responsible for being the contents view of the content shell, and not also for doubling as the window's delegate. Instead, a separate delegate (of the stock WidgetDelegate class) is constructed and installed. Bug: 1075649 Change-Id: I3bc18b53d3c660da21571ca969541699d524af3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461591Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#815628}
-
Tanmoy Mollik authored
Add a test resource to use in place of user profile picture in tests. The tests that require it are also updated. Bug: 1125452 Change-Id: I0b6323b4c9d76816e3216c14d9ca5cd338c60b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401658Reviewed-by:
-
Jacobo Aragunde Pérez authored
This is a follow-up to crrev.com/c/2431526, where we fixed the "save card" and "translate page" bubbles as a side-effect. Now we add some tests to prevent future regressions in these bubbles. Bug: 1119349, 1119367, 1119734 Change-Id: I6e78e4aa1f5377d8512d574ae8deaa0437e51f67 AX-relnotes: Announce "save card" and "translate page" alert dialogs. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460886Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#815626}
-
Hajime Hoshi authored
Bug: 1088512 Change-Id: I95c6688bdf1fc106e77fae90fc4e37e42c99ec81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434017Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815625}
-
Tanmoy Mollik authored
Change color to grey_500 for both light mode and dark mode. Screenshot: https://crbug.com/1135915#c4 Bug: 1135915 Change-Id: I29e790195a4f6d276dceb32aab1d19ba5dc7744e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456527Reviewed-by:
-
Clark DuVall authored
Requested by peconn@ in http://crrev.com/c/2462176. Bug: 1126301 Change-Id: Id5d18fbefa553655e0a28db63c9cc64b1231d39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462173 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#815623}
-
Ewann authored
This CL enables customSeparator in Settings if the SettingsRefresh flag is enable. Bug: 922511 Change-Id: I119e37403c4161301e35982bb5733cee0497263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461327 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815622}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc8f5e0ae349..5291cbadc02e 2020-10-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from fc8264854c53 to c2553a315f5c (5 revisions) 2020-10-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 952149303d06 to 51b03d58fb17 (2 revisions) 2020-10-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 24184fe81c6f to 0046c31f2f96 (2 revisions) 2020-10-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from dc8a96d60b6b to 14ad927e679a (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ie07de8a8d7936e8df3d05bc86b5a60d8aadb5cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815621}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie44bbbdd04be998645c9ab811664ce2710d5da17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463385Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/557d8bce351a..09f602317f2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC flackr@google.com,ayaelattar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1061119 Tbr: flackr@google.com,ayaelattar@google.com Change-Id: I31fe5ef9e71425aa577b51276d7561b2ddb70a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463382Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815619}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I1ff1f3747cc456954dba0075e6e282face479fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450322 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#815618}
-
Peter Kotwicz authored
This CL adds an exception for accent_font.xml. Internal webview contains accent_font.xml but not internal monochrome because accent_font.xml is a resource alias in internal monochrome. BUG=1115604 Change-Id: I9d6b96625baff4a9903b0e0e8e19c2c5c8f8cc89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462712Reviewed-by:
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I7dea7045db9c4c3e25c0fbadc5f0ecd4f369c3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461123Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815616}
-
Robbie Gibson authored
The edit menu was being shown inside a DCHECK. (I.e DCHECK([self methodWithSideEffects]). This meant that it was stripped out in release builds, but not in debug, which is why this didn't reproduce locally. Bug: 1134647 Change-Id: Idbe1a48d0f9c82543cffcc3f79d05128e9589470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462266 Commit-Queue: Robbie Gibson <rkgibson@google.com> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815615}
-
Xida Chen authored
TBR=eirage@chromium.org NOTRY=true Bug: 955316 Change-Id: I44db3fb85a0c84d31f745aa238e4e290844ca8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463329Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815614}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2bf76269e147..c251d370b65e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I72daa0b68e2429acd90e3c80c524d02afddcfa38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461697Reviewed-by:
-
Michael Ludwig authored
Bug: 1136863 Change-Id: I072c08012b90272de4ad4a5f66ceadabcb476e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462558 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#815612}
-
Alexander Dunaev authored
The DBus Menu supports rendering keyboard shortcuts for its items, for which the 'shortcut' property should be set for the menu item. The shortcut is built from the key code using platform-specific conversions. This CL adds a platform interface that allows the DBus menu to query the platform for the key sym string for the given key code, and enables the menu shortcuts for Ozone X11. Bug: 1121908 Change-Id: I42828f967cc2c0eec24d86ba0e0ad0528435bb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450192 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#815611}
-
David Maunder authored
So it can be more easily depended on Bug: 1130769 Change-Id: I79785f1ab1ce4eb5e5773295e4723e8366153e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426296Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#815610}
-
Sorin Jianu authored
This tool is intended for developer use. It is not a production tool, although it may be extended at some point to offer the functionality of Omaha's ApplyTag.exe. The script is a wrapper for certificate_tag.exe. Since the tag format is not a simple concatenation of the magic string start and the tag, but it requires a big-endian value be inserted in between the strings, and certificate_tag.exe requires the tag be provided as a hex-encoded string, then some command wrapping is needed. For now, the tooling assumes the tag is ASCII-encoded, but UTF-8 support can be provided later on. To use the tool, invoke it like this: python3 chrome\updater\tools\tag.py --certificate_tag=out\Default\certificate_tag.exe --in_file=out\Default\UpdaterSetup.signed.exe --tag=appguid={8A69D345-D564-463c-AFF1-A69D9E530F96} Bug: 1128751 Change-Id: I2dab1dfd4e7fff34c9982868625b995cff122d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426765Reviewed-by:Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815609}
-
Renato Silva authored
Being the first screen in the OOBE flow, it remains important to have useful metrics about the state of this screen. Extend the metrics until M94, similar to the other metrics that already exist. Fixed: 1125676 Change-Id: I99525286ed51692687be4179554db950807a5de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461108Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#815608}
-
Xida Chen authored
TBR=eirage.chromium.org NOTRY=true Bug: 1136687 Change-Id: I6390de8529b22ac35a33ac1c9c2942d5214dcb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462386 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
-
Kushagra Sinha authored
Bug: 1117478 Change-Id: I018277df50d1b786d5b72ab397e274d224ad4960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461115 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#815606}
-
Miyoung Shin authored
This CL is a part of moving mojom::FrameHost::UpdateState to blink, and moves //content/common/page_state.{cc, h, mojom}, /page_state_serialization.{cc,h} with relevant unit tests to blink. Bug: 1110246 Change-Id: Ifad68ae84931b45c48f0fa433c61d549737ec94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416208Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#815605}
-
Fredrik Söderqvist authored
We would previously produce the same angle for 180 -> 0 transitions as for 0 -> 180 (or similarly 90 -> -90 and -90 -> 90 respectively), which isn't correct. Tweak the condition in BisectingAngle() to adjust the in-angle when it is smaller than the out-angle to differentiate the two cases. Fixed: 1132525 Change-Id: I191e9e3d4889517f1188ec4a19e71beb8a966ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446729Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#815604}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/78768c9a86bf..58919b4db13b 2020-10-09 szuend@chromium.org [ts] Type-check network/RequestTimingView.js with TypeScript 2020-10-09 alexrudenko@chromium.org Enable TypeScript for AdvancedApp.js 2020-10-09 szuend@chromium.org [ts] Type-check network/HARWriter.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5791f52a761feeba3a344ca345d8e0d52876c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463251Reviewed-by:
-
Mikel Astiz authored
This advanced API maps to the the equivalent TrustedVaultClient::AddTrustedRecoveryMethod() and allows the identity page (Gaia) to register a public key that is known to be trusted. Among other purposes, this is designed to allow the user to resolve degraded sync recoverability states from a web page. Bug: 1081650 Change-Id: Iadb57e71dd1c57925fadba456ff2efabac94863b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449329 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#815602}
-
Milica Selakovic authored
autofill_assistant::RunningManager This CL deprecates AutofillAssistant's state in PasswordManager. Now, ChromePasswordManager is autofill_assistant::RunningManager's observer. Bug: 1133783 Change-Id: I9149af34fa0a5da2833b37f4d19331d16817e58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440871Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#815601}
-
Sebastien Lalancette authored
This change was made based on a suggestion from isherman in: https://chromium-review.googlesource.com/c/chromium/src/+/2456288 Change-Id: Icf2f01b2bdf8cf933b7646659f9afc385787e531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461088Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
Bug: 1089619 Change-Id: I2ce420088488eeee1f093a146e80d01a6873f522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434597Reviewed-by:
-
