- 03 Jul, 2018 40 commits
-
-
Javier Fernandez authored
We defined two LayoutBox elements list to identify grid items that need to perform a pre-layout: orthogonal and baseline items. We were creating these lists as part of the PlaceItemsOnGrid logic. This design has 2 main problems that lead to bug 855844, and likely many other: * The PlaceItemsOnGrid function is not executed completely if the grid is not dirty. * There might be items in the list that should not be there due to style changes; also, some should have been added for the same reason. The simplest and safest approach is to avoid such lists and identify the items needing pre-layout during the first steps of the grid's layout logic. Since style changes affecting either the writing-mode or the Self Alignment properties of a grid item will force a re-layout of the grid it belongs to, we can be sure that all the grid items will perform the pre-layout, if they needed to. Bug: 855844 Change-Id: I396524b0fc6a4816bcb7962997f129a325c04934 Reviewed-on: https://chromium-review.googlesource.com/1122623 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#572162}
-
Sylvain Defresne authored
This reverts commit 330fc4a1. Reason for revert: speculative revert to fix views_unittests (https://bugs.chromium.org/p/chromium/issues/detail?id=859829). Original change's description: > Make all MacViews windows potentially draggable. > > This fixes the PiP window not being draggable on Mac. > > Bug: 849983 > Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75 > Reviewed-on: https://chromium-review.googlesource.com/1121145 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572038} TBR=avi@chromium.org,sdy@chromium.org Change-Id: Ic1e718a03d272c2c1b4646ead018ad776d03fd18 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849983,859829 Reviewed-on: https://chromium-review.googlesource.com/1124299 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#572161}
-
jdoerrie authored
This change modifies base::win::Vector to use ComPtrs in the backing storage for types derived from IUnknown. Bug: 821766 Change-Id: Ib531a3e3c15e8cae1ec94de3f11b36d01b7a5acf Reviewed-on: https://chromium-review.googlesource.com/1120337 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#572160}
-
Dominik Röttsches authored
We tripped over this when adding Unicode 11 emoji. There is no need to introduce an additional obstacle for characters that the OS or our Emoji fallback code might already know about but our ICU might not have been updated yet. Bug: 850336 Change-Id: I0748ac5b755a2d8c3b92be9c9e21cf96ed75be16 Reviewed-on: https://chromium-review.googlesource.com/1122407 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572159}
-
Alexander Timin authored
Enable the feature by default and remove waterfall config. R=skyostil@chromium.org,rkaplow@chromium.org TBR=kenrb@chromium.org BUG=806271 Change-Id: I20627952407b2cb7926060b5d36d3ef5fa2db60e Reviewed-on: https://chromium-review.googlesource.com/1102505Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572158}
-
Kurt Horimoto authored
This CL creates ReadingListCoordinator, which uses UITableViews and replaces the old UICollectionView-based implementation. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I59acbe85cb389c69462bb72ddb7858acb1249c55 Reviewed-on: https://chromium-review.googlesource.com/1104941 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#572157}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37774c911e68..d7425b58df89 git log 37774c911e68..d7425b58df89 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-07-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a72f400c5ff3..92da844eb754 (1 commits) Created with: gclient setdep -r src/third_party/skia@d7425b58df89 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I02bdfffe800af4d31a8cad450a8478410422c299 Reviewed-on: https://chromium-review.googlesource.com/1123946Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572156}
-
Mihai Sardarescu authored
This CL adds a unit tests for the unified consent service. The current tests only covers the non-personalized services. It should be enhanced to also include the sync-related part once teh unified consent starts managing the sync state. This CL also makes the following changes: * replaces the dependencies of the service on profile_sync_service with a dependency on the more generic sync_service * enabled Url-keyed anonymized data collection when unified consent is enabled. Bug: 823809 Change-Id: I2ab27429272ecccfbd254ffc4100234ce95623df Reviewed-on: https://chromium-review.googlesource.com/1122858 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#572155}
-
Gyuyoung Kim authored
As StagingbufferPool and ResourcePool, SoftwareImageDecodeCache has been only supporting the MemoryCoordinator. However, it is not enabled by default. So it would be good if we support the memory pressure handler until the MemoryCoordinator is enabled by default. Especially, it will help low-end devices to reduce memory usage under the out-of-memory situation. Bug: 856527 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0aace1839b9d0e056f1a2db18f5d9e652c742c5f Reviewed-on: https://chromium-review.googlesource.com/1122016Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#572154}
-
Makoto Shimazu authored
Previously SWNavigationLoader::Cancel() didn't clear |binding_| and it didn't delete itself. This CL is to close the binding explicitly and fixes the leak. Bug: 859415 Change-Id: I99a79f2f0cc21802bdd36d507c4c8692955cc3d9 Reviewed-on: https://chromium-review.googlesource.com/1122065 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#572153}
-
Mihai Sardarescu authored
Sync model type TYPED_URLS can be enabled only if the user has encryption, while HISTORY_DELETE_DIRECTIVES cannot be enabled then. So in order to check whether the user is sending history to google in a readable way, HISTORY_DELETE_DIRECTIVES is the better one. This CL changes the URL-keyed anonymized data collection helper to use HISTORY_DELETE_DIRECTIVES. Bug: 823809 Change-Id: Ideb0a6129750f7e0e122e82a0c932aa6acd7bdc6 Reviewed-on: https://chromium-review.googlesource.com/1122118Reviewed-by:
-
Lei Zhang authored
Change-Id: I09581a1f8459e5dcfd15815780531acd339e8130 Reviewed-on: https://chromium-review.googlesource.com/1123891Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572151}
-
Wang Qing authored
This CL fixes the build error with the following message: ../../base/allocator/partition_allocator/partition_alloc_unittest.cc: In member function ‘virtual void base::internal::PartitionAllocTest_PurgeDiscardable_Test::TestBody()’: ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1905:42: error: ‘PartitionAllocGeneric’ was not declared in this scope char* ptr1 = reinterpret_cast<char*>(PartitionAllocGeneric( ^~~~~~~~~~~~~~~~~~~~~ ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1905:42: note: suggested alternative: ‘PartitionAllocatorGeneric’ char* ptr1 = reinterpret_cast<char*>(PartitionAllocGeneric( ^~~~~~~~~~~~~~~~~~~~~ PartitionAllocatorGeneric ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1909:5: error: ‘PartitionFreeGeneric’ was not declared in this scope PartitionFreeGeneric(generic_allocator.root(), ptr1); Bug= 859785 R= haraken@chromium.org Change-Id: I6e06534ba78fa7a3742ec3585502d60943374b1a Reviewed-on: https://chromium-review.googlesource.com/1123931Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#572150}
-
Zhuoyu Qian authored
Follow the spec[1], negative values are not allowed. We should reject the negative values of background-size during parsing. [1]: https://drafts.csswg.org/css-backgrounds/#background-size Bug: 825549 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ib260bafa421249aed471ff801c8b49a4b97aba1e Reviewed-on: https://chromium-review.googlesource.com/989529Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#572149}
-
Fergal Daly authored
The previous implementation gave the document the ability to forward a part from sub-component of a component but only the component author should be able to do that. Bug: 859446, 805271 Change-Id: I37dc9399646a2db677c350546cbb1cfad7ee2d39 Reviewed-on: https://chromium-review.googlesource.com/1122136Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#572148}
-
Gauthier Ambard authored
The -openerOfTab: method of the TabModel wasn't used. This CL removes it. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79d219e52798a47da582d373b0b8e277e263a11e Reviewed-on: https://chromium-review.googlesource.com/1122631Reviewed-by:
-
Paul Irish authored
Bug:851311 Change-Id: Ia13bc1f082b69f37ee8ca65ac467cea166c11a2b Reviewed-on: https://chromium-review.googlesource.com/1120951 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#572146}
-
Anders Hartvoll Ruud authored
R=eae@chromium.org Bug: 851490 Change-Id: I0090986f81763d3c84f1245d5340286f9a3a1dff Reviewed-on: https://chromium-review.googlesource.com/1121463Reviewed-by:
-
Christian Dullweber authored
Session Storage is currently not properly tested by BrowsingDataRemoverBrowserTest because it is not supported by the SiteDataCounter and the CookieTreeModel. This Cl adds an integration test for its web-visible behavior. Bug: 843995 Change-Id: I3eac6903995e4b4773bbcc08bc3f551001a4cdbb Reviewed-on: https://chromium-review.googlesource.com/1113306 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#572144}
-
Daniel Bratell authored
There are two g_previews_factory now which causes issues with some jumbo builds. This renames one of them g_previews_service_factory. Change-Id: I05d4ab366239888e80fb32f782ac4e4880a8609f Reviewed-on: https://chromium-review.googlesource.com/1122131Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#572143}
-
Olga Sharonova authored
Change them to set up switches::kUseFileForFakeAudioCapture in SetUpCommandLine(), so that it can be propagated to the audio process. Bug: 850936 Change-Id: Ia6cccc01d2b5fa7545abe8cb1554d72c33146566 Reviewed-on: https://chromium-review.googlesource.com/1122857Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#572142}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=derat@google.com Change-Id: I1b89bf3a0fbd96363f9f47dd86ee10ed1058c90a Reviewed-on: https://chromium-review.googlesource.com/1123930Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#572141}
-
Trent Apted authored
On ChromeOS, it started segfaulting when the ChromeOS bots switched to Ozone (see https://crbug.com/671355). Activation on ChromeOS is more similar to Windows than X11 anyway. But the test did other weird stuff. Fix it on Linux too by catering for asynchronous window activation. To address the history of flakiness on Desktop Linux, add judicious use of ui_test_utils::BringBrowserWindowToFront(..) to ensure the state of the window server process is in sync with the window state in the browser process. Bug: 788232,62538 Change-Id: Ibceb4fbaf5b72a4f4b6b03e58b3dc1e936aff830 Reviewed-on: https://chromium-review.googlesource.com/1117972 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#572140}
-
Yoichi Osato authored
This patch fixes document marker painting on writing-mode:vertical-lr. We paint document markers at 2 phases: background and foreground. At the background phase, we paint find-in-page highlight or so on. This is done before graphics context rotation following writing-mode. At the foreground phase, we paint spellcheck markers. This is done after the rotation. Since the background phase painting needs only physical rect of target range on the text fragment. It has worked. However foreground painting needs a rotated rect because it is after the rotation. This patch fixes the foreground painting by adding MarkerRectForForeground function that returns layout rect. Bug: 850448 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If6e401028536cc5412be420f6600b978677af98a Reviewed-on: https://chromium-review.googlesource.com/1109663 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572139}
-
Kurt Horimoto authored
Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1e536359e9a0ebad3a13382afd04969d4cfa6244 Reviewed-on: https://chromium-review.googlesource.com/1110756 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
As StagingbufferPool, ResourcePool has been only supporting the MemoryCoordinator. However, it is not enabled by default. So it would be good if we support the memory pressure handler until the MemoryCoordinator is enabled by default. Especially, it will help low-end devices to reduce memory usage under the out-of-memory situation. Bug: 856527 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I070e71c3d39da61b56f2b11d51bf5efdf1ac3c7c Reviewed-on: https://chromium-review.googlesource.com/1121949Reviewed-by:
-
Luciano Pacheco authored
This is flaky often on WebKit Linux Trusty Leak. Tbr: alph@chromium.org No-presubmit: true No-try: true Bug: 859640 Change-Id: I1534c2933889153738e853614b4cdd5068015502 Reviewed-on: https://chromium-review.googlesource.com/1124002Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572136}
-
James Darpinian authored
Automatically grow the transfer buffer when it is full and shrink it when the full capacity is not being used. Allow choosing larger and smaller sizes than before. Before we would only grow it when a single transfer request was larger than the whole buffer; requests smaller than the whole buffer would just block if the buffer was full. Also we would not ever shrink the buffer until someone called Free() manually. Bug: 850271, 835353, 828363, 856347 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If2f2235a1d5297c63663398b37e1e30791347a3e Reviewed-on: https://chromium-review.googlesource.com/1105505 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572135}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff8c49dd..7ce703ef Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7add395549b1ec50a5706eb554c34099babbbc56 Reviewed-on: https://chromium-review.googlesource.com/1123893Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572134}
-
Ramin Halavati authored
A unittest is added for content settings EphemeralProvider. Bug: 850062 Change-Id: If4e488291b8242accb10998e884b33258b6d3b0e Reviewed-on: https://chromium-review.googlesource.com/1114842 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Bug: 859445 Change-Id: I28c1176c89efd35ba959a0a710f51d759e155cfa Reviewed-on: https://chromium-review.googlesource.com/1123972 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572132}
-
Dominic Battre authored
If a user focuses a field for which password generation is promoted, a popup is shown. http://crrev.com/288935 introduced that this popup remains visible until the user has typed 5 characters, hypothesizing that users look at their keyboard while typing and therefore not notice the popup. Our new hypothesis is that this a) may not be true, and b) may bother users because the popup occludes part of the website, in particular it can occlude password requirements for users who chose to invent their own password. This CL introduces a Finch experiement such that we can test whether keeping the popup visible until the user has typed >5 characters produces a statistically significant higher number of generated passwords. If not, we can just hide the password generation popup as soon as the user has typed a key. The default configuration sticks to the 5 character threshold. Bug: 859472 Change-Id: I1d2a82ce90f696dc32d97633ac29ba15f3ea9bbd Reviewed-on: https://chromium-review.googlesource.com/1122399 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572131}
-
Bill Orr authored
The page encodes a frame id into the clear color, clears the texture, then submits it. The test then reads the frame id, and validates that the pose used was the expected pose used. The test found an issue where frames would be submitted after getting the next frame's pose, causing extra latency and worse reprojection. This is fixed as part of the change so the test passes. BUG: 854309, 850165, 801034 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0f891e9929d4a0427c74ae137ed2a9c31d7744cd Reviewed-on: https://chromium-review.googlesource.com/1123228 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572130}
-
Gauthier Ambard authored
This CL changes the background color of the infobars to be more aligned with the UI Refresh look. Bug: 817753 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I06db3d63b619fc63bf381d936f4c59cab4afaa28 Reviewed-on: https://chromium-review.googlesource.com/1122860Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#572129}
-
Jinsuk Kim authored
Fixes bugs reported after landing: - Android CFI test failures https://crbug.com/854611 WebContentsViewAndroid::SetFocus should have null checks as well, and should not have run in the tests that use TestRenderViewHost. The tests failed due to invalid cast (TestRenderWidgetHostView -> RenderWidgetHostViewAndroid), which was caught by CFI config. And even in real situation ::SetFocus should run only when the RenderWidgetHostViewAndroid is not null. These two issues are addressed by calling the method when current RWHVA is non-null. - Amazon app not getting key input https://crbug.com/854499 WebContentsViewAndroid::RenderViewSwappedIn and WebContentsObserver::RenderViewHostchanged were not always called together. This caused the WebView not to get the updated after the change. This CL deletes RenderViewSwappedIn and defines RenderFrameSwappedIn, and invokes it from WebContentsImpl::NotifyFrameSwapped to ensure native view tree update + focus change occurs in response to the main render frame host swapping. Bug: 598880, 854611, 854499 This reverts commit efb24e49. Change-Id: Ieaa3d43029583a17560dc83b5009416e71e89f13 Reviewed-on: https://chromium-review.googlesource.com/1112950 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#572128}
-
Luciano Pacheco authored
These 3 tests have been failing a lot, passing only 60% of time according to findit-for-me. Tbr: xiyuan@chromium.org Bug: 859715 Change-Id: I45f89d626cccad4d1aac55184e7aac11fc862bc9 Reviewed-on: https://chromium-review.googlesource.com/1124001Reviewed-by:
-
Kyle Milka authored
Add a new EmbeddedSearch API for allowing users to select a local file for the NTP background image. After a file is selected copy it to the Profile directory. Set the background url preference to the new endpoint, chrome-search://local-ntp/background.jpg, which serves the file. Bug: 839152 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I90e9768f468748f7c072d36c71c2a9a859cba490 Reviewed-on: https://chromium-review.googlesource.com/1101639 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#572126}
-
Darren Shen authored
In 1119610, there were some comments that were addressed, but the updated patch was not uploaded by mistake. This patch just addresses those comments. TBR=yhanada@chromium.org, jamescook@chromium.org Bug: 849980 Change-Id: Ida53707785789fda4b8ee687198932dd266477fb Reviewed-on: https://chromium-review.googlesource.com/1124074 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#572125}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I8dfa0e2421a7c9142bc0a0381be714acfe2faab0 Reviewed-on: https://chromium-review.googlesource.com/1124101Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572124}
-
Oscar Johansson authored
When building using jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variable kDefaultNumConnections in: net/third_party/quic/core/congestion_control/cubic_bytes.cc net/third_party/quic/core/congestion_control/tcp_cubic_sender_bytes.cc This commit solves the issue by moving the variable definition to net/third_party/quic/core/quic_constants.h. Bug: 772146 Change-Id: Ib7c961511823a8ecbc996775485a5fe23649e65e Reviewed-on: https://chromium-review.googlesource.com/1120169Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#572123}
-
