- 20 Jan, 2021 40 commits
-
-
Adam Norberg authored
external_constants.cc now uses ExternalConstantsOverrider to load overrides rather than DevOverridesProvider. Tests have been updated to use ExternalConstantsBuilder or write the override file directly, whichever is more appropriate. Bug: 1154901 Change-Id: I35383e25058c1799f99583128b5e695cbf90ac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634264Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Adam Norberg <norberg@google.com> Cr-Commit-Position: refs/heads/master@{#845352}
-
Wojciech Dzierżanowski authored
Bug: 1140960 Change-Id: Ib33835d9da6777599ef0ab1515a8cf6465e8cdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640393Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#845351}
-
Eugene But authored
Bug: None Change-Id: I7ffc7064b2a84e47d466512ef5eab7cfd873cbd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638098Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845350}
-
Boris Sazonov authored
Adds AccountManagerFacade::Observer interface along with {Add/Remove}Observer methods, corresponding implementation in AccountManagerFacadeImpl and some tests. Bug: 1117472 Change-Id: Ia84f37703af56b8f22683d9a97cfc2dddb5579ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560122 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#845349}
-
Eugene But authored
Bug: None Change-Id: I29a3862af76bb103713374ca2b06d8172eca1d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633852 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#845348}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611153816-7597e0f48ca66fa59a87e60988316d59a3bbff86.profdata to chrome-win64-master-1611165592-b5253c098e9c7fa5265e7248ae4df5f8c48efe50.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib7d9cfc6368daecad4a6217eccfeccc8475de9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845347}
-
manukh authored
Closing the omnibox popup can change the selected suggestion. This occurs in 3 cases: 1) Search what you type suggestions that look like URLs. E.g. after selecting the search-what-you-typed suggestion 'x.com' and closing the popup, the omnibox will navigate to 'x.com' instead of searching the default search engine for 'x.com' 2) Title autocompletions for inputs that look like searches. E.g., for the suggestion 'jupiter - wi[kipedia]', after closing the popup, the omnibox will display 'jupiter - wikipedia (wikipedia.org/wiki/Jupiter)' but will search for 'jupiter - wikipedia' instead of navigating to 'wikipedia.org/wiki/Jupiter'. 3) Title autocompletions for inputs that look like a different URL than their URLs. E.g., for a bookmark titled 'x.com' with URL 'y.com', after closing the popup, the omnibox will display 'x.com (y.com)' but actually navigate to 'x.com' instead of 'y.com'. The first case isn't problematic, because closing the popup updates the omnibox favicon, and there's no additional text. Cases 2 and 3 are problematic because the additional text from before closing the omnibox no longer represents where the omnibox will actually navigate to after closing the omnibox. This CL addresses this by clearing the additional text when closing the popup. Perhaps the preferred long-term solution would be to prevent the selected suggestion from changing when closing the popup. But for the time being, this CL at least updates the view to correspond to the updated suggestion. Bug: 1062446 Change-Id: If5c4ef25abbd73d54540eeb8cb5b85b4db307107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628011Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#845346}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d79f95e908d..a3c06205b28b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8974ac0963cf26b478f74572c01167ad89af86fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640995Reviewed-by:
-
alanlxl authored
To make sure ServiceConnection is bound to UI sequence task_runner. Bug: chromium:916760 Test: pass the unit_test Change-Id: Ia03094fca3dcaa86774520f681b522f77508d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631805Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#845344}
-
Andrew Grieve authored
module_build_configs were not being added as inputs nor to depfile. Bug: 1168655 Change-Id: I7576f168f219a2e45625988ecfc20ca9c0e6d2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640897 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#845343}
-
Sunny Sachanandani authored
https://crrev.com/c/2626100 added RG_16EXT as a viz::ResourceFormat, and accidentally marked it as a supported GpuMemoryBuffer format too. This causes crashes on ChromeOS when playing VP9.2 HDR video. Bug: 1116101, b/177910735 Change-Id: Iaed4ffefa42bcca4b6bd1885d7e090d9f2782b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639578 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845342}
-
Amr Aboelkher authored
This CL is adding test coverage for Hash dance request status i.e. AutoEnrollmentRequestStatus, and Hash dance network error i.e. AutoEnrollmentRequestNetworkErrorCode UMA histograms. BUG=chromium:1167383 Change-Id: Ib35c0bd99ff0457007df500d4e6d7b273fffd2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639762 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#845341}
-
Dominick Ng authored
Bug: None Change-Id: I3032cf6514dbe29d44092b871e12b2a022dc67c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639417Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845340}
-
Lei Shi authored
Previously, at the end of a nodeGroup, we use the trimmed text of the nodeGroup to update currentCharIndex_. This approach causes issues when the user resumes from selection that ended in space. Bug: 1167435 Change-Id: Ifa74c459100f6fd444f6200b09eec1fe2f2b4042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638917Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Lei Shi <leileilei@google.com> Cr-Commit-Position: refs/heads/master@{#845339}
-
Eugene But authored
Bug: None Change-Id: I7a65f31b28c977a92c8d96759d29f35bc364a237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634268 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Bailey Berro authored
This change wires up the TelemetryLog to the SystemDataProvider so that updates are pushed to the log whenever new information is fetched. This change also adds the SessionLogController to DiagnosticsManager so that it is instantiated whenever the app is opened. Bug: 1128204 Change-Id: I7974bbece2e40da9fe5cef1d6db1a32720276033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632871Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#845337}
-
Rune Lillesveen authored
The counter counts the usage of matching non-UA rules with ::target-text. Bug: 1168273, 1136817 Change-Id: I784680927b62dbd592eb1d05bef5e6edb76805d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640255Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#845336}
-
Brandon Jones authored
Changes Dawn validation layer tests to run sequentially, rather than in parallel jobs. This may address flaky failures being seen on Intel GPUs when running with D3D12's GPU-based validation. Bug: dawn:598 Change-Id: Ie53656f63bd2550d66f55f3f43f9c0baa19e1c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629610Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Brandon Jones <brandon1.jones@intel.com> Cr-Commit-Position: refs/heads/master@{#845335}
-
Hongchan Choi authored
The access to |shared_buffer_| in AudioBufferSourceHandler needs to be controlled by |process_lock_|. This CL adds one into PropagateSilence() method. Bug: 1167472 Test: ToT crashes with the repro case, but it doesn't with this patch. Change-Id: I52f95d52889c9b809507c88a16c61f0e85b36f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638097 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845334}
-
Ramya Nagarajan authored
Bug: 1098078, 1004336 Change-Id: Ic237293ceaa635723b6dda215d9b0bb16d1e20f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637453Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845333}
-
Gavin Williams authored
Remove customSort() as scan settings only uses alphabetical sort or numeric sort. Bug: 1168346 Change-Id: I7f0151de3945ebdb752f467a4dff0f4c48b2576b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638793 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#845332}
-
Ahmed Mehfooz authored
This CL adds protection to ensure a notification can not be added after ash has been destroyed Bug: 1164631 Change-Id: I497a142b1f05990a855ce837408adf3660247e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639161Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845331}
-
Tommy Li authored
Extensions that use the Override Settings API to create new search engines matching prepopulated engines currently erreneously duplicate the Sync GUID of the prepopulated engines. That violates an invariant of TemplateURLService - that each engine have a unique Sync GUID. It also caused CHECK crashes, when it seemed like we were trying to remove an engine that matched the GUID of the DSE, yet it didn't match the pointer value of the DSE. This CL also relaxes the CHECK, because now we have to be tolerant of users with a strange database state of multiple engines having the same Sync GUID. It seems like this bug has been around for years without causing harm though, so it's probably mostly harmless except for our CHECK. Bug: 1166372 Change-Id: I4c0e0729a3b3f27f29615b782532b20dcd4dc996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636683 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#845330}
-
Ryan Hansberry authored
Change-Id: I895a4e96676e8084ae9f15533e8430eb5fdd092c Fixed: 1160903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612033 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#845329}
-
Rahul Singh authored
This CL obsoletes the following histograms and their corresponding enums 1. Apps.ShortcutsMenu.Registration.Win.Result 2. Apps.ShortcutsMenu.Unregistration.Win.Result These histograms were used to gauge feature health for Shortcuts Menu on Windows which launched in M85. The feature has remained healthy into M87. So, we can safely obsolete these histograms and remove the corresponding instrumentation code from Chromium. Bug: 1125647,1125648 Change-Id: Ic0fa250aa431562a453ab783f47f10bc129a8444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632148Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
-
Xing Liu authored
Uses Android's accessibility API to announce checked state when tapping on an item when the selection mode is enabled. Bug: 1166721 Change-Id: Ifeb2a9ffa80b9a6eecfe1d639a47f4338972aff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639155Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845327}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6dcbcead3da4..812c73cdc25a 2021-01-20 ivoc@webrtc.org Another ilbc cross correlation fix 2021-01-20 mbonadei@webrtc.org Prefix HAVE_SCTP macro with WEBRTC_. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1161837 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I96186c2ca73d4cf80e917f5fe101f1c478ab89dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639650Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2900a0f4cb82..ea71c6b63417 2021-01-20 syoussefi@chromium.org Vulkan: Emulate R32F images with R32UI 2021-01-20 jmadill@chromium.org Capture/Replay: Don't serialize compile resources string. 2021-01-20 mpichlinski@opera.com Make metal_shader_cache_file_hooking a data_deps 2021-01-20 syoussefi@chromium.org Vulkan: Simplify RewriteCubeMapSamplersAs2DArray 2021-01-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dd50a3bce3ca to 3180f85f9bcd (11 revisions) 2021-01-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8da0f82baf35 to 22be66d40712 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I22625941d836b96174485b7c30ef360353f3dca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640704Reviewed-by:
-
Bailey Berro authored
Mocks: go/cros-diagnostics-ux Bug: 1125150 Change-Id: I93994701c98d5a558c36c166b049bc92c445b55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638597 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Katie Dektar authored
This will let us do things similar to DCHECK for test by logging any bad state in the extension and causing a test failure. It also serves to remind developers to remove verbose logging. AX-Relnotes: N/A Bug: 1167335 Change-Id: Ib6da571243c0684115527ef87b8189796dba7e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634082 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845323}
-
Sebastien Lalancette authored
The work around that was built doesn't meet the quality and stability requirements. Bug: 1139208 Change-Id: I7d1f7bcc9eb9c2f3b6c3cdabc50cbe5eadc92421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639400 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845322}
-
Ravjit Singh Uppal authored
The OneTimeGeolocationPermissionProvider tries to unregister itself from an already shutdown context, causing the crash. Update the observer unregistration pattern in the OneTimeGeolocationPermissionProvider to handle the case of the context being already shutdown. Bug: 1168488 Change-Id: Id92b9a3b15410b3732d9021a666282ad1f568036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640096 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845321}
-
Mike Jackson authored
No product code changes, just updating comments, and removing TODOs. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ Bug: 897302 Change-Id: Id8f1a8e9bfbb3435f3b653d6b9a587279b401fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637265Reviewed-by:
-
Stepan Khapugin authored
Since the button has a descriptive text now, there's no need for this background label which was previously providing context for voicover users. Bug: 1164917, 1138892 Change-Id: Ia3fcd9a43dd9814559e0909f4c3849014b518c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637706 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#845319}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611142151-b9d265a27dc1ef032fcc18909cf95e9a04349e8f.profdata to chrome-mac-master-1611165592-ce7a0617ff859a9176e865c0be149d7728639a62.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I67b874f43c44c4d1f7277d9befeb6c8d19129aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639216Reviewed-by:
-
Lily Chen authored
This fixes a bug where a base::Feature ref was implicitly converted to reference_wrapper incorrectly, such that the feature override worked on debug builds but not on release builds. This explicitly converts it via std::cref, which fixes the behavior for release builds. Bug: 986319 Change-Id: Ic2511f71d83b2c25e4a5cbf2bc8a3f205fec464e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640921Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#845317}
-
Joe Mason authored
This feature was never enabled and is not well tested. * Remove json_splicer which was only used to modify installed extension lists in JSON files. * Remove force_installed_extension which tracks detected extensions that could be removed. * Remove extension_util functions that remove extensions. * Remove uwe_matcher.proto which defines extensions to be removed, and GetUwEMatchersResourceID that returns the id of the proto file. * Remote uwe_scanner_wrapper and uwe_engine_cleaner_wrapper which inject extension cleaning steps into the scanner and cleaner. * Remove force_installed_extension_scanner that implements detection of extensions that could be removed. * Remove the disable extension methods from ChromePrompt, which notify the user of extensions to remove (these have never been enabled). * Remove WriteRegistryValue which was only used to modify installed extension lists in the registry. * Clean up some unused includes and dependencies. R=drubery Bug: 981388 Change-Id: I87173308d1af939154abac254946638d4a0a0ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638001Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#845316}
-
Li Lin authored
This CL includes adding: - Feature flag for gating Projector feature. - ProjectorController: the main controller - ProjectorUiController: the controller responsible for interacting with the UI. - ProjectorMetadataController: the controller responsible for recording and saving the screencast metadata. - ProjectorMetadata: model of the projector metadata. Follow up CLs will add more implementations and unit tests. More detail about Projector at: go/projector-prd Bug: 1164029 Test: unit tests Change-Id: I808a044c444a999ecfdbcf1615949cdd4df182b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627441 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845315}
-
Peter E Conn authored
Change-Id: I6ba0d84b62120e380c6a8fa5b4ce7cf27e472cd0 Bug: 1166691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640376 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#845314}
-
Christos Froussios authored
[Sheriff] Disable external/wpt/focus/iframe-activeelement-after-focusing-out-iframes.html on Win and Mac It is flaky. Bug: 1168522 Change-Id: Idcc7293410a65f3f41d172b31d486789b0004bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640333 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#845313}
-
