- 26 Jun, 2020 40 commits
-
-
Mirko Bonadei authored
This reverts commit 3a2a481f. Reason for revert: This doesn't work because gtest_enable_absl_printers is declare_arg'd in googletest so in WebRTC we get an error even if we use declare_default in the .gn file. Original change's description: > Add gtest absl deps to the absl component. > > This CL conditionally adds absl/debugging deps to the absl component > if build_with_chromium=false. This will allow downstream projects to > use gtest with absl (for pretty printers and matchers) but it will > remove these dependencies in Chromium to avoid to add static > initializers. > > When static initializers will be removed, the dependency will not be > conditional so Chromium will also be able to set > 'gtest_enable_absl_printers=true'. > > Bug: 1046390 > Change-Id: Ifffea81ba8f7a9412bebc3798e8f79eaff2777d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262972 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782889} TBR=thakis@chromium.org,mbonadei@chromium.org,danilchap@chromium.org Change-Id: I808c4b928c98733965276fd49093bfe35b4d9f74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270082Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#782921}
-
Benjamin Smith authored
R=tmrts@chromium.org, ulan@chromium.org Open Conversation is a critical user journey for Gmail. Open first conversation in inbox. Bug: 1044682 Change-Id: Ia03c9b5799823a203e63ee1357f025b874945e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246867 Commit-Queue: Benjamin Smith <codesmith@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782920}
-
Jia authored
Following a hard-to-reproduce bug report (crbug.com/1098059), this cl adds logging to monitor if some curve data is invalid. Bug: 881215 Change-Id: I9b2b099c052ff601a747b4e6241d6cb31b5b3c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269598 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#782919}
-
Tim van der Lippe authored
shell=True is a security hazard per the Python documentation: https://docs.python.org/2/library/subprocess.html#frequently-used-arguments This has 2 effects that required changes in scripts: 1. The shell removes extraneous quotes from arguments, which we now should no longer include in any argument passed in 2. The shell now requires an array of arguments, rather than a string Next to that, removal of shell=True is required if we later want to call the script as part of a GN action. R=tapted@chromium.org,dpapad@chromium.org Bug: 1096473 Change-Id: I77e85048e5a6db33035ca774434857170aeaf91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264365Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#782918}
-
David Roger authored
This reverts commit 60d33a56. Reason for revert: unittests are flaky. See https://crbug.com/1099629 Original change's description: > Add shutting down process to the Storage and StorageQueue. > > Making that will guarantee, that queue is destructed on the appropriate > queue only and in order with other asynchronous operations (after them > all). When the device is shutting down, it won't allow any new asyn > operations to start. > This should resolve crbug/1098359. > > Bug: 1098359 > Change-Id: I12fd860778bc8dd7efb1f51f6d878c2cd1dd3256 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268382 > Reviewed-by: Zach Trudo <zatrudo@google.com> > Commit-Queue: Leonid Baraz <lbaraz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782828} TBR=zatrudo@google.com,lbaraz@chromium.org Change-Id: I63eeb790e5bbd164ed4e7b4884ef5ffe7ba457c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098359, 1099629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270143Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#782917}
-
Marc Treib authored
The whole folder components/sync/notifier was part of the old invalidations system and can go away: InvalidationPreferences and InvalidationIntentProtocol were trivially unused. InvalidationClientNameProvider/Generator and its implementations were not fully unused: A global provider instance was set up with a generator, but it was never actually used. Bug: 1029481 Change-Id: I490620d1a75e1fa66993788e9b1f1ff79d7fe3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266957 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#782916}
-
Victor Hugo Vianna Silva authored
The CL fixes a typo in a CSS selector used in crrev.com/c/2254281, which caused a bad alignment of the Undo button. The CL also merges the selector with #undoLabel, which is actually a leftover that has been around since M78 (crrev.com/c/1729469). Bug: 1099236 Change-Id: I8315fafd4e4c20be66324d9cc013872066e9f362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266877Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#782915}
-
Sami Kyostila authored
Implement Perfetto's platform abstraction layer using Chrome's TLS and task runner primitives. Bug: b/158460267 Change-Id: I2b2653c550db4c6bb8c8e8e325af7693d1bb496b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248559 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#782914}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c81da1c809fe..3330d56fbe19 2020-06-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 0f4d5f74f199 to ff825d988fe8 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I2c65dcd816b7c021ca5f096f254abc7dfa5cb4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782913}
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: Id5e95549368323ce77fd3d0ff8957e92445b3b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266255 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782912}
-
Pâris Meuleman authored
Change-Id: I34bf1a3c07c0f3379a50a68bdd7a07c0032dc37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251999 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782911}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d15f969132d7..46f8ecc40de9 2020-06-26 sigurds@chromium.org Fix stylelint-config-standard issues in elements/computedStyleWidgetTree.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibee786cb29c5c256021f1987c73ab041e586337e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270419Reviewed-by:
-
Yutaka Hirano authored
Bug: 1091665 Change-Id: I5487cf88e0b5d60c3a421cce521428adc0822938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269403 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782909}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7be9918fef15..837b9c5748eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC droger@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: droger@google.com Change-Id: I952e9866356eb26d3fffb5dcaa6b82eb76d1e1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270100Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782908}
-
Kenichi Ishibashi authored
This CL removes old ServiceWorkerResponseReader and starts using new mojofied ServiceWorkerResourceReader in prod code. Bug: 1055677 Change-Id: I2fb4daf37242535716a0e38c9a89a69de960f37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256110Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Maksim Sisov authored
Verifying local use_x11 && use_ozone build and sending for review the fixups. TBR=sky@chromium.org Bug: 1085700 Change-Id: Idca3d217224339fcf53dfdc4c65fb33c2ecb84b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266672Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#782906}
-
Mathias Bynens authored
This test is now captured as an e2e test in the DevTools repository: https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/test/e2e/console/console-message-format_test.ts;l=11-21;drc=869374bcab6fa261360d6cd62fd135898274204d Bug: chromium:1099603 Change-Id: I1e109c0e6d87d38b621acafca41f7e49cc2abe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270058 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#782905}
-
Yoshifumi Inoue authored
This patch changes "hit-test-on-text-with-line-height.html" to test all platforms by using |internals.settings.setEditingBehavior()|. This patch also adjusts hit points for platform 'mac'. Bug: 707656 Change-Id: I840cdc7db8de3f5ca695e045fa1fbd862b752056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269605 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782904}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593129542-2eaae9cac4b4a7ab29032c694ec87a1eba9074ff.profdata to chrome-win64-master-1593151085-cd414c91e242db50072f832cc2413fee8d11ae76.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6194113c51fb3b54a4383dcf8d4ddc5e05d04e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270106Reviewed-by:
-
Takashi Toyoshima authored
The test depends on 100 msec timeouts to load and reload the plugin iframe, and this is the root of flakiness. Bug: 1090400 Change-Id: I03800d347d864a4032c784b0888509d563640cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266253 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#782902}
-
Eric Seckler authored
Base code should include base_tracing.h instead of trace_event impl headers, so that base can build with enable_base_tracing = false. Previously, a presubmit check emitted a warning if a trace_event implementation header was included outside trace_event implementation directories. This modifies the warning into an error, which can be bypassed via a source code comment. TBR: rsesek@chromium.org Bug: 1093406 Change-Id: Ic82f399390ededd12c04ad6005de8f68929bae87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264555Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#782901}
-
Hitoshi Yoshida authored
For performance, we'd like to define simple methods in class definitions, but it is difficult for some methods because they need forward-declared classes' definitions. This CL moves definitions of such methods from .h to .cc. Bug: 839389 Change-Id: I8ef040191e6a5c0f30961b43667af200494cb995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255729 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#782900}
-
Jihwan Marc Kim authored
The TokenPreloadScanner::StartTagScanner class has its own LoadingAttrValue enum, and member of this type. However, we've introduced a more general LoadingAttributeValue enum, along with a helper method to convert strings to members of this enum. The StartTagScanner class should use these more general primitives, as opposed to providing its own. This is good so that the preload scanner infrastructure does not accidentally become out-of-sync with other code that uses the more general LoadingAttributeValue class. Bug: 1099123 Change-Id: I7a07e17baa722881b10bd55ae28d10976bfae50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267518Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#782899}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Idda4aadcf1aee4b7c75cc0ea90444edb4ae6ff97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270101Reviewed-by:
-
Joel Hockey authored
Remove the dedicated Crostini/GuestOs code for fetching icons. This code was written before AppService existed to manage icons. When icons are not found for crostini, return the default penguin, but for Plugin VM, return an empty icon so that AppService will use its defaults. Bug: b/158617133 Bug: b/159050715 Change-Id: I0ea16e6b795f8e8cdace315f6c9b500781bd0b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269619Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#782897}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/82270c608217..d15f969132d7 2020-06-26 vidorteg@microsoft.com Service Worker should not be translatable 2020-06-26 wolfi@chromium.org Styling for 'deactivate breakpoints'-button If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1041830 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I46dfb44327dc46b605249e09c97fd1d42a1ec88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270102Reviewed-by:
-
David Roger authored
This reverts commit ce6e5f49. Reason for revert: the test is now flaky. See details in https://crbug.com/1099615 Original change's description: > [WebAppProvider] Fix test flakiness for AppSorting. > > The test waits for both installations, but this can be flaky as waiting > for the first installation could hide the second installation. So when > it waits for the second installation, it already happened. > > This fix only waits for the second installation to prevent this race > from happening. > > R=loyso@chromium.org > > Change-Id: I57549f0d1be11e980ecebc6ba7fb8d2ec4e0b7be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268180 > Auto-Submit: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Chase Phillips <cmp@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782775} TBR=cmp@chromium.org,dmurph@chromium.org,loyso@chromium.org Change-Id: I69984efe4b14b967eeccc4a59f617725bd648339 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270178Reviewed-by:
-
Joel Hockey authored
This changes on the approach taken in crrev.com/c/2251571 where we stopped notifying app service of changes to be consistent with the fact that we were not registering pvm apps to start with. Now we register all pvm apps, but we set them not to show in launcher, shelf, etc. This will allow us to use AppService to manage icons. Bug: b/158617133 Bug: b/159050715 Change-Id: I5813a3249af20f81229c6829d9c81e56628bdecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268897Reviewed-by:
-
Wojciech Dzierżanowski authored
This workaround is no longer needed now that there is no WebMediaPlayerAndroid. Bug: 1091203 Change-Id: I50aeea360d7b81f65c803c70ca8dc96b413d5e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263159Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#782893}
-
Christian Dullweber authored
File 'Location' and geo 'Location' need different translations in German. Add 'meaning' attribute to the app 'Location' permission to translate it correctly. Bug: 1098432 Change-Id: Ie7927409fdbe03b4d92f0a1584c0d3b0e93a50e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264370Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#782892}
-
Jeremy Leconte authored
Bug: None Change-Id: I14f5e823e956e49eb72955497afa4fbdd04fa9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270057Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782891}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e144aa33faa..b19cfeeb5c66 2020-06-26 jleconte@google.com Roll chromium_revision 4d95e6c7..71a0e190 (776481:782339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I706ee1037e284536cce1a017b273ea10dcf078fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270099Reviewed-by:
-
Mirko Bonadei authored
This CL conditionally adds absl/debugging deps to the absl component if build_with_chromium=false. This will allow downstream projects to use gtest with absl (for pretty printers and matchers) but it will remove these dependencies in Chromium to avoid to add static initializers. When static initializers will be removed, the dependency will not be conditional so Chromium will also be able to set 'gtest_enable_absl_printers=true'. Bug: 1046390 Change-Id: Ifffea81ba8f7a9412bebc3798e8f79eaff2777d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262972 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782889}
-
Mike Dougherty authored
Use proper compile guard to check for building with Xcode 12. Bug: None Change-Id: I782c101380565ca87b82bf574492422a57d70b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269763 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#782888}
-
Takashi Sakamoto authored
Use the first 16bytes region of the allocated memory for tag. So both data region, and PartitionCookie region will be moved by +16bytes. This behavior is disabled behind ENABLE_CHECKED_PTR. Change-Id: I09a0241f61ca1b186b239097601ea498f6d9f00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263417 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
Koji Ishii authored
This patch renames a few functions for the consistency: - IsVisibleToHitTest - FragmentVisibleToHitTestRequest - VisibleToHitTestRequest The last one is a sipmle shorthand that doesn't help to save much. Removed to clarify which fragment it tests. This patch has no behavior changes, in preparation to adjust the hit-test conditions for <crbug.com/1007900>. Bug: 1007900 Change-Id: If2718ffb862253aebbff582a153d819b98424192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269818 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Kent Tamura authored
Bug: 1040826, 1061823 Change-Id: I987fb8b9a55cb6ef3e99047f92ed04ec789c259e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269620 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6069b8345ecb..89b8527eceaf 2020-06-26 thestig@chromium.org Remove Mac-specific includes from fx_system.h. 2020-06-26 thestig@chromium.org Remove unused header from fx_system.h. 2020-06-25 thestig@chromium.org Clean up star drawing code. 2020-06-25 tsepez@chromium.org Dismiss exceptions while setting properties/elements from JS handlers. 2020-06-25 vmiklos@collabora.co.uk Add FPDF_GetSignatureCount() API 2020-06-25 thestig@chromium.org Do one assignment per line in CXFA_Rectangle. 2020-06-25 thestig@chromium.org Fix some nits in string tests. 2020-06-25 thestig@chromium.org Test invalid arguments for some FPDFLink_* APIs. 2020-06-25 thestig@chromium.org Remove PRIuS define from fx_system.h. 2020-06-25 thestig@chromium.org Get rid of _FX_PLATFORM_APPLE_. 2020-06-25 thestig@chromium.org Get rid of _FX_PLATFORM_WINDOWS_. 2020-06-25 thestig@chromium.org Split tiling pattern rendering code into its own file. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098213 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I73703255550202f21093b55c1b8e91875791dd78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269838 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b047a2d37d8..82270c608217 2020-06-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2ab50cb522eb8774c1a8df065aa264aee99b18e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269735Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593129542-eae571d99fb364561b81bf0410208d0db84ed4e4.profdata to chrome-mac-master-1593151085-57fe35f0746eacbd2632836a414f4d24425341a7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2a3e107a81e3db5a918c9a1fd0dc478e5975fbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269736Reviewed-by:
-
