GitLab

BUG=738628

Review-Url: https://codereview.chromium.org/2963393002
Cr-Commit-Position: refs/heads/master@{#486483}

This CL adds xcode_test_application_name to create_bundle target so 
that the relationship between xcode unit or ui test target and test 
application target can be specified in BUILD files instead of being 
identified by parsing target names in GN.

Bug: 741147, 709289
Change-Id: Idf0cb700b300d80d49803dae33eb90c87c0e41a0
Reviewed-on: https://chromium-review.googlesource.com/566587
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486482}

There are five different classes in
third_party/WebKit/Source/platform/exported named ExtraDataContainer.
They are only used as local internal classes so they don't normally
collide in the compiler, but they do so in jumbo builds.

This patch renames them so that the names are more unique.

Bug: 742337
Change-Id: Iad42e0d29f600fabd6ea9081687a7107d3043282
Reviewed-on: https://chromium-review.googlesource.com/570052Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: bratell at Opera <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#486481}

Changes:
1. Change SearchBoxView and SearchResultPageView's corner radius and
layout in state AppListModel::STATE_SEARCH_RESULTS.
2. Remove separators between SearchResultView.
3. Add separators in SearchResultPageView to separate
SearchResultContainerView.

specs: https://screenshot.googleplex.com/409fBM7pTO2
screenshot: https://screenshot.googleplex.com/zYZqsT9ndum
    
BUG=740732

Change-Id: Iffeb6d726970dacfe0745acd7d809d482e801b19
Reviewed-on: https://chromium-review.googlesource.com/566024
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486480}

Commit 5fb31977 added this new target but
didn't depend on the //sandbox:sandbox_features target so it failed to
compile:

In file included from ../../sandbox/linux/seccomp-bpf-helpers/seccomp_starter_android.cc:5:                                                                       
../../sandbox/linux/seccomp-bpf-helpers/seccomp_starter_android.h:10:10: fatal error: 'sandbox/sandbox_features.h' file not found                                 
#include "sandbox/sandbox_features.h"                                                                                                                             

NOTRY=true

Bug: 742028
Bug: 730066
Bug: 739879
Change-Id: Ib0bc9f34f0cbf35be0f9f3cf412cd0fdcf678f3f
Reviewed-on: https://chromium-review.googlesource.com/570514
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486479}

Bug: 579255
Change-Id: I30c8e76c6fa35c77bfe731d6bd7e89bb7d8f8c08
Reviewed-on: https://chromium-review.googlesource.com/570513Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486478}

Change-Id: Ice02da6a6906b27bee7ece5e8567c559dbbe0673
Reviewed-on: https://chromium-review.googlesource.com/568911Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486477}

"getInitialSettings" should always be the first message from
the print preview Javascript, so only call AllowJavascript()
in PrintPreviewHandler::HandleGetInitialSettings().

Bug: None
Change-Id: I764e72c10a39c82cf85f75b38867def5fae41c99
Reviewed-on: https://chromium-review.googlesource.com/569301
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486476}

Bug: 742355
Change-Id: I6b94d7358bd77d6d5d80d2eb608653aecd759cff
Reviewed-on: https://chromium-review.googlesource.com/570628
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486475}

Bug: 721802
Change-Id: I12cc789f4052be4b02e175ad6cb9c0c763c3de6b
Reviewed-on: https://chromium-review.googlesource.com/567043
Commit-Queue: Anna Maria <paezagon@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486474}

When crrev.com/2850863002 added a call to InitChromeLogging() it had to
pull in //chrome/common:common, and that necessarily pulls in several MB
of code that is not wanted. The tendrils of dependencies are many and
varied and since a sword was disallowed there was no practical way to
cut this Gordian knot. See the investigation in bug 717103 for details.

So, InitChromeLogging() was copied, named as InitChromeWatcherLogging(),
and made to work. This gets the size-cost of the logging code down to
~25 KB.

A non_code_constants target was added to //chrome/common because the
existing constants target was actually the main cause of excess code
being pulled in.

While testing this change it was discovered that the command-line
logging flags were not passed to the chrome_watcher process, so that
logging was not actually being enabled. This was also fixed.

It may be possible to delete more of the copied code, depending on what
logging features are actually needed. Thoughts?

Bug: 717103, 715060
Change-Id: I536b0813fff32e513dfd3e0bbb8fc3cb715546c1
Reviewed-on: https://chromium-review.googlesource.com/567030Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486473}

Previously media/mojo/sevices:lib was done as a source_set due to issue
670094. Now that that issue is fixed, the intermediate "lib" target is
no longer needed.

Removing the suppression of duplicate symbols revealed that some of the
CdmPromiseTemplate methods end up in multiple modules when doing a
component build. So fix CdmPromiseTemplate<>::GetResolveParameterType()
implementation to avoid this.

This also enables //media/mojo/services/media_service_unittests on
Windows (which was disabled due to linking issues that are now fixed).

BUG=676418,676055,656706
TEST=media_mojo tests compile and run

Review-Url: https://codereview.chromium.org/2737513004
Cr-Commit-Position: refs/heads/master@{#486472}

All with one shard and 15-16min hard timeout. Will increase pool size
by a few bots when this lands.

This includes:
viz_unittests
base_unittests
cc_unittests
gfx_unittests
device_unittests
blink_heap_unittests
gpu_unittests
media_unittests
browser_side_navigation_components_browsertests
components_browsertests
chrome_public_test_vr_apk
chrome_sync_shell_test_apk

Bug: 670879
Change-Id: Ibdb0e9f2307b2d5fbd897d2df52ac3c11565a0d6
Reviewed-on: https://chromium-review.googlesource.com/568223Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486471}

Incorrect:
patch: http://screen/QGKMPviZDDf outcome: http://screen/ep69c4GW4uS

NOTRY=true

Bug: 543161,742463
Change-Id: I0134f1fd992a49f3411be8ea6f4df72d1f4f9e3d
Reviewed-on: https://chromium-review.googlesource.com/570843
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486470}

The |root_location| of the synthetic touch event isn't set which breaks
event dispatch. Since Ozone X11 is used for testing off device, and
proper touch screen associations don't exist, just set |root_location|
on the event.

Also only parse the --touch-devices flag once with Ozone X11, it's not
necessary to do it multiple times.

Testing with the following command works for both displays:

./chrome --ash-host-window-bounds=900x900,900+0-900x900 \
  --ash-touch-hud --touch-devices=X

Bug: 741824
Change-Id: I0377db53eb07a4b1e1412dffbda4cc7325a55118
Reviewed-on: https://chromium-review.googlesource.com/570382
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486469}

This CL adds accessible content ensuring that errors (e.g., "Email
address required") will be read when navigating to the respective
profile.

Bug: 733684
Change-Id: I595736de370645656964ddd85fc7d7edb02142b9
Reviewed-on: https://chromium-review.googlesource.com/568242Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486468}

Change-Id: I2d85d3dc803f9b13ed8da842b9dd0f119e1c03c2
Reviewed-on: https://chromium-review.googlesource.com/569518Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486467}

Extends the use of EasyResizeWindowTargeter to transient children of
top level windows that currently use EasyResizeWindowTargeter - as long
as those children can themselves be resized.

Bug: 741013
Test: added ToplevelWindowEventHandlerTest.EasyResizerUsed
Change-Id: I5e9db48e80210a0ee108dcbd8f02dd33b1c62d78
Reviewed-on: https://chromium-review.googlesource.com/567266
Commit-Queue: Valery Arkhangorodsky <varkha@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486466}

BUG=

Change-Id: I5d52053de8dba8af8682d907d56e69ad7e545f8d
Reviewed-on: https://chromium-review.googlesource.com/570738Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486465}

- Dynamic Code Disable >= Win8.1.
  - Thread opt-out >= Win10 RS1.
  - Prevents the process from generating dynamic code or modifying executable code. Second option to allow thread-specific opt-out.
    - VirtualAlloc with PAGE_EXECUTE_*
    - VirtualProtect with PAGE_EXECUTE_*
    - MapViewOfFile with FILE_MAP_EXECUTE | FILE_MAP_WRITE
    - SetProcessValidCallTargets for CFG

- MS Code Signing enforcement >= Win10 TH2.
  - Prevents the process from loading binaries NOT signed by MS.

- Image load prefer system32 >= Win10 RS1.
  - Forces image load preference to prioritize the Windows install System32
 folder before dll load dir, application dir and any user dirs set.
  - Affects IAT resolution standard search path only, NOT direct LoadLibrary or executable search path.

TEST= sbox_integration_tests.exe, ProcessMitigationsTest.*
BUG=733739
R=forshaw@chromium.org
TBR=grt@chromium.org

Change-Id: I4347a9002368961e17f3f83ba39d50c469065bdc
Reviewed-on: https://chromium-review.googlesource.com/566286
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486464}

UITextView defaults to listen to user interaction and editable. This
is not appropriate for sad tab content which should be readonly.

Bug: 738426
Change-Id: I36e131ac37218970c0ee58d7df0b2f0913e93361
Reviewed-on: https://chromium-review.googlesource.com/570384Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486463}

BUG=b:38505617
TEST=
  ash_unittests on ShelfLayoutManagerTest.AutohideShelfForAutohideWhenActiveWindow
  ash unittests on AppListPresenterDelegateTest.ShelfBackgroundRespondsToAppListBeingShown

Review-Url: https://codereview.chromium.org/2967543003
Cr-Commit-Position: refs/heads/master@{#486462}

This CL deletes surface_reference.mojom, along with its typemap
and StructTraits. SurfaceReferences are an implementation detail of
surfaces.

TBR=tsepez@chromium.org

Bug: 722935
Change-Id: I42236cce804efe574ebcf6abd68dbd1e4ed78e0f
Reviewed-on: https://chromium-review.googlesource.com/569978
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486461}

On iOS 11 WKWebView loads much slower if it is not a part of the view
hierarchy. This is more-likely a system issue, however it is important
to have a workaround until Apple fixes the bug.

BUG: 739390, 703222, 734669
Change-Id: I09d5c3ffadee44d3a5a6d834d4b5f0839b20f50b
Reviewed-on: https://chromium-review.googlesource.com/566183Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486460}

This reverts commit fdef07af.

Reason for revert: Breaks browser_tests on the chromium.webrtc bots on Linux, Win7, and Mac. Gathering of ICE candidates fails with this error log:
[7466:7466:0713/070330.078566:INFO:CONSOLE(13)] "Returning Test failed: Error: Received invalid ICE candidate list from peer: []
    at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15)
    at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11)
    at <anonymous>:1:51 to test.", source: http://127.0.0.1:52364/webrtc/test_functions.js (13)
../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc:412: Failure
      Expected: "ok-received-candidates"
To be equal to: ExecuteJavascript( base::StringPrintf("receiveIceCandidates('%s')", ice_candidates.c_str()), to_tab)
      Which is: "Test failed: Error: Received invalid ICE candidate list from peer: []\n    at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15)\n    at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11)\n    at <anonymous>:1:51"
With diff:
@@ -1,1 +1,4 @@
-ok-received-candidates
+Test failed: Error: Received invalid ICE candidate list from peer: []
+    at failTest (http://127.0.0.1:52364/webrtc/test_functions.js:46:15)
+    at receiveIceCandidates (http://127.0.0.1:52364/webrtc/peerconnection.js:371:11)
+    at <anonymous>:1:51

Link to bots:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester

Original change's description:
> [scheduler] Reenable timer throttling for background renderers.
> 
> Use renderer scheduler policy to throttle background timer queues
> when the renderer is backgrounded.
> 
> R=​alexclarke@chromium.org
> 
> Change-Id: Iff6f4b80883f1030b14e9f67345a7df9dd018a63
> Reviewed-on: https://chromium-review.googlesource.com/567932
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485947}

TBR=alexclarke@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

NOTRY=TRUE

Change-Id: Iaf76027f0bc8894f8a8812c0843b27d26192a44a
Reviewed-on: https://chromium-review.googlesource.com/570404
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Magnus Jedvert <magjed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486459}

Interactions media queries were returning wrong values on laptops with
touch screens which are neither convertible, neither detachable.
The reason is that GetSystemMetrics(SM_CONVERTIBLESLATEMODE) returns
always 0 on these machines which is buggy as they are not in a
slate/tablet mode.

One solution would be to check the presence of ConvertibleSlateMode
key in the registry (that key is used to know when the
laptop is flipped or detached) but it doesn't seem to be consistent
across hardware (my desktop PC doesn't have that key but the hardware
listed in the bug below has it).

The last possible alternative is to query the hardware about screen
rotation. If the screen rotation is supported then it's most likely
a tablet/detachable/convertible, if not then it's a desktop PC, a
non touch laptop or a classic touch laptop. If the screen rotation
is not supported, if the laptop doesn't have a screen rotation sensor
or if the laptop is in laptop mode then it's not a tablet.

BUG=739430, 442418

Change-Id: I1aad26d7d833a425981bf0d46a7dae9878f19cd1
Reviewed-on: https://chromium-review.googlesource.com/566567Reviewed-by: Ananta Iyengar <ananta@chromium.org>
Reviewed-by: Carlos Pizano <cpu@chromium.org>
Commit-Queue: Alexis Menard <alexis.menard@intel.com>
Cr-Commit-Position: refs/heads/master@{#486458}

TBR=yszshen@chromium.org
NOTRY=true

Change-Id: Ia01b7d9027419eb2c055bf2eaaba9fa87834e35b
Reviewed-on: https://chromium-review.googlesource.com/570839Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486457}

This reverts commit 9d704fa8.

Reason for revert: FYI Buildbot ClangToTLinuxASan fails. We want to find out if this CL caused the failure.

Original change's description:
> [Zucchini] Introduce buffer_source and buffer_sink.
> 
> Cursors with convenient read and write methods to ease manipulation of
> raw data.
> 
> Bug: 729154
> Change-Id: I8a7303964b02b9df7ef033de8756b09716a91eae
> Reviewed-on: https://chromium-review.googlesource.com/560657
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486238}

TBR=huangs@chromium.org,erikchen@chromium.org,etiennep@chromium.org

Change-Id: I15d90734a0e8b4791d51ee0b8bc04a4ce4116a45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 729154
Reviewed-on: https://chromium-review.googlesource.com/570502Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486456}

This reverts commit f3a69e04.

Reason for revert: ios-device and ios-device-xcode-clang broken

Original change's description:
> Add optimized arm implementations to base/numerics
> 
> BUG=672489
> 
> Change-Id: I7bb13d0ae3850f3334978bd8d483550ea2f3e3fd
> Reviewed-on: https://chromium-review.googlesource.com/567436
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486438}

TBR=jschuh@chromium.org,eae@chromium.org

Change-Id: I2555ad7458b1379675e2c9fd4385d4bdaef0212c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 672489
Reviewed-on: https://chromium-review.googlesource.com/570898Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486455}

This reverts commit 66dbfe27.

Reason for revert: ios-device and ios-device-xcode-clang broken

Original change's description:
> Fix ios builders after refs/heads/master@{#486438}
> 
> TBR=eae@chromium.org
> NOPRESUBMIT=true
> NOTRY=true
> NO_DEPENDENCY_CHECKS=true
> 
> Change-Id: I61a733adb8570b6246da5b3d0dd34780c81d4dce
> Reviewed-on: https://chromium-review.googlesource.com/570838
> Reviewed-by: Justin Schuh <jschuh@chromium.org>
> Commit-Queue: Justin Schuh <jschuh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486452}

TBR=jschuh@chromium.org,eae@chromium.org

Change-Id: I8b3d22b84096b92d7800cb42ae230d1a6307fcf0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/570878Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486454}

This CL replaces use of i18n-content/values with $i18n{} in the internal
appcache page. This page was and is only partially localized.

TBR=michaeln@chromium.org

Bug: 677338
Change-Id: I3113d51ab80381291807f298e3885d9128464144
Reviewed-on: https://chromium-review.googlesource.com/569314
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486453}

TBR=eae@chromium.org
NOPRESUBMIT=true
NOTRY=true
NO_DEPENDENCY_CHECKS=true

Change-Id: I61a733adb8570b6246da5b3d0dd34780c81d4dce
Reviewed-on: https://chromium-review.googlesource.com/570838Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486452}

Stability, usability improvements for Fuchsia test runner.
* Fix test flakiness that seemed to be related to qemu sharing the
  stdin stream with Python. The OS would then tear down the scripts
  prematurely causing Python to panic.
  Specifying a subprocess PIPE for stdin fixes that.
* Disable the QEMU interactive monitor. It was overriding the user's
  terminal settings and blocking important keypresses like ^C, making
  it difficult to terminate tests early.

R: wez@chromium.org,thakis@chromium.org
BUG: 741194,740201
Change-Id: Ibda6ac59d44b07c1b75902a7dc13db086841baa0
Reviewed-on: https://chromium-review.googlesource.com/568739
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486451}

iOS previously did not consult the embedder for its list of secure
schemes, meaning that chrome:// urls were not treated as secure. This
change enables the Web Client to declare a list of application-specific
secure schemes, and adds the chrome:// scheme to that list.

Bug: 739480
Change-Id: Ia794aef6d9b34229755f9c7aad0cbc93158a659e
Reviewed-on: https://chromium-review.googlesource.com/568624
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486450}

This is a reland of 2096391c
Original change's description:
> Reimplement base::WaitableEvent with a kqueue on Mac.
> 
> For a single WaitableEvent, a custom EVFILT_USER kevent is used to wait and
> signal. This replaces the default POSIX implementation that uses a
> pthread_cond_t and a boolean flag.
> 
> To implement WaitMany, a new kqueue is created to wait on all the individual
> WaitableEvent's kqueue descriptor. This replaces a complex locking algorithm
> used in the default POSIX implementation.
> 
> For the asynchronous WaitableEventWatcher, a TYPE_READ dispatch_source_t is
> used to watch the WaitableEvent's kqueue. This replaces the POSIX
> implementation of a reference-counted list of async watchers guarded by a lock.
> 
> Microbenchmarks show that the kqueue implementation is significantly faster in
> most cases. The one potential drawback is hitting the low RLIMIT_NOFILE on
> macOS, since each WaitableEvent and WaitableEventWatcher requires a new
> descriptor.
> 
> Bug: 681167
> Change-Id: I135012fdd25e547ffb911fc7adc97c203df38241
> Reviewed-on: https://chromium-review.googlesource.com/553497
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485788}

Bug: 681167
Change-Id: I1b0296022f7bd1a31b074fbbb551bccc3b28d05b
Reviewed-on: https://chromium-review.googlesource.com/568642Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486449}

This CL adds extra_attributes property to create_bundle target so that
these values can be specified in BUILD files instead of hard coded in
GN.

Bug: 740800, 709289
Change-Id: I1c0393e11405527bda5cf70fb8b653fc76454b97
Reviewed-on: https://chromium-review.googlesource.com/566390
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486448}

TBR: scheib@chromium.org

Change-Id: I51eb3a98ad2d8c2d4b1417f8396220b9f46070c9
Reviewed-on: https://chromium-review.googlesource.com/570185Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486447}

TBR=zmo@chromium.org
NOTRY=true

BUG=668223

Change-Id: Ib4e0e2993c285b7edfa9e443d63fdefdcd28986d
Reviewed-on: https://chromium-review.googlesource.com/570668Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486446}

Using MessageLoop across the death test fork does not work well on Mac. The
threadsafe death test style solves this issue.

Bug: 741256
Bug: 681167
Change-Id: I301981a704c284d4264642d4a553d3cc2570e0fa
Reviewed-on: https://chromium-review.googlesource.com/568800Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486445}

Bug: 740141
Change-Id: I2f82a5e8af3d79aeb0f7fd82a4c2a43ccccbcb49
Reviewed-on: https://chromium-review.googlesource.com/568842Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486444}