- 25 Apr, 2018 40 commits
-
-
Mohamed Heikal authored
Currently if an Async Trace event was processed by early tracing it is given the category (EarlyJava) and if the finish of that same event happened after native has loaded and regular tracing has started then it is given a different category (Java). This CL fixes this bug by keeping track of all async events started during early tracing and making sure the finish event is also sent from early tracing. Bug: 822816 Change-Id: Idaec00c243b9b77195b91e8409e99076be158853 Reviewed-on: https://chromium-review.googlesource.com/1024911 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553714}
-
Artur Khachatryan authored
Test ChromeLoggingCapabilityTest.testPerformanceLogger is not flaky anymore on Android build. Enabling test execution on Waterfall for Android builds. Bug: chromedriver:2108 Change-Id: Iee167f37a195385ab5e65fb20261256cd28801fe Reviewed-on: https://chromium-review.googlesource.com/1028618Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553713}
-
Eric Lawrence authored
The ChromeOS debugging instructions include a HTTP link that should be using HTTPS instead. TBR=jcivelli@chromium.org Change-Id: I678027a32b9de592c4d37849c546de265e3e7d48 Reviewed-on: https://chromium-review.googlesource.com/1028659Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#553712}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=msw@chromium.org Bug: 825327 Change-Id: I508ddefd5a91415253e907811a17b7d11c818a12 Reviewed-on: https://chromium-review.googlesource.com/1024712Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#553711}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=kinuko@chromium.org Bug: 825327 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie66f2b93d069fae255bd65750a27e2aeef819ffd Reviewed-on: https://chromium-review.googlesource.com/1024652Reviewed-by:
-
Michael Spang authored
Bug: 714018 Test: CQ & run chrome on eve Change-Id: I7f6bb7a0165d99fb1890cdaa4e893f1fbb28ff51 Reviewed-on: https://chromium-review.googlesource.com/1026417 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#553709}
-
Ned Nguyen authored
TBR=perezju@chromium.org NOTRY=true Bug: 836447 Change-Id: I8058c3f219831333b7539e5d015d825cf53620e8 Reviewed-on: https://chromium-review.googlesource.com/1028715Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#553708}
-
Jonathan Backer authored
This refactor CL allows useful GPU service flags like --enable-gpu-service-logging (log all GL commands processed) and --enable-gpu-debugging (check for GL error after every command) to be used when running unittests (e.g. cc_unittests) that use InProcessCommandBuffer. There are no security implications of this change because - only tests use the codepath updated here (Viz and android webview do not) - flags are whitelist passed to child processes (renderer/GPU processes) ParseGpuPreferences could not easily be added as a member of GpuPreferences because of dependencies. - ParseGpuPreferences depends on gpu/command_buffer/service:gles2 to check if passthrough decoder is enabled. - gpu/command_buffer/service:gles2 has a dependency on gpu/command_buffer/service:service - GpuPreferences lives in gpu/command_buffer/service:service - Moving GpuPreferences to gpu/command_buffer/service:gles2 seems non-trivial. I did not want to introduce a new component just for GpuPreferences. ParseGpuPreferences did not seem to belong to gpu_preferences_util.h because that is IPC specific. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I76db4fe0eebd3eb7720fa24265f69093715c6137 Reviewed-on: https://chromium-review.googlesource.com/1019662Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#553707}
-
Jonathan Backer authored
This implements SetColorSpaceMetadata for Raster{Implementation,Decoder}. Mostly copy paste from GLES2{Implementation,Decoder}. Other changes: - parameterize raster_in_process_context_tests.cc to test both RasterDecoder and GLES2Decoder - added a new RasterInProcessCommandBufferTest.SetColorSpaceMetadata to cover the new RasterDecoder codepath and the prior GLES2Decoder path Bug: 789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I437955dfc0821866e251aa15efa2adbfbb9ad8ed Reviewed-on: https://chromium-review.googlesource.com/1024607Reviewed-by:kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#553706}
-
Elly Fong-Jones authored
Bug: None Change-Id: I4b88978f8088cc65be94955c0e037fbb580e08ae Reviewed-on: https://chromium-review.googlesource.com/1028455Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#553705}
-
Emily Hanley authored
Android Nexus 7v2 Perf Android Nexus6 Perf Win 8 Perf Win 7 ATI GPU Perf Win 7 x64 Perf Bug: 836798 Change-Id: I072b4ed9b0cc49ac6179cb49dcab067bb2dc2f79 Reviewed-on: https://chromium-review.googlesource.com/1027995Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#553704}
-
rodmartin authored
Writer for Priority List. Write a base::Value() in a string with PLIST format. The decisions were all as pretty print format and kept only the types that we need for policies. The implemented types are Boolean, string, integer, list and dictionary. Bug: Change-Id: If43041a2e5dd2e97014a266f35b176019fffb2ff Reviewed-on: https://chromium-review.googlesource.com/986912 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#553703}
-
David Black authored
This CL stubs in an AssistantBubble/AssistantContainerView as part of a series of CLs to move the AssistantBubbleView out of the app_list. With this CL: - Bubble will be shown on interaction start. - Bubble will be auto-dismissed after interaction finish (w/ delay). See bug for demo. Bug: b:77637813 Change-Id: I69c146f386405e33d3a0a503f9bf87072d704abe Reviewed-on: https://chromium-review.googlesource.com/1024804 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#553702}
-
Jiaquan He authored
Bug: 733662 Change-Id: I3db2d80a9a8edab1609b12deac96f320a9630273 Reviewed-on: https://chromium-review.googlesource.com/1026848Reviewed-by:
-
Yuly Novikov authored
Bug: 835867, 575305 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I03bd2083fc5df341ce0d4717d0c5af3abe822763 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1028224Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553700}
-
Gabriel Charette authored
Replacing it with modern RunLoop+QuitClosure usage. R=caseq@chromium.org Bug: 825327 Change-Id: I43e021d3a3c5e76923e77c8d28560931dc3ee866 Reviewed-on: https://chromium-review.googlesource.com/1024445Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553699}
-
Mohamed Heikal authored
mDelayedInitialTabBehaviorDuringUiInit is a private runnable that is never set. It looks like it is added here (https://codereview.chromium.org/2912473003). Change-Id: Ic612e95340616ab905d594a25471daea62e6fac1 Reviewed-on: https://chromium-review.googlesource.com/1026422Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#553698}
-
Michael Moss authored
This brings things back in sync after a failed branching. TBR=govind@google.com NOTRY=true Bug: 825063 Change-Id: Id141a41135fab3b5b4736746d5b790659a254bf5 Reviewed-on: https://chromium-review.googlesource.com/1028665 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#553697}
-
John Budorick authored
This reverts commit f09f52a1. Reason for revert: yet another friendly lesson on the dangers of notry. Original change's description: > Add mac_window_server_killers to browser_tests data on Mac. > > TBR=ellyjones@chromium.org,liaoyuke@chromium.org > > Bug: 828031 > Change-Id: Ie98ee83cee2d4c98c29a2ac1290728da5b87c4a7 > No-Try: True > Reviewed-on: https://chromium-review.googlesource.com/1028482 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553626} TBR=ellyjones@chromium.org,liaoyuke@chromium.org,jbudorick@chromium.org Change-Id: Ida00d9ae602b301008a0bdaab46255c2361c6107 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828031 Reviewed-on: https://chromium-review.googlesource.com/1028491Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#553696}
-
Andrey Kosyakov authored
This adds Network.takeResponseBodyForInterceptionAsStream, which returns a stream handle that can be used with IO.read/IO.close. Note this is only supported with the Network Service currently, the legacy URLRequestJob based interception support will be added later. Bug: 831887 Change-Id: Ibc5a43e86824f0c86397f200b5a6852171705f0e Reviewed-on: https://chromium-review.googlesource.com/1026692Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#553695}
-
Xiyuan Xia authored
Bug: 836187 Change-Id: Id072e00ca0d6e4f278a43f34deea6880d2aa0536 Reviewed-on: https://chromium-review.googlesource.com/1026039Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553694}
-
Xiaohan Wang authored
This class can be useful for any classes to implement/support multiple versins of library CDM interface. Hence, move it out of clear_key_cdm folder. In a later CL, I'll use them for a mock library CDM implementation. Bug: 836046 Test: No functionality change. Change-Id: I7567e405de0251ddce3718eb76d102f07ff8f33e Reviewed-on: https://chromium-review.googlesource.com/1026970Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553693}
-
https://pdfium.googlesource.com/pdfium.git/+log/ac19439e28b6..d9da586dd3db $ git log ac19439e2..d9da586dd --date=short --no-merges --format='%ad %ae %s' 2018-04-25 npm Roll third_party/freetype/src/ 26ad1acbc..2157d8fa6 (21 commits) Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I22f771416c8dde47fd823191cb2b196499d9dfdd Reviewed-on: https://chromium-review.googlesource.com/1028475 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553692}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icd4046545efb94a6a54de3a5452ac085fee311fa Reviewed-on: https://chromium-review.googlesource.com/1028657Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#553691}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: I791e51cafbfc1a03f64f1edc58699e65307ce3b5 Reviewed-on: https://chromium-review.googlesource.com/1025068Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#553690}
-
dpapad authored
- Move some styles from shared_style_css.html to paper_button_style_css.html. - Update paper-button styles per latest spec. - Collapse previously different types of buttons "primary" and "action" into a single button type. Note this change is intentionally changing the shared styling for buttons. If a certain WebUI page needs a different pre-MD refresh style, should be updated individually to override (hopefully there are no such cases though). Bug: 832173 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If083bf3ad1d60623300bb9e584ae9179e815ef7d Reviewed-on: https://chromium-review.googlesource.com/1028478Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#553689}
-
Alexei Filippov authored
BUG=832313,820250 Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf Reviewed-on: https://chromium-review.googlesource.com/1011350 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Conley Owens authored
This change removes the Physical Web privacy preference. BUG=826540 Change-Id: I5bd06d3df7cb6e03051921a3c6d8d02b2c82b329 Reviewed-on: https://chromium-review.googlesource.com/1024756Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#553687}
-
Adam Langley authored
Change-Id: I41aa3d4be8cbd16c9ed78cd888b0341dedc8727a Reviewed-on: https://chromium-review.googlesource.com/1028353Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#553686}
-
Jinho Bang authored
When openWindow() is not triggered by user activation, currently throws InvalidAccessError. But it's already deprecated in spec level. Instead we should throw NotAllowedError. Related spec change: https://github.com/w3c/payment-handler/pull/291 Bug: 833532 Change-Id: Icc21301abcafa0ecd00d6232d73a273ca6e4dd9b Reviewed-on: https://chromium-review.googlesource.com/1013659 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#553685}
-
Dan Harrington authored
This will help us understand how many articles show up with a thumbnail in downloads home. Bug: 794828 Change-Id: I4576620f877147e0d897e29af11186150ddcf816 Reviewed-on: https://chromium-review.googlesource.com/1024639Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#553684}
-
Daniel Cheng authored
This reverts commit 8839d302. Reason for revert: causing WebUI renderer kills Original change's description: > Enforce user gesture requirement on browser side for WebUI. > > WebContentsImpl now tracks the last time it received an input event that > could be considered user interaction. When the browser process receives > a WebUI message that requires a user gesture, it checks the WebContents > hosting the WebUI to make sure that the user recently interacted with > it. > > This also cleans up a few incidental bits of code: > - RenderWidgetHost no longer prefilters events before notifying the > delegate. This exposed some broken event filtering, tracked at > https://crbug.com/827659. > - Since the delegate method no longer prefilters input events, > RenderWidgetHostDelegate::OnUserInteraction() is now named > RenderWidgetHostDelegate::DidReceiveInputEvent(). > - The IPC message used to pass WebUI messages from the renderer to the > browser sends the source URL. However, this requires trusting the > untrustworthy renderer to not lie about the URL. Instead, just use > GetLastCommittedURL(). > > Bug: 823864 > Change-Id: I687776c8c7f7f93f78c968dd432b1674d65629c0 > Reviewed-on: https://chromium-review.googlesource.com/1023174 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553001} TBR=dcheng@chromium.org,thestig@chromium.org,isherman@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 823864 Change-Id: I7e6266f5e0d87197a76f2f201faef13bce129734 Reviewed-on: https://chromium-review.googlesource.com/1028335 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Albert Chaulk authored
If we recieve a request for an extension that doesn't have a 'cast_url' key present defer to the normal extension request processor to load the files from disk This is also required to load background pages (as it is from disk) Bug: b/73768170 Test: Load extension that loads from disk, verify fallback occurs Change-Id: I7bf477f92dbebfd37077ed417e12d17a03d35308 Reviewed-on: https://chromium-review.googlesource.com/934924Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#553682}
-
Emircan Uysaler authored
When kVTVideoEncoderSpecification_RequireHardwareAcceleratedVideoEncoder is set, VideoToolbox doesn't create encoder sessions below 640x384 resolution. From the spec, this indicates that it is falling to SW implementation. Since we want to actually test HW backed cases, we should input a higher resolution video for Mac. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel Change-Id: Ie10cd533473ffca501f80772fffe27644004e123 Reviewed-on: https://chromium-review.googlesource.com/1019733 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553681}
-
Mounir Lamouri authored
This is an opportunistic fix for a crash that we were not able to reproduce locally. Bug: 833360 Change-Id: If376405dd75591bcbbb47273e2330027de8ebd0d Reviewed-on: https://chromium-review.googlesource.com/1028359Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#553680}
-
Sammie Quon authored
Test: ash_unittests SplitViewControllerTest.ShadowDisappearsWhenSnapped Bug: 818295 Change-Id: Icb1ed1d1c03e00cd74cf9d60986d6853b3160ea5 Reviewed-on: https://chromium-review.googlesource.com/988935 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#553679}
-
David Bokan authored
When a layout object is the effective root scroller, the OverflowClipRect uses the ViewRect rather than computing the padding box as usual. This is because the padding box won't expand when the URL bar is hidden. Unfortunately in the root scroller case we forget to set the passed in location. This patch adds that so the rect is in the correct coordinate space. Additionally, this all works only if the box set as the effective root scroller has no border since the OverflowClipRect uses the padding box. I've updated the root scroller to ensure the padding box matches the viewport rect. Ideally we'd just return View()->OverflowClipRect - which does remember to set the location - in LayoutBox but this could lead to an infinite recursion as that calls LayoutBox::OverflowClipRect if the ViewRect is empty. Thus, we call ViewRect directly. Bug: 816161 Change-Id: I2f622ff0c25e58373955e1d0e22d54e254e134ff Reviewed-on: https://chromium-review.googlesource.com/1026517Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553678}
-
Mina Almasry authored
Bug: b/74612005 Test: On device unittests Change-Id: I628a3ad8563fb1fb35ea783f73f24a62e497091a Reviewed-on: https://chromium-review.googlesource.com/1028560Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#553677}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9990de59..96706998 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If2540c38879b3438082a7569b931945f7d00bb75 Reviewed-on: https://chromium-review.googlesource.com/1027803Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#553676}
-
Henrik Boström authored
The internal class owns AdapterRefs which have to be destructed on the main thread. As such, the last reference to the internal class had to be freed on the main thread. In flaky cases, when tasks were posted to the signaling thread, an operation performed and a task posted back to the main thread - the main thread would finish before the signaling thread task and the last reference to the internal class would be released on the signaling thread, causing DCHECK crashes at ~AdapterRef for being on the wrong thread. With destructor traits, if we are not already on the main thread we post to the main thread and delete RTCRtpReceiverInternal there. The TearDown of RTCRtpReceiverTest is updated to ensure that any pending tasks get a chance to execute, in case the signaling thread was not finished yet or else the destructor posted to the main thread does not get a chance to execute and the test would flakily leak. Before this CL: Flake's symptoms could be reproduced by adding a thread sleep at RTCRtpReceiverInternal::GetStatsOnSignalingThread. After this CL: Unable to repro flake. Bug: 827450 Change-Id: Icdfdd3e22c3e86308ee7911e67eff43590fde581 Reviewed-on: https://chromium-review.googlesource.com/1013492 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#553675}
-
