- 07 Dec, 2018 40 commits
-
-
Samuel Huang authored
This reverts commit 1ec12653. Reason for revert: Likely to cause consistent failures in single_process_mash_interactive_ui_tests for linux-chromeos-dbg due to assertion failure from missing icon "cr:insert-drive-file". Bug: 912678 Original change's description: > Downloads: detect failed file icons and show default thumbnail > > On the downloads page, we consult the system for a themed image for the > type of file downloads. Ex: zip files -> archive icon. > > When a system doesn't know why type of icon to show for a specific file > type, it can either return a default or nothing. Right now, Linux > returns nothing, so we show nothing. chrome://fileicon tries to warn > us by giving a network error (which has been ignored until now). > > So, when a chrome://fileicon fails to load, show a default filetype > icon in respond. > > Before & after screenshots: https://imgur.com/a/txRbfIG > > R=dpapad@chromium.org > BUG=855259 > > Change-Id: I370fd8ea119b194ad8e1ba7e0dfad32c6cea1bbe > Reviewed-on: https://chromium-review.googlesource.com/c/1132560 > Commit-Queue: Dan Beam <dbeam@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614581} TBR=dbeam@chromium.org,dpapad@chromium.org Change-Id: I4ef27f132954754a80e3b3def4aadf5774b3875d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855259 Reviewed-on: https://chromium-review.googlesource.com/c/1367933Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#614713}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/158df43c2d19..7a3805c348c3 git log 158df43c2d19..7a3805c348c3 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 scroggo@google.com SkWuffsCodec: Do not swizzle frame of width 0 2018-12-07 brianosman@google.com Half float vertex colors (when necessary) in small path renderer 2018-12-07 reed@google.com remove unused drawText entry-points in LiteDL 2018-12-07 brianosman@google.com Use GrVertexWriter and support half-float colors in rrect ops 2018-12-07 kjlubick@google.com [canvaskit] Add createPattern support to canvasAPI 2018-12-07 reed@google.com guard paint's breaktext -- trying to remove it 2018-12-07 reed@google.com remove dead methods leftover from drawPosText etc. Created with: gclient setdep -r src/third_party/skia@7a3805c348c3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I9152253fd275c8fd61dfdba2ddcc699c3cd7435f Reviewed-on: https://chromium-review.googlesource.com/c/1367865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614712}
-
Tommy Martino authored
This CL adds a new option to the Autofill dropdown footer. This consists of: * Changes to components/autofill to include the row as a suggestion under the appropriate conditions. * Changes to the native popup views to display properly if only footer rows are present. (This was not possible before the introduction of the new row type.) * Updates to the autofill_popup_layout_model to return a Google "G" logo as one of the possible icons. * Moves a Google "G" logo vector icon to be available on platforms other than Mac. Bug: 912303 Change-Id: Idc03d7eccc1d9ea371ece79475b0b6e738ce0853 Reviewed-on: https://chromium-review.googlesource.com/c/1356199 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#614711}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/18f0c3c038fc..3f10ca8145d9 git log 18f0c3c038fc..3f10ca8145d9 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 benwright@webrtc.org Always record receive timestamps even on when the invalid flag is set. 2018-12-07 sprang@webrtc.org Include protection bitrate in total max allocated bitrate 2018-12-07 jonasolsson@webrtc.org Export the standardized IceConnectionState. 2018-12-07 saza@webrtc.org Fuzz unfuzzed AEC3 killswitch field trials 2018-12-07 nisse@webrtc.org Replace RegisterExternalDecoder in NetEq test VerifyTimestampPropagation. 2018-12-06 sukhanov@webrtc.org Make sure media transport is deleted before ICE. 2018-12-06 emircan@webrtc.org Add visibility for rtc_vp9_profile 2018-12-06 mirtad@webrtc.org Replace VideoEncoderFactory::QueryVideoEncoder with VideoEncoder::GetEncoderInfo 2018-12-06 kwiberg@webrtc.org Introduce some placeholder build targets 2018-12-06 srte@webrtc.org Merges RtpTransportControllerSend with SendSideCongestionController. 2018-12-06 benwright@webrtc.org Adding partial authentication of the Generic RTP Frame Descriptor. 2018-12-06 orphis@webrtc.org Copy VP8EncoderSimulcastProxy to EncoderSimulcastProxy Created with: gclient setdep -r src/third_party/webrtc@3f10ca8145d9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I457ec21aeb581a7da2a38ecbb92f346e9b274b24 Reviewed-on: https://chromium-review.googlesource.com/c/1367588Reviewed-by:
-
manuk authored
Instead of clearing and re-building the entire list of tables, and then clearing and re-adding those tables to the DOM every time AutocompleteController returned a new response, this CL appends to the list of tables and the DOM. Bug: 891303 Change-Id: I817ddded6531fb0836771e6f70c15ac46dd528e3 Reviewed-on: https://chromium-review.googlesource.com/c/1365879 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#614709}
-
Kush Sinha authored
Please see the attached bug for a Design Document. AccountReconcilor must be paused while accounts are being migrated to Chrome OS Account Manager and must be re-enabled after migration completes. Bug: 904128 Change-Id: I930f1b090dede1db55297d184ab13d58f9625bdb Reviewed-on: https://chromium-review.googlesource.com/c/1350952 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#614708}
-
manuk authored
Currently, we highlighted only the rows that matched. Sometimes, rows it would be unclear why some rows matched and were highlighted; e.g. if you're filtering for `goo` with the intention of finding `google` urls, and some match had a url `go.com/o`, it would match and be highlighted. Highlighing the specific cell helps identify which specific cells of a row actually matched. Bug: 891303 Change-Id: I99965255c386aecb6b49f85bf989159716209bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1364157 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
manuk authored
This results in multiple organizational changes. 1) Filtering logic is engulfed by these elements instead of being grouped in FilterDelegate. FilterDelegate, as a result, only contains static methods that operate on plain strings and are oblivious to the OmniobxOutput hierarchy. 2) As FilterDelegate no longer exists, it seemed unnecessary to maintain the distinction between OmniboxOutput and RenderDelegate; RenderDelegate was merged into OmniboxOutput. 3) Decoupled display input (e.g. showDetails) logic from rendering. First, the HTML elements are created, without regards to display inputs, and then visibility of various sections is updated afterwards. This has the added advantage that toggling display inputs no longer require recreating the HTML elements. Bug: 891303 Change-Id: I7872e8b4449ce5fbd4a22e230c549ccc0d2764dd Reviewed-on: https://chromium-review.googlesource.com/c/1357010 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Rayan Kanso authored
There are a few disk reads that take place between regaining connectivity and dispatching the event. This adds another check right before dispatching the event to increase the reliability of the sync events Also collect how often this happens via UMA (until M74). Change-Id: I3aaf408bbb45b920a02236487df5246e8499500e Reviewed-on: https://chromium-review.googlesource.com/c/1361860 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#614705}
-
Xi Cheng authored
Change-Id: I3589e5a89ddeb40482e29511165655d2f0f5440f Reviewed-on: https://chromium-review.googlesource.com/c/1363860Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
sangseok.jang authored
The value of the indicator's |x| should change according to the apps_page_shortcut_ and managed_bookmarks_button_'s visble() Bug: 912446 Change-Id: I71b9f0abef43c7a2adaed5e2e54f830b1979b14a Reviewed-on: https://chromium-review.googlesource.com/c/1364975Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#614703}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ced5efe4094..dddb0585df2c Created with: gclient setdep -r src-internal@dddb0585df2c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6554c7e4c0d6a1fc9b485af4391ae9ec8eabd668 Reviewed-on: https://chromium-review.googlesource.com/c/1367590Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614702}
-
Hans Wennborg authored
It currently fails to link, see first bug. TBR=mmoroz Bug: 912919, 701825 Change-Id: I9491ebd1adf970173a4f2d009ca80254e7c6c7df Reviewed-on: https://chromium-review.googlesource.com/c/1367652Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#614701}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f1a2558c421d..3dde0186457b git log f1a2558c421d..3dde0186457b --date=short --no-merges --format='%ad %ae %s' 2018-12-07 primiano@google.com UI: make counters deal with negative numbers Created with: gclient setdep -r src/third_party/perfetto@3dde0186457b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5b0464af1e1ed09698abd16fcc1420873c15b0fe Reviewed-on: https://chromium-review.googlesource.com/c/1367589Reviewed-by:
-
Edin Kadric authored
Bug: 774530 Change-Id: I6ce46224cf1e39a5bd6a06d100dca2a0262923e5 Reviewed-on: https://chromium-review.googlesource.com/c/1365800Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#614699}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2a590893903..158df43c2d19 git log d2a590893903..158df43c2d19 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 reed@google.com hide non-blob versions of getTextIntercepts Created with: gclient setdep -r src/third_party/skia@158df43c2d19 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I57b7f630cd7673190e9c29e986f7929e47c30056 Reviewed-on: https://chromium-review.googlesource.com/c/1367587Reviewed-by:
-
Kush Sinha authored
Add a |AccountMigrationRunner::Step| for migrating Gaia Device Accounts to Chrome OS Account Manager. Bug: 904128 Test: Manually Change-Id: I33b86c378d6dfca13516b86accef59d20777755b Reviewed-on: https://chromium-review.googlesource.com/c/1349268 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Lukasz Suder authored
When we detect user interaction through TouchEventFilter, the preconditions check is rerun. The old solution was to listen for such events, but we encountered websites that didn't let through standard events (one SPA built using Angular). The drawback of the new solution is that we also reacto on scroll events, but that might be actually what we should do (eg. parallax websites, certain switch form elements, ..). Bug: 806868 Change-Id: I81e28e7e9c11797dcae113ecf99b21f4f28f6385 Reviewed-on: https://chromium-review.googlesource.com/c/1366291Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Lukasz Suder <lsuder@chromium.org> Cr-Commit-Position: refs/heads/master@{#614696}
-
Mike Reed authored
Skia now routes drawText, drawPosText and drawPosTextH to textblobs, so these virtuals are no longer called/used. Change-Id: I0acd861ec53d2f3a23b424aee71b911d1b69f6e3 Reviewed-on: https://chromium-review.googlesource.com/c/1366926Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#614695}
-
Peng Huang authored
With this CL, we will create a GLContextVirtual in RasterDecoderContextState, and share it with all raster decoders, display compositoer, etc. It is a temporary solution. In follow up CLs, we will share the one GLContext with GLES2 as well. In that case, we will use GLContext directly instead of GLContextVirtual. Change-Id: If9b8d1f32e58b32a9d9f8cd07aa10c30432e3183 Bug: 902904 Reviewed-on: https://chromium-review.googlesource.com/c/1357463 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#614694}
-
Michael Lippautz authored
This reverts commit c9efdb6f. Bug: 911662 Change-Id: I78c93aceaf32850fcfecb2a714f3d9e6e0997b50 Reviewed-on: https://chromium-review.googlesource.com/c/1367728Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#614693}
-
Peter Beverloo authored
Change-Id: Id4dda74d1fc4748fb59568c8dbd606327c8501eb Reviewed-on: https://chromium-review.googlesource.com/c/1367645Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#614692}
-
Egor Pasko authored
In attempt to avoid breaking customtabs_benchmark also move chrome_setup.py to tools/android/customtabs_benchmark/scripts. Reason: currently unused, does not comply with presubmit checks, no plans to develop it further. Change-Id: I01486f7fcbd663281e43c6db95bd621969a5f7d2 Reviewed-on: https://chromium-review.googlesource.com/c/1366275Reviewed-by:
Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#614691}
-
Eric Stevenson authored
This CL introduces a per-Profile BadgeManager that keeps a record of badge contents for installed PWAs and handles dispatching badge changes via. a delegate. This CL doesn't add any UI support. Bug: 719176 Change-Id: I4779c1ec5486ee1c71e35f1a4116580fdaefe7da Reviewed-on: https://chromium-review.googlesource.com/c/1170451Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
The icon on Desktop has one line under the arrow. Android's has two. Change-Id: I6ad41874d38b623cc81d5b33be31ad233ced4c86 Reviewed-on: https://chromium-review.googlesource.com/c/1365897Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#614689}
-
David Bokan authored
In https://crrev.com/59d9ba119448a269289d57e7c3d23a7f04f19248 we added the restriction that an element can only be promoted to implicit root scroller if none of its ancestors have scrolling or clipping. This inadvertantly removed a special case for allowing a horizontally scrollable document. Bug: 837007 Change-Id: I5a52d821266a5775e5be8641bdb6ed56fc9892f3 Reviewed-on: https://chromium-review.googlesource.com/c/1366784Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614688}
-
Christian Dullweber authored
To find out whether the flaky test is caused by a timing issue or if there is an actual problem, a short timeout is added. Bug: 912313 Change-Id: Iff4ff88fc64fa8addc0ff1f001aee7ba3bba0015 Reviewed-on: https://chromium-review.googlesource.com/c/1367644Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#614687}
-
Marc Treib authored
and into sync_service_utils.h/cc. It was already a static function, so easy to move. Generally, clients should not use (or even have to know about) the concrete *Profile*SyncService. This also cleans up its interface a bit. TBRing simple call site updates: tangltom for profile_chooser_view.cc dpapad for people_handler.cc TBR=tangltom,dpapad Bug: 884159 Change-Id: Id32e943a083d3cb851766171a3d1cfb3f9282ee4 Reviewed-on: https://chromium-review.googlesource.com/c/1367604 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#614686}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7f306df5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id90c647ea875c38691b79681ddc439dc200133d0 Reviewed-on: https://chromium-review.googlesource.com/c/1366821Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614685}
-
Leszek Swirski authored
Duplicate a slow test for the streaming-preload virtual test. Bug: 842995 Bug: 910846 Change-Id: Id3c5135d6585f4695ac33624ab563f3f867c685f Reviewed-on: https://chromium-review.googlesource.com/c/1358500 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#614684}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/845f9d53..9dff9d14 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icfe6bb481dd4622ea2faf71bcd43d827058375d4 Reviewed-on: https://chromium-review.googlesource.com/c/1366823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614683}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0f50114b3c68..6f0e1f9d8235 git log 0f50114b3c68..6f0e1f9d8235 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 cwallez@chromium.org Remove BufferView and inline offset/size in BindGroup Created with: gclient setdep -r src/third_party/dawn@6f0e1f9d8235 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I60939ae1c79899eeb136631f7f7647c52689100f Reviewed-on: https://chromium-review.googlesource.com/c/1367586Reviewed-by:
-
Roman Sorokin authored
Active Directory devices apply the setting that come from device cloud policy. BUG=chromium:889893 Change-Id: I0738f35dfdad56042c388699f811b43f3a530501 Reviewed-on: https://chromium-review.googlesource.com/c/1365595 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#614681}
-
Ioana Pandele authored
The histograms are currently recorded downstream in CL 725249. Bug: 912033 Change-Id: I4266135e3b63ad0bbafdb0a06ea7bd7a2a8c2ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1361722Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Marc Treib authored
The dialog contains a ListView of encryption options, and an explanatory text (with a "reset sync" link) below it. Before this CL, if there was insufficient screen space to fit everything, then the text could get pushed offscreen and become inaccessible, because only the ListView was scrollable (see bug). This CL moves the explanatory text into the ListView as a footer. This way, it is part of the scrollable area and thus remains accessible even if not everything fits on screen at once. Two small changes were necessary to make things work: - The text view now needs to be created dynamically, since it's not possible to set a footer view in xml. - ListView does not support margins on its elements, so we use padding instead. Bug: 911635 Change-Id: Ida64735ae571fd9d4d9b1dd3e5650a322d81207f Reviewed-on: https://chromium-review.googlesource.com/c/1365611 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#614679}
-
Bence Béky authored
Introduce HTTP2_RELOADABLE_FLAG_COUNT and remove platform-specific prefix. This way HTTP2_RELOADABLE_FLAG_COUNT syntax will be identical across platforms. Also remove unused HTTP2_FLAG_COUNT_N and HTTP2_CODE_COUNT* macros. This CL merges internal change 224404468 by bnc. Bug: 488484 Change-Id: Ib1c29d1c59101af7a60c85805ed53ae612212b25 Reviewed-on: https://chromium-review.googlesource.com/c/1366576Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#614678}
-
David Jean authored
This is a reland of 965f2dd7 Original change's description: > Reland "[ios] add credit card test for manual fallback" > > This is a reland of 30e1dd18 > > Adding feature flags to slimnav. > Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970 > > Original change's description: > > [ios] add credit card test for manual fallback > > > > Also adds AutofillManualFallbackPhaseTwo to test bots. > > > > Bug: 845472 > > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d > > Reviewed-on: https://chromium-review.googlesource.com/c/1337347 > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Commit-Queue: David Jean <djean@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611171} > > TBR=rohitrao@chromium.org > > Bug: 845472,908970 > Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29 > Reviewed-on: https://chromium-review.googlesource.com/c/1352328 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611679} Bug: 845472, 908970 Change-Id: Ia84d71d73733d5c326443c3441e3127b700e73ef Reviewed-on: https://chromium-review.googlesource.com/c/1356718 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614677}
-
Marc Treib authored
Previously, GetRegisteredDataTypes and GetForcedDataTypes were only exposed from the (concrete) ProfileSyncService, not from the (interface) SyncService, as opposed to GetPreferredDataTypes and GetActiveDataTypes. It seems right and sensible to expose the registered and forced data types too. Concretely, this will allow us to write more code (e.g. PeopleHandler) in terms of SyncService rather than ProfileSyncService. Bug: 884159, 910518 Change-Id: I1d9176d4d2ced1dc5defda1b85b6ced2fa51afba Reviewed-on: https://chromium-review.googlesource.com/c/1365594 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Mark Cogan authored
This CL removes the remaining public and private BVC tab creation methods, and instead factors callers to directly call into the tab model. Bug: 90338 Change-Id: I44231cf05816130875dd17f5892f43a7389ed402 Reviewed-on: https://chromium-review.googlesource.com/c/1329742Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#614675}
-
Dan Elphick authored
Replaces use of deprecated BooleanValue, Int32Value, Get and GetOwnPropertyNames v8 functions. Bug: v8:7279, v8:8238 Change-Id: I73bb7deb93dffb985d4ea2fdf77fb8400d436913 Reviewed-on: https://chromium-review.googlesource.com/c/1352760Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#614674}
-
