- 19 Jul, 2017 40 commits
-
-
mgersh authored
Revert of Handle Java assert using a customized function in base (patchset #8 id:390001 of https://codereview.chromium.org/2971063003/ ) Reason for revert: Broke compile on Cronet bots with error about "can't find referenced class org.chromium.base.JavaExceptionReporter": https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20x86%20Builder%20%28dbg%29/builds/61854 Original issue's description: > Create java_assertion_handler, a Java binary that takes in a JAR file > and modifies the bytecode of classes. > > Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler > that throws Exception. > > Output is written to a new JAR file. > > > BUG=672945 > > Review-Url: https://codereview.chromium.org/2971063003 > Cr-Commit-Position: refs/heads/master@{#487903} > Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589 TBR=yfriedman@chromium.org,agrieve@chromium.org,zpeng@chromium.org,ranj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672945 Review-Url: https://codereview.chromium.org/2981273003 Cr-Commit-Position: refs/heads/master@{#487914}
-
Yuwei Huang authored
Since we are not going to implement the send email feature soon, this CL hides the send email button in the host instruction page. This CL replaces the HostSetupFooterView with an empty view. Bug: 736932 Change-Id: Id3ce3faea6f2352667904eb48d4e811587254d82 Reviewed-on: https://chromium-review.googlesource.com/575302Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#487913}
-
Yuke Liao authored
This CL adds unit test files for Xcode objects in tools/gn/xcode_object.h, and specifically exercises class instantiations and tests that it doesn't crash. Bug: 742258 Change-Id: I234b0e643e718edf09a011c390c70c1d5ed0743f Reviewed-on: https://chromium-review.googlesource.com/572702Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487912}
-
Yuke Liao authored
The original XCTest files search code was in pretty bad shape, not only ridiculously long, but also not extensible enough to accommodate XCUITest. This CL re-factors it to clean it up and makes it more general. Bug: 709289 Change-Id: I14c0ad95af8365e3bbbf1db899560d5cac103b7a Reviewed-on: https://chromium-review.googlesource.com/576990Reviewed-by:
-
Peter Kotwicz authored
This CL changes the logic for showing the Lightweight First Run Experience to show the Lightweight First Run Experience for "Unbound WebAPKs" only. "Unbound WebAPKs" are WebAPKs whose package name does not start with "org.chromium.webapk" This CL adds AsyncInitializationActivity#shouldPreferLightweightFre(). Sub classes should override the method to request the Lightweight First Run Experience. BUG=738133 Change-Id: Icd7796c57d928751c595e6b02467b1054119546a Reviewed-on: https://chromium-review.googlesource.com/563885Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#487910}
-
Mohamad Ahmadi authored
- Creates a PaymentRequestCache class as KeyedService along with its factory to ensure only one instance of it exists per BrowserState. - PaymentRequestCache maintains a map of web::WebState to a list of payments::PaymentRequest instances maintained for that WebState. - The PaymentRequestCache instance can be accessed in browser tests via the instance of BrowserState in order to verify the correct creation and state of payments::PaymentRequest objects. BUG=602666 Change-Id: I4aef5be49ab93261bcbebd6f742378bcca59938e Reviewed-on: https://chromium-review.googlesource.com/577379Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487909}
-
Adithya Srinivasan authored
RuntimeCallStats creates TracedValue objects using the same set of strings repeatedly. For this case, it makes sense to not create string copies when adding an entry to a TracedValue. The current TracedValue class defined in third_party/WebKit only has methods that create copies of strings. This CL renames the existing methods to match the base::trace_event::TracedValue method they call, and adds methods that call the versions that do not make copies. Bug: 724543 Change-Id: Ice4582c250247fc6caf1123de260fa0d1861c4bf Reviewed-on: https://chromium-review.googlesource.com/550435Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#487908}
-
Devlin Cronin authored
Finish wiring up native extension bindings for service-worker based contexts. Following the IPC refactoring, the only missing piece is adding logic for getting the service worker contexts (which aren't in the normal ScriptContextSet). This makes ServiceWorkerTest.Events, ServiceWorkerTest.TabsCreate, and ServiceWorkerAppTest.RegisterAndPostMessage pass with native bindings enabled. Bug: 653596 Change-Id: Ic09745caab760084a94d85b79f11add5d94d7a74 Reviewed-on: https://chromium-review.googlesource.com/570992 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#487907}
-
Geoff Lang authored
TBR=zmo@chromium.org NOTRY=true BUG=602688 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8d33707758586b53d0459d0e5ddc04396e5b5b93 Reviewed-on: https://chromium-review.googlesource.com/578047 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#487906}
-
Robert Kaplow authored
This is for services like UKM who want to report different field trial names. Bug:746402 Change-Id: I0ca7cf7abb519583ecb35aa40a1ea672dfb80343 TBR=calamity@chromium.org,oysteine@chromium.org,nparker@chromium.org Change-Id: I0ca7cf7abb519583ecb35aa40a1ea672dfb80343 Reviewed-on: https://chromium-review.googlesource.com/577634 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#487905}
-
nzolghadr authored
There was a lot of data being reported as part of the Event.ScrollUpdate.Touch UKM. For now we decided to reduce the volume of the data by a simple sampling scheme until we find a more permanent solution. BUG=742363 Review-Url: https://codereview.chromium.org/2976113002 Cr-Commit-Position: refs/heads/master@{#487904}
-
ranj authored
and modifies the bytecode of classes. Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler that throws Exception. Output is written to a new JAR file. BUG=672945 Review-Url: https://codereview.chromium.org/2971063003 Cr-Commit-Position: refs/heads/master@{#487903}
-
Lutz Justen authored
The ChromeOS code in platform2/authpolicy has been sending AuthPolicy.TimeToRunNetAdsGpo for a while now (see https://chromium-review.googlesource.com/c/440084/), but it was never added to histograms.xml. BUG=chromium:676299 TEST=PCQ Change-Id: I48ba1d1fed31a11dde3c8994d4e0adbef3c39ecc Reviewed-on: https://chromium-review.googlesource.com/574912 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487902}
-
arthursonzogni authored
In order to make the RenderFrameHost ready for simulating RenderFrame originated IPCs, the RenderFrame needs to be initialized. Bug: 728571 Change-Id: Ia80080a2e304dc2c37582599406b0cde3a22b027 Reviewed-on: https://chromium-review.googlesource.com/575237 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#487901}
-
Eric Stevenson authored
This reverts commit c2fadc96. Reason for revert: Added static initializer to MonochromePublic.apk. Original change's description: > Enable bounded mode logging on chrome://net-export. > > There is an option to configure the maximum size of the NetLog. The > default is 100MiB. > > Bug: 679030 > Change-Id: I9260d7ee895d589c4789a350ca4fe1dfc8617b65 > Reviewed-on: https://chromium-review.googlesource.com/571514 > Commit-Queue: Eric Roman <eroman@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487602} TBR=eroman@chromium.org,xunjieli@chromium.org Change-Id: I7d8fb8daee69e381097b441f3ed42bd24ae252d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 679030, 746430 Reviewed-on: https://chromium-review.googlesource.com/577197 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487900}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/23c93ef6e3b9..4442d453f570 $ git log 23c93ef6e..4442d453f --date=short --no-merges --format='%ad %ae %s' 2017-07-19 janeliulwq Added testing flag --save-attachments that saves embedded attachments 2017-07-18 janeliulwq Removed public/ in include 2017-07-18 janeliulwq Basic APIs and tests for extracting attachments 2017-07-18 npm Remove JBig2_GsidProc class Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ib054d6b6f2f2f6b3945803e3275752af5ac95939 Reviewed-on: https://chromium-review.googlesource.com/577787 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487899}
-
Donn Denman authored
Updates Contextual Search to correctly handle words in alphabets with unreliable word-break characters. The Android method Character.isIdeographic does not do what I thought it did! Instead we now use a regular expression to scan a string for non latin_basic characters. Also updates the short/long word suppression to be less confusing when applied to non-latin languages. Since these characters in CJKV alphabets are data-dense the shortness rule should not apply. BUG=745970, 746097 Change-Id: I65527c614a2ae3a1e74df90a01f00f5e60fea197 Reviewed-on: https://chromium-review.googlesource.com/576909 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#487898}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5e433d5a..67c78739 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iadbd8c3a56bd580a256c48a0fcb7aa0c3dae86be Reviewed-on: https://chromium-review.googlesource.com/577196Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487897}
-
Justin Cohen authored
Revert this after M61 branches. Bug: 737589 Change-Id: Icdd293b970b2577d785a6454d2bb14070457229e Reviewed-on: https://chromium-review.googlesource.com/577848Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487896}
-
Florin Malita authored
(remove SK_SUPPORT_LEGACY_HQ_SCALER) Change-Id: If5430b136027c50d01c9f832907b3cc7a518dea4 Reviewed-on: https://chromium-review.googlesource.com/568363 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#487895}
-
James Cook authored
Windows Ash support was removed in 2016, so remove Windows code from this test. Also remove the ash::test namespace, since we don't use that anymore. Bug: 373238 Test: chrome unit_tests Change-Id: I7dba77222fc36b7b8a5a372e7ed883eb20077332 Reviewed-on: https://chromium-review.googlesource.com/576871Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#487894}
-
Jay Civelli authored
Adding more unit-test coverage to ChildProcessConnection. Bug: 702316 Change-Id: I8ffee3636f944db7fa0e36fcc9a825aa1bd1766f Reviewed-on: https://chromium-review.googlesource.com/569403 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487893}
-
Yuly Novikov authored
BUG=670879 Change-Id: Ie108aa5a070020782cc304d5fdcbd1d51a7795ad Reviewed-on: https://chromium-review.googlesource.com/576394Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#487892}
-
Helen Li authored
This CL adds a build flag include_transport_security_state_preload_list=false on Cronet bots. For more details please see the linked bug. Bug: 603597 Change-Id: I0b0a85a6c7d296bf5b94e4f17c38ed10ca38f9b0 Reviewed-on: https://chromium-review.googlesource.com/577592Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487891}
-
Yipeng Wang authored
1. Use apk_operations.py as a python module rather than executing it so that stack traces & argparse errors refer to the generated script as the main script. 2. Don't force --incremental selection for commands where it makes no difference. 3. Log the adb_gdb command & forward the --verbose flag. Bug: 674250 Change-Id: I1260f282c79eed7acf9e27343f8c4e3d74566e6c Reviewed-on: https://chromium-review.googlesource.com/576769Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yipeng Wang <yipengw@chromium.org> Cr-Commit-Position: refs/heads/master@{#487890}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5af44defbd5f..925f52d03b73 $ git log 5af44defb..925f52d03 --date=short --no-merges --format='%ad %ae %s' 2017-07-19 ethannicholas fixed SPIR-V int->uint conversion 2017-07-14 bsalomon Remove GrAnalyticRectOp, the last legacy GrMeshDrawOp 2017-07-19 reed experimental: draw into unpremul 2017-07-19 reed remove google3 colortable flag 2017-07-19 fmalita Singleton SRGB color filters 2017-07-19 egdaniel Add blacklist to vk win intel for skp 2017-07-19 halcanary SkPDF: Fix color glyphs with absolute positioning 2017-07-18 scroggo Report first GIF frame after knowing its meta data 2017-07-19 rmistry Download material design SVGs from Google Storage 2017-07-18 brianosman Some basic Flutter/Fuchsia docs 2017-07-18 jshin Add aliases mapping Windows CJ fonts to Noto Serif CJK 2017-07-18 bsalomon Revert "Revert "Make GrAtlasTextOp a non-legacy GrMeshDrawOp"" Created with: roll-dep src/third_party/skia BUG=617403,722470 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I75eac4d2db0d0c21b05c5561ad44556fb25dcf8f Reviewed-on: https://chromium-review.googlesource.com/577769Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487889}
-
Luke Zielinski authored
Trigger is using a copy of the ad detection code from ads_page_load_metrics, to be refactored later when that code is shared. Trigger is currently not plugged into the TriggerManager (next CL), so this change is a no-op. Bug: 744869 Change-Id: Idff7d23df6aaa53c3b564c6daf16c96fe5a95c9b Reviewed-on: https://chromium-review.googlesource.com/574831 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487888}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8641322e4a40..1195fa0a2590 $ git log 8641322e4..1195fa0a2 --date=short --no-merges --format='%ad %ae %s' 2017-07-19 ashleymarie Changing version from "3" to 3 in json test results format Created with: roll-dep src/third_party/catapult BUG=717394 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I37876d87e72f59c4e0eff02dbf6291bca41e6138 Reviewed-on: https://chromium-review.googlesource.com/577727 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487887}
-
Alexander Timin authored
Do not run observers on main thread default queue and always run OnTaskCompleted regardless of ShouldNotifyObservers setting, in order to record task duration metrics for all queues. R=alexclarke@chromium.org Change-Id: I5223a9d704af98d02088557f27a5c32733c8b577 Reviewed-on: https://chromium-review.googlesource.com/577535 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487886}
-
Hajime Hoshi authored
base::AlignedAlloc uses memalign, which goes through the malloc zone, and the result size might be different from the resident size of the region in Mach virtual memory on macOS. This CL replaces base::AlignedAlloc usages with mmap to get accurate resident size. This is a preparation for crbug.com/742042 to use mach_vm_region instead of mincore on macOS for performance. Bug: 742042 Change-Id: I2b0dbdfd13ab895645b4d420a91a53a3b5307b6b Reviewed-on: https://chromium-review.googlesource.com/577494Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487885}
-
Nicolas Dossou-gbete authored
The remote suggestions provider is null when the feature is completely disabled. (via NTPArticleSuggestions) Bug: 742056 Change-Id: I6ae85b9583767fb85cea4d32aa655106d355b813 Reviewed-on: https://chromium-review.googlesource.com/576029Reviewed-by:
-
Yash Malik authored
Bug: 738037 Change-Id: Iae0012c53291453131a0d1ab94e8036259fb4d27 Reviewed-on: https://chromium-review.googlesource.com/575207Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#487883}
-
Hajime Hoshi authored
Bug: 742042 Change-Id: I5ff8f3b7be14be1b79bb43ebd349aded5aa818b9 Reviewed-on: https://chromium-review.googlesource.com/575304Reviewed-by:
-
Olivier Robin authored
When creating a new tab from the NC extension, commands can be executed on it (focus Omnibox, launch QR Code search, launch Voice Search). The current process relies on async call to launch the command after the tab is created. For some scenarios (focus Omnibox while creating a new tab), this is not enough, and the search is cancelled by the new tab animation. Add a completion handler in the tab creation to execute the command the tab is created. Bug: 744596 Change-Id: I3e4688ff858e4ed70e7df62ac10e541a7375cbf1 Reviewed-on: https://chromium-review.googlesource.com/574537 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#487881}
-
Theresa Wellington authored
A toolbar #onLayoutChange() causes the bottom sheet state to get reset when the user fullscreens a video. If they immediately tap the omnibox or otherwise trigger the sheet to open while fullscreen video mode is activated, the sheet previously ended up open over the video. Prevent this by setting the sheet state to peek if overlay video mode is active. Also exits fullscreen mode when an NTP is created; this ensures the toolbar is visible if the user enters fullscreen mode, uses a hardware menu button to open the menu then selects "New tab". BUG=740499 Change-Id: Ie1743df3dabcf6de344af03d2232b3806a133d36 Reviewed-on: https://chromium-review.googlesource.com/576143 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#487880}
-
Lambros Lambrou authored
Don't present a sign-in screen if the user has only just cancelled one. This moves account-reloading from onStart() to onResume(), so it's guaranteed to happen after an onActivityResult() notification which informs the Activity that the user has just cancelled sign-in. In that case, onActivityResult() sets a flag which then prevents reloadHostList() from being triggered again. The user can retry sign-in either by switching to a different (or same) account, or by switching away from the app and back again. Bug: 740231 Change-Id: I40a5c31c89c66e36be31ae6fc1574ddbf1989f07 Reviewed-on: https://chromium-review.googlesource.com/571568Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#487879}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/19817af6f201..23c93ef6e3b9 $ git log 19817af6f..23c93ef6e --date=short --no-merges --format='%ad %ae %s' 2017-07-18 tsepez Avoid unterminated string segment in cfx_saxreaderhandler.cpp 2017-07-18 thestig Prevent more crashes in wcsftime. Created with: roll-dep src/third_party/pdfium BUG=738303 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I32dd5ef3587cbe13fe9dc877dca240b51c12e8be Reviewed-on: https://chromium-review.googlesource.com/577633 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487878}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I5211d3e9c7ab4002e2d39024eb8857157591c23d Reviewed-on: https://chromium-review.googlesource.com/576647 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487877}
-
Xi Han authored
Change-Id: I27bf102d779df17702edb36429d4151fee909bc1 Reviewed-on: https://chromium-review.googlesource.com/577636Reviewed-by:
-
Aaron Gable authored
This was a typo, I accidentally removed the RUN_POST_UPLOAD_HOOKS line (which still has a function) when I meant to remove the TRY_ON_UPLOAD line (which doesn't). I blame them both containing the word 'UPLOAD'. Bug: 746079 Change-Id: I007ed90443680a7f3741367b368c55e5056e3252 Reviewed-on: https://chromium-review.googlesource.com/576530Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
