- 04 Jun, 2019 40 commits
-
-
Daniel Rubery authored
computeIcon_ can be called while this.data is still undefined, leading to TypeErrors when interacting with the chrome://downloads page. Bug: 917190 Change-Id: I4ef3fda1d53f3d9fbd9c80270594c6115b757bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635434 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#665969}
-
Becky Zhou authored
This reverts commit eec7c07a. Reason for revert: crbug.com/970298 Original change's description: > Using R8 in place of Proguard for creating main dex list > > Bug: 908988 > Change-Id: I9cfe718d3754b92022c9045f860dee36c7e049bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635949 > Commit-Queue: Sam Maier <smaier@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665957} TBR=estevenson@chromium.org,smaier@chromium.org Change-Id: I101d3a08afe9ae37eb3ed37472a4b625ea12af7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643081Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665968}
-
Carlos Caballero authored
Call is cheap and content::BrowserThread::PostAfterStartupTask is going away. Commit tasks already run on the COMMIT_SEQUENCE which itself is BEST_EFFORT so it will only run after startup. R=mek@chromium.org Bug: 887407 Change-Id: I05b68eafb59ec30b20f18951c8c49537df602377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631701Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665967}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a549bb817523..2f4a8dfd3a59 git log a549bb817523..2f4a8dfd3a59 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 johnkslang@users.noreply.github.com Merge pull request #1788 from jeffbolznv/ifdef_fix 2019-06-04 johnkslang@users.noreply.github.com Merge pull request #1786 from jeffbolznv/fsi Created with: gclient setdep -r src/third_party/glslang/src@2f4a8dfd3a59 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Ie4d673b4081ac29d8a9510a5a334065c3add8e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665966}
-
Ian Kilpatrick authored
:first-letter is weird. The element which the first letter is attached to can differ from the layout object which it is attached to. This difference caused us to crash. Bug: 967194 Change-Id: Id186ae1d61ce42ae0d6d54d8524cc854abb3c78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636312 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#665965}
-
Robert Ogden authored
TBR=ryansturm@chromium.org Bug: 969794 Change-Id: If85e6dddb1c3d3923d966ec745e6a09ebb87b9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643656Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#665964}
-
Dan Harrington authored
Both http/tests/security/mixedContent/insecure-css-resources.html and virtual/blink-cors/http/tests/security/mixedContent/insecure-css-resources.html have been failing on most bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fsecurity%2FmixedContent%2Finsecure-css-resources.html TBR=jochen@chromium.org Bug: 970142 Change-Id: Iee373b94c08cca52fe801ff2994895333f76e92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643756 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#665963}
-
Elly Fong-Jones authored
Bug: None Change-Id: I8d961861a9edec88ca2aa93ef9d2e26743d09ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612841 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#665962}
-
Elly Fong-Jones authored
Bug: None Change-Id: If6cbce7a49f9ac697993644156ad4a4e8f7a3a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638737Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665961}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/961407f5e86f..479a3c0f92b9 git log 961407f5e86f..479a3c0f92b9 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 mirtad@webrtc.org Add support for enabling and negotiating raw RTP packetization. Created with: gclient setdep -r src/third_party/webrtc@479a3c0f92b9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I556567edcb8150ee7db3510467008e472a6cf38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643317Reviewed-by:
-
Tommy C. Li authored
Currently, ZeroSuggestProvider uses DEFAULT_SERP_FOR_URL by default. After this CL, ZeroSuggestProvider will use NONE as the default. And there will be a ZeroSuggestVariant value of "RemoteSendURL" that can be queried via: OmniboxFieldTrial::InZeroSuggestRemoteSendURLFieldTrial() The objective of this is twofold: 1) Enable us to switch put certain page classifications into the DEFAULT_SERP_FOR_URL mode without putting every page classification into this. This is needed for On Focus Query Refinement. 2) Disables ZeroSuggestProvider by default for all page classifications not in this field trial. This will allow us to get rid of the fake ZeroSuggestRedirectToChrome URL method of disabling ZeroSuggestProvider, which is not obvious. This is also fairly important for On Focus Query Refinement, as then we will want to specify a real endpoint URL, not a fake one to disable the feature. Bug: 963173 Change-Id: I61ce4bbf2f228b477bdf82c581b4cedd88fa546b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632920Reviewed-by:Mark Pearson <mpearson@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#665959}
-
Pavel Shmakov authored
Bug: 916531 Change-Id: I802b01621be55b440fd3624764a51b63f087d81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638458 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#665958}
-
Sam Maier authored
Bug: 908988 Change-Id: I9cfe718d3754b92022c9045f860dee36c7e049bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635949 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#665957}
-
Takuto Ikuta authored
The test is slow on android. https://chromium-swarm.appspot.com/tasklist?c=name&c=duration&c=state&d=desc&f=pool-tag%3AChrome&f=state%3ACOMPLETED_SUCCESS&f=name-tag%3Apixel_test&k=name-tag&s=duration Bug: 941946 Change-Id: I142e57e41662d0ccfa8215c06e5ec6091c3c4cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642754 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665956}
-
Erik Wolsheimer authored
Change-Id: I2d6d9628f752860afcc8bf13caecc36e2c10fc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640788Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Erik Wolsheimer <ewol@google.com> Cr-Commit-Position: refs/heads/master@{#665955}
-
Jon Wilson authored
Bug: 950413 Change-Id: I6959707406d1830c5570321b24860441f8eca43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642529Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jon Wilson <jpwilson@google.com> Cr-Commit-Position: refs/heads/master@{#665954}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/886d9e9f735a..009bc1a74cf5 Created with: gclient setdep -r src-internal@009bc1a74cf5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: Ief09636e2e1dc92ed265b11cd7caac9f91467b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643315Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665953}
-
Lowell Manners authored
Bug: 786836 Change-Id: I37d56bedccfeb2f59f908b63d6782dc976aba76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628732Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#665952}
-
W. James MacLean authored
This CL makes page-level state from Blink's TextAutosizer available to remote-frame renderers by plumbing it through the browser process and sending it back out using a PageMessage. While this CL does not fix TextAutosizing in OOPIF renderers, it makes the necessary information available in those renderers. Bug: 393285 Change-Id: I1bc04fb503821e1eeebfc8f2aa919007ed35a279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627930 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#665951}
-
danakj authored
This adds a ChromeBrowserTests java activity and application, based on content and components browser tests. It additionally sets up a ChromeBrowserInitializer which is needed before running the native setup of ChromeBrowserMainParts etc. The JNI_Onload runs the Chrome Android production path to set up a ContentShellDelegate, and unsets the product version number afterward as tests do no expect to have a version number. The test_activity.xml layout refers to a ShellManager as the java pieces are setting up the same UI as content-based browser tests for now. We will need to use more Chrome java pieces for the UI in order for tests to call out to java probably. But this gives a baseline framework that runs the //chrome C++ code in an Android browser test. We still need a BrowserTestBase subclass to provide the Test class so that we may begin writing browser tests on Android. We standardize the java code for content and components browser tests while writing the ChromeBrowserTestsApplication, based on the code in ChromeApplication and NativeUnitTest. In order to depend on NestedMessagePumpAndroid in browser tests, but not depend on WebTestSupport, we split the web_test_support target into two parts, and we depend on the NestedMessagePumpAndroid in each place it is used directly, which are the onload.cc files for each android browser test target. We remove dependencies on web_test_support from everywhere but content_shell_lib, where it is used. R=jam@chromium.org Bug: 961849 Change-Id: I4212482849eaf52dc8b8c22070806572215a8905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633212 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Yun Liu authored
Currently only set default output directory for instrumentation tests https://cs.chromium.org/chromium/src/build/config/android/internal_rules.gni?type=cs&q=%22--coverage-dir%22&sq=package:chromium&g=0&l=763-772 Should do the same for junit tests as well. Will use this default directory to collect coverage data on bot. Bug: 970021 Change-Id: I346a8a1493622e61634eebd340b4a8c1c64e93e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641379Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=mcasas@chromium.org Change-Id: I3c7f0757fba9484cd6a44f5bb2cdac434cdd3fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635814 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665948}
-
Katie D authored
The widget had no insets in which to display the shadow. In this change, add insets to the widget, and ensure they are taken into account after calculating the preferred layout for the autoclick menu view. Bug: 966153 Change-Id: If43a4f3e91f20261195102018aad90c8427ac9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636285Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#665947}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/525aa0ca60c8..62fd2c32bbe6 git log 525aa0ca60c8..62fd2c32bbe6 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 brianosman@google.com Interpreter: Minor cleanup of opcodes 2019-06-04 jbroman@chromium.org Don't mark inline functions in SkString.h as static. 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 borenet@google.com [infra] Supply revision as target_branch to bot_update 2019-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bb575d48d5f9..79d4ac9ab695 (6 commits) Created with: gclient setdep -r src/third_party/skia@62fd2c32bbe6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I7cb2f83a5aa7ffb030b4e5cd17def3a4458dcb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643490Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=rsesek@chromium.org Change-Id: I0a25ecf615af7e81acf65422c7f91870395bb68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636192Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665945}
-
Alison Maher authored
This change fixes flaky test failures caused by the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1591484/22 Flaky behavior is fixed for the following tests: -DumpAccessibilityTreeTest.AccessibilityIframePostEnable -DumpAccessibilityTreeTest.AccessibilityIframe DumpAccessibilityTreeTest.AccessibilityIframePostEnable is also re-enabled as a revert to the following change: https://chromium-review.googlesource.com/c/chromium/src/+/1638201 Bug: 969185 Change-Id: I1c961f215936a04ba54b5dd5ca6ba35205567648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638925Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665944}
-
Jeremy Roman authored
Bug: 955171 Change-Id: Ie939ad338912fdfe7f54c30f0d416efc407a63b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638280 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665943}
-
Jun Mukai authored
The LauncherAnimationsTest measures the performance for one-shot action. Recently the app-list widget will remain and be reused once created for the performance reason, but the existing one-shot scenario doesn't capture it properly. This CL adds new test scenarios which opens and closes the app-list in prior to the actual test scenario, so that we can measure the performance on both one-shot and reused. Here's the performance on 5 runs in nocturne:nocturne: one-shot Fullscreen: 13, 13, 13, 13, 13 Close: 79, 79, 39, 79, 73 Peeking: 58, 33, 49, 49, 33 Close: 100, 100, 100, 100, 91 Half: 33, 49, 33, 41, 41 Close: 58, 100, 91, 83, 100 FullscreenSearch: 46, 66, 59, 86, 66 Close: 79, 100, 93, 93, 93 reused Fullscreen: 66, 59, 59, 59, 66 Close: 93, 100, 100, 100, 93 Peeking: 83, 83, 91, 100, 74 Close: 100, 100, 100, 100, 100 Half: 74, 91, 91, 83, 91 Close: 100, 100, 100, 100, 100 FullscreenSearch: 86, 93, 93, 86, 86 Close: 93, 86, 93, 100, 86 So this CL reveals that the reusing improves the appearing animation smoothness. Fullscreen-app-apps isn't still ideal, but the numbers aren't bad. Bug: 961467 Test: cros_run_test on nocturne Change-Id: I69907f9c70b3dec3655b873ddcbe5611ab3432a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639558Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#665942}
-
Wojciech Dzierżanowski authored
Recreating the NetworkContext upon the network service process restart is a legitimate scenario where a new CustomProxyConfigClient ought to replace any old CustomProxyConfigClient set in DataReductionProxySettings. Bug: 970236 Change-Id: I849b8aebd5f94cab50d11318101e96ffc4c51589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642639Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#665941}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2c0111e6eba7..620197bd6535 git log 2c0111e6eba7..620197bd6535 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 afdx@google.com Add fuzzer pass that adds useful constructs to a module (#2647) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@620197bd6535 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I31a59be26e9e5eb5b76c4c822d84a044fec2aebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643078Reviewed-by:
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 969789 Change-Id: I543d75510a71662b03bf1e75e7637a24da41b919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641545Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#665939}
-
Nate Chapin authored
https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate indicates that javascript: url handling should be modeled like a navigation as much as possible. The spec is slightly unworkable in places, but this CL changes our handling to greatly resemble traditional navigations. This also removes the sole case where a DocumentLoader would be associated with 2 different Documents over its lifetime. Change-Id: I169cab35a54bf87634e326fc0c400c01122c3512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553718Reviewed-by:
-
Gauthier Ambard authored
This CL changes the separator displayed on the iPad NTP. Instead of being always visible the separator is now fade in when the fake omnibox is reaching the real omnibox. Bug: 968520 Change-Id: I5421094499a57d023d1a5c533bab68a4a76b6e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643570 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665937}
-
Steven Zhu authored
When |io_task_runner| is power managed, delayed tasks and timers running on it can wake up the system. Bug: internal b/132993317 Change-Id: Iee07e47e51e8c5f0ac011d351ba9fff3822f32b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637997Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Steven Zhu <jz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665936}
-
Eric Orth authored
All DoH queries will be padded to the next multiple of 128 bytes. Implemented as a feature of DnsQuery to add the padding to the OPT record, rather than just having it specified in the |opt_rdata| passed to the DnsQuery constructor because adding the correct amount of padding requires knowledge of the DnsQuery being constructed. Bug: 967848 Change-Id: I6be13c24c770e80d06ac3f7e988cdf814ce5c00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614454 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#665935}
-
Chris Harrelson authored
Bug: 957248 Change-Id: Iabd11d14ce835668b3c455c35ff5534189fb54b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638289Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665934}
-
Vladimir Levin authored
Accessing the offset mapping with a locked subtree is not correct, since it may not have been laid out. The exceptions for this are things that force the layout before accessing them. This patch fixes a DCHECK/crash that happens when an element is locked while some text within it is selected. The general approach is to mimic the behavior of display: none (which doesn't generate a layout object), or visibility: hidden (which is explicitly checked in the code). R=chrishtr@chromium.org, rakina@chromium.org Bug: 966754 Change-Id: Ib67fa345d7554b9caf6307db33bfc26e0582c950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628871 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665933}
-
Chris Hamilton authored
This builds a cheap RTTI for full casting between the 4 basic flavors a node can take in the graph: a Node, a NodeBase, a public FooNode, and a private FooNodeImpl. This casting is necessary for private graph internals to use the public observer interfaces, so we can avoid having to maintain separate public and private observer interfaces. A further CL will remove NodeBase entirely in favor of Node. BUG=910288 Change-Id: I542b01ab0af6d73297c39b4c2cf3205de4769b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637846Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#665932}
-
David Benjamin authored
Per https://crbug.com/795110#c3, newer fontconfigs are threadsafe. https://bugs.chromium.org/p/skia/issues/detail?id=1497 suggests the relevant version is 2.10.91. third_party/fontconfig is newer than that now, so remove the suppression. Bug: 795110 Change-Id: Ib9297814d682e75278c6d9d78d6c7d5315b5fce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643027 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#665931}
-
Nicolás Peña Moreno authored
This CL makes the implementation match the changes in the explainer: https://github.com/WICG/element-timing. In particular, name is now set to "image-paint" for image entries, and url is added. Bug: 879270 Change-Id: Id02e5305ac1e9bf9fa1fc18efe63d8cc280c5f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635733Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#665930}
-
