GitLab

BUG=115472

Review URL: https://codereview.chromium.org/551093003

Cr-Commit-Position: refs/heads/master@{#293959}

Rework strings in the keyboard overlay so they'll fit inside
of the keys. Omitting some repetition, the changes are:

  Activate last launcher item -> Last shelf item
  Activate last tab -> Last tab
  Activate launcher item 1 -> Shelf item 1
  Activate next tab -> Next tab
  Activate tab 1 -> Tab 1
  Bookmark current page -> Add bookmark
  Cycle through input methods -> Next input method
  Find text again -> Find again
  Focus address bar in search mode -> Focus address bar for search
  Focus launcher -> Focus shelf
  Focus next pane -> Next pane
  Lock screen or power off -> Lock / power
  Magnifier decrease zoom -> Demagnify
  Magnifier increase zoom -> Magnify
  Maximize window -> Maximize
  Minimize window -> Minimize
  Open address in new tab -> Open in new tab
  Open file manager -> File manager
  Open Google Cloud Print -> Google Cloud Print
  Reload current page -> Reload
  Select previous input method -> Previous input method
  Show the Chrome menu -> Show Chrome menu
  Show message center -> Message center
  Show status menu -> Status menu
  Take screenshot -> Screenshot
  Toggle bookmark bar -> Bookmark bar
  Toggle caps lock -> Caps Lock
  Toggle Chromevox (spoken feedback) -> ChromeVox (spoken feedback)
  Toggle projection touch HUD -> Projection touch HUD
  Toggle speech input -> Speech input
  View keyboard overlay -> Keyboard overlay

Also update more "launcher" references to instead be
"shelf".

BUG=248353,412132
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/550373002

Cr-Commit-Position: refs/heads/master@{#293958}

r1974: Changes ninja generator to only output empty names if not already output
r1973: Changes the ninja generator to output phony targets for uninteresting targets

BUG=410410
TEST=none
R=thakis@chromium.org
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/555853003

Cr-Commit-Position: refs/heads/master@{#293957}

Original CL: https://codereview.chromium.org/522463005

TBR=kenrb@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/554083002

Cr-Commit-Position: refs/heads/master@{#293956}

BUG=266484
TBR=mcasas@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/554323002

Cr-Commit-Position: refs/heads/master@{#293955}

Fixes webrtc/ Debug build with libc++ which failed to link std::getline
as this is defined in <istream>. <iostream> causes static initializers
and shouldn't be necessary.

Also adds to README.chromium that the overrides are used too get rid of
static initializers and to build on libc++.

R=thakis@chromium.org
TBR=ronghuawu@chromium.org
BUG=webrtc:3739

Review URL: https://codereview.chromium.org/552013004

Cr-Commit-Position: refs/heads/master@{#293954}

BUG=412367

Review URL: https://codereview.chromium.org/552983002

Cr-Commit-Position: refs/heads/master@{#293953}

NOTRY=true

Review URL: https://codereview.chromium.org/551703002

Cr-Commit-Position: refs/heads/master@{#293952}

Bug was introduced in https://codereview.chromium.org/485083002 .

BUG=410537

Review URL: https://codereview.chromium.org/559543002

Cr-Commit-Position: refs/heads/master@{#293951}

https://skia.googlesource.com/skia/+log/87c4138fae37ba6b7e4de7acc3fce19524d726ea..90dc6412b46fa0bcf01ce45feeb4934fb774e7eb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/559563003

Cr-Commit-Position: refs/heads/master@{#293950}

Visibility tracks whether the view itself is visible and drawn whether
all the views ancestors are visible and connected to the root.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/557573002

Cr-Commit-Position: refs/heads/master@{#293949}

Bug was introduced in https://codereview.chromium.org/421113002 .

BUG=

Review URL: https://codereview.chromium.org/552353002

Cr-Commit-Position: refs/heads/master@{#293948}

1. Previously, we didn't animate the browser actions
   container when the visible count changed, because we set
   the width prior to calling animate. Fix it by animating to
   the desired width.
2. There was a bug where we would improperly hide an extension
   upon loading another, because we wouldn't account for the
   chevron width. Fix this, and add a test.

BUG=410348
BUG=410361

Review URL: https://codereview.chromium.org/539543002

Cr-Commit-Position: refs/heads/master@{#293947}

It was running in Chrome's unit_tests suite for historical reasons.

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/554963002

Cr-Commit-Position: refs/heads/master@{#293946}

BUG=391488

Review URL: https://codereview.chromium.org/556863004

Cr-Commit-Position: refs/heads/master@{#293945}

__get_item__ enumerates ExtensionBackendList, and when it discovers
a matching index, it access ExtensionBackendList at that index. However,
ExtensionBackendList.__get_item__ calls Update, which can invalidate index.

BUG=411612
TEST=extension_unittest

Review URL: https://codereview.chromium.org/555823002

Cr-Commit-Position: refs/heads/master@{#293944}

This CL adds a BASE_EXPORT to EnabledStateObserver class. This CL is a
part of the effort to get NetLog data into tracing. Since
EnabledStateObserver is not base exported, we would like it to be so
that we can use it outside base.

BUG=399701

Review URL: https://codereview.chromium.org/551333003

Cr-Commit-Position: refs/heads/master@{#293943}

Bisect working directory was not reset on build failures, because of this svn commands were executed in wrong directory.

BUG=391109
NOTRY=true

Review URL: https://codereview.chromium.org/555503004

Cr-Commit-Position: refs/heads/master@{#293942}

https://chromium.googlesource.com/chromium/blink/+log/fafeabb7ba52e586cd3b6d60095c20b0920ebba9..9f1c0c1143fb771cb53750d5d0b7913a95f84b8b
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/552343002

Cr-Commit-Position: refs/heads/master@{#293941}

This is a part of the effort to get NetLog data into
tracing. The reason to add these new APIs for logging
NetLog events is that NetLog events are logged
asynchronously and can have multiple nested levels of
inner events. The current ASYNC_STEP APIs only allow
one level of nested events.

In general, it would be useful if we could can have an
async event broken into sub steps, each sub step has an
explicitly defined beginning and end within that overall
event, with additional arguments.

Design Doc:
https://docs.google.com/document/d/1Z2uqj59UEts5IiXX78mkdU4kd6e7kE3JUKPoDK97bVs/edit?usp=sharing
BUG=399701

Review URL: https://codereview.chromium.org/536503002

Cr-Commit-Position: refs/heads/master@{#293940}

Revert of Skia roll 87c4138:49e3199 (patchset #1 id:1 of https://codereview.chromium.org/554293002/)

Reason for revert:
read the bot results wrong.  we did break a test

Original issue's description:
> Skia roll 87c4138:49e3199
>
> https://skia.googlesource.com/skia/+log/87c4138fae37ba6b7e4de7acc3fce19524d726ea..49e3199e638595d7e8b8bf41081eb9cac5daaa2d
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
> TBR=fmalita@google.com
>
> Failing tests are failing with and without this CL.
> NOTRY=true
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3903c20d4c27bfc0092ed9056d43f4837288ef60

TBR=fmalita@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/553013002

Cr-Commit-Position: refs/heads/master@{#293939}

https://skia.googlesource.com/skia/+log/87c4138fae37ba6b7e4de7acc3fce19524d726ea..49e3199e638595d7e8b8bf41081eb9cac5daaa2d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Failing tests are failing with and without this CL.
NOTRY=true

Review URL: https://codereview.chromium.org/554293002

Cr-Commit-Position: refs/heads/master@{#293938}

Drop TaskRunner in MetadataDatabase, that is no longer needed.

BUG=412367

Review URL: https://codereview.chromium.org/556803002

Cr-Commit-Position: refs/heads/master@{#293937}

https://chromium.googlesource.com/chromium/blink/+log/f3ac987b91cc9d98b6c583125e777dc843fc17c3..fafeabb7ba52e586cd3b6d60095c20b0920ebba9
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/552303002

Cr-Commit-Position: refs/heads/master@{#293936}

This reinstates cflags we used for GCC 4.8 for WebView builds.

BUG=407545
NOTRY=true

Review URL: https://codereview.chromium.org/555503006

Cr-Commit-Position: refs/heads/master@{#293935}

When the Blink cache produces conditional requests, the Chrome cache
always sends them to the origin server without attempting to serve them
from the cache. Add a histogram to find out how common conditional
requests from Blink are, and how many are hitting the network
even though a usable Chrome cache entry exists.

BUG=407968
TEST=manual inspection of about:histograms

Review URL: https://codereview.chromium.org/531693003

Cr-Commit-Position: refs/heads/master@{#293934}

BUG=None

Review URL: https://codereview.chromium.org/539253002

Cr-Commit-Position: refs/heads/master@{#293933}

BUG=

Review URL: https://codereview.chromium.org/554723004

Cr-Commit-Position: refs/heads/master@{#293932}

Before read-only properties which cannot be set by the user or policy, were explicitly marked as 'unmanaged' in the augmented dictionary returned by getManagedProperties.

Now, instead these properties are returned as plain values, which simplifies the consumer side, especially of Array typed properties like IPConfigs (compare this with SavedIPConfig).

BUG=410877

Review URL: https://codereview.chromium.org/551753002

Cr-Commit-Position: refs/heads/master@{#293931}

Also remove a few redundant consts that result in warnings like:

../../content/common/cursors/webcursor_aurax11.cc:20:1: error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
const ui::PlatformCursor WebCursor::GetPlatformCursor() {
^~~~~~

TBR=davemoore@chromium.org,sadrul@chromium.org
R=brettw@chromium.org, thakis@chromium.org,rch@chromium.org
BUG=393046, 335824

Review URL: https://codereview.chromium.org/538333002

Cr-Commit-Position: refs/heads/master@{#293930}

BUG=410228

Review URL: https://codereview.chromium.org/547663002

Cr-Commit-Position: refs/heads/master@{#293929}

Cr-Commit-Position: refs/heads/master@{#293928}

This change makes memdump able to parse and print out 64 bit addresses.
No change is intended for the 32-bit output.
This also updates the memdump parser in memory_inspector to match the
memdump change and updates its prebuilts.

BUG=340294

Review URL: https://codereview.chromium.org/550093003

Cr-Commit-Position: refs/heads/master@{#293927}

This updates the test case to use a synthesized single tap gesture
to follow the link instead of JavaScript.

BUG=408426
TEST=AndroidWebViewTest

Review URL: https://codereview.chromium.org/552813002

Cr-Commit-Position: refs/heads/master@{#293926}

BUG=412340
R=vasilii@chromium.org
TBR=vasilii

Review URL: https://codereview.chromium.org/551393002

Cr-Commit-Position: refs/heads/master@{#293925}

Change MediaStreamVideoSource::StartSourceImpl to use VideoCaptureFormat instead of VideoCaptureParams.
MediaStreamVideoSource only need the VideoCaptureFormat and thus should not pass VideoCaptureParams to its implementations.
This just a small code cleanup and does not change any behaviour.

TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/528783002

Cr-Commit-Position: refs/heads/master@{#293924}

BUG=412284
TEST=Check output from DVLOG(1) << device.name() << " " << supported_format.ToString() in VideoCaptureDeviceFactoryLinux::GetDeviceSupportedFormats. For a Kinect Camera, it will now list: Microsoft Kinect Camera resolution: 640x480, fps: 0.000000, pixel format: UYUY

Review URL: https://codereview.chromium.org/544033002

Cr-Commit-Position: refs/heads/master@{#293923}

* Object.seal use the more memory than Object.preventExtensions.

BUG=402708

Review URL: https://codereview.chromium.org/551353002

Cr-Commit-Position: refs/heads/master@{#293922}

We checkout the Android WebView glue layer (frameworks/webview)
into a new third_party directory (android_webview_glue)
which is checked out via gclient.

This is built against a jar containing frameworks/base
(in android_platform/webview/frameworks.jar).

We have to work around a few other issues:
    - Change build/java_apk.gypi to bypass the hardcoded
      'src' path.
    - Move libwebviewchromium to an include so we can make both
      the prefixed and un-prefixed version in the same build.

BUG=391488
R=mkosiba@chromium.org

Review URL: https://codereview.chromium.org/477903003

Cr-Commit-Position: refs/heads/master@{#293921}

BUG=None

Review URL: https://codereview.chromium.org/554623002

Cr-Commit-Position: refs/heads/master@{#293920}