GitLab

BUG=700327

Review-Url: https://codereview.chromium.org/2743803003
Cr-Commit-Position: refs/heads/master@{#456171}

BUG=

Review-Url: https://codereview.chromium.org/2740223002
Cr-Commit-Position: refs/heads/master@{#456170}

This CL removes FetchRequest::mutableResourceRequest() calls that are
used to modify ResourceRequest created just before, i.e. replaces:
  FetchRequest request(ResourceRequest(foo), bar);
  request.mutableResourceRequest().baz();
with:
  ResourceRequest resourceRequest(foo);
  resourceRequest.baz();
  FetchRequest request(resourceRequest, bar);
To clarify what kind of modifications to ResourceRequest via
mutableResourceRequest() is needed (https://crbug.com/632580#c8).

BUG=632580

Review-Url: https://codereview.chromium.org/2740253002
Cr-Commit-Position: refs/heads/master@{#456169}

We are adding COMPONENT/TEAM information into OWNERS file
(UI>ProximityAuth related, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=tengs@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2743073002
Cr-Commit-Position: refs/heads/master@{#456168}

The code in ParsedContentType is based on RFC2045, which does not mention what
should happen if the same parameter name is mentioned multiple times. However,
RFC6838 (Media Type Specifications and Registration Procedures), which defines
the MIME types for media and is based on RFC2045/2046, has the following
statement:
  It is an error for a specific parameter to be specified more than once.

Add an option to have ParsedContentType fail if the same parameter is
specified multiple times. navigator.requestMediaKeySystemAccess() is updated
to reject MIME types that mention the same parameter name more than once.

BUG=698436
TEST=new tests pass

Review-Url: https://codereview.chromium.org/2736283002
Cr-Commit-Position: refs/heads/master@{#456167}

This is required for the existing subresource filtering and css scanning
page load metrics, as well as for the upcoming metrics for pages where
media is played.

In the render process:
* move policy decision about whether to process timing or metadata updates
  from blink to chrome/renderer/page_load_metrics code
* instantiate MetricsRenderFrameObservers for child frames
* track metadata updates for child frames
* send at most one update per second per frame over IPC to the browser process
  (this is the existing page load metrics IPC policy)

In the browser process:
* track child frame loading behavior flags
* notify observers whenever the loading behavior flags for a child frame
  are updated

In the SubresourceFilterMetricsObserver:
* consider the page to have filtered subresources if subresource filter loading
  behavior is observed in either the main frame or child frames

Note that we still do not track timing updates for child frames. This change
gets us closer to being able to do so, but given that there is no current
need, we don't do this for the time being.

BUG=699849

Review-Url: https://codereview.chromium.org/2737563007
Cr-Commit-Position: refs/heads/master@{#456166}

Fix SpdySessionPool::FindAvailableSession() to log the correct
NetLog event type and the correct Net.SpdySessionGet histogram
value when pooling to an existing HTTP/2 connection by IP
address every time, not only the first time.

BUG=700451

Review-Url: https://codereview.chromium.org/2739183005
Cr-Commit-Position: refs/heads/master@{#456165}

Revert of Re-land WebVR compositor bypass via BrowserMain context + mailbox (patchset #37 id:710001 of https://codereview.chromium.org/2729523002/ )

Reason for revert:
Layout tests still failing for mac and windows despite passing on the trybots. Example: https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.9&number=43627

Original issue's description:
> Re-land WebVR compositor bypass via BrowserMain context + mailbox
>
> Implement compositor bypass for WebVR via mailbox copy:
>
> - Create a GPU command buffer GL context in the VrShellGl thread that's
>   backed by a native Surface. This is encapsulated inside the new
>   MailboxToSurfaceBridge class.
>
> - WebKit's VRDisplay sends a MailboxHolder for each frame (as drawn
>   via WebGL on the GPU process) as argument to the SubmitFrame mojo
>   call.
>
> - MailboxToSurfaceLayerBridge uses its GPU command buffer GL context
>   to draw the mailbox content to a Surface.
>
> - VrShellGl picks up the frame from the corresponding SurfaceTexture
>   and  proceeds with rendering as usual with its native GL context
>   as needed for the low-level GVR API.
>
> Also implements on-the-fly canvas resizing, the transfer surface and
> GVR renderbuffer are resized as needed to match the source canvas.
>
> Added frame number as an argument to various TRACE_EVENTs for timing
> analysis.
>
> It includes two separate modes for frame scheduling, the more
> aggressive one is conditional on
> chrome:://flags#enable-webvr-experimental-rendering since the
> framerate seems a bit less stable.
>
> BUG=698643
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2729523002
> Cr-Original-Commit-Position: refs/heads/master@{#455592}
> Committed: https://chromium.googlesource.com/chromium/src/+/6280ec5b6e3b4c307926eb1bf0167acc2a0d4a74
> Review-Url: https://codereview.chromium.org/2729523002
> Cr-Commit-Position: refs/heads/master@{#456130}
> Committed: https://chromium.googlesource.com/chromium/src/+/9f86464794416e81abfe5921e9fac892716c610b

TBR=mthiesse@chromium.org,bajones@chromium.org,khushalsagar@chromium.org,dcheng@chromium.org,piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698643

Review-Url: https://codereview.chromium.org/2742083002
Cr-Commit-Position: refs/heads/master@{#456164}

The CL implements peak detection in memory dump scheduler.
More discussion at https://goo.gl/0kOU4A.

BUG=607533

Review-Url: https://codereview.chromium.org/2737153002
Cr-Commit-Position: refs/heads/master@{#456163}

This patch fixes a bug in the TabbedEditorContainer's handler for
persistence binding.

As the binding comes in, we should retain selected tab no matter
what.

R=dgozman

Review-Url: https://codereview.chromium.org/2740053002
Cr-Commit-Position: refs/heads/master@{#456162}

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2738893003
Cr-Commit-Position: refs/heads/master@{#456161}

There's a race condition causing the WebMediaPlayer to be destroyed
before MediaCustomControlsFullscreenDetector dispatches the final
change. This CL fixes the issue.

BUG=698034

Review-Url: https://codereview.chromium.org/2743573003
Cr-Commit-Position: refs/heads/master@{#456160}

To emulate <a> :focus styling, action-link adds .no-outline on
mousedown, but removes .no-outline on blur. This indiscreminate removal
disregard the edge case where source of blur is from outside the web
page (e.g., Alt-Tab). This CL add an extra check to remedy this.

BUG=698270
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2744893002
Cr-Commit-Position: refs/heads/master@{#456159}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/faa1c3e0aeca..aa4354795733

$ git log faa1c3e0a..aa4354795 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 jessimb Updating the Anomaly index to include end_revision, master, and benchmark.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2744903002
Cr-Commit-Position: refs/heads/master@{#456158}

https://pdfium.googlesource.com/pdfium.git/+log/52c73c24ab05..5c1961dfa0b1

$ git log 52c73c24a..5c1961dfa --date=short --no-merges --format='%ad %ae %s'
2017-03-10 npm Add public method FPDFText_GetTextIndexFromCharIndex

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2740013006
Cr-Commit-Position: refs/heads/master@{#456157}

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353

Review-Url: https://codereview.chromium.org/2742693003
Cr-Commit-Position: refs/heads/master@{#456156}

In the case of extension-controlled prefs, extensions like fillr use

  chrome.privacy.services.autofillEnabled.set({value: false});

To disable Chrome's native Autofill.

When this happens, code runs[1] in chrome to set a pref in the:

1) profile pref store
2) extensions pref store

We observe changes to the profile pref store.  So the order is:

1) set value in profile pref store
-> change happens
2) set value in extensions pref store

Unfortunately, we ask in the observer whether
pref->IsExtensionControlled()[2], which check which store the value comes from.

This will change on the next line of code, but isn't updated yet.

I considered just changing the order (which might be valid), but I think
asyncrifying potentially solves other types of observer order issues.

R=rdevlin.cronin@chromium.org
BUG=693226

[1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/preference/preference_api.cc?type=cs&q=passwordsavingenabled&l=448,446
[2] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/settings_private/prefs_util.cc?q=prefs_util.cc&sq=package:chromium&dr&l=486,751

Review-Url: https://codereview.chromium.org/2742663002
Cr-Commit-Position: refs/heads/master@{#456155}

When native GPU memory buffers were enabled we noticed many crashes
reporting mmap failing.

This CL adds fd number to crash report when dmabuf mmap fails, because we think
fd limit may cause this crash.
It's follow-up CL of https://codereview.chromium.org/2710183005/

BUG=629521

Review-Url: https://codereview.chromium.org/2725813005
Cr-Commit-Position: refs/heads/master@{#456154}

On Linux, Video encoding is currently erroneously reported on chrome://gpu as "Hardware
accelerated". This CL fixes this by adding a blacklist entry.

BUG=641485
TEST=Open chrome://gpu on Linux and check that Video Encode is reported as
     Software only, hardware acceleration unavailable
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2744683002
Cr-Commit-Position: refs/heads/master@{#456153}

This patch adds a Java wrapper for RenderFrameHost. It also adds a
getMainFrame method to WebContents.

This will be useful for Payment Request which needs to know
the exact (sub)frame issued the payment request.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2681933002
Cr-Original-Commit-Position: refs/heads/master@{#455635}
Committed: https://chromium.googlesource.com/chromium/src/+/67dd9f2795389cc3776481ff07740984b2389f43
Review-Url: https://codereview.chromium.org/2681933002
Cr-Commit-Position: refs/heads/master@{#456152}

See also https://codereview.chromium.org/2641123006.

BUG=700229

Review-Url: https://codereview.chromium.org/2741193003
Cr-Commit-Position: refs/heads/master@{#456151}

This also switches the snappy mirror reference to the new mirror that
tracks the google/snappy GitHub repository. See http://crbug.com/693936
for details.

BUG=533648

Review-Url: https://codereview.chromium.org/2712273002
Cr-Commit-Position: refs/heads/master@{#456150}

No new code, just shuffling things around so WebKit/Source/modules
and content/renderer have a more related structure, also in terms
of bug components and OWNERS.

BUG=none  (no new code)

TBR=jochen@chromium.org
for adding a third_party/skia to DEPS; this dependency was
in content/renderer/media before anywa, and
third_party/skia hasn't got OWNERs itself :?

Review-Url: https://codereview.chromium.org/2739253003
Cr-Commit-Position: refs/heads/master@{#456149}

This component provides one dedicated thread per
SingleThreadTaskRunner.

Reference Change:
https://codereview.chromium.org/2686593003/

BUG=684080, 694823, 697697

Review-Url: https://codereview.chromium.org/2698843006
Cr-Original-Commit-Position: refs/heads/master@{#453162}
Committed: https://chromium.googlesource.com/chromium/src/+/fc203f52e046a8d82e053525d764671f7128f3d4
Review-Url: https://codereview.chromium.org/2698843006
Cr-Commit-Position: refs/heads/master@{#456148}

It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the expected_report.mp4 in the bug. Tested for RTL as well.

TEST=manual
BUG=696913
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2723613005
Cr-Commit-Position: refs/heads/master@{#456147}

As a result of this patch, we have:
- 65 icons of 28x24 size (belong to "large" icons)
- 24 icons of 10x10 size (belong to "small" icons)

The rest of the icons belong to "medium" icons and will
be normalized to be 16x16.

R=dgozman, pfeldman
BUG=700249

Review-Url: https://codereview.chromium.org/2744643003
Cr-Commit-Position: refs/heads/master@{#456146}

We are adding COMPONENT/TEAM information into OWNERS file
(security, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estark@chromium.org

Review-Url: https://codereview.chromium.org/2741833003
Cr-Commit-Position: refs/heads/master@{#456145}

This CL implements the get() and fetch() methods for Background Fetch.
The BackgroundFetchRegistration interface and BackgroundFetchOptions
and IconDefinition dictionary types are added too.

The method has not been hooked up with the browser process yet, as the
Mojo interface has not been implemented yet.

Tests are provided, and will be moved to the WPT directory once it has
been approved upstream:
  https://github.com/w3c/web-platform-tests/pull/5094

BUG=692534

Review-Url: https://codereview.chromium.org/2745543002
Cr-Commit-Position: refs/heads/master@{#456144}

We are adding COMPONENT/TEAM information into OWNERS file.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=eranm@chromium.org

Review-Url: https://codereview.chromium.org/2740133004
Cr-Commit-Position: refs/heads/master@{#456143}

On Android, when we'd like to use a SurfaceView for video playback,
we must enable the alpha channel on the CompositorView.  Otherwise,
we cannot draw a hole to see the video's SurfaceView.  We can't keep
transparency enabled all the time since it can cause power
regressions on some hardware.

However, because SurfaceView destroys and recreates the surface when
changing the pixel format, there is a visible flash during the
transition.  This CL removes that.

It causes the CompositorView to have two SurfaceView child views,
rather than extending SurfaceView directly.  When a request is made
to switch the output format, it makes the change to the background
SurfaceView, and swaps it to the front.  It also keeps the outgoing
SurfaceView around until the new one is in use by the compositor.

There are a few interesting bits:

- SurfaceViews are invisible until the first buffer is posted.  So,
  we can continue to see the outgoing view until the compositor is
  ready to use the new one.
- All buffers are released by the outgoing SurfaceView when its
  visibility is set to Gone.  'dumpsys SurfaceFlinger' shows that the
  same amount of gralloc memory is used in steady state.
- No power regression was observed on a Nexus 5.
- Unfortunately, new SurfaceViews are z-ordered behind existing ones,
  which makes it critical that we guess when to delete the outgoing
  (topmost) SurfaceView.  We currently time one frame, and then hide
  it.  Empirically, this works fine.
- This might seem like a more natural extension to
  CompositorViewHolder, but the CompositorView currently owns the
  native compositor.  Since CompositorViewHolder is already fairly
  complicated, it wasn't clear that it would be a good idea to
  refactor that into CVH.

Another approach is to use EGL to change the buffer format to include
an alpha channel, or not.  This avoids the power regression, since
opaque surfaces and buffers without alpha channels are treated the
same by SurfaceFlinger.  However, it causes problems for virtualized
contexts.  In particular, the off-screen contexts will have an alpha
channel at all times, so they cannot be shared with the compositor
context without one.  For some hardware (e.g., QC) that requires the
use of virtualized GL contexts rather than share groups, this may
have a stability regression.  So, we don't try it.

Please see https://goo.gl/aAmQzR for the design doc.

BUG=629130

Review-Url: https://codereview.chromium.org/2201483002
Cr-Commit-Position: refs/heads/master@{#456142}

generate_test_data.sh uses `hdiutil create` and `hdiutil convert`. The former
can overwrite an existing output file, but the latter cannot. This led to the
following error:

  hdiutil: convert failed - File exists

But this message was getting swallowed because the script 1) did not do `set -e`
to stop on errors, and 2) redirect all output to /dev/null. This also fixes both
of those issues.

BUG=696529
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2748453002
Cr-Commit-Position: refs/heads/master@{#456141}

Revert: https://codereview.chromium.org/2729733003/

As this is currently crashing on all mash builds, preventing development.

TBR=rockot@chromium.org, jochen@chromium.org, sammc@chromium.org
BUG=700155, 654988

Review-Url: https://codereview.chromium.org/2742523005
Cr-Commit-Position: refs/heads/master@{#456140}

Review-Url: https://codereview.chromium.org/2740173002
Cr-Commit-Position: refs/heads/master@{#456139}

Add unit tests using the new NavigationSimulator infrastructure

BUG=637415

Review-Url: https://codereview.chromium.org/2731013002
Cr-Commit-Position: refs/heads/master@{#456138}

The LayoutManagerChrome can still be null when #onNewTabPageShown()
is called for the first time.

BUG=699935

Review-Url: https://codereview.chromium.org/2741843003
Cr-Commit-Position: refs/heads/master@{#456137}

This CL replaces the Clang 'c++-analyzer' Perl script with logic added to the Python wrapper script. This gives us the hooks we need to run analysis builds with "gomacc" (necessary for distributed builds) and gives us a convenient place to specify analyzer config flags which aren't exposed by scan-build.

Adds a warning suppression rule which prevents the analyzer from raising false positives from stdlib code (code w/namespace "std").

Other changes:
* Modify Goma portions of the GCC toolchain GNI to build paths to
  the Clang static analyzer.
* Create an exception for ASM tool invocations, which don't play
  well with the analysis command line flags.
* Removed 'scan-build' DEP.

BUG=687245
R=thakis@chromium.org,wez@chromium.org

Review-Url: https://codereview.chromium.org/2667853004
Cr-Commit-Position: refs/heads/master@{#456136}

Wrap usage of ContentVideoView in an AndroidOverlay interface.  This
doesn't change the functionality, but starts to move AVDA towards
using AndroidOverlays rather than hard-coding CVV.

Much of Allocate/DeallocateSurface could be moved from
AVDACodecAllocator to ContentVideoViewOverlay.  However, to keep the
size of this change small, it isn't yet.

There shouldn't be any functional difference with this CL.

BUG=667950

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2692863011
Cr-Commit-Position: refs/heads/master@{#456135}

Child frames have some degree of continuity across navigations: the
contents are still embedded in the same document. Let them continue to
propagate user gesture state across navigations. However, main frames
don't have that continuity and should reset their user gesture state
on navigation.

TEST=DocumentUserGestureTokenTest.Navigate
BUG=chromedriver:922

Review-Url: https://codereview.chromium.org/2721423003
Cr-Commit-Position: refs/heads/master@{#456134}

TEST=manual; verify Docs, Sheets, and Slides work with regard to whitespace, key echo, etc when braille mode is off.
BUG=690635,690636,618099
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2740793002
Cr-Commit-Position: refs/heads/master@{#456133}

This CL changes the name of a CSS variable. The checkbox spacing was/is
being used for spacing between a control label and something graphical
such as the checkbox or a policy indicator. The intent is to convey
that it's used for more than checkbox spacing.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2744763003
Cr-Commit-Position: refs/heads/master@{#456132}