- 28 Mar, 2019 40 commits
-
-
François Doray authored
This is required to land https://webrtc-review.googlesource.com/c/src/+/128823. Bug: 889029 Change-Id: I0a4bbc71d7e9024ab9538a0c9d78e586dd37335a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538615 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#645257}
-
Karolina Soltys authored
I have added to PostTask a variant of runSynchronously returning a value, analogous to ThreadUtils.runOnUiThreadBlockingNoException -- this is needed to migrate several non-test usages of this function. Bug: 863341 Change-Id: Ie9ca5a44ffb9427df682881300e09d4e3f7b8272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541087Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#645256}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/exported, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Iefe9b0c8975a2719de0a08e4f00f15ef5a8a9b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542751Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#645255}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1b0ea7c9..a7b7d2ef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib8997114d64fe19a159ca926bcf74df6de79e382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543020Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645254}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab23393d. With Chromium commits locally applied on WPT: 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I40dfbb5c88ee915c021bcfe465b089af78472739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543019Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645253}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2e35430ab78..a82d8927e675 Created with: gclient setdep -r src-internal@a82d8927e675 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I9844c424321ea6b949a85499ee9348ba1d3af3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543118Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645252}
-
Joanmarie Diggs authored
* kAlertDialog should be exposed as ATK_ROLE_DIALOG; not ATK_ROLE_ALERT * kDocument and kGraphicsDocument should each be exposed as ATK_ROLE_DOCUMENT_FRAME; not ATK_ROLE_DOCUMENT_WEB Bug: 946680 Change-Id: Ida4ce8a2aa3d0a7d7dd1fbf6efede5d6aa9368e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542091Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Cr-Commit-Position: refs/heads/master@{#645251}
-
Maksim Moskvitin authored
Bug: 944831 Change-Id: Ifdba1bfc5e1e3a4f8e4eceb67586c73e53081d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539701 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#645250}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b3ae979ecd92..20574f48b540 git log b3ae979ecd92..20574f48b540 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 mbonadei@webrtc.org Testing no /DUNICODE assumptions with Win more configs bots. 2019-03-28 mbonadei@webrtc.org Prefix AUDIO_DEVICE_INCLUDE_ANDROID_AAUDIO with WEBRTC_. Created with: gclient setdep -r src/third_party/webrtc@20574f48b540 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I926c05ceebe7e373f1dbea139d56d94fc5b0e7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645249}
-
Stephane Zermatten authored
WebController ownership of its helpers. This change adds a helper to WebController for FindElement, similar to ElementPositionGetter. It also generalizes ownership of these two kinds of helpers, by keeping them in a map, so owned directly by the WebController instance. This change: - prepares the way for upcoming changes for WebController::FindElement. - simplifies ownership of ElementPositionGetter in WebController - possibly fix bugs in delete order, that we currently work around by waiting for actions to finish before deleting the controller - is a pure refactoring without behavior change Bug: b/129254215,b/129113367,b/128300038 Change-Id: Ib328cde766ffc669953b437e27898bb5cd543111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538091 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#645248}
-
Miyoung Shin authored
- long -> int32_t considering that WebIDL long type is signed 32 bits. - no logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930251 Change-Id: I7621e803acc30058351b168a05f7db5dcf127a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539331Reviewed-by:
-
Miyoung Shin authored
- long -> int32_t - Change the internal function name. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930251 Change-Id: I8c4a9f32744bfe45778122aa6175cefb2c1d96c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540900 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: Ia17a73c8cd5586330c0bf31c9cfe1d65dcde0678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537112Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#645245}
-
Friedrich Horschig authored
By moving components into designated folders, package private visibility becomes more meaningful. This is also an intermediate step to move all of these components into a separate feature. Ideally, all of the *_component packages will provide the coordinator as sole public class. This step shouldn't change any behavior, as well the next steps: - Splitting the metrics recorder - Making all views, binders, mediators and properties package-private Bug: 945314 Change-Id: I478f360c7203f098c504125e54630395ac1b9007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539041 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#645244}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3240800a9487..4ddc9c3a8038 git log 3240800a9487..4ddc9c3a8038 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 57e05b8be2d9..94f195b18776 (1 commits) Created with: gclient setdep -r src/third_party/skia@4ddc9c3a8038 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Id0d94b31db9bc6c0a8b2742d99305a31388c62fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542968Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d6a48a188c6..aab7e3179a01 git log 6d6a48a188c6..aab7e3179a01 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 crouleau@chromium.org [Telemetry] Only print detailed browser into for first test run. Created with: gclient setdep -r src/third_party/catapult@aab7e3179a01 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:943650 TBR=simonhatch@chromium.org Change-Id: If0cc620e3545967e9bc9d4de85e9ed6ab5314ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542967Reviewed-by:
-
Jinho Bang authored
According to the spec[1], if request.[[state]] is not "interactive", updateWith() should throw an "InvalidStateError". But before this patch, it doesn't. This patch fixes the problem as follows: - Replace PaymentUpdater with PaymentRequestDelegate - Remove inheritance of PaymentUpdater in PaymentRequestUpdateEvent. - Added IsInteractive() to PaymentRequest to check whether request.[[state]] is interactive or not. Manual test: wpt/payment-request/PaymentRequestUpdateEvent/updateWith-state-checks-manual.https.html Bug: 942308 Change-Id: I1a9e69ad045c95256aae06f299712d1d9c0081d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532123 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#645241}
-
Thomas Tangl authored
...by increasing the horizontal margin. Screenshot before: https://drive.google.com/file/d/1vQ9YH-bHpjrgAmXKWUDrQlu2XSDeWkit/view?usp=sharing Screenshot after: https://drive.google.com/file/d/1kwGgh1lEBx8jBgwjLx_2qQkDMnB0aE_v/view?usp=sharing Bug: 939737 Change-Id: I403429d0248f381a33dc9e0787c4cf4c3f284c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541782 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#645240}
-
Jonas Olsson authored
Bug: 941413 Change-Id: I9987a8ce31151310104bb7b37a884cdcfeb81671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520833Reviewed-by:
-
Ivan Sandrk authored
Bug: 578342 Change-Id: I54b346798ff8e295938430058fc92b694c3dedc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541159 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Miyoung Shin authored
- long -> int32_t/uint32_t/uint64_t - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930251 Change-Id: I32a2c4c077bcf42b77830bbd1cbf596b231b4782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541619 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4788c03a0392..d5a7a435d526 git log 4788c03a0392..d5a7a435d526 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 yyanagisawa@chromium.org cros_build_lib: supports long input file names. Created with: gclient setdep -r src/third_party/chromite@d5a7a435d526 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I4e213c111f25f93e9e149d08a6cf158f5985f99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542966Reviewed-by:
-
Hayato Ito authored
No behavior change. This CL just adds various assertions for flat tree node data's possible values so that we can detect dirty status. Bug: 906494 Change-Id: Ia2a420956828ac73b08a4d563e03a83c7835f15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535725 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#645235}
-
Ramin Halavati authored
ProfileChooserView generates several menus and draws them. Drawing is done using different code paths causing difficulty in maintenance of similar output. This CL separates content generation code and menu formatting to make a unified code path for drawing all menus and prepare the class for separation of Incognito menu (which is used on all desktop platform) from Profile menu which is not used on Chrome OS. Bug: 934689 Change-Id: I657c127e38e439eff26247284e0911fcc94be2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499457Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#645234}
-
Eliot Courtney authored
Also, mark status bar tooltip bubbles as ignored for PIP collision detection using this mechanism. Bug: b/127838266 Test: unit test Change-Id: I02d4fb093199eef97f29dc1283105f12b36cbe1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530275 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#645233}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/57e05b8be2d9..94f195b18776 git log 57e05b8be2d9..94f195b18776 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 swiftshader.regress@gmail.com Regres: Update test lists @ 179c9324 Created with: gclient setdep -r src/third_party/swiftshader@94f195b18776 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ife4764ddddb52bb4e6b07eb871dadef41260d541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542965Reviewed-by:
-
Javier Ernesto Flores Robles authored
The request to the Google server for favicons now uses the size in pixels as the API requires. Bookmarks now request the icons in points an the logic to get the pixel size is consolidated in favicon_loader. Previously it was requesting in pixels, so the image retrieved had the right size, but the call subsequent call to FaviconForUrl would multiply again the size and scale . Change-Id: I59c0deacd173f9433d14a8ff3446ac7bed857d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535885 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#645231}
-
Mario Sanchez Prada authored
Make sure that we don't re-use the callbacks from TestCompletionCallback, so that we're prepared for when they become non-repeating callbacks (i.e. base::CompletionOnceCallback), instead of base::CompletionCallback. This CL was uploaded by git cl split. TBR=tzik@chromium.org Bug: 807724 Change-Id: Id1ce48998eeda76b142fc0ec91de903a47411344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541113 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Auto-Submit: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#645230}
-
David Jean authored
Added too many methods to delegate, and will work at chipping away at those next. I tried to pass in interfaceProvider to app url loader service but it introduced so many cyclic depedencies so I did a more complex delegate instead. Bug: 907527 Change-Id: I3bc38be90c353d3f7dee91778c099b074ff0a9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529002 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#645229}
-
Mario Sanchez Prada authored
Make sure that we don't re-use the callbacks from TestCompletionCallback, so that we're prepared for when they become non-repeating callbacks (i.e. base::CompletionOnceCallback), instead of base::CompletionCallback. This CL was uploaded by git cl split. TBR=pwnall@chromium.org Bug: 807724 Change-Id: I430cf751ded3734a7ff7895e890da66b840ca823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541191 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Andrew Grieve authored
Based on stack: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.Activity.finish()' on a null object reference at org.chromium.chrome.browser.preferences.privacy.OtherFormsOfHistoryDialogFragment.onClick(OtherFormsOfHistoryDialogFragment.java:89) at org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest.lambda$testDialogAboutOtherFormsOfBrowsingHistory$3$ClearBrowsingDataPreferencesTest(ClearBrowsingDataPreferencesTest.java:311) Started failing on android-cfi here: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/4869 Change-Id: If48a75067a0278a9468c2263938c122f37c19806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542489 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#645227}
-
Gauthier Ambard authored
This CL fixes the mojo tests with the new WebUI implementation. # The JS is using "var" for Mojo, which makes the presubmit fail. # However, the script isn't working without it. NOPRESUBMIT=true Bug: 739844 Change-Id: Ic7211942ee9ebcc5c2490a84b48237ed43418a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526181Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#645226}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5f4bcbb9467f..1ba2cb8589a8 git log 5f4bcbb9467f..1ba2cb8589a8 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 yunchao.he@intel.com Construct ComboInputStateDescriptor to simplify tests and examples Created with: gclient setdep -r src/third_party/dawn@1ba2cb8589a8 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I561ed7e92f72907ae4c65e7f14c26dc28a842755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542877Reviewed-by:
-
Tomas Popela authored
The XDG_CURRENT_DESKTOP could contain multiple values in priority order separated by colon. Go through them in the loop and return on the first one that we recognize/support. The previous state was causing problems with Chrome on the GNOME Classic mode (used in Red Hat Enterprise Linux 7) where the users with multiple Google accounts set in Chrome couldn't switch between them - only one was shown in the account switcher in i.e. GMail. The reason for that was that the XDG_CURRENT_DESKTOP's value GNOME:GNOME-Classic was parsed as not as base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_GNOME. base: :nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_OTHER and Change-Id: I122f24fd1cf5a0f932c3fccd5220152a9944609d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541077Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#645224}
-
Tobias Sargeant authored
On Android M+ we can use ConnectivityManager to fetch proxy information rather than relying on system properties or intent extras. In order to keep WebView applications that use reflection to trigger the proxy change broadcast working, we must continue to register the old ProxyReceiver object. To ensure that this is not triggered by real system broadcasts, we register it with an empty intent filter. Bug: 851995 Bug: 908085 Change-Id: Ibfa6c35693301868f8a63ea924649e4c2bc8a328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526268Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#645223}
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 945731 Change-Id: I480a537eb4a65bf9c6b1c3de9316a0fa111740c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542752Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#645222}
-
Christos Froussios authored
We are fully launching the migration of away from the native linux backends. Bug: 571003 Change-Id: I26d0cfe87bead16ed33f728b05f4c060331faae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536190 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#645221}
-
Eliot Courtney authored
Currently, it just goes on top of the PIP window. Bug: 942992 Test: unit test Change-Id: Ic88b5c3cdc6173277a017f6a2c4211a3d13338c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530223 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#645220}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6822584e81a7..f2e35430ab78 Created with: gclient setdep -r src-internal@f2e35430ab78 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I7a37fdf45878282d30e8e877bcf648652be7b0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543017Reviewed-by:
-
Alan Cutter authored
This CL updates content browsertests to use the existing GetTestDataFilePath() instead of hard coding "content/test/data" many times. Bug: 946403 Change-Id: Ia90dbbdcd269cccd278de80bbf85ab3326fe1463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541546 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#645218}
-
