- 25 Sep, 2018 3 commits
-
-
Nico Weber authored
Bug: 832676 Change-Id: If227bcc8b17bb5bcd8563c921c41794d4c7e9dc0 Reviewed-on: https://chromium-review.googlesource.com/1241497 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593760}
-
Timothy Loh authored
This CL fixes a crash that occurs when switching to a profile with an incomplete Crostini terminal launch. While the BrowserStatusMonitor was already excluding the Crostini terminal from getting a shelf item, it was still tracking the Browsers, and ended up trying to add these to the shelf on profile switching. Bug: 882782 Change-Id: I7e406b1481a9ad5adb372335ebab421f1742acc1 Reviewed-on: https://chromium-review.googlesource.com/1235775Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#593759}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9461dcf1306a..a85f3a138cbc git log 9461dcf1306a..a85f3a138cbc --date=short --no-merges --format='%ad %ae %s' 2018-09-24 fmalita@chromium.org Reland: [skottie] Initial property setters 2018-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f668a4b5fb72..5272a543705e (1 commits) 2018-09-24 jvanverth@google.com More valid input checking for text 2018-09-24 bsalomon@google.com Revert "[skottie] Initial property setters" 2018-09-24 bungeman@google.com Filter TextBlob paints in Viewer. Created with: gclient setdep -r src/third_party/skia@a85f3a138cbc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Id532ca22f14e58f7d8ba6c001b8df2aba6592fcc Reviewed-on: https://chromium-review.googlesource.com/1241519Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593758}
-
- 24 Sep, 2018 37 commits
-
-
Scott Violet authored
WindowTree::OnWindowSurfaceChanged() is not needed anymore and can be removed (it hasn't been called in quite a while). BUG=none TEST=none Change-Id: Iaaf457c200577ece8185b61cfcfcb2ca322e9d1e Reviewed-on: https://chromium-review.googlesource.com/1241393 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#593757}
-
Krishna Govind authored
R=kariah@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I252210203821201dece28b1bb49bd8c3769ab7df Reviewed-on: https://chromium-review.googlesource.com/1242075Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#593756}
-
Karan Bhatia authored
This CL adds the field trial config for the runtime host permissions experiment. This experiment is currently enabled for 25% Canary and Dev channel. BUG=869996 Change-Id: I4ecaa1f6ccc6dd22a6f30f40c681048a568eb835 Reviewed-on: https://chromium-review.googlesource.com/1239204 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593755}
-
Justin DeWitt authored
sql::connection DCHECKs that cached statements match that extracted from the SQL statement object. However SQLite strips whitespace from the beginning and end of such strings. Change-Id: I470515e53e20c2d3fd8a51cb3820232ff56104ba Reviewed-on: https://chromium-review.googlesource.com/1240866 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#593754}
-
Stefan Zager authored
The new options behaves similarly to the 'delay' parameter to window.setInterval: it limits the frequency of observations to no more often than once per N milliseconds, for a delay parameter N. Also, require a delay parameter of at least 100 to enable occlusion detection, and raise a javascript exception if the requirement isn't met. The intention here is to hopefully force developers to consider carefully whether they truly want and need to use trackVisibility. With this change, we cannot rely on a dirty bit on the LocalFrameView to avoid all processing of IntersectionObserver's during lifecycle update. It may happen that a lifecycle update runs while the view is dirty; but an observation has a delay timer that hasn't expired yet. In that case, we mark the observation itself as dirty. We need to compute the observation on a subsequent lifecycle update when the observation's delay timer has expired. If the view is clean on that subsequent lifecycle update, we *still* need to descend into the observation to give it an opportunity to recompute. IOv2 spec language forthcoming. BUG=827639 R=chrishtr@chromium.org,ojan@chromium.org Change-Id: Ia987aec67d60340b263ba1a2cbcb30502d9e6288 Reviewed-on: https://chromium-review.googlesource.com/1234265 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593753}
-
Tommy Steimel authored
This CL updates the immersive mode styles to handle the new overlay play button positioning, as well as fixing an issue where the loading spinner was incorrectly styled for immersive mode. Bug: 884770 Change-Id: I395bea19f0047deaf85e4923735418105f833def Reviewed-on: https://chromium-review.googlesource.com/1241841Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593752}
-
Kevin Marshall authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=wez@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: Ib2d62c836525ba70e7a80f42f6c00c7ff9852310 Reviewed-on: https://chromium-review.googlesource.com/1240737Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#593751}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/835cc9ad9eb5..7fd8b20a597a git log 835cc9ad9eb5..7fd8b20a597a --date=short --no-merges --format='%ad %ae %s' 2018-09-24 moragues@google.com nocturne: remove firmware and factory signing from master Created with: gclient setdep -r src/third_party/chromite@7fd8b20a597a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie187576d3141b125503fe9cd6602049e7dbb9802 Reviewed-on: https://chromium-review.googlesource.com/1241596Reviewed-by:
-
Pavel Shmakov authored
NotificationBuilderBase#hasSmallIconBitmap() returns true even if the bitmap is going to be discarded when the Notification is built. Since small icons as Bitmaps are not supported on pre-M devices, this leads to TWA not using app's icon (specified in meta-data for TWAService or by extending TWAService) as a fallback. Instead Chrome icon is shown. This CL ensures TWA does use app icon as a fallback on pre-M devices. Samsung and Yulong devices with M sdk have the same problem (due to http://crbug/829367), except the fallback cannot be used either - see NotificationBuilderBase#setSmallIconForRemoteApp. So this CL doesn't fix the Samsung issue, but fixes a similar one on pre-M. Bug: 864786 Change-Id: I449431d3b98d5f0cab24863137ac66730be38f1a Reviewed-on: https://chromium-review.googlesource.com/1226595 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#593749}
-
ziyangch authored
BUG=internal b/115688282 Test=cast to Chromecast V1 from Google Play Movie. Change-Id: Ic57c4861016066457d850ace0f9da8e3cd905959 Reviewed-on: https://chromium-review.googlesource.com/1237613 Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#593748}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/645512ba5966..a36631cdb571 git log 645512ba5966..a36631cdb571 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 danilchap@webrtc.org Expect late delayed task is deleted. 2018-09-24 buildbot@webrtc.org Roll chromium_revision c92470b7..695c43e4 (593506:593611) 2018-09-24 niklas.enbom@webrtc.org Revert "Bug in histogram metric reporting." 2018-09-24 srte@webrtc.org Don't reset initial constraints in congestion controller. 2018-09-24 orphis@webrtc.org Add dummy implementation for SetCodecPReferences. 2018-09-24 terelius@webrtc.org Add helper class to process RtcEventLog events in order. 2018-09-24 yvesg@webrtc.org ResultsContainer: Initialize fields. 2018-09-24 yvesg@webrtc.org Auto roller: [unittest cleanup] Proper patching mechanism. 2018-09-24 kwiberg@webrtc.org TestStereo: Don't rely on the ACM to create encoders 2018-09-24 gustaf@webrtc.org AEC3: Delay estimator adapts even when estimated echo saturates 2018-09-24 kron@webrtc.org Refactor to remove direct memory dependency on kMaxId 2018-09-24 aleloi@webrtc.org Bug in histogram metric reporting. 2018-09-24 buildbot@webrtc.org Roll chromium_revision a7544fa3..c92470b7 (592771:593506) 2018-09-24 sprang@webrtc.org Revert "Reland "Enable simulcast screenshare by default"" 2018-09-24 phensman@webrtc.org Include stringutils to allow build on chromium 2018-09-24 devicentepena@webrtc.org AEC3: Bounding the nearend spectrum used as input for the suppressor gain computation 2018-09-24 artit@webrtc.org Disabled TestPacketBuffer.SeqNumWrapOneFrame test due to clang update 2018-09-24 nisse@webrtc.org Delete unused Url class. 2018-09-24 nisse@webrtc.org Delete unused HttpData methods. 2018-09-24 kwiberg@webrtc.org AudioCodingModuleTest.TestStereo: Delete write-only variables 2018-09-24 mflodman@webrtc.org Don't throttle key-frame requests per layer. 2018-09-24 jonasolsson@webrtc.org Make fewer copies when using StringBuilder. 2018-09-24 asapersson@webrtc.org Android: Add maxFramerate to RtpParameters. 2018-09-24 artit@webrtc.org Revert "Added support of getting coverage on mac" 2018-09-24 phensman@webrtc.org Add WriteVideoToFile to video_file_reader. 2018-09-24 henrika@webrtc.org Ensures that ADM unittest uses default audio devices for all platforms. Created with: gclient setdep -r src/third_party/webrtc@a36631cdb571 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:755660,chromium:855108,chromium:None,chromium:690537,chromium:887464,chromium:844647 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I906ee8f2b3f7798a61aef95bce71fbcbe0d81221 Reviewed-on: https://chromium-review.googlesource.com/1241517Reviewed-by:
-
Balazs Engedy authored
Bug: None Change-Id: I5aa68fa0426a6174931093f97fa0cad13db30fbb Reviewed-on: https://chromium-review.googlesource.com/1240284Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593746}
-
Dominic Mazzoni authored
Checked menu items were not being announced by screen readers on all platforms. Two separate fixes were needed: 1. Some of our code was ignoring the "checked" state on a menu item if the role wasn't kMenuItemCheckbox or kMenuItemRadio. Fix MenuItemView to set the proper role, and then fix code that expected just kMenuItem to expect any of those three roles. 2. On macOS in particular, implement AXMenuItemMarkChar, which is the API used to indicate a checked menu item. Bug: 421341,879754 Change-Id: Ibf986e4bbe6766d6c60aa96b2cc0f4cb3bea8c3a Reviewed-on: https://chromium-review.googlesource.com/1239874 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593745}
-
David Black authored
Fixes two UI issues: 1. "Nothing found on screen" card was still being clipped despite using border-box box-sizing. Because the border is 1px wide, this is probably caused by pixel rounding when we size our WebView. To work around this we will just add a slight margin to the card to ensure the border is drawn within WebView bounds. 2. When changing screen resolution with the UI open, multiline labels would sometimes not be bounded correctly. To address this, we make sure that the Label width matches parent width. We accomplish this by using STRETCH cross axis alignment on the box layout (which is default cross axis alignment). Bug: b:116001082, b:115585763 Change-Id: Iec80955e45011d73816978c43ddf1235e49b476d Reviewed-on: https://chromium-review.googlesource.com/1241470 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#593744}
-
Artur Khachatryan authored
TakesScreenshotTest tests are now being tracked with the new ChromeDriver bugs. Bug: chromedriver:2594,chromedriver:2595 Change-Id: I4942b660487d86c99c7d38cf59904e288c3d8238 Reviewed-on: https://chromium-review.googlesource.com/1241459 Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593743}
-
Pavel Shmakov authored
Use full classpath for desugar as a temporary measure against the desugaring issue in tests. Bug: 860018, 885273 Change-Id: I0d314dceb31c7df2176bfa6fab452afaa541e22c Reviewed-on: https://chromium-review.googlesource.com/1236434Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593742}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/64f2ed4bb2f1..c51eb628dd91 git log 64f2ed4bb2f1..c51eb628dd91 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 chiniforooshan@chromium.org Telemetry: UI frame time metrics in TBMv2 2018-09-24 chiniforooshan@chromium.org Telemetry: surface flinger metrics in TBMv2 Created with: gclient setdep -r src/third_party/catapult@c51eb628dd91 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553,chromium:760553 TBR=sullivan@chromium.org Change-Id: I62e4f3af9d10e032a30122d510b0dac2438842e7 Reviewed-on: https://chromium-review.googlesource.com/1241528Reviewed-by:
-
Andrew Luo authored
Bug: 884070 Change-Id: I0b7355c29f1c699091537a75ba2f300cff8d7e00 Reviewed-on: https://chromium-review.googlesource.com/1226524 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#593740}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aaf2cc09c687..482d615b83e1 git log aaf2cc09c687..482d615b83e1 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 gab@chromium.org Revert "my_activity: Add review.coreboot.org as a source" 2018-09-24 ajp@chromium.org Revert "git cl upload: print response headers on 404 Gerrit RPC status." Created with: gclient setdep -r src/third_party/depot_tools@482d615b83e1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:888641,chromium:881860 TBR=agable@chromium.org Change-Id: Ie6fea307792db8a9e8d4c06cd509e991985269c4 Reviewed-on: https://chromium-review.googlesource.com/1241595Reviewed-by:
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/win. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=gab@chromium.org Bug: 874080 Change-Id: Icf9c25f614e296b069ce76297ba85b3b8b6e1197 Reviewed-on: https://chromium-review.googlesource.com/1191663 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#593738}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb85aabf9a15..b2070a13fbde Created with: gclient setdep -r src-internal@b2070a13fbde The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id7647b0e35b14522e6b33e6f4cd4db47e7670c19 Reviewed-on: https://chromium-review.googlesource.com/1241527Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593737}
-
Jeremy Klein authored
This allows for another forced retry point for when installation fails. If a user goes into multidevice settings and clicks the "set up" button for Android Messages, it should install the PWA if it hasn't already been installed before trying to launch it. Bug: 874605 Change-Id: I319067d100712b84b4161f5ee281179bd8acbf12 Reviewed-on: https://chromium-review.googlesource.com/1240205 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#593736}
-
Tatiana Buldina authored
Change-Id: I086c920a77cb3bdd5c99d9b7bed6bd790076c469 Reviewed-on: https://chromium-review.googlesource.com/1241933Reviewed-by:
-
John Abd-El-Malek authored
Bug: 887381 Change-Id: I2f0ac7465772e09bf00af224e61ace0a791129fe Reviewed-on: https://chromium-review.googlesource.com/1241278Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#593734}
-
Ken Rockot authored
Changes a DCHECK to a PCHECK in an attempt to help sort out some crashes we see in the wild where the broker process apparently receives handles but doesn't attempt to duplicate them to itself. This should only be possible if it doesn't know a valid handle for the remote (sending) process, which points to potential application raciness in ownership of the process handles passed into Mojo. Bug: 887576 Change-Id: I1f8786af8170b7db03804a98125365eeb44fc598 Reviewed-on: https://chromium-review.googlesource.com/1241197 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593733}
-
Dana Fried authored
Eliminates text rendering artifacts resulting from launching Chrome browser with Windows Text Zoom enabled. ---------- Background ---------- The new Windows Text Zoom accessibility feature scales small text on the screen by an amount in addition to normal DPI scaling. In consultation with MS accessibility engineers, we have decided that rather than doing complex and extensive scaling math in Chrome, we are just going to have the browser scale additionally by that factor. Chrome now scales dynamically with the zoom factor. When we read default system fonts (such as those used by the views::Label class - used by tabs, menu items, bookmarks, etc.), Windows reports the logical size of the font. This does not take DPI into account, but it *does* take the Windows Text Zoom amount into account (for backwards-compatibility with apps that don't read it directly). When the UI renders the text, it scales by the overall browser scale factor (which includes both DPI and Windows Text Zoom). So effectively, if the Text Zoom is set before Chrome starts, all system-default text ends up scaled *twice*. Correct text size (current behavior only if Text Zoom is changed *after* launching Chrome): Text Scale 100% 150% 200% DPI 100% 12 18 24 DPI 150% 18 27 36 DPI 200% 24 36 48 Current text size if Text Zoom is enabled prior to launching Chrome: Text Scale 100% 150% 200% DPI 100% 12 27 48 DPI 150% 18 39 72 DPI 200% 24 54 96 ------------- Patch Details ------------- This change captures the situations in which we ask Windows for a system font (for menus and captions), and removes the additional scaling done by the OS, since we are already taking this into account when rendering text. We already apply scaling for localization in most of these places for similar reasons, so there is a precedent. Chrome still scales appropriately when Text Scale Factor or DPI is set prior to Chrome launch or changed dynamically while Chrome is running. ---------- Follow-Ups ---------- We call GetNonClientMetrics() in a number of plces, and use LOGFONT* structs as well. These are Windows implementation details and should ideally be hidden away from browser code. We should consolidate to a single cache of system fonts, which will internally ensure that the fonts are scaled appropriately (preferably in gfx::PlatformFontWin or similar). Bug: 866513 Change-Id: Ideb248e2f196bb93d46a3f60780c68cf31446097 Reviewed-on: https://chromium-review.googlesource.com/1235313 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Kevin Marshall authored
makesdk.go was deprecated and removed; use artifact tarballs generated from the supported GN/ninja-based SDK build methods instead. Change-Id: I6c3e3eb38451f2d0fbfc8940f3c4d4b5c6e89fef Reviewed-on: https://chromium-review.googlesource.com/1237534Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#593731}
-
Giovanni Ortuño Urquidi authored
We always end up using DBusThreadManagerLinux on Linux and DBusThreadManager on Chrome OS. Rather than having clients pass these when initializing BluezDBusThreadManager, have BluezDBusThreadManager choose which one to use based on the OS. This puts the logic for choosing which one to use in a single place. Bug: 882771 Change-Id: I9c36eb9de8419fd5ac4bc6fbab3ded2738b33d91 Reviewed-on: https://chromium-review.googlesource.com/1237694Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#593730}
-
Mostyn Bramley-Moore authored
We have a few different "features" namespaces, which can collide in subtle and confusing ways, particularly in jumbo builds. The Google C++ Style Guide advises avoiding collisions between nested namespaces and well-known top-level namespaces, and I think "features" qualifies. Let's therefore rename app_list::features to app_list_features. Change-Id: I4fbad5a33b6e5d217924cd008b0f8d9374cf1a43 Reviewed-on: https://chromium-review.googlesource.com/1215023Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#593729}
-
Robert Sesek authored
Bug: 832676 Change-Id: I1a7c9f0834789bbf67692edcd5317d0487905b9f Reviewed-on: https://chromium-review.googlesource.com/1241713Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593728}
-
Chris Sharp authored
Change-Id: I2d5955ad226d16428cc28cc8e0c908663b9346f8 Reviewed-on: https://chromium-review.googlesource.com/1237866Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#593727}
-
Tom Anderson authored
Issue can be triggered by running Chrome with testing/xvfb.py. The check looks like the following: [130960:130960:0921/173814.814345:FATAL:color_utils.cc(356)] Check failed: (((base) >> 24) & 0xFF) == SK_AlphaOPAQUE (0 vs. �) 0 0x7f05478f815d base::debug::StackTrace::StackTrace() 1 0x7f05475ff9ac base::debug::StackTrace::StackTrace() 2 0x7f054766f47a logging::LogMessage::~LogMessage() 3 0x7f0545ec4e19 color_utils::GetBlendValueWithMinimumContrast() 4 0x7f0545ec4d25 color_utils::GetColorWithMinimumContrast() 5 0x7f05319ec298 libgtkui::GtkUi::LoadGtkValues() 6 0x7f05319eb2ae libgtkui::GtkUi::Initialize() 7 0x55847d44a79b ChromeBrowserMainExtraPartsViewsLinux::ToolkitInitialized() 8 0x558478c10b15 ChromeBrowserMainParts::ToolkitInitialized() 9 0x558478c0a9c5 ChromeBrowserMainPartsLinux::ToolkitInitialized() 10 0x7f0540a4b64d content::BrowserMainLoop::InitializeToolkit() 11 0x7f0540a4e7b5 content::BrowserMainRunnerImpl::Initialize() 12 0x7f0540a39a6b content::BrowserMain() 13 0x7f05428fefe4 content::RunBrowserProcessMain() 14 0x7f05429018cb content::ContentMainRunnerImpl::Run() 15 0x7f05428f67cc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() 16 0x7f0547ba37fa service_manager::Main() 17 0x7f05428fca23 content::ContentMain() 18 0x558476d46246 ChromeMain 19 0x558476d46152 main 20 0x7f051c7152b1 __libc_start_main 21 0x558476d4602a _start R=pkasting Change-Id: Ib6d421dc3cd0f8fb9a41afd4b1487548404f58f0 Reviewed-on: https://chromium-review.googlesource.com/1238487Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#593726}
-
Robert Sesek authored
Bug: 832676 Change-Id: Ib83450567e95f83f819980fccb2ea81c6be2a326 Reviewed-on: https://chromium-review.googlesource.com/1241496Reviewed-by:
-
Michael Ludwig authored
Bug: 888675 Change-Id: I511958c73dec8caf1c04daf582f7cc4e0752b745 Reviewed-on: https://chromium-review.googlesource.com/1241016Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#593724}
-
Ted Meyer authored
Bug: 881922 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9298701a3790ca2b7c9aaf43a6c9ce6c1abaa74c Reviewed-on: https://chromium-review.googlesource.com/1241556 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593723}
-
Brian White authored
Most of the observed crashes are enumeration (aka "linear") ones for "cast" that are apparently differences between extensions. Behave in the expected fashion (return dummy histogram) for those so as to not impact users unnecessarily. Bug: 836238 Change-Id: I5f68146be7a5988c4b529d54861bb215869fac2b Reviewed-on: https://chromium-review.googlesource.com/1241495 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#593722}
-
Danyao Wang authored
TabModelTest.AddWithOrderControllerAndGrouping is converted into TabOrderTestCase/testChildTabOrdering. TabModelTest.AddWithLinkTransitionAndIndex is removed because the behavior it tests, i.e. child tabs being inserted before parent tab, is not possible using public interfaces. Child tabs are always inserted after the parent tab. The original tests use NavigationManager::CommitPendingItem() with a test server. This is no longer possible with WKBasedNavigationManagerImpl. Updating the original tests to use embedded test server was rejected because TabModel is a deprecated class. Converting them to EG test allows the behavior to be tested with WKBasedNavigationManager and during a future removal of TabModel. Bug: 863026 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia8f2b604cab93cba38142cac384a356153e95d9b Reviewed-on: https://chromium-review.googlesource.com/1240741 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593721}
-
