- 16 Feb, 2018 40 commits
-
-
Robert Flack authored
There are multiple accessibility notifications but the test should only continue when it receives the one for the programmatic scroll. This patch also fixes another use after free from trying to use the smooth scroll coordinator. Bug: 797298,812702 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1340d8cd1d5d3e53e75d9ab0c5f50b523041b187 Reviewed-on: https://chromium-review.googlesource.com/922685 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537317}
-
Leonard Grey authored
Change-Id: I7e2aa4037ef014ccc9b5943ef01c005f58139000 Reviewed-on: https://chromium-review.googlesource.com/922762Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#537316}
-
Evan Stade authored
TBR=rdevlin.cronin@chromium.org Bug: 578868 Change-Id: I362564a5469fedd7f16024303b8dfd54046da8b1 Reviewed-on: https://chromium-review.googlesource.com/917527 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#537315}
-
Amirhossein Simjour authored
Fling is not consumed by content anymore, so we can remove it from the controller. BUG=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I85c958e4e8b4ca2dde4f20948978bebfad732543 Reviewed-on: https://chromium-review.googlesource.com/919544 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#537314}
-
Sylvain Defresne authored
Refactor IOSChromeBrowsingDataRemover to have a queue of pending removals (based on similar refactor that happened to BrowsingDataRemover in //content). Remove helper class BrowsingDataRemoverHelper as it is now redundant (it implemented the pending removal tasks queue). Change IOSChromeBrowsingDataRemover from thread-affinity to sequence-affinity (as is recommended). Fix references to old enumeration RemoveDataMask. Bug: none Change-Id: I4d18b2d0db59954af723e72af034b57acdc7e85d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/918666 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537313}
-
Troy Hildebrandt authored
This reverts commit 6df08e7d. Reason for revert: Tests fail on K tablet. TBR=tedchoc@chromium.org Original change's description: > [Android] Show voice search icon alongside delete button in omnibox. > > Allows the voice search button to display alongside the delete icon in > the omnibox, as long as voice search is enabled. Hides the feature > behind a flag. > > Bug: 807726 > Change-Id: I3695222b9ca0f74673ca286e052b121fdfde924b > Reviewed-on: https://chromium-review.googlesource.com/896002 > Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537289} TBR=mariakhomenko@chromium.org,tedchoc@chromium.org,thildebr@chromium.org Change-Id: Iac939cc82ba49be164bdfcf0f2be9c7c20136213 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807726 Reviewed-on: https://chromium-review.googlesource.com/923423Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537312}
-
Raymond Toy authored
Replace the tests that are using ScriptProcessor and online contexts with an offline context and verify all the output values instead of just one. This change exposed a couple of issues: - setTargetAtTime wasn't actually testing setTargetAtTime because a linearRampToValueAtTime event was called at the same time, effectively replacing the setTargetAtTime event - linearRampToValue and exponentialRampToValue tests expose bugs in Chrome's implementation of these when the event is scheduled in the past, and there is no preceding event. Bug: 812285, 626703 Change-Id: Iad3f54dd4373411431c019de44d4c3bad07587ff Reviewed-on: https://chromium-review.googlesource.com/919151 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537311}
-
Francois Doray authored
Some code in Chrome needs to change the window tree in response to a change of visibility for a WebContents (e.g. close zoom bubble, create a new RenderWidgetHostViewAura). Because of that, we need to allow changes to the window tree from aura::WindowDelegate::OnWindowOcclusionChanged(). With this CL, aura::Window::SetOcclusionState() is not called immediately when the occlusion of a tracked window is computed. Instead, we compute occlusion for all tracked windows. Then, we call aura::Window::SetOcclusionState() on all tracked windows. Having separate phases ensures that the window tree is not modified while occlusion is being computed. If a call to aura::Window::SetOcclusionState() in the 2nd phase changes the window tree in a way that could affect occlusion, we go back to phase 1. There is a hard cap of 2 iterations, after which we crash. Bug: 668690, 813076 Change-Id: I61e5cdbb605343a5b587aeb96effcbd8dc07de33 Reviewed-on: https://chromium-review.googlesource.com/861953 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#537310}
-
Charlie Andrews authored
TBR=ashleymarie@chromium.org NOTRY=true Bug: 812615 Change-Id: Ib89c68b30e3b0f33eded7e35572dd71208d60a4d Reviewed-on: https://chromium-review.googlesource.com/922788Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537309}
-
Charlie Andrews authored
TBR=chiniforooshan@chromium.org NOTRY=true Bug: 812618 Change-Id: I626b76647aa5dd8b85f681ca9d33c0f10cf24931 Reviewed-on: https://chromium-review.googlesource.com/922911Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537308}
-
Gabriel Charette authored
As requested @ https://chromium-review.googlesource.com/c/chromium/src/+/738469/8/docs/design/threading.md#b122 Already had "Keep the Browser Responsive" and "Use Sequences instead of Locks" sections, but amended them with a bit more text from the old docs. R=jam@chromium.org Bug: 752144 Change-Id: I67857ad21f8cc5884aeb65fe08fe184f63deed44 Reviewed-on: https://chromium-review.googlesource.com/921041Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537307}
-
Rune Lillesveen authored
We currently don't compute style for elements being reattached in the style recalc step when the element has custom style callbacks. The reason is that some CustomStyleForLayoutObject() implementations rely on ancestor elements being attached. Here, we stop relying on SVG corresponding elements having a LayoutObject by retrieving ComputedStyle from the Node instead. If the parent element is being (re-)attached, we will get the non-attached style through Node::GetComputedStyle(). Bug: 813057 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I18b6a41087836746869071a409841692fa168537 Reviewed-on: https://chromium-review.googlesource.com/923732Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537306}
-
Francois Doray authored
base::GetFieldTrialParams() used not to work in child processes. For that reason, we built a system to pass scheduler field trial params to renderers on the command line. Now that base::GetFieldTrialParams() works fine in child processes (https://cs.chromium.org/chromium/src/content/app/content_main_runner.cc?l=160&rcl=9030625190ec0a2b60be2af279bcb234f47d3f51), we don't need to use that system anymore. TBR=rohitrao@chromium.org Bug: 810049 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic40653eece1a103a9c913cb286925061fed1121c Reviewed-on: https://chromium-review.googlesource.com/909169 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#537305}
-
Daniel Bratell authored
third_party/OpenSSL and msi.h both indirectly define X509_NAME so to have avoid them clashing, tell msi.h to not include wincypt.h where X509_NAME is set. This became a problem in jumbo builds where msi_util_win.cc was grouped with code using browser_process.h which includes openssl headers. Bug: 746957 Change-Id: Ibaaf60ab6b5b46f9a86e90e0f5a7de9d4ecd57d7 Reviewed-on: https://chromium-review.googlesource.com/924072Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#537304}
-
Thomas Tangl authored
This CL replaces the turn-on-sync illustration in the user menu with a new asset. The code to create the signin/turn-on-sync view is refactored and the spacing is adjusted. Bug: 811510 Change-Id: Ifd2155a20c79918b046eca96b94ccb59481ce5d1 Reviewed-on: https://chromium-review.googlesource.com/919281 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#537303}
-
Tommy C. Li authored
This CL: 1. Refactors AutocompleteMatch so that we can't accidentally swap the contents and description of matches stored in the model code. 2. Consolidates some swapping behavior living in the UI code in with the rest of the swapping behavior. 3. Fixes ZeroSuggest swapped title and description for Cocoa. Bug: 807702 Change-Id: Ibb17860122a52a9fba7df707ab2c18ac327297ac Reviewed-on: https://chromium-review.googlesource.com/912101Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#537302}
-
Elad Alon authored
1. WebRtcRemoteEventLogManager did not always update the counts for active and pending logs correctly; this CL fixes the issue. For that fix, it was necessary to put the BrowserContextId as part of the PeerConnectionKey, so that when a log file is closed, we would be able to decrement the active logs count for that BrowserContext. 2. The opportunity is also taken to restructure some of the code: a. The internal methods now operate on PeerConnectionKey, rather than accept the render_process_id and lid separately. b. Additional DCHECKs were added to verify that the log count remains consistent. c. Removed the assumption that DisableForBrowserContext() would only be called during Chrome shutdown. Bug: 775415 Change-Id: I33c327e2160b3035f6d413262b54b10887b37454 Reviewed-on: https://chromium-review.googlesource.com/918682 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#537301}
-
Stephen McGruer authored
This consolidates Chrome's behavior to be consistent everywhere CompositeOperations are parsed, and to match Firefox. When a CompositeOperation is found that we don't support, it is silently replaced with kCompositeReplace. When running without WebAnimationsAPI, developers should only expect to have kCompositeReplace animations. When running with WebAnimationsAPI, developers can detect which composite is in use by either querying: effect.composite; OR effect.getKeyframes(); // Check each keyframe for a keyframe-specific composite value. Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wRsafuGKr5w Bug: 806139 Change-Id: I80fefff3fc833b62787c57d22cbec656365ec374 Reviewed-on: https://chromium-review.googlesource.com/896807 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#537300}
-
Marti Wong authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I19ac155dd3d809ccd5e770dc67fc5db5dc4679a2 Reviewed-on: https://chromium-review.googlesource.com/923505 Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#537299}
-
Gustav Sennton authored
We cannot hold onto a lock that could potentially block the UI thread, while calling into any getter in WebViewChromiumAwInit related to chromium initialization. This is because those getters 1. hold a lock, 2. post a chromium-initialization task to the UI thread, and then 3. wait for the task to finish after releasing the lock in 1 So if thread X holds another lock, and calls a WebViewChromiumAwInit getter, a deadlock occurs if the UI thread tries to hold onto that other lock before running the chromium-initialization task. We fix this issue by providing a getLock() method on WebViewChromiumAwInit for WebViewChromiumFactoryProvider to re-use the existing lock to guard its member variables (instead of using another lock). Bug: 812203 Change-Id: I2e8d69f2667bce1e4312cc821fc804d44b6deaba Reviewed-on: https://chromium-review.googlesource.com/922823 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537298}
-
Dmitry Iljinskiy authored
Bug: 812531 Change-Id: I0a9d54b28ef7e17d94358a692f7a2259130210a1 Reviewed-on: https://chromium-review.googlesource.com/920991Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#537297}
-
Sylvain Defresne authored
Add a completionBlock parameter to ClearBrowsingDataCommand and use it to wait for the completion of the browsing data removal in BrowserStateDataRemover. This allow removing the circular dependency between i/c/b/signin and i/c/b/browsing_data and to simplify code. Bug: none Change-Id: I6ee62201dd321a453be8d7d6d588a8e713735d5f Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/916607 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537296}
-
Olivier Robin authored
Running glint and clang-format on JavaScript files. Bug: 487804, 802170 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic13a1a141b74b761b83d5aee20c0f4bff384b57b Reviewed-on: https://chromium-review.googlesource.com/919263Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537295}
-
Hiroki Nakagawa authored
Lock annotations mechanism was ported from Abseil in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/885506 This mechanism provides Clang's built-in support for static lock analysis. This would be really useful for workers, especially WorkerThread. Bug: 812222 Change-Id: I88d4e24ea8a2d93edf126d61148d4c7aec060901 Reviewed-on: https://chromium-review.googlesource.com/919321Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#537294}
-
Hajime Hoshi authored
This is part of efforts to replace default timer task runners with other appropriate task runners in the renderer. Note that this CL adds a usage of default timer task queue via WebThread ::GetTaskRunner(), but I think this is inevitable. Bug: 624694, 804694 Change-Id: I3a18dc9908850096050de16c66f3c78aa0e3c666 Reviewed-on: https://chromium-review.googlesource.com/923833Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537293}
-
Greg Kraynov authored
TaskQueueSelector had the logic to report when a task was prevented from running due to one of RendererScheduler's interventions. This feature is deprecated and now removed for sake of simplicity. Bug: 783309 Change-Id: I0debabf6a9c340bacf780a03259006449006292e Reviewed-on: https://chromium-review.googlesource.com/921963 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537292}
-
Morten Stenshorne authored
There were two problems: 1. We determined start/end inline margins from the direction of the child, while we should use that of the containing block. 2. We applied alignment based on text-align:-webkit-{left,right} even if there was an auto inline-end margin (so that we would override it). Standard CSS declarations should take precedence over legacy HTML align attributes (which is where text-align:-webkit-{left,center,right} typically come from). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib0a22a6293b4b2b2668d09453db16b42ef9ff258 Reviewed-on: https://chromium-review.googlesource.com/922664 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#537291}
-
Ramin Halavati authored
Network Traffic Annotation Auditor adds the following switch when calling the clang tool: '-Wno-tautological-unsigned-enum-zero-compare' Also to be faster, auditor does not rerun the clang tool to get errors when called in error resilient mode. Bug: 690323 Change-Id: Ie099b902395da5c4bb9526925d71b6dd4b94c290 Reviewed-on: https://chromium-review.googlesource.com/924061 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#537290}
-
Troy Hildebrandt authored
Allows the voice search button to display alongside the delete icon in the omnibox, as long as voice search is enabled. Hides the feature behind a flag. Bug: 807726 Change-Id: I3695222b9ca0f74673ca286e052b121fdfde924b Reviewed-on: https://chromium-review.googlesource.com/896002 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#537289}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/ca216e493f32..41172a24016b This CL also adds Clang thread safety annotations [1] to Chrome's leveldb::port::Mutex. This can't be done in a separate CL because the primitives are used in Chrome code that is compiled with -Wthread-safety turned on. [1] https://cs.chromium.org/chromium/src/base/thread_annotations.h $ git log ca216e493..41172a240 --date=short --no-merges --format='%ad %ae %s' 2018-02-13 costan Enable thread safety annotations in open source version. 2017-10-25 cmumford Add leveldb_options_set_max_file_size to the C API. 2017-10-23 cmumford Fixed style guide link in CONTRIBUTING.md 2017-10-19 cmumford Deleted unused assignments in Reader. 2017-10-17 cmumford leveldb::DestroyDB will now delete empty directories. 2017-10-10 costan Fix typo (forgotten reference operator) in test. 2017-10-10 costan Replace SSE-optimized CRC32C in POSIX port with external library. Created with: roll-dep src/third_party/leveldatabase/src Change-Id: I68dc2799673a93253bc338b141e0945b11db097a Reviewed-on: https://chromium-review.googlesource.com/920773Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#537288}
-
Yuta Kitamura authored
We no longer have WebTaskRunner, and the function is now essentially identical to GetSingleThreadTaskRunnerForTesting(). This patch removes CreateWebTaskRunnerForTesting() along with its helper class, and migrates all the call sites to GetSingleThreadTaskRunnerFor- Testing(). Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I11094734d79aca4dbf4d7b191df6adb76cce19c1 Reviewed-on: https://chromium-review.googlesource.com/923869Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#537287}
-
Jan Krcal authored
In addition to setting request priority in the request itself, add it as a get parameter to the fetch url. This is needed for load shedding later. Bug: 809986 Change-Id: I4d6520218d6ef9d25feada409cf894485e3e2872 Reviewed-on: https://chromium-review.googlesource.com/913618Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#537286}
-
Thomas Tangl authored
This CL adds a submenu arrow to the "Sync to another account" button in the user menu to match the mocks under: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr68h8u9rYJdKa9KgqJ7geGGg Bug: 786369 Change-Id: I9c3bad79535ba69bd1dc3bdf775fb059c608bba9 Reviewed-on: https://chromium-review.googlesource.com/919483 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#537285}
-
Daniel Bratell authored
Of the code pieces left to add jumbo support to, the one which benefit the most from jumbo is //chrome/browser:browser which goes from 90 to 10 CPU minutes, a reduction of more than a CPU hour. This is about 10% of the total effort compiling chrome+content_shell+blink_tests. In jumbo builds many cc files compile in the same translation unit which reduces the time spent generating debug data and machine code for headers, as well as the time to actually process the headers. Bug: 746957 Change-Id: I856f3fca1f16fa2b0738678444c455c303985962 Reviewed-on: https://chromium-review.googlesource.com/899368Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#537284}
-
Olga Sharonova authored
1) Audio service is embedded into /content. For that DeferredSequencedTaskRunner for Audio service is introduced in BrowserMainLoop. This task runner is passed into AudioServiceContext and queues all the requests to the Audio service and its factory until it is started. And it is started after AudioManager is created in BrowserMainLoop::BrowserThreadsStarted(). 2) audio::CreateAudioSystem() is introduced as a replacement to media::AudioSystem::CreateInstance(). At this point it still creates media::AudioSystemImpl instance. This CL does not change execution path, and (hopefully) should not be a source of regressions. The actual switch to using Audio service and audio::AudioSystemToServiceAdapter happens in the follow-up https://chromium-review.googlesource.com/c/chromium/src/+/918901. So if something breaks https://chromium-review.googlesource.com/c/chromium/src/+/918901 should be reverted first (and most likely that should be enough). Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie69df7bf9f593fda6a2e85f5f57a49a90aeccdb9 Bug: 792441 Reviewed-on: https://chromium-review.googlesource.com/875927Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#537283}
-
Alex Clarke authored
We incorrectly assumed it was called only once. This patch fixes that assumption. Change-Id: I9d8e624634260ca1e352d9419e84b52e64e627a4 Reviewed-on: https://chromium-review.googlesource.com/921082 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537282}
-
Manish Jethani authored
This is the first in a series of patches to implement tabs.removeCSS A style sheet injected with tabs.insertCSS will have an internal autogenerated "key" that will be passed to StyleEngine. In the case of files, this will likely be just the fully qualified name of the file, whereas in the case of code it could be the code string itself or a hash digest of the code string. In either case, a call to tabs.removeCSS with the same options will deterministically generate the same internal key, thus enabling the removal of a previously injected style sheet without the explicit use of IDs and such. This patch lays the groundwork in StyleEngine that will enable us to implement behavior similar to that observed in Firefox 57.0. Changes: 1. WebStyleSheetId is now WebStyleSheetKey (WebString) 2. WebDocument::InsertStyleSheet now accepts an optional key as a parameter 3. StyleEngine::InjectSheet and StyleEngine::RemoveInjectedSheet now take StyleSheetKey (AtomicString) instead of WebStyleSheetId 4. Both WebDocument::RemoveInsertedStyleSheet and StyleEngine::RemoveInjectedSheet now take the CSS origin as a parameter 5. StyleEngine::RemoveInjectedSheet now removes only the last style sheet injected with the given key and only from the specified CSS origin BUG=608854 Change-Id: Ie62bfcb0d8309b18cbf0d2cd119c74908e396767 Reviewed-on: https://chromium-review.googlesource.com/877663Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manish Jethani <m.jethani@eyeo.com> Cr-Commit-Position: refs/heads/master@{#537281}
-
Takayoshi Kochi authored
kLegacyUserAgentV0 type is gone, and now 2 bits are enough to hold the type for ShadowRoot, instead of 3. Bug: 787717 Change-Id: I64b00c9ac79d8d43830ac94cb5bd013a9043dcca Reviewed-on: https://chromium-review.googlesource.com/923783Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537280}
-
Christos Froussios authored
TBR=jcivelli@chromium.org Bug: 812998 Change-Id: I34b710517d8c6b066e9f66d6f98863194046ddfd Reviewed-on: https://chromium-review.googlesource.com/923942Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#537279}
-
Mostyn Bramley-Moore authored
This fixes jumbo builds after https://chromium-review.googlesource.com/923604 Change-Id: Ib7030da7e0a6acfdad8200564f9375ba218e8ca6 Reviewed-on: https://chromium-review.googlesource.com/923723Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#537278}
-