GitLab

Breaks chrome_frame_tests on Win Aura.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=chrome_frame_tests&builder=Win%20Aura%20Tests%20(1)

> Add UMA to report Preferences File Corruption
> Adds PrefMetricsService methods to track changes to user preferences
> that happen outside of Chrome and report discrepancies via UMA.
> 
> BUG=266569
> 
> Review URL: https://chromiumcodereview.appspot.com/22676002

TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/23597020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285016
TEST=YouTube playback works for videos that are available in the VP9 format.

Review URL: https://chromiumcodereview.appspot.com/23463020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221964 0039d316-1c4b-4281-b951-d872f2087c98

BUG=269131
TEST=none
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23851009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=none, no functional changes.
R=erg@chromium.org
TBR=thestig # for gyp change.

Review URL: https://chromiumcodereview.appspot.com/23743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221962 0039d316-1c4b-4281-b951-d872f2087c98

It allows us to run an experiment where only chrome.dll is instrumented.

TBR=chrisha@chromium.org, gab@chromium.org
CC=laforge@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23719017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221961 0039d316-1c4b-4281-b951-d872f2087c98

Replace --enable-device-discovery flags with --disable-device-discovery.

BUG=286157

Review URL: https://chromiumcodereview.appspot.com/23567023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221960 0039d316-1c4b-4281-b951-d872f2087c98

I don't think this is related to the crash I'm seeing, but I noticed
it when looking for dangling TabStripModelObservers.

BUG=286162
TEST=none
R=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23547006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221959 0039d316-1c4b-4281-b951-d872f2087c98

The URLRequestJob interface this forwards to is const, and marking URLRequest::GetResponseCode() as const allows passing the URLRequest as const in some cases.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23494023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221958 0039d316-1c4b-4281-b951-d872f2087c98

The size of the print preview should be based off of the available
area for dialogs, not the size of the web contents view.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23460022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221957 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23454015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221956 0039d316-1c4b-4281-b951-d872f2087c98

The number of missing packets between the current received packet and the
previously largest received packet sequence number, when the current
received packet had a lower sequence number than the previously received
packet sequence number.

Review URL: https://chromiumcodereview.appspot.com/23451015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221955 0039d316-1c4b-4281-b951-d872f2087c98

breaks XP Tests:
ActivityLogPrerenderTest.TestScriptInjected
FindInPageTest.PrepopulateRespectBlank
KeyboardAccessTest.TestAltMenuKeyboardAccessFocusOmnibox
KeyboardAccessTest.TestMenuKeyboardOpenDismiss

> Switch all windows bots to use Aura.
> 
> Because we've been shipping Aura to canary for a while. And because force compositor landed 40 hours ago and things seem ok. See https://codereview.chromium.org/23874016/
> 
> This also allows to see perf numbers for Aura. 
> 
> This has happened before see for example r204698, r211007 and 214056 as an experiment but this time it might stick.
> 
> BUG=259185
> TEST=none
> TBR=scottmg
> 
> Review URL: https://codereview.chromium.org/23816007

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/23523035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221952 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221948 0039d316-1c4b-4281-b951-d872f2087c98

Turn on the --enable-spatial-navigation flag, and also bubble up
unhandled DPAD events to the neighboring views in the view tree.
Likewise, WebContentsDelegate::TakeFocus() bubble to logical next
or previous neighbor view.

Also disabled the FileSystem API while in the area updating flags.

BUG=286698

Review URL: https://chromiumcodereview.appspot.com/23619024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221946 0039d316-1c4b-4281-b951-d872f2087c98

Consolidate common parts of VideoCaptureCapability and VideoCaptureParams into VideoCaptureFormat, renamed frames_per_second->frame_rate for all; 
VideoCaptureParams and VideoCaptureCapability changed to classes, since they have constructors.

Format extracted from VideoCaptureCapability and renamed to VideoPixelFormat (otherwise simply called "media::Format" ). Individual color "formats" renamed like kI420 -> PIXEL_FORMAT_I420, etc.


VideoCaptureFormat::isValid and VideoCaptureParams::isValid implementation.


BUG=260572
BUG=260220

Review URL: https://chromiumcodereview.appspot.com/22876027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221945 0039d316-1c4b-4281-b951-d872f2087c98

Adds PrefMetricsService methods to track changes to user preferences
that happen outside of Chrome and report discrepancies via UMA.

BUG=266569

Review URL: https://chromiumcodereview.appspot.com/22676002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221944 0039d316-1c4b-4281-b951-d872f2087c98

Added BookmarkUndoService that is owned by the profile to provide
multi-level undo and redo for bookmark changes.

This is a staged commit of a larger feature.

The code is not invoked anywhere other than the provided tests so
there should be no impact on the application at this time.
Further integration will continue in future commits.

BUG=126092

Review URL: https://chromiumcodereview.appspot.com/19287013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221943 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg

Review URL: https://codereview.chromium.org/23693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221940 0039d316-1c4b-4281-b951-d872f2087c98

> Refactor KeySystems code to call a function to populate the info.
> 
> This allows KeySystems to call GetContentClient()->AddKeySystems() so we can
> move key system information to chrome/. The new ContentClient API is defined and
> called, but we still rely on key_systems_info.cc.
> 
> BUG=224793
> TEST=Existing content_unittests and content_browsertests pass.
> 
> Review URL: https://chromiumcodereview.appspot.com/23678008

It broke chromeOs compile:

FAILED: g++ -MMD -MF obj/content/renderer/media/crypto/content_renderer.key_systems_info.o.d -DCONTENT_IMPLEMENTATION -DANGLE_DX11 -DWTF_VECTOR_INITIAL_SIZE=4 -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DENABLE_RLZ -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1 -DFILE_MANAGER_EXTENSION=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGL_GLEXT_PROTOTYPES -DLIBPEERCONNECTION_LIB=1 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DCHROMEOS -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_LINUX -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -Igen -I../../third_party/khronos -I../../gpu -Igen/content -I../../third_party/skia/src/core -I../../skia/config -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../v8/include -I../../third_party/webrtc/modules/interface -I../../third_party/webrtc/modules/audio_device/include -I../../net/third_party/nss/ssl -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -g -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -O2 -fno-ident -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare  -c ../../content/renderer/media/crypto/key_systems_info.cc -o obj/content/renderer/media/crypto/content_renderer.key_systems_info.o
../../content/renderer/media/crypto/key_systems_info.cc: In function 'void content::AddPepperBasedWidevine(std::vector<content::KeySystemInfo>*)':
../../content/renderer/media/crypto/key_systems_info.cc:104:23: error: invalid conversion from 'int' to 'content::SupportedCodecs' [-fpermissive]
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/57998/steps/compile/logs/stdio



TBR=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/23578015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221939 0039d316-1c4b-4281-b951-d872f2087c98

Because we've been shipping Aura to canary for a while. And because force compositor landed 40 hours ago and things seem ok. See https://codereview.chromium.org/23874016/

This also allows to see perf numbers for Aura. 

This has happened before see for example r204698, r211007 and 214056 as an experiment but this time it might stick.

BUG=259185
TEST=none
TBR=scottmg

Review URL: https://codereview.chromium.org/23816007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221936 0039d316-1c4b-4281-b951-d872f2087c98

> [OSX] Turn on canvas_skia for OSX
> 
> BUG=151935
> 
> Review URL: https://chromiumcodereview.appspot.com/23456020

This broke mac compile:

FAILED: clang++ -MMD -MF obj/ui/gfx/ui_unittests.canvas_unittest_mac.o.d -DANGLE_DX11 -DWTF_VECTOR_INITIAL_SIZE=4 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DSKIA_DLL -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -I../.. -I../../third_party/skia/src/core -I../../skia/config -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/skia/include/utils/mac -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libpng -I../../third_party/zlib -Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources -isysroot /Developer/SDKs/MacOSX10.6.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unused-function -Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -fstack-protector-all -fobjc-call-cxx-cdtors  -c ../../ui/gfx/canvas_unittest_mac.mm -o obj/ui/gfx/ui_unittests.canvas_unittest_mac.o
../../ui/gfx/canvas_unittest_mac.mm:12:10: fatal error: 'ui/base/range/range.h' file not found
#include "ui/base/range/range.h"
         ^
1 error generated.
ninja: build stopped: subcommand failed.


TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/23622022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221934 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23809008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221933 0039d316-1c4b-4281-b951-d872f2087c98

This allows KeySystems to call GetContentClient()->AddKeySystems() so we can
move key system information to chrome/. The new ContentClient API is defined and
called, but we still rely on key_systems_info.cc.

BUG=224793
TEST=Existing content_unittests and content_browsertests pass.

Review URL: https://chromiumcodereview.appspot.com/23678008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221932 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286542

Review URL: https://chromiumcodereview.appspot.com/23480046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=151935

Review URL: https://chromiumcodereview.appspot.com/23456020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221930 0039d316-1c4b-4281-b951-d872f2087c98

R=bevc@chromium.org

Review URL: https://codereview.chromium.org/23449028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=264429

Review URL: https://chromiumcodereview.appspot.com/24029004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221928 0039d316-1c4b-4281-b951-d872f2087c98

I'm working on this.

BUG=144783
TEST=checkdeps.py succeeds
R=sky@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23927008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221927 0039d316-1c4b-4281-b951-d872f2087c98

Use the main message loop for async operations in FileStream tests. Previously they were scheduled in base::WorkerPool.

Removes dependency on deprecated code and plugs memory leaks.

BUG=248513
R=rsleevi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23872004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221926 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221925 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157404:157409&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23736007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=275343
TEST=open chrome, navigate to chrome://settings/importData, select the
bookmarks option from the combobox, uncheck the "Favorites" checkbox, observe
that the "Choose ..." button isn't enabled anymore, check it, it becomes enabled
again.
R=dubroy@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23717032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221923 0039d316-1c4b-4281-b951-d872f2087c98

BUG=273203

Review URL: https://chromiumcodereview.appspot.com/23649002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221922 0039d316-1c4b-4281-b951-d872f2087c98

- Printers now have printer icon next to them
- Text before the registration step refers to "devices" rather than "printers"

BUG=286157
TBR=thestig

Review URL: https://chromiumcodereview.appspot.com/23447013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221921 0039d316-1c4b-4281-b951-d872f2087c98

Add GetPluginRefererURL to PPB_URLUtil_Dev interface to get the 'Referer' HTTP header value that was sent by request that loaded plug-in. 
Sometimes Pepper plug-in needs to create additional HTTP request to its source URL (for example, PDF plug-in downloads parts of the file using HTTP Range requests). These requests will fail for servers that check Referer header (example: http://fs51.www.ex.ua/get/96354baf7547114fa116c56ecdbdb3ee/66511913/FRoziner_Iskusstvo_Ciurlionisa_1993.pdf).

Review URL: https://chromiumcodereview.appspot.com/23444004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221920 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92948

Review URL: https://chromiumcodereview.appspot.com/23245003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221919 0039d316-1c4b-4281-b951-d872f2087c98

ServiceDiscoveryHostClient now listens for IP address changes (and, by
extension, sleep/wake) and flushes the cache and resets the utility process.

BUG=284673

Review URL: https://chromiumcodereview.appspot.com/23851008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221914 0039d316-1c4b-4281-b951-d872f2087c98

Added UMA actions for devices page, including for when it is opened, when "add
printers" is clicked, when "register" is clicked, when a registration is
canceled, when a registration fails, and when a registration succeeds.

BUG=286157

Review URL: https://chromiumcodereview.appspot.com/23508003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221913 0039d316-1c4b-4281-b951-d872f2087c98

BUG=258612
TEST=email address appears under billing address section (in Autofill mode) and
     is still filled correctly (in both modes)

R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23579009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221912 0039d316-1c4b-4281-b951-d872f2087c98

Allow code coverage bots to set --jobs to 1 to avoid bottleneck running tests.  This will overrides --use-less-jobs and -j1.

Review URL: https://chromiumcodereview.appspot.com/24059002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221911 0039d316-1c4b-4281-b951-d872f2087c98