GitLab

https://chromium.googlesource.com/angle/angle.git/+log/d0e56cc64289..66e0feec40dc

git log d0e56cc64289..66e0feec40dc --date=short --no-merges --format='%ad %ae %s'
2019-09-05 jmadill@chromium.org Remove default template args in ResourceMap.

Created with:
  gclient setdep -r src/third_party/angle@66e0feec40dc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org,jmadill@google.com

Bug: None
Change-Id: I2f5e5b37a9eaba61157c8965157592d3fd4a66d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787850Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693861}

Also, enable the flag for all channels except stable.

Bug: b:130798103
Test: android-sh -c getprop | grep ro.boot.arc_print_spooler
Change-Id: I4ca45c248737bbc0e5c90ed679bfe2b77ec9ed12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784006Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693860}

Added following histograms recording for USS Nigori (same as we have
for Directory implementation):
Sync.PassphraseType
Sync.CryptographerReady
Sync.CryptographerPendingKeys
Sync.KeystoreDecryptionFailed
Sync.CustomEncryption

There are some remaining histograms, which we should add later:

Together with full SCRYPT support:
Sync.Crypto.CustomPassphraseKeyDerivationMethodOnNewPassphrase
Sync.Crypto.CustomPassphraseKeyDerivationMethodOnSuccessfulDecryption
Sync.Crypto.CustomPassphraseKeyDerivationMethodStateOnStartup

Together with ping-pong prevention:
Sync.AutoNigoriOverwrites

Together with conflict resolution:
Sync.ResolveSimpleConflict

Bug: 922900
Change-Id: Ia5d6886ea7dd2855cf2240ffd14780c6158b7550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787600Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#693859}

Currently there are two methods, OnProfileAdded (to replace
NOTIFICATION_PROFILE_ADDED and NOTIFICATION_PROFILE_CREATED) and
OnProfileMarkedForPermanentDeletion (to replace
NOTIFICATION_PROFILE_DESTRUCTION_STARTED).

Use the new interface in NoteTakingHelper and ExtensionService.

Another option would be to have OnProfileMarkedForPermanentDeletion
be a part of a ProfileObserver interface, but it seems best to
minimize the number of observer interfaces.

Bug: 268984
Change-Id: I96ba72e558ee3da30729207adcd8e22e0755293a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776682
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693858}

Also some slight refactoring.

Bug: 997768
Change-Id: I25c6f2815c12b6de5c737fd9f6831149a92b7675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783663Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693857}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/printing.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug: 891670
Change-Id: I6077f3d2fb31e4fa16a64be3cf209e25ef2998db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787179
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693856}

Noticed this while testing triggers. :)

Change-Id: Ib12f289bdc3bbf9cd96516c4f32d16b257102345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787323
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693855}

This CL updates the strings to follow the latest spec.

Bug: 954228
Test: builds
Change-Id: Ibe49b3dea0bfecbb1413d78079ddf5d9c4d3d90f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787764Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693854}

Bug: 988276, 860467
Change-Id: Ic5f69b9b6216b3bf812769369cef26cf2828d794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787325Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693853}

Bug: 856601
Change-Id: Ic16d0527736d4b0bc5aa05f4a168cbb857c67485
TBR: robertma@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788137Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693852}

Some web sites (e.g., salesforce.com) modifies the prototype of
AsyncFunction object, causing errors in Execute Script endpoint.
The CL works around this issue by avoid directly using AsyncFunction
object.

Bug: chromedriver:3103
Change-Id: If328aab279bd818f5766381cc537d9612674599c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785738Reviewed-by: Rohan Pavone <rohpavone@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693851}

This reverts commit a9ef3160.

Reason for revert: Breaks right click in other contexts.

Original change's description:
> Allow a Frame Background Context Menu on Mac
>
> This brings the frame context menu available on other platforms to Mac
> and allows users to restore the previously closed tab within the
> tabstrip.
>
> BUG=997637
>
> Change-Id: Iaff4cbb6066e52a6ffc969d030b9351051a7a1f6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779019
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693229}

TBR=ellyjones@chromium.org,robliao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 997637, 1001021
Change-Id: I9a154b7ca387371f188a1790f9af1b7ac2910075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787445
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693850}

This reverts commit 48327f50.

Reason for revert: https://crbug.com/1000270 (device policy should not affect non-affiliated user sessions, I will create a new policy that is scoped down to login-screen only)

Original change's description:
> Add DeviceWebUsbAllowDevicesForUrls policy
>
> This CL adds a new device policy to whitelist certain USB devices for
> certain urls in order to be used by the WebUSB API. We already have a
> user policy for that, so this device policy reuses the existing user
> policy's infrastructure.
>
> Bug: 968373, 854329
> Change-Id: I21a80f0b6557a1270a8fd6243f07e2fc8682004a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636350
> Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665844}

TBR=battre@chromium.org,poromov@chromium.org,odejesush@chromium.org,hendrich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 968373, 854329, 1000270
Change-Id: Idc6961d6119325be385b67809fb685ede70cacad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787647
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693849}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/content/browser/fileapi.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=mek@chromium.org

Bug: 891670
Change-Id: Id40fcab691f3126d75b96599b381d622f6c6cc11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786814
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693848}

The URLRequestContext is only being used by one internal legacy
consumer, which doesn't need either file or data URL support. We'll want
to remove the URLRequestContext when we can, but for now, removing these
two factories will let us remove the code in net/ to handle those two
types of URLs, as they're not handled by the network service.

Bug: 934009
Change-Id: I753f03bcc6e9f915cb64490d9bee9a8664a90695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787401Reviewed-by: Junbo Ke <juke@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693847}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/invalidation.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=pavely@chromium.org

Bug: 891670
Change-Id: I7bd7daa3a93a1ff5166ee56bdff138cd098ab4f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787098
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693846}

This CL converts WakeLockPtr and WakeLockRequest in chrome,
chromeos, components, content, extensions, services and blink to
the new Mojo types, and uses pending_receiver<WakeLock>
in wake_lock.mojom, wake_lock_context.mojom, wake_lock_provider.mojom
in services and wake_lock.mojom in blink.

Bug: 955171, 978694
Change-Id: Ia79726cbdbc97ffd5714e976f65c4339d9356ca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771371
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693845}

We were seeing out of memory errors on Windows ThinLTO bots. After
measuring memory consumption of linking chrome.dll and
chrome_child.dll, it became clear that the estimated memory usage of a
thin link was too low. Adjusting to a more realistic value.

R=dpranke,gbiv,thakis
BUG=967074

Change-Id: I7d43d38e28e351a2dc16d79abbf332972cf66e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785680Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Auto-Submit: Bob Haarman <inglorion@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693844}

Use [RaisesException] for immediate promise rejections in /third_party/blink/renderer/modules/picture_in_picture.

The bindings layer implicitly converts thrown exceptions in promise-returning
functions to promise rejections, and using ExceptionState makes this more
similar to ordinarily throwing exceptions, notably by including the auto-
generated exception context that makes it easier to see what IDL operation
caused an exception to be thrown.

This CL was uploaded by git cl split.

R=beaufort.francois@gmail.com

Bug: 1001114
Change-Id: I0d6265ccaccab772bac9e7d2ff111ff111432000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786670
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#693843}

This reverts commit e5bdbac6.

Reason for revert: Wrong revert, test added here is not failing. The other CL introduced a flaky, which is reverted in:
https://chromium-review.googlesource.com/c/chromium/src/+/1787277

Original change's description:
> Revert "Notification scheduler: Add icon database metrics."
> 
> This reverts commit 63c7234e.
> 
> Reason for revert: Unit test failure (crbug.com/1001018)
> 
> Original change's description:
> > Notification scheduler: Add icon database metrics.
> > 
> > This CL adds icon database metrics, also fixes a typo in
> > stats::LogImpressionEvent.
> > 
> > Bug: 963298
> > Change-Id: I2fcd44d773166345760ee647c26e464c9ca0f89e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785161
> > Commit-Queue: Xing Liu <xingliu@chromium.org>
> > Reviewed-by: Hesen Zhang <hesen@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#693510}
> 
> TBR=isherman@chromium.org,dtrainor@chromium.org,xingliu@chromium.org,hesen@chromium.org
> 
> Change-Id: I94b298d9754e4651f757de2ba82a369be6523801
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 963298
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786372
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693607}

TBR=peria@chromium.org,isherman@chromium.org,dtrainor@chromium.org,xingliu@chromium.org,hesen@chromium.org

Change-Id: I7db11edabd91c9a8265b7f8961054def38f804ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786644Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693842}

This CL also utilizes the defined metrics and also adds Shared Clipboard error dialog
on desktop to Android flow.

Bug: 995256
Change-Id: I2fbfb969870d462f199ff44c268a1d10376f345d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782806Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693841}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/content/browser/screenlock_monitor.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=braveyao@chromium.org

Bug: 891670
Change-Id: I6bcf570a1b0a1edaa4f35c20250692026ff66de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787067
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693840}

This CL expands existing Page Info histograms to record Safety Tip
status.

Bug: 987754
Change-Id: I3ed817597965e3b1072bc44b601a2502e25b7789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783713
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693839}

This CL converts mojo::Binding to mojo::Receiver in
TestRendererServiceImpl. And also, this CL applies
mojo::Receiver to mojom::TestServiceRequest.

Bug: 955171
Change-Id: I74c3b39f48060544adc7496657c0485eb504800c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786364Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#693838}

Backport some tests in /components/web_resource/resource_request_allowed_notifier_unittest.cc to SingleThreadTaskEnvironment

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/web_resource/resource_request_allowed_notifier_unittest.cc.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=asvitkine@chromium.org

Bug: 891670
Change-Id: I13509fa01b3fadb6cffa203cba15975ac553e8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786777
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693837}

Currently there is no visibility in interventions-internals if a coin
flip is preventing you from seeing a preview. This posts a new event
to that page when a coin flip happens.

Bug: 1000436
Change-Id: I5e1367891acb3e5f57e045a6e55335b081a25357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785821
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693836}

This unions different types of rare-data which are mutually exclusive.
They fall into (3) categories at the moment:
 - block-data (inflow block which which doesn't establish a new
   formatting context).
 - table-cell-data (display: table-cell).
 - custom-data (display: layout(foo)).

This keeps the actual structs within the union private such that nobody
messes around with uninitialized "things".

This saves ~28bytes of RareData size. (+/- 4 bytes for bad math).

Change-Id: I1af5445222d82d8a0ac5dac5573602b807751857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758654
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693835}

Ran `./tools/clang/scripts/upload_revision.py 6964027315f70c6817217d8dba0368fd3a274ba3`.

Also add a temporary workaround for a pre-existing-but-now-triggered msan false positive.

TBR=thestig

Bug: 998158,998966
Change-Id: I638cc88d9d7b161c42cf849acbf6a3e0fd95d9b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773745
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693834}

The `updateUI`'s options parameter should be optional. No behavioral
changes are required.

Bug: 1000785
Change-Id: I0d84ce1e985911e8e0db16311678aa93d8db886e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787281
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693833}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/offline_pages.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=chili@chromium.org

Bug: 891670
Change-Id: Ie41dd4e6a7e49c643df9a45421b6f7fef1b57c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786822
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693832}

- Add a flag for the 'Use Camera' button in the 'Add Credit Card' view.
- The button directs the user to a credit card scanner that uses the camera to scan a credit card number.

Bug:989432

Change-Id: I431e8c915cdf3a745f470a2ab1ecc4552e761311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787550Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Cr-Commit-Position: refs/heads/master@{#693831}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/ui/base/x.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=thomasanderson@chromium.org

Bug: 891670
Change-Id: I5f3900a36d951e5c999e5a27f02d4a076dc1578b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787178
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693830}

This reverts commit 85d4a0fa.

Reason for revert: most likely wrong culprit?

Original change's description:
> Revert "Backport some tests in /remoting to SingleThreadTaskEnvironment"
> 
> This reverts commit afa2cbc7.
> 
> Reason for revert: non_viz_browser_tests failed because of:
> OAuth2Test.SetInvalidTokenStatus
> 
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6325
> 
> Original change's description:
> > Backport some tests in /remoting to SingleThreadTaskEnvironment
> > 
> > These tests were previously migrated from single-threaded MessageLoop to
> > a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
> > part of crbug.com/891670.
> > 
> > //base OWNERS decided in retrospect that it was better to keep a
> > single-threaded option for TaskEnvironment and introduced
> > SingleThreadTaskEnvironment. This CL retrofits that decision for
> > /remoting.
> > 
> > This CL is a no-op if it passes CQ.
> > 
> > This CL was uploaded by git cl split.
> > 
> > R=​jamiewalch@chromium.org
> > 
> > Bug: 891670
> > Change-Id: Id50cc3412d6fbec3e5c71672bf74f6abf0f7332d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786679
> > Auto-Submit: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> > Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#693548}
> 
> TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,gab@chromium.org
> 
> Change-Id: Ibe96ffa6ddf39371dc64c6ad7236ec366f9331c4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 891670
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787279
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693613}

TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,gab@chromium.org,olka@chromium.org

Change-Id: Idb489a187fcfb8343079c83f66088c6b6c8b5091
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787184Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693829}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/ash.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=jamescook@chromium.org

Bug: 891670
Change-Id: Ia6c9e5450e044adca6f225e44796d5f58923e893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787101
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693828}

Previously, it was possible that the RenderFrameHost was destroyed before
attempted access by OfflinePageAutoFetcher::Create().

The fix is to avoid passing a task runner, which would PostTask().

Bug: 1000002
Change-Id: Ibb3859e9a859442cd80ef04d483c5c4ea37d01f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782695Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693827}

This CL provides expand and contract animations for views that are being
shown or hidden. It should cover the needs of the identity chip and
butter.

Still to do:
 - Move animating_layout_manager to ui/views/layout
 - Rename flex_layout_types_internal to something more appropriate
 - Implement slide and fade animations
 - Handle multiple views being added/removed at once more cleanly
 - Allow per-child-view transition rules instead of a per-layout default

Bug: 1000131
Change-Id: Ia73475e9eda7e72c118a02160b3fc7234474ee83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782040Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693826}

Change-Id: Ia7ae936644266d98abe9be88341e81fb3fc2eb96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786138Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Marc-André Decoste <mad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693825}

https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/d460d6b1cb96..baa5dc24258b

$ git log d460d6b1c..baa5dc242 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 jonathan.wright Add Arm NEON implementation of h2v2_merged_upsample
2018-07-19 jonathan.wright Add Arm NEON implementation of h2v1_merged_upsample

Created with:
  roll-dep src/third_party/libjpeg_turbo

Change-Id: I869c7d101395df111340cf70fe0d18793a9a5311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785622Reviewed-by: Jonathan Wright <jonathan.wright@arm.com>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693824}

Fixed regression introduced in #1693175 (https://chromium-review.googlesource.com/c/chromium/src/+/1693175/4/third_party/blink/renderer/devtools/front_end/ui/Toolbar.js) which kept
toolbar buttons from showing their keyboard shortcuts
in the tooltip.

Bug: chromium:999195
Change-Id: I0d0259f19a4abc45d3fe57df419319866e311688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782172
Commit-Queue: Jan Scheffler <janscheffler@google.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693823}

BackendMigrator logic requires resetting sync metadata for specific
datatype. For regular datatypes, corresponding logic lives inside
ModelAssociationManager and DataTypeManager, which don't have access
to Nigori's ModelTypeController. For Directory implementation of Nigori
this logic implemented through Directory::PurgeEntiesWithTypeIn().

We can detect required migration, because call of
Directory::PurgeEntiesWithTypeIn() plumbed through SyncEngineBackend.
We just restart ModelTypeController for Nigori and this triggers call
of NigoriSyncBridge::ApplyDisableSyncChanges().

We keep in-memory state of explicit passphrase key loaded from the
prefs, because we need it for future support of BackendMigrator for USS
Nigori. It's safe, because if we stop due to disabling sync, we will
also clear corresponding pref and we should not worry about in-memory
state of the bridge, since we won't continue use the same instance.

This is not perfect solution, and we need to try a better one. But for
now all alternatives too intrusive (getting rid of ModelTypeController
for Nigori or moving it into the UI thread).

This CL allows passing Migration*ClientTest with enabled USS
implementation of Nigori.

Bug: 922900
Change-Id: I9f7b218dec46ebfcc21ad8093b73e3c019fd438f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784606
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693822}