- 18 Nov, 2013 40 commits
-
-
phajdan.jr@chromium.org authored
This is the only change that needs to be made to Chrome (except for Blink changes, also small) to compile with gcc-4.4. One example of a distro that still uses it is RHEL 6. BUG=none R=erikwright@chromium.org Review URL: https://codereview.chromium.org/69813017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235821 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
Change the format of the data provided to PrivetLocalPrintOperationImpl to RefCountedBytes. Remove PrivetLocalPrintRequestPDF/PrivetLocalPrintRequestPWG. Have users provide PDF data consistently, and do conversin in the PrivetLocalPrintOperation. BUG=318373 Review URL: https://codereview.chromium.org/73503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235820 0039d316-1c4b-4281-b951-d872f2087c98
-
ygorshenin@chromium.org authored
BUG=263527 TEST=none Review URL: https://codereview.chromium.org/70173007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235819 0039d316-1c4b-4281-b951-d872f2087c98
-
kalyan.kondapally@intel.com authored
This cl renames icon_loader_aurax11 as icon_loader_auralinux so that the same implementation can be used with Aura+Ozone on Linux. This fixes linking problems for Ozone platform. BUG= Review URL: https://codereview.chromium.org/74543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235817 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/74283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235816 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
BUG=317523 Review URL: https://codereview.chromium.org/59673007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235815 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
The idea of this change is to only call Do***SyncSessionJob from single function TryJob and have all other functions in class call it. The hope is that maybe someday we'll call it asynchronously. Previously it would look like this: http://www.plantuml.com/plantuml/svg/ZP5HJiCm38RVSue-0jAkW0JRa8OGJCquGDQuRKPg5pUTbjkJfXfQrzBnvlZ_REUtfLFiaiLZygGFRUEsPAt1GWYPbQ1R2s-KAVlUwWAIHQ3EwPZPLBKTWYda34sPmdSBZRjHiS6ZiaOhPmZd9eXHAe9Ru9ouMe5L7dJKnC14JuLuPohWfR9shx8lyOckP7BEzlDsx9SA5VjNselrgIO4T4RPvy1IdgVWs8_13vJ0nz2L427h7AoPYL_C2VIO5fUlAAyeLEQcQ3dQbnup2KqJmewVmAE_srXdzueIiZ_ntsry3LTBcGOdDZv3_vvjuFGVxiNePZFcPbl5khk7Up7vmmjrtFai_W00 Now it will look like this: http://www.plantuml.com/plantuml/svg/XP5HJiGW48RVEKKVrMIlOAAxQxB6wARK0x1bsg9Jg5FOBBUNqbHRsTGtcE-3uH-u5MIppNts83zSRuy6KUcQCLus81t2Yoa5lZfPGxO9rbIEbKFRuLBCeIBecno-7FJsdnC7VHQefB3AwBKEB2b5yGXK6MftWCA3Z8mjGenMM1Ug1TeAn9CeFzcxjWqPQt7iLv3V2Yt8FviJsryweq5R9V0nkAQgSh3aK_5DSw1pkDLe3UMGO4zaw4bTGAOsc-ycF83Yjx8puQvArOxYGBZN9OU-3yj4Z5dNX27q7yxu-D6pthw3T1O3kJBPEVxvZyM35qOozGLTZHhDcxjRTZNdZAOX9_WD The change should be roughly equivalent to today's behavior. BUG=259913 Review URL: https://codereview.chromium.org/68013007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235814 0039d316-1c4b-4281-b951-d872f2087c98
-
dtu@chromium.org authored
Its current check is inherently flaky, and we've seen failures on some bots. BUG=None. TEST=tools/telemetry/run_tests wait_unittest R=tonyg@chromium.org Review URL: https://codereview.chromium.org/61213007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235813 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
This is a follow-up to https://codereview.chromium.org/63153013/ NOTRY=True BUG=318950, 246169 Review URL: https://codereview.chromium.org/60233008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235812 0039d316-1c4b-4281-b951-d872f2087c98
-
pshenoy@chromium.org authored
PluginTest.FlashOctetStream is failing consistently on official Windows builder. Disabling it for now. TBR=jschuh BUG=320041 Review URL: https://codereview.chromium.org/73563005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235811 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
This was a SPDY dissector for Wireshark. New versions of the dissector live in a separate project at https://code.google.com/p/spdyshark/ BUG=319973 Review URL: https://codereview.chromium.org/68013005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235810 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Remove DialogDelegate::UseNewStyle; (true since r235220). (update callsites to assume the new style should be used) Rename CreateNewStyleFrameView -> CreateDialogFrameView. Remove TabbedPane's draw_border ctor arg (always false). Remove ConstrainedWindowFrameView and helper classes. Remove constrained_*_vista.png and IDR_CONSTRAINED_*_V. Update Widget::CreateWindowAsFramelessChild callsites. (remove old |parent| arg, web_contents_view.h includes) BUG=319038,170193,166075 TEST=No UI changes, no build breaks, just less code. R=sky@chromium.org,oshima@chromium.org,estade@chromium.org Review URL: https://codereview.chromium.org/63343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235809 0039d316-1c4b-4281-b951-d872f2087c98
-
ttuttle@chromium.org authored
We're trying to chase down http://crbug.com/317138. Make some relevant DCHECKs into CHECKs in hopes of an earlier crash. BUG=317138 Review URL: https://codereview.chromium.org/70183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235808 0039d316-1c4b-4281-b951-d872f2087c98
-
pwestin@google.com authored
New structure allows a better interface to add sending and receiving log messages from the remote peer over RTCP. The acctual RTCP messaging and plugging this into the log class will follw in 2 seperate cls. Review URL: https://codereview.chromium.org/70713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235807 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
Review URL: https://codereview.chromium.org/68683010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235806 0039d316-1c4b-4281-b951-d872f2087c98
-
vmpstr@chromium.org authored
This patch adds a rasterize and record micro benchmark. It depends on https://codereview.chromium.org/67563002/ R=enne@chromium.org, nduca@chromium.org, ernstm@chromium.org Review URL: https://codereview.chromium.org/66213007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235805 0039d316-1c4b-4281-b951-d872f2087c98
-
rsadam@chromium.org authored
Adds support for the search key in the Virtual Keyboard. We currently do not use the search key, but may need it in future layouts. BUG=315071 Review URL: https://codereview.chromium.org/59813004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235803 0039d316-1c4b-4281-b951-d872f2087c98
-
http://crbug.com/152330pshenoy@chromium.org authored
PDFBrowserTest.Basic (see http://crbug.com/152330), PDFBrowserTest.FindAndCopy and PDFBrowserTest.Scroll (see http://crbug.com/79837) are failing consistently on official Windows bot. Disabling it for now to keep official bot green. BUG=152330, 79837 Review URL: https://codereview.chromium.org/67473008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235802 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
Fix crash when locking a profile. The crash is happening because navigating to a URL triggers the signin header helper code. Since locking shouldn't actually do a Gaia logout, I'm removing all the code related to that. NOTRY-ing because it's been a week of "extension "RANDR" missing on display ":9" bot errors. BUG=NONE TBR=pkasting@chromium.org NOTRY=TRUE Review URL: https://codereview.chromium.org/64313005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235801 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=none TEST=tests keep passing Review URL: https://codereview.chromium.org/72333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235800 0039d316-1c4b-4281-b951-d872f2087c98
-
yfriedman@chromium.org authored
Needed as part of setting up the DomDistillerBrowserContextKeyedService. Distilled articles will be stored in an "Articles" directory in the user's profile directory. BUG=288015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235562 NOTRY=true Review URL: https://codereview.chromium.org/63553009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235799 0039d316-1c4b-4281-b951-d872f2087c98
-
elham@google.com authored
1) Verify that setLocalDescription fails when trying to negotiate an unsupported video codec - Verify that setLocalDescription fails when trying to negotiate with a client that does not support encryption BUG=303035 Review URL: https://codereview.chromium.org/47923023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235798 0039d316-1c4b-4281-b951-d872f2087c98
-
bshe@chromium.org authored
This relands https://codereview.chromium.org/47873003. It was reverted because of VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest test crash on win8_aura. R=oshima@chromium.org TBR=jamescook, sadrul BUG=310331 TEST= 1. add keyboard-usability-experiment flag 2. hook up an external screen 3. boot device expected: a full screen keyboard on one of the screen Review URL: https://codereview.chromium.org/62833010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235795 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235793 0039d316-1c4b-4281-b951-d872f2087c98
-
navabi@google.com authored
We want to pick up this change: https://gerrit.chromium.org/gerrit/#/c/67837/ The SDK added 32-bit linkers to build-tools with SDK 19. We use 64-bit linkers in the ndk directory. BUG= NOTRY=True Review URL: https://codereview.chromium.org/74133004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235792 0039d316-1c4b-4281-b951-d872f2087c98
-
falken@chromium.org authored
This is a follow-up to r235091 now that the tests are no longer crashing. BUG=304779 Review URL: https://codereview.chromium.org/63903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235791 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235790 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
> DEPS roll for OpenSSL to r235188 > > Brings in the following changes: > > ------------------------------------------------------------------------ > r233370 | agl@chromium.org | 2013-11-06 16:17:55 -0500 (Wed, 06 Nov 2013) | 17 lines > > third_party/openssl: add ChaCha20+Poly1305 support. > > This change is not as scary as it appears. Most of the code has already been > reviewed and is running in production without issues. The only new code is the > ARM support. > > ARM now builds both the NEON and generic versions of the code and can enable > the NEON code at runtime by calling CRYPTO_set_NEON_capable(1). This patch does > not contain the code to call that, however. > > The addition openssl/patches/channelidchromium.patch and > fix_lhash_iteration.patch is noise from the import script. > > BUG=310768 > > https://codereview.chromium.org/59083010/ > > ------------------------------------------------------------------------ > r233061 | agl@chromium.org | 2013-11-05 14:42:31 -0500 (Tue, 05 Nov 2013) | 6 lines > > Fix the patch file from r233053. > > The patch file should be a patch that adds a patch, and that patch should do > the actual patching, except for openssl.config, which should be patched > directly. > > ------------------------------------------------------------------------ > r233053 | agl@chromium.org | 2013-11-05 14:28:17 -0500 (Tue, 05 Nov 2013) | 4 lines > > Add patch file missing from r233017. > > This addition allows import_from_android.sh to be idempotent again. > > BUG=310768 > > Review URL: https://codereview.chromium.org/69953024 TBR=agl@chromium.org Review URL: https://codereview.chromium.org/75033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235789 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235788 0039d316-1c4b-4281-b951-d872f2087c98
-
ncbray@chromium.org authored
BUG=317890 Review URL: https://codereview.chromium.org/71863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235787 0039d316-1c4b-4281-b951-d872f2087c98
-
mkosiba@chromium.org authored
Turns out the refactoring in r158146 made us use the incorrect WebContentsObserver callback. BUG=https://code.google.com/p/android/issues/detail?id=62100, b/11656658 TEST=AndroidWebViewTest Review URL: https://codereview.chromium.org/68763012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235785 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235784 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Brings in the following changes: ------------------------------------------------------------------------ r233370 | agl@chromium.org | 2013-11-06 16:17:55 -0500 (Wed, 06 Nov 2013) | 17 lines third_party/openssl: add ChaCha20+Poly1305 support. This change is not as scary as it appears. Most of the code has already been reviewed and is running in production without issues. The only new code is the ARM support. ARM now builds both the NEON and generic versions of the code and can enable the NEON code at runtime by calling CRYPTO_set_NEON_capable(1). This patch does not contain the code to call that, however. The addition openssl/patches/channelidchromium.patch and fix_lhash_iteration.patch is noise from the import script. BUG=310768 https://codereview.chromium.org/59083010/ ------------------------------------------------------------------------ r233061 | agl@chromium.org | 2013-11-05 14:42:31 -0500 (Tue, 05 Nov 2013) | 6 lines Fix the patch file from r233053. The patch file should be a patch that adds a patch, and that patch should do the actual patching, except for openssl.config, which should be patched directly. ------------------------------------------------------------------------ r233053 | agl@chromium.org | 2013-11-05 14:28:17 -0500 (Tue, 05 Nov 2013) | 4 lines Add patch file missing from r233017. This addition allows import_from_android.sh to be idempotent again. BUG=310768 Review URL: https://codereview.chromium.org/69953024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235783 0039d316-1c4b-4281-b951-d872f2087c98
-
andrewhayden@chromium.org authored
Changes: * Decouple the version of the SDK that is installed from the version of the Android API that will be used. * Upgrade the SDK to Android-19 while we are at it. * Allow an "--api-level" argument to choose system images. * Automagically download and install platform libraries for any --api-level BUG= Review URL: https://codereview.chromium.org/59943011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235782 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
> Removed RunUntilIdle between Stop and Close in UT, after Valgrind found a NULL addressing. > > Reland of: https://codereview.chromium.org/29423003/ > > Added video capture capabilities retrieval and caching to VideoCaptureManager. > > The local cache of video capture names and capabilities is created in a > codepath starting in EnumerateDevices. The cache is update during > StartCaptureForClient() and StopCaptureForClient(). > > Also added unittests (http://goo.gl/QQbpXW). > > BUG=309554, 319955 > TBR=perkj, ncarter, xians1 > > Review URL: https://codereview.chromium.org/74703002 TBR=mcasas@chromium.org Review URL: https://codereview.chromium.org/61213006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235781 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235780 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=162192:162211&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/72073006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235779 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
BUG=none TEST=none R=isherman@chromium.org Review URL: https://codereview.chromium.org/62873006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235777 0039d316-1c4b-4281-b951-d872f2087c98
-
craigdh@chromium.org authored
BUG=318387 TEST=None NOTRY=True Review URL: https://codereview.chromium.org/60043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235776 0039d316-1c4b-4281-b951-d872f2087c98
-
skuhne@chromium.org authored
Instead of blindly hiding a window, this patch will check if the owner of the window is a system modal container. If so, switch users instead. BUG=318832 TEST=unittest (and visual) Review URL: https://codereview.chromium.org/74363004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235773 0039d316-1c4b-4281-b951-d872f2087c98
-