- 14 Aug, 2020 40 commits
-
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/tnUpbECn-eLbumpU1g06p173LxX2eM_OP4QF_-OtILgC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200813_RC00.html Bug: b/163296306, b/159083441, b/159083441, b/164206096, b/157387116 Fixed: 1112044 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I04dbf75b137a2ffd1ab0067a9b1d80c249e175a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352299Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#798024}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4faa62a0e9f8..241a4a92fb96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idf2c93ae4a1ac82ff18596cb7d8352df8fc79214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354888Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798023}
-
Sven Zheng authored
Based on https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/967? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/966? Bug: 1111979 Change-Id: I861a7cc11c2834cccaf275c90de0c3ba80c4f478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354719 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798022}
-
Lan Wei authored
org.chromium.weblayer.test.ErrorPageCallbackTest.testOverrideErrorPage is flaky on Android, https://analysis.chromium.org/p/chromium/flake-portal/flakes/ occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfAsSBUZsYWtlInFjaHJvbWl1bUB3ZWJs YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl c3QuRXJyb3JQYWdlQ2FsbGJhY2tUZXN0I3Rlc3RPdmVycmlkZUVycm9yUGFnZQw, disable it for now until it is fixed. TBR=estade@chromium.org Bug: 1116277 Change-Id: Id9eaa577587cb64136cd36364dc7e882f1c34876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355399Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#798021}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a6dff6f4..6f6dc9f3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ice797c49ec562bc6bcab6d178471d31738fd6949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355214Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798020}
-
Alexander Dunaev authored
This is a reland of 1523bb86 Original change's description: > [ozone] Improved clipboard tests and de-duplicated string constants. > > This CL pays a bit of technical debt in the clipboard implementation. > > First, it updates a test that verifies that putting text into clipboard > registers the proper set of MIME types, as had been suggested in [1]. > > Second, it enables for Ozone the test that verifies selection buffers. > > Third, it de-duplicates some string constants. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2306252 > > Change-Id: I6beb6b5b3827f0ec09cf19bc1868e7955141f680 > Bug: 911992, 1105892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346338 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#797572} Bug: 911992 Bug: 1105892 Change-Id: I832d56641910a7014d7b53a8ce19fd3c71be2c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352803Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#798019}
-
Ken MacKay authored
Bug: internal b/163708246 Change-Id: I7868fe3e507af53fa82206652c5dec130efd468c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351390 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798018}
-
Andrew Grieve authored
Prevents gn gen failure for v8. Bug: 1114750, 1115981 Change-Id: I9cdd0ad4e7bc0ed511b3d99d1ec6d004e31e6ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355436 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#798017}
-
Sinan Sahin authored
This reverts commit 52b501ca. The reason for the revert has been fixed with crrev.com/c/2248931. This reland also includes changes in tools/perf/benchmarks. We basically add a command-line switch to force the offline indicator an online state. This is because these benchmarks are run on offline devices and this causes the offline indicator to show and affects the stories being run. Showing the offline indicator isn't realistic when the test is simulating navigating webpages that would normally require the device to be online. Also, showing the offline indicator might cause flakiness in the results or dilute real regressions. We've investigated the reported regressions and confirmed that they're WAI when the indicator is showing. Original change's description: > Revert "[Offline indicator v2] Add field trial testing entry" > > This reverts commit ceaac935. > > Reason for revert: continued assertion failures on some phones; see http://crbug.com/1084740#c17 . > > Original change's description: > > [Offline indicator v2] Add field trial testing entry > > > > Enabling the feature causes some test failures since the bots are > > offline and the offline indicator is always visible. For the short term, > > we are adding a command-line switch to disable the offline indicator. > > > > The longer-term plan is to enable the feature for most tests, and only > > disable where we have to. > > > > Bug: 989148, 1091491, 1093085 > > Change-Id: I89e7ef93233b4c4cc2bd395ce1309bc14d5dea09 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228367 > > Reviewed-by: Steven Holte <holte@chromium.org> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Commit-Queue: Sinan Sahin <sinansahin@google.com> > > Cr-Commit-Position: refs/heads/master@{#777216} > > TBR=avi@chromium.org,twellington@chromium.org,holte@chromium.org,bsheedy@chromium.org,sinansahin@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 989148, 1091491, 1093085 > Change-Id: I6c22120bbb27ff430f73a40ea28f1bf1a9a7da31 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244195 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778024} Bug: 1091491 Change-Id: I3fd5e9d92f61c980a664ad6b5c311fe6b68cd57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246834Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#798016}
-
Russ Hamilton authored
Bug: 973801 Change-Id: Ic3a1b125ffa72b282899c2e65b7dacb43af13cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354589 Commit-Queue: Russ Hamilton <behamilton@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798015}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7e699cfedef62bb783c68d903d4ce3bd03866292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354588Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4faa62a0e9f8..241a4a92fb96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3b47c5631e8d38e671e20e7f0fbb63b227b2ec5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354968Reviewed-by:
-
Kenichi Ishibashi authored
These are wrappers of ServiceWorkerStorage's Disable() and DeleteAndStartOver(). ServiceWorkerStorage::DeleteAndStartOver() doesn't seem to have logic for "start over" so ServiceWorkerStorageControl drops that part. Bug: 1055677 Change-Id: I955519150a1fb4e481a6143243ae68cc637eac45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353974Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798012}
-
Wenbin Zhang authored
In order to skip running some stories, Benchmarking uses tags defined in typ_expectations.py to update expectations.config. Though, we don't have a tag to allow us stop running a story only on win-10_laptop_low_end-perf. This CL adds a new tag win-laptop in expectations.config. The changes in catapult is in this CL: crrev.com/c/2351395. Bug: chromium:1114681 Bug: chromium:1115156 Change-Id: Ia0c816d11b9434e20d1d06d4dca96678d379d643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353949Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#798011}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 852091bd. With Chromium commits locally applied on WPT: 7baae9f7 "[IndexedDB] Implement putAllValues with correct error handling" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ieb150e10cd7857c0fe70a18c591d88526644e3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353175Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798010}
-
Yoichi Osato authored
Bug: 1007703 Change-Id: I1cbd5b3f1643a43a2741deb33ec022761887a995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326854Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#798009}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/13f3340173aa..d315022be5b7 2020-08-13 idanr@google.com Add Metal vertex pulling behind a flag 2020-08-13 idanr@google.com Enable robust buffer access pass if robustness on 2020-08-13 enrico.galli@intel.com Eagerly destroy CommandBuffer commands after submission 2020-08-13 enga@chromium.org Roll 5 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia1cc063c33ab4972bad2ef46b129d7c1f4434c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355391Reviewed-by:
-
ziyangch authored
Bug: Internal b/162079069 Merge-With: eureka-internal/424693 Test: Check whether the observer receive the signal on device. Change-Id: I44c15917a4104cfb94ca619d986587fd96b6857b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349415Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#798007}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7369107c7819..46d39660e0e6 2020-08-14 tsepez@chromium.org Remove CFWL_WidgetMgr::GetOwnerWidget() 2020-08-13 tsepez@chromium.org Remove CFWL_WidgetProperties::m_pFWLThemeProvider. 2020-08-13 tsepez@chromium.org Remove unused members from CFWL_WidgetMgr::Item 2020-08-13 vmiklos@collabora.co.uk FPDFSignatureObj_GetSubFilter: avoid manual buffer management 2020-08-13 tsepez@chromium.org Remove some dead code in xfa/fwl. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2d6f75d3cad03ec8ce3126cecac2f05134b39c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355075Reviewed-by:
-
Maggie Cai authored
This CL adds integration tests for sharesheet button in the files app. BUG=1097623 Change-Id: If6ca472a1d9cc4b83b4ed547f717f0770c574f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351262 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#798005}
-
Jamie Madill authored
These perf tests create a new graphics context for each and every test. Running complex programs leaves the processes in a dirty state in most every driver because this usage pattern of multiple graphics contexts and different graphics APIs in the same process. This leads to flaky crashes and undefined behaviour. Work around these crashes by forcing each test to run in its own process. The change slows down the tests but should be much more stable. Increases the shard count to compensate for the slower test runs. No-try: true Bug: angleproject:4943 Change-Id: I9b81c108c97d89e80d06c6fae1ab8553cd0d773c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351960 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#798004}
-
Dirk Pranke authored
Previously, if you uploaded a CL that only changed //testing/buildbot/gn_isolate_map.pyl, then no tests would be run: analyze would not think anything had changed. This should really be fixed by marking it as a data dependency of all of the test targets, but that's hard to do without the generic build wrapper framework. Besides, I'm trying to make the file be obsolete. In the meantime, this'll mark it so that we do trigger tests and make sure changes to the file don't break things. Bug: 816629 Change-Id: If9f65e743d276582720860893dcb877e75ba1844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354779Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#798003}
-
Shakti Sahu authored
This CL sets up - Video tutorials feature flag - Video tutorials code directory in chrome/browser/video_tutorials/ - BUILD, DEPS, OWNERS files - An empty VideoTutorialService class with factory Bug: 1114065 Change-Id: I676ae7b8e83e3b2ff709d80a4f6ccdc96a316255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346742Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798002}
-
Hirokazu Honda authored
media/gpu/video_encode_accelerator_tests: Fix the timing of FlushDoneTask() when VEA doesn't support Flush() When VideoEncodeAccelerator (VEA) doesn't support Flush(), VideoEncoderClient simulates the Flush() flow. VideoEncoderClient starts the Flush event when the last frame is fed to VEA. VideoEncoderClient, however, invokes FlushDoneEvent() when the VEA read the last frame. This may be before the encoded bitstream of the last frame is returned by BitstreamBufferReady(). This not only breaks VEA API rule; FlushDoneTask() is called after the encoded bitstream of the last frame is returned, but also BitstreamBufferProcessors may process less number of frames than expected. This CL fixes the timing of FlushDoneTask(). Bug: b:159384004, 1045825 Test: video_encode_accelerator_tests on hana Change-Id: I47e3bc39699a727f5bdb9ccc0043dc2bd096fa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340853 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#798001}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I07fcafbe11cf4a00af1549f4a4ae3ef17db1ce0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354467 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#798000}
-
Hirokazu Honda authored
V4L2VideoEncodeAccelerator (V4L2VEA) may not proceed encoding unless an output bitstream buffer is provided. BitstreamBufferValidator decodes bitstreams and releases bitstreams when decoding the bitstreams completes. This causes a dead-lock issue. To progress the decoding in BitstreamBufferValidator, successive decoder buffers are required, but they don't come because V4L2VEA doesn't have bitstream buffers to be filled. This fixes the issue that by releasing the bitstreams in BitstreamBufferValidator when it finish reading the bitstream, i.e., VideoDecoder::DecodeCB is invoked. Bug: 1045825 Test: video_encode_accelerator_tests on hana Change-Id: Ic02d36511437ee87cba0a68c2e10fde36260a955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340653Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/af63c44964ad..4daf2c7a45b2 2020-08-14 wenbinzhang@google.com [benchmarking] Add win-laptop tag for filtering win-10_laptop_low_end-perf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114681,chromium:1115156 Tbr: eseckler@google.com Change-Id: I62659876382ab763f1852cda1d71b9c5cd68737b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355121Reviewed-by:
-
Peter Kasting authored
* Use Tween::SizeValueBetween() * Use range-for loops * Use View::SetBoundsRect() * Some variable name improvements Bug: none Change-Id: I55f1d50723053e36eaddb29715bed86f2a438d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350303Reviewed-by:
-
Kent Tamura authored
The feature enables LayoutNG for <fieldset>, and fix some interoperability issues such as flex/grid support. This CL adds base::Feature for LayoutNGFieldset runtime flag. We can disable the feature by Finch if we find critical issues of the feature. Bug: 375693, 875235 Change-Id: Ib0a212b7ccfe13d561aef4051950beb6db4722e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354120 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#797996}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I336fafabbbb901fed5017874466c4eee220394e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354964Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#797995}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Idabb9f7c3351307abb8b06ec74947cbe3fae9fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355438Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797994}
-
Peter Kasting authored
No intended behavior change. This doesn't exhaustively convert things, just some in code I was already touching elsewhere. Bug: none Change-Id: I1b1fdc7a097126075e8392a76cf42fef4c563156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345477 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
If TPM is locked show banner with steps on how to fix this issue. Bug: 1114656 Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#797992}
-
Kent Tamura authored
Bug: 1040826 Change-Id: I0a2f9db962e74a44758293e0711009617e6a42d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354119 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Lan Wei authored
org.chromium.weblayer.test.DownloadCallbackTest.testBasic fails on Android, https://analysis.chromium.org/p/chromium/flake-portal/flakes/ occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybwsSBUZsYWtlImRjaHJvbWl1bUB3ZWJs YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl c3QuRG93bmxvYWRDYWxsYmFja1Rlc3QjdGVzdEJhc2ljDA, disable it for now until it is fixed. TBR=jam@chromium.org Bug: 1116248 Change-Id: I24f0ab8414f4b17ff3689f3686e3f58682c48b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354162Reviewed-by:
-
Lan Wei authored
AddressViewControllerTestCase/ testAddressesViewControllerIsPresented is flaky on ios-simulator-full-configs, https://ci.chromium.org/p/chromium/builders/ci/ ios-simulator-full-configs/25750, disable it for now until it is fixed. TBR=javierrobles@chromium.org Bug: 1116274 Change-Id: Ia300c71fb7acb074095842436a20fd3b9380cd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355291Reviewed-by:
-
Avi Drissman authored
Bug: 1104256 Change-Id: I8d308d6dc6973e1c537e3896f5bd81d8ae2b127d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354965 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797988}
-
Bo Liu authored
Remove the separate base::Feature, and tie enabling this to when site isolation is enabled. Bug: 946216 Change-Id: Ic14262b2fde78858b8f67f4e84ed35e199c2d3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354271 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797987}
-
Hazim Mohamed authored
Introduces a browser test that implements end-to-end testing of the DataTransferItem.getAsFileSystemHandle() method. It contains two tests: one for dropped files and one for dropped directories. Bug: 1080811 Change-Id: Ie64096539a732c0a2d101ca98bf9e86fcc9190ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339945 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797986}
-
Ben Goldberger authored
This implementation will be used to support teamfood experimentation and will be replaced with a non-blocking async implementation before exposing to live traffic. Change-Id: I5936d6506013d3d0beb251500974ec5b92214da8 Bug: 1099982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289207 Commit-Queue: Ben Goldberger <benwgold@google.com> Auto-Submit: Ben Goldberger <benwgold@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#797985}
-
