- 20 Nov, 2017 40 commits
-
-
Paul Jensen authored
The test calls ConnectivityManager.getActiveNetwork() which is an Android M API. Bug: 786423 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id26b4eb49294a35129fc9cc300084ee293403ca5 Reviewed-on: https://chromium-review.googlesource.com/777299Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517870}
-
Dominic Mazzoni authored
No user-visible change, just modernizing the code behind the chrome://accessibility Accessibility Internals page. We were calling CallJavascriptFunctionUnsafe, which was unsafe because the page might not have been ready. Switch to using a WebUIMessageHandler so we can call AllowJavascript() when we get a message from the page, indicating we're sure it's ready, then future calls to CallJavascriptFunction will succeed. See https://goo.gl/qivavq for details. Bug: 785493 Change-Id: I1623aae2be16b968ae8d7b17058348980637f02c Reviewed-on: https://chromium-review.googlesource.com/772876Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517869}
-
Jochen Eisinger authored
R=ojan@chromium.org Change-Id: Idbbd5e7bed12d41c8b53dd99233386d502bd8da3 Reviewed-on: https://chromium-review.googlesource.com/778323Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517868}
-
Maria Khomenko authored
CustomNotificationBuilder is not used on N+. BUG=779228 Change-Id: Ic8bf59e6b6e2d58306dbb53eb26a26f878e9b4e8 Reviewed-on: https://chromium-review.googlesource.com/777420Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517867}
-
Marc Treib authored
LogEvent computes the time between the current event and navigation start. It gets the navigation start time from WebPerformance:: NavigationStart() which is a wall time (i.e. base::Time), but before this CL, it got the current time from base::TimeTicks::Now(). This CL fixes that by using base::Time::Now() instead and also cleans up the code a bit. I believe this is a pure cleanup, though I'm not entirely sure if the old way always delivered well-defined results. Bug: 777568 Change-Id: I81ed3e1fae2650a6bbc053ae8a4917a8e6c91f5e Reviewed-on: https://chromium-review.googlesource.com/776854 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#517866}
-
Maks Orlovich authored
SimpleCache: Revert temporary DCHECK -> CHECK conversion + extra checks from https://chromium-review.googlesource.com/c/chromium/src/+/728344 It's been a month (and it didn't catch anything), new branch should be coming up soon, and there is some DCHECK-enabled testing happening in canaries, too. Bug: 774652 Change-Id: I1866b49fd0cbe906215555be496cbf9a61df73f9 Reviewed-on: https://chromium-review.googlesource.com/779224Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#517865}
-
Min Qin authored
The initiator is used for checking cookies. And it is mising from the URLRequest when URLLoader is used. For example, DownloadContentTest.DownloadAttributeSameOriginRedirect will redirect a link click to a download with a different origin. Download should pass the initiator in the URLRequest, but missing it causes the wrong cookie to be passed. This CL sets the intiator in the URLRequest so the above test can partially work. BUG=786598 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4efffd41fc9ca26063d853ce03e7c7ff817a917c Reviewed-on: https://chromium-review.googlesource.com/777552Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#517864}
-
Milko Leporis authored
Change adds support for installing Debian Stretch sysroot for mips64el. BUG=751812 Change-Id: Iaa32d0b0701b17a49e0ac735134ad85cf746fe23 Reviewed-on: https://chromium-review.googlesource.com/776873Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517863}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f9ec4707ee13..b842703085a9 $ git log f9ec4707e..b84270308 --date=short --no-merges --format='%ad %ae %s' 2017-11-18 benjaminwagner Add Linux IntelHD405 Vulkan jobs. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: If2063ed60838aa9e07ca660f143007f4a511ad8b Reviewed-on: https://chromium-review.googlesource.com/779301Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517862}
-
Alex Clarke authored
This is important because otherwise there will be a race between the virtual time budget expiring and the side effects of asynchronous dom storage methods. Bug: 777763 Change-Id: I41481070958a0e47232c8d5f22fbfbe5894ec605 Reviewed-on: https://chromium-review.googlesource.com/730711 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#517861}
-
Scott Violet authored
This name better matches what we do else where. BUG=none TEST=none Change-Id: I8e820ec89c45b09844caba3f8b450a23449c108f Reviewed-on: https://chromium-review.googlesource.com/775879 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#517860}
-
Adrian Elder authored
Adds a flag to webrtcLoggingPrivate's RequestInfo that causes the API functions to look up the render process id for a webview in the caller's web contents. There are 2 ways webrtcLoggingPrivate functions can be called. 1. From a whitelisted component extension on behalf of a page with the appropriate origin via a message from that page. In this case, either the guest process id or the tab id is on the message received by the component extension, and the extension can pass that along in RequestInfo as |guest_process_id| or |tab_id|. 2. From a whitelisted app that hosts a page in a webview. In this case, the app should call these API functions with the |target_webview| flag set, from a web contents that has exactly 1 webview . Case 1 was already supported before. This change adds support for case 2. Bug: 777933 Change-Id: I02f6d011fc7a6f1589c10aff19dc6e6e8f2e24a8 Reviewed-on: https://chromium-review.googlesource.com/763911 Commit-Queue: Adrian Elder <aelder@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517859}
-
Reza.Zakerinasab authored
When premultiplyAlpha is set to "none" in ImageBitmapOptions, we should never pass through premul format in color managed ImageBitmap code. Bug: 781908, 785313 Change-Id: I3a2fc1664dd57530bdc31694c5f9d61e95a9501b Reviewed-on: https://chromium-review.googlesource.com/759116 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#517858}
-
Anita Woodruff authored
- This method returns a WebNotificationManager so updated the method to reflect this. - This avoids confusion with the NotificationManager (a subclass of WebNotificationManager living outside of blink). Bug: Change-Id: Id9d1746d31cafa7ee68bfdd5b996c625b6834057 Reviewed-on: https://chromium-review.googlesource.com/775198Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#517857}
-
John Abd-El-Malek authored
NOTRY=true Bug: 769401 Change-Id: Id963e057735613afd481658c1fa566f0b792dd49 Reviewed-on: https://chromium-review.googlesource.com/779085 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517856}
-
Fernando Serboncini authored
This reverts commit 6d8b790a. Reason for revert: All those tests are failing on: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak Sorry for the revert, but since they are new tests, please fix or mark them off for this bot before submitting. Original change's description: > Media Controls: Double tap on either side to jump > > Add double tap gesture recognition to MediaControlOverlayPlayButton so > it can detect double tap gestures on the side and jump accordingly. Adds > LayoutTests as a virtual test suite so they are tested with the modern > media controls flag on. > > BUG=779989 > > Change-Id: I6e62f88bc51794b21132ec0532cdbd8c5ccbb677 > Reviewed-on: https://chromium-review.googlesource.com/757138 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517839} TBR=jbroman@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: If381e9ad02782008083d78b24edfd92042f63818 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779989 Reviewed-on: https://chromium-review.googlesource.com/779226Reviewed-by:
-
Darin Fisher authored
Change-Id: I9ba559836293512cfcc71632cb40917a98dfa4ef Reviewed-on: https://chromium-review.googlesource.com/777028Reviewed-by:
-
Biao She authored
Bug: 764441 Change-Id: Iea755b93f9f6506603dee28f10cf06c88a63d109 Reviewed-on: https://chromium-review.googlesource.com/775145Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#517853}
-
Rob Buis authored
Nothing in the spec [1] mentions having to convert JS null to a null/empty string internally and the wpt test indicates we should just do the default, i.e. stringify to "null", so remove the TreatNullAs extended attribute. Behavior matches Firefox and Edge. [1] https://html.spec.whatwg.org/#dom-tdth-headers Bug: 651762 Change-Id: I400d86bfa19702cef4607c2ae0d21a2becf7ee0a Reviewed-on: https://chromium-review.googlesource.com/776237Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#517852}
-
Aaron Leventhal authored
Provide friendlier-sounding suggestions that are more efficient for screen reader use. Bug: 785436 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifbf93609bc274f445e8ae81cccb5cb60a705da2e Reviewed-on: https://chromium-review.googlesource.com/772316 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#517851}
-
Erik Chen authored
The original CL added a javatest and its dependencies to the apk_under_test. This causes the dependencies to be stripped from the instrumentation_apk, which causes issue. This CL updates the build configuration so that the javatest and its dependencies are only added to the instrumentation_apk. This is a reland of e0b4355f Original change's description: > Add Android OOP HP end-to-end tests. > > This CL has three components: > 1) The bulk of the logic in OOP HP was refactored into ProfilingTestDriver. > 2) Adds a java instrumentation test, along with a JNI shim that forwards into > ProfilingTestDriver. > 3) Creates a new apk: chrome_public_apk_for_test that contains the same > content as chrome_public_apk, as well as native files needed for (2). > chrome_public_apk_test now targets chrome_public_apk_for_test instead of > chrome_public_apk. > > Other ideas, discarded: > * Originally, I attempted to make the browser_tests target runnable on > Android. The primary problem is that native test harness cannot fork > or spawn processes. This is difficult to solve. > > More details on each of the components: > (1) ProfilingTestDriver > * The TracingController test was migrated to use ProfilingTestDriver, but the > write-to-file test was left as-is. The latter behavior will likely be phased > out, but I'll clean that up in a future CL. > * gtest isn't supported for Android instrumentation tests. ProfilingTestDriver > has a single function RunTest that returns a 'bool' indicating success. On > failure, the class uses LOG(ERROR) to print the nature of the error. This will > cause the error to be printed out on browser_test error. On instrumentation > test failure, the error will be forwarded to logcat, which is available on all > infra bot test runs. > (2) Instrumentation test > * For now, I only added a single test for the "browser" mode. Furthermore, I'm > only testing the start with command-line path. > (3) New apk > * libchromefortest is a new shared library that contains all content from > libchrome, but also contains native sources for the JNI shim. > * chrome_public_apk_for_test is a new apk that contains all content from > chrome_public_apk, but uses a single shared library libchromefortest rather > than libchrome. This also contains java sources for the JNI shim. > * There is no way to just add a second shared library to chrome_public_apk > that just contains the native sources from the JNI shim without causing ODR > issues. > * chrome_public_test_apk now has apk_under_test = chrome_public_apk_for_test. > * There is no way to add native JNI sources as a shared library to > chrome_public_test_apk without causing ODR issues. > > Finally, this CL drastically increases the timeout to wait for native > initialization. The previous timeout was 2 * > CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL, which flakily failed for this test. > This suggests that this step/timeout is generally flaky. I increased the timeout > to 20 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL. > > Bug: 753218 > Change-Id: Ic224b7314fff57f1770a4048aa5753f54e040b55 > Reviewed-on: https://chromium-review.googlesource.com/770148 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517541} Bug: 753218 TBR: brettw@chromium.org Change-Id: Ic6aafb34c2467253f75cc85da48200d19f3bc9af Reviewed-on: https://chromium-review.googlesource.com/777697 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517850}
-
Fernando Serboncini authored
Bug: 786995 Change-Id: Ifd48a214d84503e571abd6da6884dd17cfa90a3b Reviewed-on: https://chromium-review.googlesource.com/779639Reviewed-by:
-
Patrik Höglund authored
WebRTC api:video_frame_api is splitting into two targets, and all targets that include i420_buffer.h must depend on a new target api:video_frame_api_i420. This CL fixes that for Chromium. Bug: webrtc:7504 Change-Id: Ic383a5592a5b01a4463565326fe4fecd2fc96829 Reviewed-on: https://chromium-review.googlesource.com/776715Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#517848}
-
Bence Béky authored
* Remove duplicate includes. * Include spdy_session.h for SpdySession::TimeFunc. * s/NULL/nullptr/ * Ever since https://crrev.com/199633019 landed three and a half years ago, |expected_status| argument of CreateSpdySessionHelper() is unused. Remove it, and remove the inaccurately named TryCreateSpdySessionExpectingFailure(). * Move |this_header| and |this_value| declaration closest to their first use in AppendToHeaderBlock(). The compiler should be smart enough to optimize this. * In the same method use implicit pointer to bool conversion in DCHECKs. * Purge naked news in favor of MakeRefCounted<> or make_unique<>. * s/expected_error/expected_status/ for consistency. * Use TestCompletionCallback::GetResult() [1] in CreateSpdySessionHelper() instead of inlining it. [1] https://cs.chromium.org/chromium/src/net/base/test_completion_callback.h?l=72 Bug: Change-Id: Id5bc3f37f068f78901afbf8fb027cc6c63744b22 Reviewed-on: https://chromium-review.googlesource.com/775868 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#517847}
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: I951cb50ed4e72ab5d77cab812627a3b7967d70a3 Reviewed-on: https://chromium-review.googlesource.com/776782Reviewed-by:
-
Jérôme Lebel authored
The SigninPromoViewMediator should be in charge of registering and using: - prefs::kIosBookmarkSigninPromoDisplayedCount - prefs::kIosBookmarkPromoAlreadySeen Also, once the sign-in promo view has been seen too much by the user, it should not set prefs::kIosBookmarkPromoAlreadySeen to true. kIosBookmarkPromoAlreadySeen should be used only for the close button. Some views could have a max number of views, without a close button. This work is to prepare the clean up for the sign-in promo view in the settings (crrev.com/c/774519). Bug: 772050 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id7f7cfc1146afbec552aaa159b628caac691d105 Reviewed-on: https://chromium-review.googlesource.com/776780Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#517845}
-
Theresa Wellington authored
BUG=781994 Change-Id: I45f50f44ccb7ac510255f8659d77713f95962b86 Reviewed-on: https://chromium-review.googlesource.com/777941 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517844}
-
Jayson Adams authored
https://chromium-review.googlesource.com/769238 cleans up the TabView initialization code but the reordering causes the TabView to never receive a pointer to its closeButton. This cl ensures closeButton creation occurs before TabView creation. Bug: 786326, 786387 Change-Id: Id1fce1b8dcd1014ae015b7806df3541981d08253 Reviewed-on: https://chromium-review.googlesource.com/777394Reviewed-by:
-
Ehsan Karamad authored
This CL removes the mentioned classes from the autofill client implementation. The PageClickTracker logic used to observe RenderView to get information about user clicks and gesture taps inside form elements. Since AutofillAgent is now a RenderFrameObserver, most of the notifications are directly received from the RenderFrame of the owner WebLocalFrame, or from inside blink through WebAutofillClient interface. Therefore, PageClickTracker code is no longer necessary. Furthermore, currently PageClickTracker is simply a state machine to determine clicks inside a form control element where all its inputs come from AutofillAgent and its only listener (PageClickListener) is the same AutofillAgent. To support the current tests for PageClickTracker, a few test only state variables are added to AutofillAgent. Eventually, the tests should be diligently modified to remove the need for such variables. Bug: 712754 Change-Id: I44e16ba0b10909f84377bb5e7c78a5266786e898 Reviewed-on: https://chromium-review.googlesource.com/773450 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517842}
-
Mathieu Perreault authored
Bug: 784550 Test: browser_tests --gtest_filter=PaymentRequestIframeTest.CrossOriginIframe Change-Id: I89800dd1d9e73804cd93f77ec2b8122d861ccef6 Reviewed-on: https://chromium-review.googlesource.com/779082Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#517841}
-
Alex Clarke authored
Bug: 783898 Change-Id: Ifa0fcbe77bbf9ca952cbd873cca14e3b6e0c7ad0 Reviewed-on: https://chromium-review.googlesource.com/765974 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517840}
-
Becca Hughes authored
Add double tap gesture recognition to MediaControlOverlayPlayButton so it can detect double tap gestures on the side and jump accordingly. Adds LayoutTests as a virtual test suite so they are tested with the modern media controls flag on. BUG=779989 Change-Id: I6e62f88bc51794b21132ec0532cdbd8c5ccbb677 Reviewed-on: https://chromium-review.googlesource.com/757138 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#517839}
-
Egor Pasko authored
Remove the ModernLinker since it becomes unused. Also remove the possibility to set the linker differently in tests. Public document explaining the motivation: https://goo.gl/kWnHYr BUG=719977 (google-internal) Change-Id: I5b9b85817093b36127fa4a607bced57b4350a5b8 Reviewed-on: https://chromium-review.googlesource.com/538582 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517838}
-
Victor Costan authored
This is a follow-up of https://crrev.com/c/771510 and finishes the replacement of the std::string ("Set-Cookie:" HTTP header line) argument with net::CanonicalCookie in network delegates that give embedders an opportunity to block cookies. This CL removes duplicate parsing of Set-Cookie: HTTP header lines, which was an opportunity for bugs. Bug: 756093 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibe4ea727cb55665f1973483345c97e4b2122b7ea Reviewed-on: https://chromium-review.googlesource.com/775606Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
The overlay should show when the video is tapped or interacted with. Bug: 785322 Change-Id: I9ac249005cf08723c35fc6885070c7ec90234aae Reviewed-on: https://chromium-review.googlesource.com/774459Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#517836}
-
David Bokan authored
When RLS is turned on, children of the root layer now have a composited scrolling ancestor. This causes them to use their unclipped bounding rects to test overlap. It turns out overlap testing inside composited scrollers is somewhat buggy (https://crbug.com/783532). In order to prevent regressing existing behavior, this CL makes an exception for children whose composited scrolling ancestor is the root layer. In that that case, we use the clipped rects. This is necessary so that overlap testing is performed against other clipped rects (see comments in OverlapMap::Add for how clipped vs unclipped comparisons work). However, since the root layer is now a scrolling layer, this would break overlap testing for boxes that are offscreen. This CL additionally makes overlap test-related clipping ignore the root layer so that the clipped_absolute_bounding_box for the root layer is actually unclipped, as pre-RLS. The newly added test covers this case. Bug: 783532 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5e302f3f29775d829b94593e8053025c5da0f980 Reviewed-on: https://chromium-review.googlesource.com/742506Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Anita Woodruff authored
- I no longer think this TODO to remove the DCHECK is necessary: It's appropriate to DCHECK since we should only ever create a channel if the old status is UNAVAILABLE, or the same as the new status (to handle the possibility that two code paths try to create a channel at the same time, e.g. during channel migration). Bug: 700377 Change-Id: I0554d2962051863a6c38a9f9ccb262f905f6a241 Reviewed-on: https://chromium-review.googlesource.com/544842 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 761994 Change-Id: I7eb1f7e457eb3a1d23f734c15ba1dc898ade4e52 Reviewed-on: https://chromium-review.googlesource.com/779423Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517833}
-
Dmitry Gozman authored
This is a preparation step to migrate DevTools for shared workers to Mojo. Drive-by: rewrite the test to use new DevToolsAgentHostObserver. Bug: 776009 Change-Id: Ia1f3f4952e8d8ac834a36f94c680cb81e7c50e0e Reviewed-on: https://chromium-review.googlesource.com/777740 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#517832}
-
Renee Wright authored
Also change CSSPropertyValue to take a CSSProperty instead of a CSSPropertyID. This is part of Project Ribbon. This is the first patch in a series which will replace CSSPropertyID with CSSProperty references in the style engine wherever possible. The next patches will propagate this change further out into the rest of the animation directory, and CSSPropertyValueSet. Bug: 779939 Change-Id: I3f30c52a06185933a591d60f080803af72369d72 Reviewed-on: https://chromium-review.googlesource.com/765620 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#517831}
-
