GitLab

This was an incorrect conversion from the old UI; VPN should show
the proxy section.

Bug: 802930
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iba5385a7286b8fc2c2b92a5ab15a4add65b79870
Reviewed-on: https://chromium-review.googlesource.com/876983Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530679}

This performs reload in the browser, to make it more consistent with
regular reload expirience (e.g. warning about resubmitting POST
navigation would be shown now).

Bug: 614869
Change-Id: I90d36eb389b04cc41f5ab7524cbc6209bf100412
Reviewed-on: https://chromium-review.googlesource.com/860575
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530678}

https://pdfium.googlesource.com/pdfium.git/+log/f668ed47ae54..5ca283f37681

$ git log f668ed47a..5ca283f37 --date=short --no-merges --format='%ad %ae %s'
2018-01-19 rharrison Remove code added in by a bad rebase or merge
2018-01-19 hnakashima Fix CFX_Matrix.RotateAt()

Created with:
  roll-dep src/third_party/pdfium
BUG=803732,803735


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib98604211a47521d853516da68adcdf091973e43
Reviewed-on: https://chromium-review.googlesource.com/876882
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530677}

This was only recently noticed when Shill started setting the property.

Bug: 798924
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I031e0faf80fda62c006968009ab746d8c105e2de
Reviewed-on: https://chromium-review.googlesource.com/876881
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530676}

A handful of TestExpectations entries noted in crbug.com/508734 tracked
test behavior changes back when --enable-wptserve was a thing. Now it's
the default for imported tests, so rebaseline and/or update expectations
with specific tracking bugs.

Bug: 508728,508734,651778,803942,803949
Change-Id: I9b360f3f2e0d46320e0c063ce27f992cfd8d2e81
Reviewed-on: https://chromium-review.googlesource.com/876769Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530675}

The CSSGeneratedImageValue image and client cache has only
one slot for the size of the image associated with any given
client, but the client could be registered with an empty size
and a non-empty size. In such cases we would not over-write
the non-empty size with the empty size, despite having deleted
the non-empty image. Subsequently removing the client again
would try to remove the non-empty one instead.

This patch adds DCHECKs to catch these cases, and fixes the
logic to only store non-empty sizes. Comments are added explaining
the invariant that the client only be present at one non-empty size
at any given time.

R=fs@opera.com
BUG=803224

Change-Id: Ie5601aaffe6e3eace4ff4a989dc892bea4fd381b
Reviewed-on: https://chromium-review.googlesource.com/876900Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530674}

Screenshot: https://drive.google.com/file/d/1H0fFnEPwxOtIwXQ_XOyChjaR-V88klKq/view?usp=sharing

Bug: 803191
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a41f51a82213f628a3ab11b5af341cc94f89a56
Reviewed-on: https://chromium-review.googlesource.com/876765Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530673}

R=piman@chromium.org

Change-Id: If0c213fe5b96ce874908a9ebafd92923c7c56be8
Reviewed-on: https://chromium-review.googlesource.com/877183Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530672}

Also refine GetActiveTextureUnit and FakeResourceProvider.
This was to followup https://chromium-review.googlesource.com/c/chromium/src/+/859106.

BUG=757291

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I40dd516e12c35a2388e9c857e87dbe83e638804c
Reviewed-on: https://chromium-review.googlesource.com/875530Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#530671}

GamepadSharedBuffer was internally creating an anonymous shared memory
object, prohibiting the object from being sharable as anything other
than read-write on some platforms.

This CL corrects the situation.

Bug: 803768
Change-Id: I122d71753be2dd02d12e5bb9f23c1bfc71623f34
Reviewed-on: https://chromium-review.googlesource.com/877042Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530670}

This is a speculative fix to a problem that is causing flakiness on
site isolation browser tests. It looks like the cause is that hit test
queries are being sent to renderers before the LocalFrameView has begun
lifecycle updates. These fail on out-of-process iframes when the
Document has had layout but has not composited because
BeginLifecycleUpdates() has not yet been called. This triggers a DCHECK
on the hit testing path in PaintLayer.

This change prevents hit testing in that case.

Bug: 798476
Change-Id: Ie44fd3d5b988e1c758b7472af6444d7b260b15ec
Reviewed-on: https://chromium-review.googlesource.com/876939
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530669}

Apps should be able to use NEL, but they shouldn't share state with the
main request context.

Bug: 803604
Change-Id: I6533ce46e21c2b47e888524aeeeb293367919ab3
Reviewed-on: https://chromium-review.googlesource.com/875050
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530668}

Replace WaitUntilCondition with WaitUntilConditionOrTimeout.

Bug: 784735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I73039a4c54223d64ddab73a8ef9a7eb8e93ea1a3
Reviewed-on: https://chromium-review.googlesource.com/874552Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530667}

Prevent SpdySessions from being shared by SpdyStreams using different socket
tags by keying SpdySessions on socket tags.  In other words when a
request comes in, an existing SpdySession will be found and reused if
the socket tag of the SpdySession matches that of the request,
otherwise a new TransportClientSocket, SSLClientSocket, and potentially
SpdySession will be created.  This functionality is achieved by adding
the socket tag to the SpdySessionKey.  HttpStreamFactoryImplJob passes
the socket tag from the HttpRequestInfo down to SpdySessionKey().

Bug: 520198
Change-Id: I495f241ea3a60f9070b049450b8fc8a418914795
Reviewed-on: https://chromium-review.googlesource.com/867354
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530666}

Bug: 800883
Change-Id: I34d2085f0f3d3d94e6120e1a7c9fa1a1f6443d67
Reviewed-on: https://chromium-review.googlesource.com/869331
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530665}

Bug: 738275, 799268
Change-Id: I6a2c4b313879b7d690661fe95d4d84ed03315028
Reviewed-on: https://chromium-review.googlesource.com/876987Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530664}

BUG=784732
TEST=Ran base_unittests -gtest_filter=*Optional*

Change-Id: Ibb5d7cc5d62deacdba7f811f5a7b83c1c58c3907
Reviewed-on: https://chromium-review.googlesource.com/855976Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530663}

In StylesSidebarPane, you can press Arrow keys to increment a numeric value.
Holding Alt/Shift/Ctrl can affect the delta by 0.1/10/100

This CL
- Brings the same ability to 2 clients of UI.bindInput(): Latitude/longitude in
  Sensors and width/height in Device Mode
- Gives Latitude/longitude smaller step sizes of 0.01/1/10.

Bug: 637897
Change-Id: I3844280a71449ab5021c9aadee9313cb626379b6
Reviewed-on: https://chromium-review.googlesource.com/818535Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530662}

This adds a parameter to ConnectToNetwork 'succeed_on_send_connect'.
If set, ConnectToNetwork will call the 'success' callback as soon as
a connect request is sent to Shill (if there were no configuration
errors) instead of after the connect succeeds.

This is used by the networkingPrivate implementation to more correctly
implement the API.

This CL causes the Settings based network config UI to close its dialog
when the connection starts.

Bug: 795715
For minor changes to comonents/arc/net:
TBR=hidehiko@chromium.org

Change-Id: I5de65a32a46d57dc628c65542a275505d4d7c944
Reviewed-on: https://chromium-review.googlesource.com/875002Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530661}

Cancel the previous autofill session until the new autofill session
is triggered. We don't cancel the autofill session when WebView
navigates to the new page now.

This should also improve the detection of form submission.

Bug: 791182
Change-Id: I883b322f921ef29221995681ad07044d35bfb76d
Reviewed-on: https://chromium-review.googlesource.com/876507Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530660}

Bug: 803888
Change-Id: Ia818b0ac6454d52dc51bea997d0ec814ee4905e9
Reviewed-on: https://chromium-review.googlesource.com/868505Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530659}

BUG=749713
TEST=manual

Change-Id: I05908a8761336bf6bb8daf24e40201536ab16c40
Reviewed-on: https://chromium-review.googlesource.com/876940Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530658}

Bug: none
Test: still compiles
Change-Id: Ie57ac85850a2dc2fa6985b216a77c339658f472a
Reviewed-on: https://chromium-review.googlesource.com/876492Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530657}

Bug: Skia:7500

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie5ed5ad7c4baeec95bad0710e156f6eb9008e95b
Reviewed-on: https://chromium-review.googlesource.com/876444Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530656}

This paves the way for getting rid of TYPE_BLOB elements (or
at least not having to reintroduce TYPE_BLOB when BlobDataItem
is updated to no longer depend on network::DataElement).

TBR=kinuko@chromium.org

Bug: 803585
Change-Id: I344b7a16a1686059a2b4058cc46711444f96f8f5
Reviewed-on: https://chromium-review.googlesource.com/876527
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530655}

https://skia.googlesource.com/skia.git/+log/b1b80f7de422..16d0ad06b468

$ git log b1b80f7de..16d0ad06b --date=short --no-merges --format='%ad %ae %s'
2018-01-19 fmalita [skottie,sksg] Improved shape group semantics
2018-01-19 reed use GrFPArgs for maskfilters
2018-01-19 robertphillips Move more internal methods from GrContext to GrContextPriv (take 2)
2018-01-19 robertphillips Add explicit abandoned flag to the GrProxyProvider
2018-01-19 egdaniel Add Android_API26 bot to CQ
2018-01-17 reed drawimage + maskfilter bug fix
2018-01-19 robertphillips Split GrContext into Normal/DDL flavors
2018-01-19 reed check for crazy bounds from fuzzer
2018-01-19 halcanary Revert "Move more internal methods from GrContext to GrContextPriv"
2018-01-19 halcanary SkQP: use bitmap.pixmap()
2018-01-19 robertphillips Move more internal methods from GrContext to GrContextPriv
2018-01-19 reed make rrect's more self-consistent, check drawable index
2018-01-19 scroggo Stop defining SK_CODEC_PRINTF in debug
2018-01-18 csmartdalton ccpr: Blacklist vertex shaders on ANGLE/Skylake
2018-01-19 reed rename inner AsFPArgs to stand-alone GrFPArgs
2018-01-19 egdaniel Delete SkColorSpaceXformImageGenerator and SkImagePriv::SkMakeImageInColorSpace
2018-01-19 hcm Update Skia milestone to 66
2018-01-19 brianosman Add more asserts about MSAA render buffers and FBO 0

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I8e84eb4eb8c40e79498172ce3c7c56d6c576d8b6
Reviewed-on: https://chromium-review.googlesource.com/876768
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530654}

The condition actually applies to all SPv175+.

Bug: 771643
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8f0910050c2e3e4b9b80a076bb951feaacf31166
Reviewed-on: https://chromium-review.googlesource.com/876956Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530653}

The WebStateObserver callback specifies that the change is for the
visible SSL status, so we should be checking agains the visible item.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie0eca53ded643167e3f48a94e80ea5090277712a
Reviewed-on: https://chromium-review.googlesource.com/877103Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530652}

on connectivity probing path for connection migration v2.

Bug: 
Change-Id: Ide2f376ee514a76028e8a5694cd536e64d680cff
Reviewed-on: https://chromium-review.googlesource.com/779039Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530651}

Bug: 799616
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic05966416c1f82dd593d061cccc9ac0a2728b588
Reviewed-on: https://chromium-review.googlesource.com/853172
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530650}

Merge flag changes.
https://chromium-review.googlesource.com/c/874891/

Deprecate FLAGS_quic_reloadable_flag_quic_explicit_close_after_tlp.  It was globally enabled around December 1st and had an associated increase in IDLE timeouts sent by the server and received by Chrome.

Merge internal change: 181974765
https://chromium-review.googlesource.com/c/873931/

Ignore the ack delay supplied in a QUIC ack frame if it results in an RTT less than min_rtt.  Protected by FLAGS_quic_reloadable_flag_quic_min_rtt_ack_delay.
Reflects IETF PR#975(https://github.com/quicwg/base-drafts/pull/975)

Merge internal change: 181917067
https://chromium-review.googlesource.com/c/873930/

Notify QuicSentPacketManager when a connectivity probing packet is sent. Not flag protected.

Merge internal change: 181768745
https://chromium-review.googlesource.com/c/873492/

Support multi-packet CHLOs when using LOAS.
Protected by FLAGS_quic_reloadable_flag_quic_inspect_chlo_tags.

Merge internal change: 181638450
https://chromium-review.googlesource.com/c/871531/

In QUIC, factor checking whether a transmission info has retransmittable frames to a standalone function. No functional change expected. Not protected.

Merge internal change: 181634653
https://chromium-review.googlesource.com/c/871550/

Change number of notifications to bytes_to_ack for TestAckListener in e2e test.

Merge internal change: 181605627
https://chromium-review.googlesource.com/c/871530/

Applied ClangTidy fixes.

Merge internal change: 181499563
https://chromium-review.googlesource.com/c/871471/

Remove unused least_packet_awaited_by_peer_ from QuicSentPacketManager. Not flag protected.

Merge internal change: 181492456
https://chromium-review.googlesource.com/c/870817/

Add IETF/QUIC  VarInt encoding
This CL adds code to do IETF-style Quic VarInt encoding
and decoding.  This code is not used anyplace as of this
writing; it's being added in support of later Ietfization
efforts.
No operational effects; adding code to be used later

Merge internal change: 181481889
https://chromium-review.googlesource.com/c/870816/

- Stop quic_frame.h from including itself.
- Make "enum QuicFrameType" smaller by changing it to "enum QuicFrameType : int8_t", this is ok because it is only used in memory, never used on wire directly.

Merge internal change: 181476510
https://chromium-review.googlesource.com/c/870815/

In QUIC, mark stream connection level write blocked when it gets flow control unblocked. Protected by FLAGS_quic_reloadable_flag_quic_streams_unblocked_by_session.

Merge internal change: 181468440
https://chromium-review.googlesource.com/c/871231/

Applied ClangTidy fixes.

Merge internal change: 181464835
https://chromium-review.googlesource.com/c/868240/

Deprecate FLAGS_quic_reloadable_flag_quic_allow_address_change_for_udp_proxy.

Merge internal change: 181461339
https://chromium-review.googlesource.com/c/868915/

In QUIC, move goaway_sent_ and goaway_received_ from QuicConnection to QuicSession. Not protected, no functional change expected.

Merge internal change: 181456008
https://chromium-review.googlesource.com/c/868914/

R=rch@chromium.org

Change-Id: I7e7c67e15d23075e9bc7e368e089225937ffbbf7
Reviewed-on: https://chromium-review.googlesource.com/874897
Commit-Queue: Bin Wu <wub@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530649}

This CL changes the identity internals from using the old i18n-content
to the new $i18n{} replacement.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia603e5463eaff981a6bf7902d8eff36642602f5d
Reviewed-on: https://chromium-review.googlesource.com/872431Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530648}

Removes the try/catch block that leads to an Assert.fail in favor of
using a Callable vs. Runnable to let the exception be thrown as is.

Change-Id: I9987ebfa93354d05239753800cf58df4bb1b6560
Reviewed-on: https://chromium-review.googlesource.com/876948Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530647}

The 'Clear Site Storage' button within the site settings menu in
preferences is currently solid gray regardless of whether or not it has
focus. This patch fixes it to respond when it receives BT keyboard
focus.

Bug: 803960
Change-Id: Ief3f2ad856fd2cea7e99609a8286a6c0307ee9e5
Reviewed-on: https://chromium-review.googlesource.com/876959Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530646}

These tests flake under our Fuchsia/x64 try-bots.

Bug: 776424
Change-Id: I706ed77b4a2e882c9f1f3d042fc11677ceee440e
Reviewed-on: https://chromium-review.googlesource.com/876126
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530645}

This CL adds some simple tests to the SubresourceFilter in filtering
ads on sites violating the better ads standard.

Followups will include tests for other android-specific features like UI.

Bug: 800176
Change-Id: I28a1c8c7af4a2646ddf9572c2560d6cf43c18f3a
Reviewed-on: https://chromium-review.googlesource.com/857656Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530644}

These same constant names are used in MediaRemotingInterstitial.cpp,
which causes the jumbo build to fail.

Bug: 726619
TBR=jochen@chromium.org

Change-Id: I2c2cc45f010b1212185d59a58dcf070ef0e16ee1
Reviewed-on: https://chromium-review.googlesource.com/876015
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530643}

Fixes CatchFail warnings by throwing AssertionErrors with the original
exception instead of calling Assert.fail with a message and no stack
trace.

A couple tests were using assert instead of the appropriate junit.Assert
method, and causing a UseCorrectAssertInTests warning. These were fixed.

Change-Id: I72089ab76197b048baa9cb319f8269613a4674fe
Reviewed-on: https://chromium-review.googlesource.com/876982Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530642}

Cronet doesn't support controlling base::Features, so:
1. For Chromium, move the base::Feature check to NetworkContext.
2. For Cronet, add an experimental feature.

TBR=mkwst@chromium.org

Bug: 799616
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5baab77588d8f1ef9d292febca826777820b6a23
Reviewed-on: https://chromium-review.googlesource.com/858176
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530641}

Throws an AssertionError containing the stack trace instead of calling
Assert.fail, and gets rid of a try/catch block for an exception that
won't occur.

Change-Id: Ia6342346599dd1042c555dc144fab24808129660
Reviewed-on: https://chromium-review.googlesource.com/876824Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530640}