GitLab

isolate it to skia/ext/ for simpler refactoring.

I took the opportunity to also change calls to the deprecated
SkCanvas::getDeviceSize() to the preferred replacement,
SkCanvas::getBaseLayerSize().

R=fmalita@chromium.org,junov@chromium.org
BUG=543755
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1432443004

Cr-Commit-Position: refs/heads/master@{#361196}

It is now legal for Blink to provide an implementation of cc::LayerClient.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/1468753002

Cr-Commit-Position: refs/heads/master@{#361195}

Doing this prevents us from logging bogus values (for duplicate and could_fire) in case of failure.

BUG=559143

Review URL: https://codereview.chromium.org/1465533006

Cr-Commit-Position: refs/heads/master@{#361194}

This guarantees that any throttling-specific errors do no affect no-throttling scenario.

BUG=none

Review URL: https://codereview.chromium.org/1461403003

Cr-Commit-Position: refs/heads/master@{#361193}

Allow usage of |std::begin| and |std::end|. This is useful for iterating
fixed-size arrays.

Discussion thread: https://groups.google.com/a/chromium.org/d/topic/cxx/5iFNE8P5qT4/discussion

Furthermore, this CL replaces home-brewn |std::end|-like functions in
base/trace_event with |std::end| to verify that <iterator> is supported
on all platforms.

Review URL: https://codereview.chromium.org/1471683002

Cr-Commit-Position: refs/heads/master@{#361192}

net::TCPServerSocket::Listen will close its internal socket if it fails
to bind and begin listening. This leaves the extensions socket object in
a bad state. Instead reset the socket so that an application can try to
bind it again.

BUG=559368

Review URL: https://codereview.chromium.org/1463293004

Cr-Commit-Position: refs/heads/master@{#361191}

The action uses the NaCl IRT files as inputs, but lacks the
necessary dependencies on the the targets that build them.

BUG= 512869
R=dpranke@chromium.org, gab@chromium.org

Review URL: https://codereview.chromium.org/1460113002

Cr-Commit-Position: refs/heads/master@{#361190}

BUG=559530
NOTRY=true

Review URL: https://codereview.chromium.org/1470023002

Cr-Commit-Position: refs/heads/master@{#361189}

This bug reproduces at times with multiple monitors and occurs when our attempt to
retrieve the taskbar edge information via the ABM_GETAUTOHIDEBAR appbar message fails.
msdn recommends using the ABM_GETAUTOHIDEBAREX call with the monitor rectangle for the multiple
monitor case. However that does not work.

The following fallback does work though.
1. Query for the auto hide status of the taskbar.
2. Retrieve its position and check if the edge information returned in this call matches the
   edge we are looking for. This along with the monitor check is sufficient.

BUG=472139
TEST=Set taskbar to autohide. Connect multiple monitors to the machine and start chrome on the
primary monitor and attempt to reproduce this case. If it does not repro then move chrome to
the other monitor and attempt the test case. If that fails, disconnect the secondary monitor
exit chrome and try. One of these cases should reproduce the problem.

Review URL: https://codereview.chromium.org/1462373003

Cr-Commit-Position: refs/heads/master@{#361188}

cl/1436373002 removed this field from the response, which created
inconsistent behavior between service_discovery_client_impl.cc
and service_discovery_client_mac.mm.

Also added test expectations to catch the regression.

BUG=560448
R=vitalybuka@chromium.org
CC=wez@chromium.org

Review URL: https://codereview.chromium.org/1467393002

Cr-Commit-Position: refs/heads/master@{#361187}

BUG=559338

Review URL: https://codereview.chromium.org/1469503002

Cr-Commit-Position: refs/heads/master@{#361186}

Telemetry's find_dependencies has reached the end of its deprecation cycle, and
the version in tools/perf is now the recommended one to use.

BUG=528331

Review URL: https://codereview.chromium.org/1472923003

Cr-Commit-Position: refs/heads/master@{#361185}

BUG=

Review URL: https://codereview.chromium.org/1465283002

Cr-Commit-Position: refs/heads/master@{#361184}

This patch starts generating transform and effect paint property nodes
for SVG. PaintPropertyTreeBuilder has been changed to walk both
LayoutBoxModelObjects and SVG nodes. The effect node generation is
straightforward, but SVG transform nodes need some svg-specific logic:
  1) SVG does not use paint offset because everything is effectively
     absolutely positioned. The SVG root element now always creates a
     paint offset transform so all children do not need to.
  2) SVG bakes the transform origin into all matrices. We may want to
     refactor this later to support compositor animations.
  3) At the SVG->HTML boundary, out-of-flow and fixed positioning
     data is kept up to date by checking for both xforms and isSVGRoot.

BUG=537409

Review URL: https://codereview.chromium.org/1461223002

Cr-Commit-Position: refs/heads/master@{#361183}

Review URL: https://codereview.chromium.org/1466253002

Cr-Commit-Position: refs/heads/master@{#361182}

Create a SVG1DOMFilter UseCounter to measure all filter related SVG
DOM functionality. The assumption we want to test is that the filter
related SVG DOM has really low usage.

From a quick test it would shave off 90kb of the binary if we could
remove it. That's only counting binding code and there is a good
chance number-optional-number related functionality can be removed
too, if these interfaces can be removed.

BUG=415074

Review URL: https://codereview.chromium.org/1472773002

Cr-Commit-Position: refs/heads/master@{#361181}

These formats don't work for TexStorage3D if target is TEXTURE_3D.
TEXTURE_2D_ARRAY should work.

BUG=295792
TEST=conformance2/textures/misc/tex-storage-compressed-formats.html

Committed: https://crrev.com/5b5a54a2d7c287e09f644d04e29718b310949221
Cr-Commit-Position: refs/heads/master@{#360760}

Review URL: https://codereview.chromium.org/1463503002

Cr-Commit-Position: refs/heads/master@{#361180}

To ensure layer is set needsRepaint().

BUG=536999
TEST=scrollbars/scrollbar-added-during-drag.html etc with sync painting enabled

Review URL: https://codereview.chromium.org/1469823004

Cr-Commit-Position: refs/heads/master@{#361179}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2280bfa0..01158a14

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1468883004

Cr-Commit-Position: refs/heads/master@{#361178}

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1469733004

Cr-Commit-Position: refs/heads/master@{#361177}

This removes the DocumentTabObserver as a separate class inside
DocumentTab. It also add the favicon image as a param to
onFaviconUpdated inside TabObserver and uses that to update the
icon used for task descriptions to largest size in both Document
and WebAppActivities.

BUG=546182

Review URL: https://codereview.chromium.org/1464743005

Cr-Commit-Position: refs/heads/master@{#361176}

For a normal SQLite build using uClibc, autoconf would generate a
config.h which SQLite would use.  Chromium's build system doesn't make
it easy to use different versions of a file depending on platform.
Use SQLite's config.h support to build a hybrid which allows additional
preprocessor detection.

BUG=489784

Review URL: https://codereview.chromium.org/1437823005

Cr-Commit-Position: refs/heads/master@{#361175}

Revert of DevTools: Add dark theme hidden experiment (patchset #2 id:20001 of https://codereview.chromium.org/1458223005/ )

Reason for revert:
Since the theme does not work and can't be used, this should really be behind 10 shifts.

Original issue's description:
> DevTools: Add dark theme hidden experiment
>
> BUG=559524
>
> Committed: https://crrev.com/a7d0f43f83b514a46ec3850aab3160412cdd8a53
> Cr-Commit-Position: refs/heads/master@{#361015}

TBR=paulirish@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=559524

Review URL: https://codereview.chromium.org/1471693003

Cr-Commit-Position: refs/heads/master@{#361174}

BUG=510485

Review URL: https://codereview.chromium.org/1442473002

Cr-Commit-Position: refs/heads/master@{#361173}

This fixes initializer for benchmark_enabled to actually check for both benchmark and
latencyInfo to match the categories actually used in trace events and renames it to
latency_info_enabled.

BUG=520659

Review URL: https://codereview.chromium.org/1462923003

Cr-Commit-Position: refs/heads/master@{#361172}

R=tkent
BUG=

Review URL: https://codereview.chromium.org/1470873002

Cr-Commit-Position: refs/heads/master@{#361171}

win platform to be 1 to temporarily fix the race condition on
win bot.

BUG=559154
NOTRY=true

Review URL: https://codereview.chromium.org/1471673003

Cr-Commit-Position: refs/heads/master@{#361170}

It used to be that WebContentsImpl only knew about the RWHs created
  through WebContentsImpl::CreateNewWidget() and stored them in
  WCI::created_widgets_. However, widgets created through
  FrameTree::CreateRenderViewHost() used to be left out.
This made RenderWidgetHostImpl::WasResized() to incorrectly send
  ViewMsg_Resize while the WebContents was being torn down. WasResized()
  has a check for !delegate_ but |delegate_| never became nullptr during
  WebContentsImpl shutdown. Adding all widgets to WCI::created_widgets_
  will ensure that we notify RWHs about the delegate's (WC) destruction
  via DetachDelegate and do not send ViewMsg_Resize while a the delegate
  (WC) is shutting down.

BUG=523644, 523451
Test=See https://code.google.com/p/chromium/issues/detail?id=523644#c16
  for repro steps. Ensure the renderer does not crash.

Review URL: https://codereview.chromium.org/1457203002

Cr-Commit-Position: refs/heads/master@{#361169}

There are instances where callbacks and events can be triggered
and then the host tab for Reader Mode is destroyed. This change
adds checks for these cases.

BUG=556930, 556456, 556354

Review URL: https://codereview.chromium.org/1451103004

Cr-Commit-Position: refs/heads/master@{#361168}

BUG=558839

Review URL: https://codereview.chromium.org/1457883004

Cr-Commit-Position: refs/heads/master@{#361167}

TBR=brettw@chromium.org
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1469783002

Cr-Commit-Position: refs/heads/master@{#361166}

TBR=haraken
BUG=559300

Review URL: https://codereview.chromium.org/1468173002

Cr-Commit-Position: refs/heads/master@{#361165}

BUG=527856

Review URL: https://codereview.chromium.org/1434413002

Cr-Commit-Position: refs/heads/master@{#361164}

Revert of views/mus: Fix showing menu in chrome in mus. (patchset #2 id:20001 of https://codereview.chromium.org/1460003004/ )

Reason for revert:
Suspected in build failure. see crbug.com/560461

Original issue's description:
> views/mus: Fix showing menu in chrome in mus.
>
> For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
> window. For desktop builds, this means we attempt to host in a HWND or an
> X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
> NativeWidgetMus. To do this, use the native-widget factory first if it's
> available.
>
> BUG=none
>
> Committed: https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971
> Cr-Commit-Position: refs/heads/master@{#361151}

TBR=sky@chromium.org,jam@chromium.org,sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1472873003

Cr-Commit-Position: refs/heads/master@{#361163}

We'll need this for cursors and shadows.

BUG=548426
TEST=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/1466483003

Cr-Commit-Position: refs/heads/master@{#361162}

BUG=557739

Review URL: https://codereview.chromium.org/1470613003

Cr-Commit-Position: refs/heads/master@{#361161}

1. Scrolls the page when navigating to a node, and updates the active indicator
location when a scroll event is received.

2. Update the active indicator location on every Output, rather than only
for speech or only for braille. (It was sometimes getting set and then
overwritten with nothing.)

3. Handle subranges within a node with a new boundsForRange API.

4. Automation API: implement boundsForRange, take frame offsets and
scroll offsets into account when returning a node's bounding box,
and use heuristics to avoid returning an empty bounding box.

BUG=537248
TBR=aboxhall

Review URL: https://codereview.chromium.org/1458723002

Cr-Commit-Position: refs/heads/master@{#361160}

TEST=conformance2/renderbuffers/framebuffer-test.html, gpu_unittests

BUG=429053

Review URL: https://codereview.chromium.org/1236053003

Cr-Commit-Position: refs/heads/master@{#361159}

Previously, the interface for URLRequestJob::ReadRawData was as follows:

  bool ReadRawData(IOBuffer*, int, int*)

Subclasses were expected to signal completion of the ReadRawData call by
calling NotifyDone, SetStatus, or maybe one of the other Notify* functions
on URLRequestJob, most of which do internal housekeeping and also drive the
URLRequest's state machine. This made it difficult to reason about the
URLRequestJob's state machine and needlessly complicated most of URLRequestJob.

The new interface is as follows:

  int ReadRawData(IOBuffer*, int)

Subclasses are required to either:

a) Return ERR_IO_PENDING, and call ReadRawDataComplete when the read completes in any way, or
b) Return a count of bytes read >= 0, indicating synchronous success, or
c) Return another error code < 0, indicating synchronous failure.

This substantially narrows the interface between URLRequestJob and its
subclasses and moves the logic for the URLRequest state machine largely into
URLRequestJob.

Also, the signature of URLRequestJob::ReadFilteredData and some other internal
URLRequestJob helpers changes to propagate detailed error codes instead of
coercing all errors to FAILED.

TBR=michaeln@chromium.org,mnaganov@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,davidben@chromium.org,falken@chromium.org,mtomasz@chromium.org, sky@chromium.org,jianli@chromium.org,zork@chromium.org,rdsmith@chromium.org
BUG=553300

Review URL: https://codereview.chromium.org/1467603002

Cr-Commit-Position: refs/heads/master@{#361158}

BUG=

Review URL: https://codereview.chromium.org/1468123002

Cr-Commit-Position: refs/heads/master@{#361157}