GitLab

This reverts commit b567cf95.

Reason for revert: breaking official.continuous builders
BUG=751954

Original change's description:
> Add a "buildbucket" subcommand to mb.
> 
> This subcommand prints the trybot configuration in the
> buildbucket.config format expected by gerrit. This should hopefully
> make it a little easier to maintain the buildbucket.config file.
> 
> Bug: 
> Change-Id: I7d956efb6c08128ae0ceaa6b68bcc9001296549c
> Reviewed-on: https://chromium-review.googlesource.com/568666
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491647}

TBR=agable@chromium.org,dpranke@chromium.org,pcc@chromium.org

Change-Id: I2cc5f086b9787723337795c3c2323c3bafdc89f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/599393Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491656}

This logic was incorrectly inverted.

Bug: 735613
Change-Id: Ib07302612c02e860c006f0cc2e9929a04f5de009
Reviewed-on: https://chromium-review.googlesource.com/596710
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491655}

This reverts commit a34be8ec.

Reason for revert: http://eureka-internal-review.git/c/81685

Original change's description:
> Make audio frame chunk_size a factor of 4
> 
> BUG=internal b/63390317
> 
> Change-Id: Ia1c11717aea70bdda8e5542fea89b0e7c7c0a46b
> Reviewed-on: https://chromium-review.googlesource.com/588470
> Reviewed-by: Le-Chun Wu <lcwu@chromium.org>
> Commit-Queue: Michael Montvelishsky <mont@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490290}

TBR=lcwu@chromium.org,slan@chromium.org,halliwell@chromium.org,wzhong@chromium.org,jyw@chromium.org,kmackay@chromium.org,bshaya@google.com,alokp@chromium.org,mont@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: internal b/63390317
Change-Id: I09c7154a5f065e320ca440583aebbd3495c6cc33
Reviewed-on: https://chromium-review.googlesource.com/598387Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Michael Montvelishsky <mont@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491654}

Make the Site Details web UI update permission values when they change without
needing to reload the Site Details page.

Manual test - With #enable-site-details on, open https://permission.site. Open
the Page Info bubble, click "Site settings", and drag the Site Details tab out
into a new window so that the https://permission.site and the Site Details
windows are viewable at the same time. On https://permission.site, open the Page
Info bubble and change a permission there. It should automatically update to
show the same permission in the Site Details page.

Bug: 656758
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If1b28afbed3317a7ac43ada1d8ca02424137b50d
Reviewed-on: https://chromium-review.googlesource.com/595299
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491653}

TBR: chenwilliam@chromium.org,dgozman@chromium.org
Bug: 751906
Change-Id: I44c2496307f32343b5120884ed58a9b4e0933722
Reviewed-on: https://chromium-review.googlesource.com/599135Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491652}

Bug: 748416
Change-Id: I37d13c799e61fff05bc75675a888ce2630995aa0
Reviewed-on: https://chromium-review.googlesource.com/597576
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491651}

We had tried filtering noisy ARC processes out, using their
ProcessState. However, ideally the task manager should summarise the
total resource usage and not completely hide processes. Further, there
were some hard to resolve issues about processes that ought to
definitely be shown being hidden (see linked bug for context). So, until
we have a better solution for noisy ARC processes, remove this filter.

BUG=738651

Change-Id: Icf9d246e053185af5c5d7b20f90245fcd169ecc8
Reviewed-on: https://chromium-review.googlesource.com/582265Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491650}

This reverts commit 433d6917.

Reason for revert: Metrics related tests are failing. See crbug.com/751948


BUG:751948

Original change's description:
> Make MetricsLog not need a PrefService.
> 
> Move system profile persistence to MetricsService.
> 
> Bug: 
> Change-Id: I5c31dc53de267dd9699a83af926f8a575bab18a0
> Reviewed-on: https://chromium-review.googlesource.com/592689
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491573}

TBR=bcwhite@chromium.org,holte@chromium.org,olivierrobin@chromium.org

Change-Id: Id9e35a2388566faf7681cddd34fdab9b83db0e03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/599089Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491649}

NOTRY=true

Bug: 746157
Change-Id: If1a8d3ecfa0101f6a8d432c658f676089830203c
Reviewed-on: https://chromium-review.googlesource.com/599270Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491648}

This subcommand prints the trybot configuration in the
buildbucket.config format expected by gerrit. This should hopefully
make it a little easier to maintain the buildbucket.config file.

Bug: 
Change-Id: I7d956efb6c08128ae0ceaa6b68bcc9001296549c
Reviewed-on: https://chromium-review.googlesource.com/568666Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491647}

Because Skia blacklists MSAA on Intel GPUs independently from Chrome, we
can end up in situations on dual-GPU Macs where CC thinks that
MSAA is available while Skia has it blacklisted. In order to avoid
these situations, we will blacklist MSAA for both GPUs (on the
Chrome side) if we want to blacklist either.

Bug: 749438, 751919
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I537ef3286f1a83330c58ae8e43e7133752575509
Reviewed-on: https://chromium-review.googlesource.com/599224Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491646}

AppWindowClient::Set sets the global AppWindowClient. Unit tests
sometimes call it more than once, e.g. when multiple BrowserProcesses
are created. Currently, each additional call silently returns instead of
changing g_client. Even Set(nullptr) does nothing.

Normally, this is fine: only tests should call it more than once, and
usually it's called with the same value anyway (because BrowserProcess
and TestingBrowserProcess both use the global ChromeAppWindowClient
singleton).

Some tests do create and destroy unique AppWindowClients, like ones in
app_shell_unittest. This CL allows g_client to be changed to nullptr and
then to a new value. Otherwise, since these tests run sequentially in the
same process, g_client may point to freed memory. This will become an
issue as we add more tests here.

Bug: 751242
Change-Id: I1bfa8f12f1fbbd5e086ae3c033e038b93c5a18ce
Reviewed-on: https://chromium-review.googlesource.com/593052
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491645}

The DesktopPWAWindowing feature must be on in order for this to work.

Makes it so that, once a user has installed a Bookmark App for a website, all
navigations to that website will open the installed Bookmark App. This includes
typing the address in the omnibox, clicking any links to an in-scope url, and
opening any links to an in-scope url from the context menu. Future patches
will change some of these so that the result is more intuitive.

For example, if the user has installed https://www.foo.com through
"Add to shelf" and the site's manifest defines scope as "/scope" and then the
user visits https://www.foo.com/scope/test.html, a new app window to
https://www.foo.com/scope/test.html will open. If the user
navigated to https://www.foo.com/index.html, we would not open a new app
window since the address is not in-scope as defined by the site's manifest.

Three changes:

1. Use 'scope' in the site's manifest to create a url handler for
   the bookmark app.
2. Allow Hosted Apps that are Bookmark apps to use url handlers.
   This means that any non-bookmark hosted app that has url handlers
   will fail to load.
3. When handling a url that a Bookmark app could handle open the
   the bookmark app with the specified url.

Bug: 740783
Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0
Reviewed-on: https://chromium-review.googlesource.com/566199Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491644}

SetCanonicalCookie pathway (used to just be enforced via
SetCookieWithOptions()).

Discovered in writing tests for the cookie service, so using that bug.

Bug: 721395
Change-Id: I6d8b0e44e99063200de6f5983d0049af4efd2bc6
Reviewed-on: https://chromium-review.googlesource.com/581797Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491643}

This patch gets rid of redundant equality checks of |Start()| and |End()| of
|VisibleSelectionTemplate| from |EqualSelectionsAlgorithm()| for improving
code health.

Change-Id: I0fd5949f8356b0527fa5e67426818434efedbee1
Reviewed-on: https://chromium-review.googlesource.com/597510Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491642}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/747d3ecd..45ad6a02

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I23411f423fa4dd71b4171930f65540c5416351ad
Reviewed-on: https://chromium-review.googlesource.com/599155Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491641}

Bug: 634443
Change-Id: If3c5536cf0dba79a14f092f9dafb701668f6c46a
Reviewed-on: https://chromium-review.googlesource.com/599327
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491640}

Added a closing animation for the peeking launcher. It lives in
AppListPresenterImpl because we use the callback function for the
animation.

The animations for all state changes will be in AppListView once we
move ui/app_list into ash/app_list. (I made  a note in 733662 for this).

bug=748190

Change-Id: I2e2e885306f2005aa3bf54470420a6aada99a3b6
Reviewed-on: https://chromium-review.googlesource.com/588083
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491639}

* This locks the compositor and prevent updating while waiting for the rotated frame.
* Timeout is currently a bit longer than I deal because Android seems to generate
  unnecessary frames that uses old bounds. I'll look into the issue separately.

Bug: b/62140863
Test: Manual.
1) Apply Android side patch: https://googleplex-android-review.git.corp.google.com/#/c/2548263/
2) Login & start ARC++ app that can rotate
3) Switch to tablet mode and tilt the device.

Change-Id: Ifb1427365cc524d69cf3b84c446fe108ca9e7a46
Reviewed-on: https://chromium-review.googlesource.com/572391
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491638}

Adds image_platform.h which declares these methods. The existing
platform-specific implementations for iOS and macOS remain in
image_ios.mm and image_mac.mm, respectively. The generic implementations
are moved to image_generic.cc.

This change makes it more obvious what's going on and moves some code
into anonymous namespace, and out of ifdefs.

Bug: 745355
Change-Id: Id40677dc1e11a0d8b6fc4db5cd22565fd7533660
Reviewed-on: https://chromium-review.googlesource.com/574994Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491637}

conformance/extensions/oes-texture-half-float-with-video.html
on Win7 Debug NVIDIA D3D11 passthrough

BUG=751849
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ieb623f457fca5937b8c82943f60ee87f7353febb
Reviewed-on: https://chromium-review.googlesource.com/599451
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491636}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c8c5d6b714f8..2857b6b6c858

$ git log c8c5d6b71..2857b6b6c --date=short --no-merges --format='%ad %ae %s'
2017-08-02 benjhayden Format chart ticks using units.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If6f91f0429c723869a69f80a6928548558895f83
Reviewed-on: https://chromium-review.googlesource.com/599215
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491635}

https://skia.googlesource.com/skia.git/+log/f12d84275cfa..255607f094da

$ git log f12d84275..255607f09 --date=short --no-merges --format='%ad %ae %s'
2017-08-02 mtklein 8-bit hacking
2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ 6c58b0620..a0bcc50be (2 commits)

Created with:
  roll-dep src/third_party/skia
BUG=750813


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I93ac33e9029b8ae6540dc545d28b4d53c986890b
Reviewed-on: https://chromium-review.googlesource.com/598511Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491634}

Now the state change will change when frames arrives, we first
need to create widget if the auto hide is set in creation time.

BUG=751915
TEST=None

Change-Id: If8810692766a4c83f6f55de2bd9553fa1cd7ea0e
Reviewed-on: https://chromium-review.googlesource.com/599360
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491633}

Bug: 727873
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieca4aab7371e7208d49c78795f8da076bd237838
Reviewed-on: https://chromium-review.googlesource.com/587991
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491632}

Removed OpenURLFromTab from the provider, as it’s not related to its
mission to produce search results.

Bug=712331

Review-Url: https://codereview.chromium.org/2947283002
Cr-Commit-Position: refs/heads/master@{#491631}

Followup to r490994.

Bug: 751412, 748068
Change-Id: Ia3c25f86e45fa67e1a6e01d9edfe79bd515ec3f4
Reviewed-on: https://chromium-review.googlesource.com/598660Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491630}

Changes:
Enable touch event in PageSwitcherButton.

BUG=750658

Change-Id: I293544abf5d90201687800d6d6d0451810dfaacd
Reviewed-on: https://chromium-review.googlesource.com/595127Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491629}

Apply feedback from UX team.
- Adopt 'Harmony motion' for small dialogue
- Make font-size smaller

Bug: 739091
Change-Id: I785820860227a9fa4584d5d816d3984c2062efdf
Reviewed-on: https://chromium-review.googlesource.com/597088Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491628}

QuitCurrentWhenIdleDeprecated can end up leaving the thread in an
unclear shutdown state and isn't really the right way to
shutdown. Converts to use RequestQuit().

BUG=none
TEST=covered by tests

Change-Id: I561a7e9a9615d759ceae44a7ad0e724a2d13d093
Reviewed-on: https://chromium-review.googlesource.com/592530
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491627}

Add LayoutThemeFuchsia theme stub to Blink.
The theme is necessary because no LayoutTheme* files are currently
built when is_fuchsia=true.

Bug: 750946
Change-Id: Iab9cdf66856164309882239e643c2006f200d669
Reviewed-on: https://chromium-review.googlesource.com/599248Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491626}

Changes this CL:
- Renames NewTabPromo::CreateSelfOwned to NewTabPromo::Create.
- Adds a NewTabPromo as a member variable of NewTabButton for the following reasons:
1. To make the promo more accessible in order to check visibility in browsertests.
2. To tie the NewTabPromo to the specific NewTabButton it is being shown by. 

Bug: 734132
Change-Id: I71993f0185d712b62ac98706b165b078c4bb574b
Reviewed-on: https://chromium-review.googlesource.com/594627
Commit-Queue: Christopher Benson <chrisbenson@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491625}

TBR=dimu@chromium.org

Change-Id: Iba7d341f33054f52c7421293fa454fc9ecde53ee
Reviewed-on: https://chromium-review.googlesource.com/599328Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491624}

BUG=751811
R=xhwang@chromium.org,mmoroz@chromium.org
TEST=local build of this fuzzer target produces a non-trivial seed corpus zip

Change-Id: I83d7bc24428200e8581db90714e69d94393d0bcf
Reviewed-on: https://chromium-review.googlesource.com/599013Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491623}

If a benchmark is disabled but still run as a step, FormatDisabled is
called on the output_formatter instead of Format. In the case of
json-test-results, this means that no json will be output by the test
(since there is no empty version of json-test-results).

BUG=chromium:751346

NOTRY=true  # This script is not run on trybot/CQ, hence should be safe to notry

Change-Id: I4f19eeab40c1b6976e0f6c92cd5b7fff8ee17e2e
Reviewed-on: https://chromium-review.googlesource.com/598729Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491622}

Changes:
1. Add TrayUpdate::ResetForTesting to reset everything in TrayUpdate
before testing to prevent effect from previous testing.

BUG=751236
TEST=TrayUpdateTest.*

Change-Id: I85e2641d50448d656b64592dd025efd481428594
Reviewed-on: https://chromium-review.googlesource.com/596523
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491621}

focus.

This matches Polymer behavior and is preferential to the current focus
effect (blue rectangle).

Also get rid of the the focus rect for views::Slider, which already has
the glow effect when focused and hence needs no further changes.

Bug: 658783
Change-Id: Id9d5e3f1434b0d444154be933f0067f97aaaed33
Reviewed-on: https://chromium-review.googlesource.com/592494
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491620}

This patch introduces |AdjustSelectionWithTrailingWhitespace()| as replacement
of |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| to simplify
|VisibleSelectionTemplate| for improving code health.

Bug: 657237
Change-Id: Iaf5e0157c42ac5a16647da9616fc3bc67c9420f9
Reviewed-on: https://chromium-review.googlesource.com/597557Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491619}

Get rid of redundant call of SetIsDirectional() in SelectionController::SetNonDirectionalSelectionIfNeeded()

This patch gets rid of redundant call of |SetIsDirectional()| in
|SelectionController::SetNonDirectionalSelectionIfNeeded()|, because
 - We want to set non-directional selection as function name suggested
 - In |FrameSelection::SetSelection()|, we always set directional selection if
   |ShouldConsiderSelectionAsDirectional()| is true.

Bug: 740804
Change-Id: Ia474742aee16d13e124c41f4d7830614c35bd2f2
Reviewed-on: https://chromium-review.googlesource.com/595427Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491618}

WebUI preload JS handling is only done on main frame, so it
makes more sense to be moved from ChromeRenderViewObserver to
ChromeRenderFrameObserver where it can also access binding
registry.

Using Associated Interface since tests were failing / flaky
without it, showing errors such as:
* encountered javascript console error(s):
* Uncaught ReferenceError: runTest is not defined
Calls to this mojo method that preloads javascript libraries must
be executed prior to the call to run JS tests.

Bug: 577685
Change-Id: I431158867f60eb40824cbdf9db7d5d5681cbfe5b
Reviewed-on: https://chromium-review.googlesource.com/595019Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491617}