1. 28 Jan, 2010 24 commits
    • benm@google.com's avatar
      [Android] [Qt] Touch event page co-ordinates are incorrect when touch is received in an iframe. · 1530d220
      benm@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34162
      
      Reviewed by Simon Hausmann.
      
      WebCore: 
      
      The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates.
      
      * dom/Touch.cpp:
      (WebCore::Touch::Touch): Remove dead code.
      * dom/Touch.h: Remove dead code.
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame.
      * platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents.
      * platform/PlatformTouchPoint.h: Ditto.
      * platform/android/PlatformTouchEventAndroid.cpp: Ditto.
      * platform/android/PlatformTouchPointAndroid.cpp: Ditto.
      
      LayoutTests: 
      
      Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received.
      
      * fast/events/touch/resources/touch-inside-iframe2.html:
      * fast/events/touch/touch-inside-iframe-expected.txt:
      * fast/events/touch/touch-inside-iframe.html:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53994 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1530d220
    • eric@webkit.org's avatar
      2010-01-28 Yury Semikhatsky <yurys@chromium.org> · a20c0657
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Simplify isActivation method.
      
              https://bugs.webkit.org/show_bug.cgi?id=34161
      
              Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
      
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::JSInjectedScriptHost::isActivation):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53993 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a20c0657
    • xan@webkit.org's avatar
      2010-01-28 Xan Lopez <xlopez@igalia.com> · aec38f00
      xan@webkit.org authored
              [GTK] Can DnD files to our filechooser widget (<input type="file">)
              https://bugs.webkit.org/show_bug.cgi?id=34246
      
              Skip failing test because of this missing feature.
      
              * platform/gtk/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53992 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      aec38f00
    • tkent@chromium.org's avatar
      2010-01-28 Kent Tamura <tkent@chromium.org> · 44df9d71
      tkent@chromium.org authored
              Reviewed by Darin Fisher.
      
              Remove tests for dates later than 275760-09-13T00:00Z.
              https://bugs.webkit.org/show_bug.cgi?id=34240
      
              Date.UTC() of V8 doesn't support such dates though Date.UTC() of
              JavaScriptCore does.
      
              * fast/forms/input-valueasnumber-date-expected.txt:
              * fast/forms/input-valueasnumber-datetime-expected.txt:
              * fast/forms/input-valueasnumber-datetimelocal-expected.txt:
              * fast/forms/input-valueasnumber-month-expected.txt:
              * fast/forms/script-tests/input-valueasnumber-date.js:
              * fast/forms/script-tests/input-valueasnumber-datetime.js:
              * fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
              * fast/forms/script-tests/input-valueasnumber-month.js:
              * platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53991 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      44df9d71
    • eric@webkit.org's avatar
      2010-01-28 Chris Jerdonek <cjerdonek@webkit.org> · 70be8d44
      eric@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              In check-webkit-style, eliminated the dependency of
              processors/cpp_unittest.py on checker.py.
      
              https://bugs.webkit.org/show_bug.cgi?id=34205
      
              * Scripts/webkitpy/style/checker.py:
                - Addressed FIXME by removing STYLE_CATEGORIES data.
                - Added style_categories().
      
              * Scripts/webkitpy/style/checker_unittest.py:
                - Minor changes.
      
              * Scripts/webkitpy/style/processors/cpp.py:
                - Added categories attribute to CppProcessor class (data
                  was originally checker.STYLE_CATEGORIES).
      
              * Scripts/webkitpy/style/processors/cpp_unittest.py:
                - Addressed FIXME by eliminating "import" from checker.py.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53990 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      70be8d44
    • eric@webkit.org's avatar
      2010-01-28 Anton Muhin <antonm@chromium.org> · 9716f7b5
      eric@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Improve treatment of conditions and rest of the line for if, else, switch and alikes
              https://bugs.webkit.org/show_bug.cgi?id=34173
      
              * Scripts/webkitpy/style/cpp_style.py:
              * Scripts/webkitpy/style/cpp_style_unittest.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53989 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9716f7b5
    • eric@webkit.org's avatar
      2010-01-28 Joe Mason <jmason@rim.com> · 8f4a7c49
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Limit login retries to 5
              https://bugs.webkit.org/show_bug.cgi?id=34193
      
              * Scripts/webkitpy/bugzilla.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53976 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8f4a7c49
    • tkent@chromium.org's avatar
      2010-01-27 Kent Tamura <tkent@chromium.org> · dfe59e32
      tkent@chromium.org authored
              Reviewed by Darin Adler.
      
              rangeOverflow/rangeUnderflow support for type=date
              https://bugs.webkit.org/show_bug.cgi?id=34209
      
              * fast/forms/ValidityState-rangeOverflow-date-expected.txt: Added.
              * fast/forms/ValidityState-rangeOverflow-date.html: Added.
              * fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Added.
              * fast/forms/ValidityState-rangeUnderflow-date.html: Added.
              * fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Added.
              * fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Added.
      
      2010-01-27  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              rangeOverflow/rangeUnderflow support for type=date
              https://bugs.webkit.org/show_bug.cgi?id=34209
      
              Add DATE type support to rangeUnderflow(), rangeOverflow(),
              minimum(), and maximum() of HTMLInputElement.
              In order to unify parsing code for value, min, and max strings,
              introduce parseToDouble() function and it is called by
              valueAsDate() and valueAsNumber() too.
      
              Tests: fast/forms/ValidityState-rangeOverflow-date.html
                     fast/forms/ValidityState-rangeUnderflow-date.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::rangeUnderflow): Support DATE type, and use parseToDouble().
              (WebCore::HTMLInputElement::rangeOverflow): ditto.
              (WebCore::HTMLInputElement::minimum): ditto.
              (WebCore::HTMLInputElement::maximum): ditto.
              (WebCore::HTMLInputElement::doubleValueFor): Added.
              (WebCore::HTMLInputElement::valueAsDate): Use parseToDouble().
              (WebCore::HTMLInputElement::valueAsNumber): Use parseToDouble().
              * html/HTMLInputElement.h: Declare parseToDouble().
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53975 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dfe59e32
    • darin@chromium.org's avatar
      2010-01-27 Darin Fisher <darin@chromium.org> · d1fd94de
      darin@chromium.org authored
              Fix chromium build bustage (take 2).
      
              * bindings/scripts/CodeGeneratorV8.pm: Really treat V8CustomGetter like CustomGetter in all cases.
      
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53974 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d1fd94de
    • ossy@webkit.org's avatar
      [Qt] Skip test introduced in r53972 because of missing eventSender.beginDragWithFiles() · b3f93c89
      ossy@webkit.org authored
      * platform/qt/Skipped: fast/dom/Window/window-postmessage-clone-frames.html skipped.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53973 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b3f93c89
    • darin@chromium.org's avatar
      2010-01-27 Darin Fisher <darin@chromium.org> · 79733b02
      darin@chromium.org authored
              Fix chromium build bustage.
      
              * bindings/scripts/CodeGeneratorV8.pm: Treat V8CustomGetter like CustomGetter in all cases.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53972 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      79733b02
    • darin@chromium.org's avatar
      2010-01-27 Darin Fisher <darin@chromium.org> · def58ce4
      darin@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Expose HistoryItem::documentSequenceNumber
              https://bugs.webkit.org/show_bug.cgi?id=34243
      
              * public/WebHistoryItem.h:
              * src/WebHistoryItem.cpp:
              (WebKit::WebHistoryItem::documentSequenceNumber):
              (WebKit::WebHistoryItem::setDocumentSequenceNumber):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53971 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      def58ce4
    • oliver@apple.com's avatar
      Windows build fix. · 00bc06ae
      oliver@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@53970 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      00bc06ae
    • oliver@apple.com's avatar
      2010-01-27 Oliver Hunt <oliver@apple.com> · 59f57bb2
      oliver@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              MessageEvent.data should deserialize in the context of the MessageEvent's global object
              https://bugs.webkit.org/show_bug.cgi?id=34227
      
              Add logic to allow us to create an Object, Array, or Date instance
              so we can create them in the context of a specific global object,
              rather than just using the current lexical global object.
      
              * JavaScriptCore.exp:
              * runtime/DateInstance.cpp:
              (JSC::DateInstance::DateInstance):
              * runtime/DateInstance.h:
              * runtime/JSGlobalObject.h:
              (JSC::constructEmptyObject):
              (JSC::constructEmptyArray):
      2010-01-27  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              MessageEvent.data should deserialize in the context of the MessageEvent's global object
              https://bugs.webkit.org/show_bug.cgi?id=34227
      
              Test that the object returned from postMessage.data is created in the correct context
      
              * fast/dom/Window/resources/window-postmessage-clone-frames-frame.html: Added.
              * fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
              * fast/dom/Window/window-postmessage-clone-frames.html: Added.
      2010-01-27  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              MessageEvent.data should deserialize in the context of the MessageEvent's global object
              https://bugs.webkit.org/show_bug.cgi?id=34227
      
              Make ScriptValue deserialisation support the provision of a specific global
              object to use when creating new objects.  This then allows us to make
              MessageEvent.data and PopStateEvent.state deserialize in the correct
              context.
      
              Test: fast/dom/Window/window-postmessage-clone-frames.html
      
              * bindings/js/JSPopStateEventCustom.cpp:
                Remove custom implementation of state getter
              * bindings/js/SerializedScriptValue.cpp:
              (WebCore::DeserializingTreeWalker::DeserializingTreeWalker):
              (WebCore::DeserializingTreeWalker::createOutputArray):
              (WebCore::DeserializingTreeWalker::createOutputObject):
              (WebCore::DeserializingTreeWalker::convertIfTerminal):
              (WebCore::SerializedScriptValueData::deserialize):
              (WebCore::SerializedScriptValue::deserialize):
              * bindings/js/SerializedScriptValue.h:
              (WebCore::SerializedScriptValue::deserialize):
              * bindings/scripts/CodeGeneratorJS.pm:
                Update bindings generation to pass the correct global object, and to
                treat "any" as synonymous with SerializedValue.
              * dom/PopStateEvent.idl:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53969 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      59f57bb2
    • mrobinson@webkit.org's avatar
      Adding myself to the committer list. No review necessary. · 88420e9a
      mrobinson@webkit.org authored
      * Scripts/webkitpy/committers.py:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53968 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      88420e9a
    • eric@webkit.org's avatar
      2010-01-27 Martin Robinson <mrobinson@webkit.org> · 15bb7fdf
      eric@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] Expose the IM context via the API
              https://bugs.webkit.org/show_bug.cgi?id=33327
      
              Expose the GtkIMMultiContext as a property of WebKitWebView. This will
              allow embedders to generate the input method context menu entries and
              make testing certain IM context behavior possible.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_property):
              (DNDContentsRequest::webkit_web_view_get_im_context):
              (DNDContentsRequest::webkit_web_view_class_init):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53967 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      15bb7fdf
    • eric@webkit.org's avatar
      2010-01-27 Nicholas Young <nicholas.young@nokia.com> · 5c9eb9e9
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              Make media controls fade in/out transition duration configurable on a theme level.
              https://bugs.webkit.org/show_bug.cgi?id=34196
      
              No new tests needed (I hope).
      
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::RenderMedia): Removed constant from contructor - the initial value is meaningless.
              (WebCore::RenderMedia::updateControlVisibility): Get fade in/out duration from theme.
              * rendering/RenderTheme.h:
              (WebCore::RenderTheme::mediaControlsFadeInDuration): New virtual method.
              (WebCore::RenderTheme::mediaControlsFadeOutDuration): New virtual method.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53966 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5c9eb9e9
    • eric@webkit.org's avatar
      2010-01-27 John Abd-El-Malek <jam@chromium.org> · 3d12ab1a
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Tests that when a page removes an iframe that sleeps in its unload handler and
              terminates its JS execution, the outer page's JS continues running.
      
              https://bugs.webkit.org/show_bug.cgi?id=34226
      
              * fast/dom/Window/slow-unload-handler-expected.txt: Copied from LayoutTests/fast/dom/Window/slow_unload_handler-expected.txt.
              * fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html: Added.
              * fast/dom/Window/slow-unload-handler-only-frame-is-stopped-expected.txt: Added.
              * fast/dom/Window/slow-unload-handler.html: Copied from LayoutTests/fast/dom/Window/slow_unload_handler.html.
              * fast/dom/Window/slow_unload_handler-expected.txt: Removed.
              * fast/dom/Window/slow_unload_handler.html: Removed.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-01-27  John Abd-El-Malek  <jam@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Tests that when a page removes an iframe that sleeps in its unload handler and
              terminates its JS execution, the outer page's JS continues running.
      
              https://bugs.webkit.org/show_bug.cgi?id=34226
      
              Tests: fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
                     fast/dom/Window/slow-unload-handler.html
      
              * bindings/v8/DateExtension.cpp:
              (WebCore::DateExtension::OnSleepDetected):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53965 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3d12ab1a
    • eric@webkit.org's avatar
      2010-01-27 Kent Tamura <tkent@chromium.org> · e79727ff
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Add valueAsNumber support for type=datetime-local.
              https://bugs.webkit.org/show_bug.cgi?id=34200
      
              The test data is equivalent to input-valueasnumber-datetime.html.
              The expectation contains two FAIL lines because they check
              unimplemented features.
      
              * fast/forms/input-valueasnumber-datetimelocal-expected.txt: Added.
              * fast/forms/input-valueasnumber-datetimelocal.html: Added.
              * fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Added.
      2010-01-27  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Add valueAsNumber support for type=datetime-local.
              https://bugs.webkit.org/show_bug.cgi?id=34200
      
              Implement necessary methods of ISODateTime, and call them from
              HTMLInputElement.
      
              Test: fast/forms/input-valueasnumber-datetimelocal.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::valueAsNumber):
              (WebCore::HTMLInputElement::setValueAsNumber):
              * html/ISODateTime.cpp:
              (WebCore::ISODateTime::setMillisecondsSinceEpochForDateTimeLocal):
                Implemented.  Just call setMillisecondsSinceEpochForDateTime().
              (WebCore::ISODateTime::millisecondsSinceEpochForTime):
                Accept to be called for m_type=DateTimeLocal.
              (WebCore::ISODateTime::toString): Add DateTimeLocal support.
              * html/ISODateTime.h: Declare new methods.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53964 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e79727ff
    • eric@webkit.org's avatar
      2010-01-27 George Wright <gwright@rim.com> · 4ba677ab
      eric@webkit.org authored
              Reviewed by Adam Treat.
      
              https://bugs.webkit.org/show_bug.cgi?id=34216
      
              Add missing include for wtf/Platform.h
      
              * DumpRenderTree/AccessibilityController.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53962 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4ba677ab
    • sfalken@apple.com's avatar
      Windows Debug_All build fix. · 8fa45bff
      sfalken@apple.com authored
      * platform/graphics/win/WKCACFLayer.cpp:
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53961 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8fa45bff
    • aroben@apple.com's avatar
      Make it possible to instantiate WebSerializedJSValue using WebKitCreateInstance · 1ce8cf5a
      aroben@apple.com authored
      Reviewed by Dave Hyatt.
      
      * ForEachCoClass.h:
      * WebKitClassFactory.cpp:
      Added WebSerializedJSValue.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53960 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1ce8cf5a
    • bweinstein@apple.com's avatar
      Rubber-stamped by Adam Roben. · 3211f92b
      bweinstein@apple.com authored
      Add platform specific failing Windows results for two recently
      added tests. I will comment on their originating bugs saying that
      failing results were landed for Windows.
              
      <https://bugs.webkit.org/show_bug.cgi?id=29564>
      <https://bugs.webkit.org/show_bug.cgi?id=32696>
      
      * platform/win/fast/css/button-height-expected.txt: Added.
      * platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53959 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3211f92b
    • eric@webkit.org's avatar
      2010-01-27 Evan Martin <evan@chromium.org> · 5ee6d748
      eric@webkit.org authored
              Reviewed by David Levin.
      
              [chromium] complex text draws newlines as bells
              https://bugs.webkit.org/show_bug.cgi?id=34186
      
              Revert r45496 -- once we've got a glyph array, it is too late to normalize
              because we could have had multiple codepoints combine into one glyph.  The
              Uniscribe code it mentions it's duplicating uses the log cluster map to fix
              this.
      
              Instead, we just normalize the input text if it contains any non-ascii-space
              whitespace.
      
              This fixes fast/text/international/hindi-whitespace, which currently has an
              incorrect baseline containing a square box glyph.
      
              * platform/graphics/chromium/FontLinux.cpp:
              (WebCore::TextRunWalker::getTextRun):
              (WebCore::TextRunWalker::getNormalizedTextRun):
              * platform/graphics/chromium/HarfbuzzSkia.cpp:
              (WebCore::stringToGlyphs):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53958 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5ee6d748
  2. 27 Jan, 2010 16 commits
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 26c063a2
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=34150
              WebKit needs a mechanism to catch stale HashMap entries
      
              It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
              is just its value, it is very unlikely that any observable problem is reproducible.
      
              This extends hash table consistency checks to check that pointers are referencing allocated
              memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
              to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
      
              * wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can
              add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems
              with those yet.
      
              * wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by
              CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
      
              * wtf/HashTable.h:
              (WTF::HashTable::internalCheckTableConsistency):
              (WTF::HashTable::internalCheckTableConsistencyExceptSize):
              (WTF::HashTable::checkTableConsistencyExceptSize):
              Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off.
              (WTF::::add): Updated for checkTableConsistency renaming.
              (WTF::::addPassingHashCode): Ditto.
              (WTF::::removeAndInvalidate): Ditto.
              (WTF::::remove): Ditto.
              (WTF::::rehash): Ditto.
              (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this
              function returns true for tables with m_table == 0.
              (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially,
              we could do the same for values.
      
              * wtf/HashTraits.h:
              (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden
              to add checks. Currently, the only override is for pointer hashes.
      
              * wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53957 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      26c063a2
    • eric@webkit.org's avatar
      2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org> · 2d098c81
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] DRT Provide worker thread ability to track counters
              https://bugs.webkit.org/show_bug.cgi?id=34221
      
              Implement workerThreadCount() in LayoutTestController of Qt DRT
      
              Tests:
              fast/workers/dedicated-worker-lifecycle.html
              fast/workers/shared-worker-frame-lifecycle.html
              fast/workers/shared-worker-lifecycle.html
              fast/workers/worker-lifecycle.html
      
              * platform/qt/Skipped:
      2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] DRT Provide worker thread ability to track counters
              https://bugs.webkit.org/show_bug.cgi?id=34221
      
              Implement workerThreadCount() in LayoutTestController of Qt DRT
      
              Tests:
              fast/workers/dedicated-worker-lifecycle.html
              fast/workers/shared-worker-frame-lifecycle.html
              fast/workers/shared-worker-lifecycle.html
              fast/workers/worker-lifecycle.html
      
              * Api/qwebpage.cpp:
              (qt_drt_workerThreadCount):
      2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] DRT Provide worker thread ability to track counters
              https://bugs.webkit.org/show_bug.cgi?id=34221
      
              Implement workerThreadCount() in LayoutTestController of Qt DRT
      
              Tests:
              fast/workers/dedicated-worker-lifecycle.html
              fast/workers/shared-worker-frame-lifecycle.html
              fast/workers/shared-worker-lifecycle.html
              fast/workers/worker-lifecycle.html
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::workerThreadCount):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53956 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2d098c81
    • eric@webkit.org's avatar
      2010-01-27 Brian Tarricone <brian@kakai.com> · 82afd09c
      eric@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [gtk] Add support for windowless NPAPI plugins
      
              Much of this is a translation of how the Qt backend does this,
              modified for Gtk.
      
              https://bugs.webkit.org/show_bug.cgi?id=18831
      
              No new tests; there is already a windowless test in the tree.
      
              * plugins/PluginView.cpp:
              (WebCore::PluginView::handleEvent):
              (WebCore::PluginView::PluginView):
              * plugins/PluginView.h:
              * plugins/gtk/PluginViewGtk.cpp:
              (WebCore::getRootWindow):
              (WebCore::PluginView::updatePluginWidget):
              (WebCore::PluginView::paint):
              (WebCore::PluginView::handleKeyboardEvent):
              (WebCore::inputEventState):
              (WebCore::PluginView::initXEvent):
              (WebCore::setXButtonEventSpecificFields):
              (WebCore::setXMotionEventSpecificFields):
              (WebCore::setXCrossingEventSpecificFields):
              (WebCore::PluginView::handleMouseEvent):
              (WebCore::PluginView::handleFocusInEvent):
              (WebCore::PluginView::handleFocusOutEvent):
              (WebCore::PluginView::setNPWindowRect):
              (WebCore::PluginView::setNPWindowIfNeeded):
              (WebCore::PluginView::getValueStatic):
              (WebCore::PluginView::invalidateRect):
              (WebCore::getPluginDisplay):
              (WebCore::plug_removed_cb):
              (WebCore::getVisualAndColormap):
              (WebCore::PluginView::platformStart):
              (WebCore::PluginView::platformDestroy):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53955 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      82afd09c
    • eric@webkit.org's avatar
      2010-01-27 Anton Muhin <antonm@chromium.org> · 12bc1f35
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove trailing \ from inline function code
              https://bugs.webkit.org/show_bug.cgi?id=34223
      
              * assembler/ARMv7Assembler.h:
              (JSC::ARMThumbImmediate::countLeadingZerosPartial):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53954 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      12bc1f35
    • eric@webkit.org's avatar
      2010-01-27 Anton Muhin <antonm@chromium.org> · af8d92f1
      eric@webkit.org authored
              Reviewed by David Levin.
      
              [v8] minor cosmetic fix in V8 bindings codegenerator
              https://bugs.webkit.org/show_bug.cgi?id=34224
      
              * bindings/scripts/CodeGeneratorV8.pm:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53953 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      af8d92f1
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · ac481a3d
      kenneth@webkit.org authored
      [Qt] QtLauncher refactoring:
      
      Make the LauncherWindow depend less on the view, so that more
      code can be shared in near future.
      
      * QtLauncher/main.cpp:
      (LauncherWindow::sendTouchEvent):
      (LauncherWindow::loadFinished):
      (LauncherWindow::zoomIn):
      (LauncherWindow::zoomOut):
      (LauncherWindow::resetZoom):
      (LauncherWindow::toggleZoomTextOnly):
      (LauncherWindow::dumpHtml):
      (LauncherWindow::selectElements):
      (LauncherWindow::setupUI):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53952 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ac481a3d
    • darin@chromium.org's avatar
      2010-01-27 Darin Fisher <darin@chromium.org> · 004bf163
      darin@chromium.org authored
              Fix Chromium build bustage.
      
              * rendering/RenderBoxModelObject.cpp: Add wtf/CurrentTime.h include.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53951 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      004bf163
    • darin@chromium.org's avatar
      2010-01-26 Darin Fisher <darin@chromium.org> · ab7c52b6
      darin@chromium.org authored
              Reviewed by Brady Eidson and David Levin.
      
              Chains of history items representing same-document navigation need to
              always remember that association
      
              https://bugs.webkit.org/show_bug.cgi?id=33224
      
              Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
              During session history traversal, if the current HistoryItem and the
              target HistoryItem have the same DocumentSequenceNumber, then it means
              that the current Document should remain.
      
              NOTE: To support Chromium's serialization of HistoryItems, I generate
              DocumentSequenceNumbers that are unique across application launches.
              DocumentSequenceNumbers are generated using a counter initialized with
              the time of day.
      
              Test: fast/loader/stateobjects/document-destroyed-navigate-back.html
      
              * dom/Document.cpp:
              (WebCore::Document::detach):
              * dom/Document.h:
              * history/BackForwardList.cpp:
              (WebCore::BackForwardList::pushStateItem):
              * history/BackForwardListChromium.cpp:
              (WebCore::BackForwardList::pushStateItem):
              * history/HistoryItem.cpp:
              (WebCore::generateDocumentSequenceNumber):
              (WebCore::HistoryItem::HistoryItem):
              (WebCore::HistoryItem::~HistoryItem):
              (WebCore::HistoryItem::setStateObject):
              * history/HistoryItem.h:
              (WebCore::HistoryItem::setDocumentSequenceNumber):
              (WebCore::HistoryItem::documentSequenceNumber):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::navigateWithinDocument):
              (WebCore::FrameLoader::loadItem):
              * loader/HistoryController.cpp:
              (WebCore::HistoryController::updateBackForwardListForFragmentScroll):
              (WebCore::HistoryController::pushState):
              (WebCore::HistoryController::replaceState):
              * loader/RedirectScheduler.cpp:
              (WebCore::RedirectScheduler::scheduleHistoryNavigation):
              * page/History.cpp:
              (WebCore::History::stateObjectAdded):
              * page/Page.cpp:
              (WebCore::Page::goToItem):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53950 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ab7c52b6
    • oliver@apple.com's avatar
      2010-01-27 Oliver Hunt <oliver@apple.com> · 31ce99ef
      oliver@apple.com authored
              Reviewed by Simon Fraser.
      
              Animated scaling of background-image is too slow
              https://bugs.webkit.org/show_bug.cgi?id=33808
      
              Implement a version of the RenderImage animated scaling optimisation
              for background images.  Due to the possibility of arbitrary transforms
              being applied to containing elements we explicitly check the current
              CTM of the context for scaling or rotation.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawTiledImage):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/transforms/TransformationMatrix.h:
              (WebCore::TransformationMatrix::isIdentityOrTranslation):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData):
              (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData):
              (WebCore::RenderBoxModelScaleData::size):
              (WebCore::RenderBoxModelScaleData::time):
              (WebCore::RenderBoxModelScaleData::useLowQualityScale):
              (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer):
              (WebCore::RenderBoxModelScaleData::setSize):
              (WebCore::RenderBoxModelScaleData::setTime):
              (WebCore::RenderBoxModelScaleData::setUseLowQualityScale):
              (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed):
              (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired):
              (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
              (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired):
              (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              * rendering/RenderBoxModelObject.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53949 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      31ce99ef
    • kenneth@webkit.org's avatar
      Rubberstamped by Simon Hausmann. · 0030a2f3
      kenneth@webkit.org authored
      [Qt] QtLauncher refactoring:
      
      Move out code from the MainWindow (renamed to LauncherWindow)
      that is not depending on the view, and add it to a new class
      called MainWindow.
      
      * QtLauncher/QtLauncher.pro:
      * QtLauncher/main.cpp:
      (LauncherWindow::LauncherWindow):
      (LauncherWindow::eventFilter):
      (LauncherWindow::loadStarted):
      (LauncherWindow::loadFinished):
      (LauncherWindow::newWindow):
      (LauncherWindow::setupUI):
      (WebPage::createWindow):
      (main):
      * QtLauncher/mainwindow.cpp: Added.
      (MainWindow::MainWindow):
      (MainWindow::buildUI):
      (MainWindow::page):
      (MainWindow::setAddressUrl):
      (MainWindow::addCompleterEntry):
      (MainWindow::load):
      (MainWindow::changeLocation):
      (MainWindow::openFile):
      * QtLauncher/mainwindow.h: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53948 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0030a2f3
    • eric@webkit.org's avatar
      2010-01-27 Yael Aharon <yael.aharon@nokia.com> · cfeb7eda
      eric@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] Enable websockets support in QtWebKit
              https://bugs.webkit.org/show_bug.cgi?id=34180
      
              Remove websockets tests from skiplist.
      
              * platform/qt/Skipped:
      2010-01-27  Yael Aharon  <yael.aharon@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] Enable websockets support in QtWebKit
              https://bugs.webkit.org/show_bug.cgi?id=34180
      
              Connected between SocketStreamHandle and QTcpSocket/QSslSocket
              to enable support for websockets.
              Proxy authentication is not yet supported.
              SSL certificate errors are ignored while this is under development.
      
              * WebCore.pro:
              * platform/network/qt/SocketStreamHandle.h:
              * platform/network/qt/SocketStreamHandlePrivate.h: Added.
              * platform/network/qt/SocketStreamHandleQt.cpp:
              (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
              (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate):
              (WebCore::SocketStreamHandlePrivate::socketConnected):
              (WebCore::SocketStreamHandlePrivate::socketReadyRead):
              (WebCore::SocketStreamHandlePrivate::send):
              (WebCore::SocketStreamHandlePrivate::close):
              (WebCore::SocketStreamHandlePrivate::socketSentdata):
              (WebCore::SocketStreamHandlePrivate::socketClosed):
              (WebCore::SocketStreamHandlePrivate::socketError):
              (WebCore::SocketStreamHandlePrivate::socketClosedCallback):
              (WebCore::SocketStreamHandlePrivate::socketErrorCallback):
              (WebCore::SocketStreamHandlePrivate::socketSslErrors):
              (WebCore::SocketStreamHandle::SocketStreamHandle):
              (WebCore::SocketStreamHandle::~SocketStreamHandle):
              (WebCore::SocketStreamHandle::platformSend):
              (WebCore::SocketStreamHandle::platformClose):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53947 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cfeb7eda
    • eric@webkit.org's avatar
      2010-01-27 Mads Ager <ager@chromium.org> · 203d9ab8
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Support getting integer-named properties using indexing notation on document object
              https://bugs.webkit.org/show_bug.cgi?id=34211
      
              * fast/dom/HTMLDocument/get-iframe-with-integer-name-expected.txt: Added.
              * fast/dom/HTMLDocument/get-iframe-with-integer-name.html: Added.
      2010-01-27  Mads Ager  <ager@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [V8] Support getting integer-named properties using indexing notation on document object
              https://bugs.webkit.org/show_bug.cgi?id=34211
      
              Add indexed property getter to HTMLDocument to support getting
              elements with integer names using indexing notation on document.
      
              Test: fast/dom/HTMLDocument/get-iframe-with-integer-name.html
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
              (WebCore::V8HTMLDocument::indexedPropertyGetter):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53946 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      203d9ab8
    • yurys@chromium.org's avatar
      2010-01-27 Yury Semikhatsky <yurys@chromium.org> · 7dc09b87
      yurys@chromium.org authored
              Reviewed by Oliver Hunt.
      
              Instead of relying on Object.prototype.toString result use JSObject::isActivationObject
              to check if a scope node is a JSActivation. Object.prototype.toString for JSActivation
              will call JSActivation::toThisObject whose result depends on the current call stack.
      
              https://bugs.webkit.org/show_bug.cgi?id=34161
      
              Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
      
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::JSInjectedScriptHost::isActivation):
              * inspector/InjectedScriptHost.idl:
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor.):
              * manual-tests/inspector/debugger-scopes-inspection.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53945 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7dc09b87
    • eric@webkit.org's avatar
      2010-01-27 Anton Muhin <antonm@google.com> · 66241d82
      eric@webkit.org authored
              Review by Adam Barth.
      
              Implement Node map in intrusive way for better speed.
              https://bugs.webkit.org/show_bug.cgi?id=33957
      
              * bindings/v8/DOMData.h:
              (WebCore::DOMData::removeObjectsFromWrapperMap):
              * bindings/v8/DOMDataStore.cpp:
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::get):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::set):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::contains):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::allocateTableEntry):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::freeTableEntry):
              * bindings/v8/DOMDataStore.h:
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntry):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntries):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visitEntries):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::TableChunk::TableChunk):
              (WebCore::DOMDataStore::domNodeMap):
              * bindings/v8/StaticDOMDataStore.cpp:
              (WebCore::StaticDOMDataStore::StaticDOMDataStore):
              * bindings/v8/StaticDOMDataStore.h:
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::getDOMNodeMap):
              * bindings/v8/V8DOMMap.h:
              (WebCore::AbstractWeakReferenceMap::AbstractWeakReferenceMap):
              (WebCore::AbstractWeakReferenceMap::weakReferenceCallback):
              (WebCore::WeakReferenceMap::WeakReferenceMap):
              (WebCore::WeakReferenceMap::set):
              (WebCore::WeakReferenceMap::visit):
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::convertDocumentToV8Object):
              (WebCore::getWrapper):
              (WebCore::V8DOMWrapper::convertNodeToV8Object):
              (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
              * bindings/v8/V8DOMWrapper.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53944 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      66241d82
    • darin@chromium.org's avatar
      2010-01-26 Darin Fisher <darin@chromium.org> · f7624d00
      darin@chromium.org authored
              Reviewed by David Levin.
      
              Add methods to support running a nested modal loop outside of WebKit.
              https://bugs.webkit.org/show_bug.cgi?id=34199
      
              * public/WebView.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebView::willEnterModalLoop): Create PageGroupLoadDeferrer
              (WebKit::WebView::didExitModalLoop): Destroy PageGroupLoadDeferrer
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53943 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f7624d00
    • eric@webkit.org's avatar
      2010-01-27 Kinuko Yasuda <kinuko@chromium.org> · de2e04b8
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove fast/events/keydown-numpad-keys.html from gtk's Skipped list.
              https://bugs.webkit.org/show_bug.cgi?id=28247
      
              * platform/gtk/Skipped:
      2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Add key event mappings for numpad keys for Gtk and Chromium/Gtk.
              http://bugs.webkit.org/show_bug.cgi?id=28247
      
              Test: fast/events/keydown-numpad-keys.html
      
              * platform/chromium/KeyCodeConversionGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent):
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent):
      2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Correctly handle the KeyLocation argument that has been introduced
              recently to test location-dependent key events in EventSender.keyDown.
              http://bugs.webkit.org/show_bug.cgi?id=28247
      
              Test: fast/events/keydown-numpad-keys.html
      
              * DumpRenderTree/gtk/EventSender.cpp:
              (keyDownCallback):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@53942 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      de2e04b8