GitLab

Change-Id: I89c98bdec12e657b7928b00082a5c6591596879e
Reviewed-on: https://chromium-review.googlesource.com/1168595
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581912}

Enable universal planes when initializing the DRM device in the browser
process. This ensures all planes are exposed via DRM.

If DRM reports 0 planes (on legacy this can happen) do not report
support for PLANE_CTM otherwise the display configuration will try to
set hardware CTM.

Bug: 869901
Test: Compiled
Change-Id: I3fd09e3628e198219d8bb0b1400afd156cb4bcbe
Reviewed-on: https://chromium-review.googlesource.com/1167892
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581911}

This reverts commit 1df37f0e33c9cfb2337be2895d6f3c434aebdf17.

Reason for revert: We actually want this change reverted :). The original CL was bad, the revert was a manual thing done by the sheriff. The GoB fix then re-landed this, and now we want to reland it again.

Original change's description:
> Reland "Use CompletionOnceCallback in //content/browser/appcache."
> 
> This reverts commit dfc0e36093e5c5818a613dc7782aa15f8c171694.
> 
> Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.
> 
> Original change's description:
> > Revert "Use CompletionOnceCallback in //content/browser/appcache."
> > 
> > This reverts commit 6b2ace6e0bb70c5c5f6d35f84e62c84207059ac0.
> > 
> > Reason for revert: Inadvertently submitted without CQ.  New UI is confusing.
> > 
> > Change-Id: Ie9b9ca30b5f456cb75ca1813041b6cba9904dd27
> > Reviewed-on: https://chromium-review.googlesource.com/1169442
> > Reviewed-by: Bence Béky <bnc@chromium.org>
> 
> TBR=kinuko@chromium.org,bnc@chromium.org
> 
> Change-Id: I32f091e1d523965cd85f18eb527ae71e3fdf18dd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1169867
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=kinuko@chromium.org,bnc@chromium.org,tandrii@chromium.org

Change-Id: If57f238de6a6d00a540ca2c241c290506becc863
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1169929Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581910}

This reverts commit bbe0692bd9283569546670318df6e3d8e605be8c.

Reason for revert: We actually want this change reverted :). The original CL was bad, the revert was a manual thing done by the sheriff. The GoB fix then re-landed this, and now we want to reland it again.

Original change's description:
> Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default"
> 
> This reverts commit 304663b467d33fbe0a7e552565aceb5a59d8b2b0.
> 
> Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.
> 
> Original change's description:
> > Revert "[SessionStorageS13N] Enabling mojo SessionStorage by default"
> > 
> > This reverts commit 1bd58466.
> > 
> > Reason for revert: The crashes are still happening, and we aren't
> >                    closer to finding the cause. Changing focus to the
> >                    onion-souping effort.
> > 
> > Bug: 859464, 857464, 867850, 866827
> > 
> > Original change's description:
> > > [SessionStorageS13N] Enabling mojo SessionStorage by default
> > > 
> > > Bug: 716490
> > > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f
> > > Reviewed-on: https://chromium-review.googlesource.com/1072918
> > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > > Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#563169}
> > 
> > TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 716490
> > Change-Id: Ic5223ccbff4d61264c070b3518cf63ddb83deeb0
> > Reviewed-on: https://chromium-review.googlesource.com/1157446
> > Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> 
> TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org
> 
> Change-Id: Ia063033d68cd05bc46ca9259ed9f49e5ee06bab9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 859464, 857464, 867850, 866827, 716490
> Reviewed-on: https://chromium-review.googlesource.com/1169843
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org,tandrii@chromium.org

Change-Id: I3ff96a37dd11d2986651dbd8a7156178c20fb018
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859464, 857464, 867850, 866827, 716490
Reviewed-on: https://chromium-review.googlesource.com/1170005Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581909}

This reverts commit a86c92901aa9f21db709d7b40d1fcf0d472570d2.

Reason for revert: We actually want this change reverted :). The original CL was bad, the revert was a manual thing done by the sheriff. The GoB fix then re-landed this, and now we want to reland it again.
Original change's description:
> Reland "WebApp: Extract BookmarkAppHelper's gfx stuff into a separate file."
> 
> This is a reland of c8299015
> to revert findit revert of the above in https://chromium.googlesource.com/chromium/src/+/224eb4663f904ffc0c1356fe5f1d83fc4afc2c90
> Why? Due to Gerrit outage http://crbug.com/872722, we are reverting this CL.
> Please, re-land it after all clear is given.
> If you have questions, please ask on the bug. Sorry for the inconvenience.
> 
> Original change's description:
> > WebApp: Extract BookmarkAppHelper's gfx stuff into a separate file.
> >
> > Extract all the low-level skia/gfx/color_util stuff as
> > ResizeIconsAndGenerateMissing function.
> >
> > This is a cut-and-paste CL, no behavior changes.
> >
> > Notes:
> > - WebApplicationInfo::IconInfo becomes IconInfo. TODO for next CL:
> > Merge IconInfo and BitmapAndSource - they are essentially the same.
> >
> > - BookmarkAppHelperExtensionServiceTest.LinkedAppIconsAreNotChanged test
> > was always broken (a bug in ValidateAllIconsWithURLsArePresent helper)
> > https://codereview.chromium.org/1066623008/patch/80001/90005
> >
> > Bug: 860581
> > Change-Id: I0d866ac323f8dfdb409b69b22fac796155b1da23
> > Reviewed-on: https://chromium-review.googlesource.com/1166751
> > Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581827}
> 
> Bug: 860581
> Change-Id: If155ed6aedda2c7256f3ab707d4d335eeab26b6f
> Reviewed-on: https://chromium-review.googlesource.com/1169795
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=ortuno@chromium.org,loyso@chromium.org,tandrii@chromium.org,dominickn@chromium.org

Change-Id: I8c9475f3ed6ddb87bc09c0b1f8317147134ecbb1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860581
Reviewed-on: https://chromium-review.googlesource.com/1169928Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581908}

This reverts commit 72bd9335.

Reason for revert: breaks test.

Original change's description:
> [iOS] Using UnifiedConsentService::SetUnifiedConsentGiven() in the settings
> 
> This CL enables unified consent given when the user signs in to Chrome.
> This CL also disabled and enables unified consent given when the user
> toggles the corresponding switch on and off in the Sync and other services
> settings screen.
> 
> Bug: 827072
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I5384052f4abe117e7816733e45dc4091afe55708
> Reviewed-on: https://chromium-review.googlesource.com/1165151
> Reviewed-by: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581873}

TBR=msarda@chromium.org,jlebel@chromium.org,sczs@chromium.org,tangltom@chromium.org

Change-Id: I057d4085ebfb55e08e7a06d7e0cc0fbdedfaf36c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1170003Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581907}

Change-Id: I8086423200b43d771ad800c84ef8c1795ef18b56
Reviewed-on: https://chromium-review.googlesource.com/1168285
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581906}

Reverts https://codereview.chromium.org/2519803003 , it shouldn't be needed
with lld.

(Running `ninja -t msvc` directly means ninja doesn't have to be in PATH,
since then clause 1 of how CreateProcessA() finds binaries can take effect:

1. The directory from which the application loaded.

Due to the delete, `ninja -t msvc` was run under `cmd /c`, which means we
did require ninja in PATH only for official builds. This removes this exception.
But we're also making sure ninja is in PATH for now until crbug.com/872740
is resolved, so this change is more a defense-in-depth thing.)

Bug: 665773,828472,828466
Change-Id: Ic86b255df1544fcb4744ff4d2bf1f3f0b25119c3
Reviewed-on: https://chromium-review.googlesource.com/1169302Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581905}

They are implemented behind the CSSLogical runtime flag.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ

Spec: https://drafts.csswg.org/css-logical/#directional-keywords

BUG=850004

TEST=external/wpt/css/css-logical/logical-values-float-clear.html
TEST=external/wpt/css/css-logical/logical-values-resize.html

The tests still have some failures because sideways writing modes have
not been implemented yet (http://crbug.com/680331).

Change-Id: Ieede2703368a44f3ce9996e917857226795ebaea
Reviewed-on: https://chromium-review.googlesource.com/1163667Reviewed-by: Anders Ruud <andruud@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#581904}

This patch fixes an issue with the bottom toolbar when entering
fullscreen while the keyboard is visible. To conserve space while
the keyboard is showing, the bottom controls height is set to 0
and reset when the keyboard is hidden. This does not account for
fullscreen mode, so when the keyboard is hidden it blindly tells
the controls to become visible again. This patch adds logic to
update the bottom toolbar when the controls height is restored
and only conditionally shows the toolbar if another browser feature
isn't blocking it.

Bug: 872323
Change-Id: Ic3f33fcd7ae207415a5d36b56dba86ec216d3a51
Reviewed-on: https://chromium-review.googlesource.com/1167997Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581903}

Test: manual
Bug: 871985
Change-Id: I3747ce934f186acd677252ce22d748f4fe853907
Reviewed-on: https://chromium-review.googlesource.com/1166326
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581902}

Bug: 872788
TBR: rohitrao
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I55e2ba91fe5cbd0ef170d7a34d7e5104b7de735a
Reviewed-on: https://chromium-review.googlesource.com/1169318
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581901}

This is a reland of 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9

Original change's description:
> Add perf/core/bot_platforms.py file that contain metadata about all perf builders
>
> Bug:871746,863768
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8
> Reviewed-on: https://chromium-review.googlesource.com/1169127
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>

Bug: 871746, 863768
Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi

TBR=perezju@chromium.org

Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797
Reviewed-on: https://chromium-review.googlesource.com/1169882Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#581900}

This CL disables EnableAndStopTracingWithEmptyFile and DoubleStopTracing
from TracingControllertest, as they are flaky on Android.
Builder:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23169

TBR=oysteine@chromium.org

Bug: 872631
Change-Id: I55612d42712a9867fce271efdefc920139a6972d
Reviewed-on: https://chromium-review.googlesource.com/1169209Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581899}

Change-Id: I5cb3c934aece88cadbd909e5162093b5b49903c7
Reviewed-on: https://chromium-review.googlesource.com/1169623
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581898}

This CL flips `use_once_callback` flag on the Mojo code generator for
//chrome/common, and fixes all compile errors after that. After
this CL, Mojo interfaces there service starts using base::OnceCallback
instead of base::Callback on its return value handling.

Bug: 714018
Change-Id: I70823c7a0ca0032fa3223e2a2926d37acc8f6523
Reviewed-on: https://chromium-review.googlesource.com/1152342Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581897}

Some windows, including tab-dragging window, want to suppress
the window animations. This property needs to be propagated
to Ash to take an effect.

BUG=867074
TEST=manually

Change-Id: I80847702e26cd04981cac71b02114389312d83e1
Reviewed-on: https://chromium-review.googlesource.com/1166331Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581896}

Previously, the results popup shadow color was kGoogleGrey800 (#3C4043) for both
incognito and normal windows. This shadow was difficult to detect on incognito's
dark new tab page. This changes the shadow color for incognito windows to black
(#000). This change only affects material refresh.

The results popup uses BubbleBorder to draw its border, including its shadow.
BubbleBorder can be provided a shadow elevation to determine the size of its
shadow, or else it will provide a default shadow. Additionally, BubbleBorder
shadows consider the material refresh flag. Elevated refresh shadows (e.g.
refresh flag is on and elevation is 3 or 16) are delegated to
ShadowValue::MakeRefreshShadowValues. Elevated non-refresh shadows (e.g. refresh
flag is off or elevation is neither 3 nor 16) are delegated to
ShadowValue::MakeMdShadowValues. Un-elevated shadows are constructed inline
within BubbleBorder::GetShadowValues.

Previously, ShadowValue::MakeRefreshShadowValues shadows were kGoogleGrey800,
while ShadowValue::MakeMdShadowValues and BubbleBorder::GetShadowValues shadows
were SK_ColorBLACK. This cl adds the ability to set custom shadow colors for all
3 shadow constructions. If no color is set, SK_ColorBLACK is used by default,
this is consistent with all current usages of ShadowValue and BubbleBorder.

Bug: 866054
Change-Id: I6d592f290daf41a6a083e7e6214c0a30dfdfb68f
Reviewed-on: https://chromium-review.googlesource.com/1165794
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581895}

Use CompletionOnceCallback instead of CompletionCallback, and
CancelableCompletionOnceCallback instead of CancelableCompletionCallback
in //content/browser/appcache.

Bug: 807724

This exact CL has been reviewed and approved at
https://crrev.com/c/1163933.  However, due to a bug in Gerrit, I
inadvertently submitted that CL skipping the CQ.  See
https://crbug.com/872722.  That CL was reverted, and now I am relanding
it properly in this CL, through CQ this time.  Original reviewer is
TBR'd.

TBR=kinuko@chromium.org

Change-Id: Ie1d8e275e754cc51457aca6537ad08b228cfaaac
Reviewed-on: https://chromium-review.googlesource.com/1169307Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581894}

This makes the behaviour consistent with BLE advertisement on ChromeOS.

Change-Id: I8405f5fafc6f29874abf7e988d6828d7d03828ad
Reviewed-on: https://chromium-review.googlesource.com/1162689
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581893}

and extend date of another omnibox histogram.

Bug: 871485
Change-Id: Ied602a6df0748faa501112c2a0dfcd38dab49071
Reviewed-on: https://chromium-review.googlesource.com/1166192Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581892}

Handles press of opt in to trigger onboarding flow.

There didn't seem to be a great place to put this so I broke out an
AssistantSetupController. Potentially this might be a good place to
cache settings state on the Ash side in the future when we clean up
VoiceInteractionController.

Note that the AssistantOptInView is still hidden programmatically.
A follow up CL will show this view when appropriate.

See bug for demo.

Bug: b:111315696
Change-Id: I6438abc780d2d5e5753dd22c34c477b7364324e4
Reviewed-on: https://chromium-review.googlesource.com/1166259
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581891}

This CL adds JNI bridge for UnifiedConsentService::ShouldShowConsentBump
and shows the consent bump if necessary.

Bug: 869426
Change-Id: I7f1ca38673c330a86effd376f3120dae6029bb61
Reviewed-on: https://chromium-review.googlesource.com/1167846Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581890}

NOTREECHECKS=True

No-Presubmit: True
No-Try: True
Bug: 872722
Change-Id: I78a357132559302f59848a712363d02cb2f0e91a
Reviewed-on: https://chromium-review.googlesource.com/1169949
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581889}

TBR=pkasting

Bug: 872722
Change-Id: Iffb249c1d61d468ac8f301b4808049e03ab52127
Reviewed-on: https://chromium-review.googlesource.com/1169912Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581888}

Before this CL, recomputing occlusion too many times before occlusion
states became stable caused a call to DumpWithoutCrashing(). Now that
we didn't get any crash reports in the last 6 months, this CL replaces
the DumpWithoutCrashing() with a simple DCHECK.

Bug: 813076
Change-Id: I2ec8c5fa89a1646367035c3585df091a9a4f76cc
Reviewed-on: https://chromium-review.googlesource.com/1168024Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581887}

https://chromium.googlesource.com/catapult.git/+log/b04cdc9bc5e1..bca7d20ad76a


git log b04cdc9bc5e1..bca7d20ad76a --date=short --no-merges --format='%ad %ae %s'
2018-08-09 nastasoiuf@google.com Integration
2018-08-09 wangge@google.com Add Test Cases for `utils.py`.
2018-08-09 wangge@google.com Add Logic to Use Monochrome After Milestone 52.


Created with:
  gclient setdep -r src/third_party/catapult@bca7d20ad76a

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:863390,chromium:863390
TBR=sullivan@chromium.org

Change-Id: I7ebb2f0dbfb94c7af0c997dbd5826e7bd03ea455
Reviewed-on: https://chromium-review.googlesource.com/1169108Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581886}

Dismiss the generation prompt when > 5 characters typed.

Bug: 869890,859472
Change-Id: Ib842b92857a79e92e411e7247ad0cc4a322dd364
Reviewed-on: https://chromium-review.googlesource.com/1167507Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581885}

Using wpt-import in Chromium 84f87556.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22574

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/IndexedDB
mtrofin@chromium.org:
  external/wpt/wasm

NOAUTOREVERT=true
TBR=kereliuk

No-Export: true
Change-Id: I8da40e9d8be7e1a738a8f2f1ffbe16f65f1d3f29
Reviewed-on: https://chromium-review.googlesource.com/1169123
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581884}

The code that was causing the problem has been removed from absl.

Removed from:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/8f96be6ca60d967bd4b37f93d0a03bcff4145200
---
5aba0b15eaf6c5beff0e91670a7cdf5ad1151886 by Derek Mauro <dmauro@google.com>:

Use std::chrono to get the current time on both Apple and Windows
platforms, eliminating the unnecessarily complicated logic on Apple
platforms.

PiperOrigin-RevId: 206979219
---

Bug: webrtc:9557
Change-Id: Idb2858b39b2ef8ed7e69d4d740faef9d369e8747
Reviewed-on: https://chromium-review.googlesource.com/1165348
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581883}

ready_state_ could be kErrorOccured as well as kReadyStreaming. Update the
logic to check for this and add a new NotStreamingReason to log it.

BUG=chromium:865098,chromium:871276

Change-Id: I7f4e17c843b74632d4cf167664f26fdb92f30a8c
Reviewed-on: https://chromium-review.googlesource.com/1164943
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581882}

This will match up pak symbols when they have moved between grdp files.

Change-Id: I55ae383498c66a11c675cb1b0eb4866da4cae721
Reviewed-on: https://chromium-review.googlesource.com/1168456Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581881}

The regression was introduced in
https://chromium-review.googlesource.com/1160229 which overlooked the
fact that the UI makes assumptions about when it's notified about the
results (i.e. no synchronous reply expected).

There are cleaner alternatives to the proposed fix, but it seems most
conservative to go back to the previous implementation by partially
reverting the offending patch.

Bug: None
Change-Id: I81d82d27234666d407708b1ccd366e493784e9c5
Reviewed-on: https://chromium-review.googlesource.com/1169045
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581880}

As a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1133975

Realized when plumbing this through in chromecast's render client
that we need the RenderFrame.

Bug: 862698
Change-Id: I1764dcd25dacac7a406d8b179d7abb5af2d14dad
Reviewed-on: https://chromium-review.googlesource.com/1151761Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581879}

The server identifies bookmark commit requests by the absence of a
client_defined_unique_tag.
Bookmarks should be handled differently when generating server ids.

This CL makes sure the client_defined_unique_tag is only populated
for non-bookmark data types.

Bug: 516866
Change-Id: I0c3b1f314c638878fd8780663484aec780215e99
Reviewed-on: https://chromium-review.googlesource.com/1169052
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581878}

Bug: None
Change-Id: I1e24a3a076ca89dcde0712620f8194fed7702183
Reviewed-on: https://chromium-review.googlesource.com/1167109Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581877}

We're moving away from using MessageLoop in Blink, hence,
we want to make SequenceManager support any missing pieces
and provide a good level of abstraction on top of a thread.

Specifically, this CL will unblock removing MessageLoop
references from content::RenderThreadImpl.

Bug: 828835
Change-Id: I5a785a26f35839eea3705ecb5abc61672c497457
Reviewed-on: https://chromium-review.googlesource.com/1167516Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581876}

This reverts commit ad618241.

Reason for revert: <INSERT REASONING HERE>
Chromeos-dbg bots are now green (for chromevox); this change was unlikely to be at fault.

Original change's description:
> Revert "Only alert accessibility when a notification's text changes"
> 
> This reverts commit feb758c3.
> 
> Reason for revert: <INSERT REASONING HERE>
> SpokenFeedbackTests failing on chromeos dbg
> Original change's description:
> > Only alert accessibility when a notification's text changes
> > 
> > Bug: 867426
> > Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208
> > Reviewed-on: https://chromium-review.googlesource.com/1166231
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Commit-Queue: David Tseng <dtseng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581474}
> 
> TBR=stevenjb@chromium.org,dtseng@chromium.org
> 
> Change-Id: I8b23c03e08642caa7b05d2ce88e6f330dd056c37
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 867426
> Reviewed-on: https://chromium-review.googlesource.com/1167603
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581607}

TBR=stevenjb@chromium.org,dtseng@chromium.org

Change-Id: I0b1270e0ebdbfbca89baefe9a9f676062862479e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 867426
Reviewed-on: https://chromium-review.googlesource.com/1168329Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581875}

This change simplifies FidoBleConnection by passing the obtained
BluetoothAdapter from FidoBleDiscovery through the FidoBleDevice to the
FidoBleConnection. This removes the need to query for the adapter within
FidoBleConnection and simplifies the implementation.

Bug: 763303
Change-Id: I83e0c5e715246db4c3ac0dc0427797c8d783853c
Reviewed-on: https://chromium-review.googlesource.com/1167056
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581874}

This CL enables unified consent given when the user signs in to Chrome.
This CL also disabled and enables unified consent given when the user
toggles the corresponding switch on and off in the Sync and other services
settings screen.

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5384052f4abe117e7816733e45dc4091afe55708
Reviewed-on: https://chromium-review.googlesource.com/1165151Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581873}