- 06 Sep, 2018 40 commits
-
-
Shahbaz Youssefi authored
extensions no longer dependens on chrome:resources, so this dependency can be removed. Bug: 881353 Change-Id: I520ebbdff9aab4d0f2c073bd8530c84c4e0eb9ba Reviewed-on: https://chromium-review.googlesource.com/1210543Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589251}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c3dc59fc1c6..e8161dd154d7 git log 0c3dc59fc1c6..e8161dd154d7 --date=short --no-merges --format='%ad %ae %s' 2018-09-06 caryclark@skia.org bookmaker self documentation 2018-09-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 155bfd11e9f0..dff32a0da1de (1 commits) 2018-09-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-06 halcanary@google.com Move some functions to MathPriv.h 2018-09-06 mtklein@google.com stop clamping in parametric stage 2018-09-06 rmistry@google.com Android compile bot target has changed. Update the bot name. 2018-09-06 mtklein@google.com remove SkRandom::next64() 2018-09-06 caryclark@skia.org Revert "SkStream: remove some WStream functions from public api" 2018-09-06 kjlubick@google.com [PathKit] Fix document.write warning in docs. 2018-09-06 halcanary@google.com SkStream: remove some WStream functions from public api 2018-09-06 mtklein@google.com Revert "update to new MakeFromStream signature" 2018-09-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 750e508722a9..155bfd11e9f0 (4 commits) 2018-09-06 reed@google.com update to new MakeFromStream signature 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@e8161dd154d7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ieed8023dfe3f15924b91b15083c4ae75e8b2eef2 Reviewed-on: https://chromium-review.googlesource.com/1211044Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589250}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09307abef3dd..77e18bee2225 Created with: gclient setdep -r src-internal@77e18bee2225 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib76920828a3a701c8be18a667958b85950ff6eb3 Reviewed-on: https://chromium-review.googlesource.com/1208972Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589249}
-
Ted Choc authored
BUG=834602 Change-Id: I88271052cacbf42db040e1925854d6dc02889323 Reviewed-on: https://chromium-review.googlesource.com/1199627Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589248}
-
spqchan authored
It's possible for the TextSuggestionsTouchBarController to receive a selection range that is out of the text bounds. This CL fixes the issue by replacing the range with an empty one if it is out of bounds. This CL also makes sure that gfx::Range::ToNSRange() gets used, since gfx::Range() can potentially be reversed. Bug: 880642, 872929 Change-Id: I4acc63b80cdf107de2ba340bb277e3e38084ff52 Reviewed-on: https://chromium-review.googlesource.com/1207575 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#589247}
-
Kurt Horimoto authored
This CL updates the NTP to only return the logo animation controller for voice search transition animations if the logo is fully visible. Bug: 863381 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I73b68748d89cea6bd9b0292847496760c41e66b6 Reviewed-on: https://chromium-review.googlesource.com/1200570 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589246}
-
Chris Palmer authored
This reverts commit 383049f2. Reason for revert: Landed wrong patchset! Original change's description: > Add `CheckedRandomAccess[Const]Iterator`. > > And add a first call site. > > Bug: 817982 > Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo > Change-Id: I2db298494e4f562ffac1f68b87c7a617e592f196 > Reviewed-on: https://chromium-review.googlesource.com/963726 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589244} TBR=ajwong@chromium.org,palmer@chromium.org,dcheng@chromium.org,jyasskin@chromium.org,mmenke@chromium.org,tsepez@chromium.org,nharper@chromium.org Change-Id: Icf99f8409054d853a15b8d27cdb232ff727f8a42 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817982 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1211743Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589245}
-
Chris Palmer authored
And add a first call site. Bug: 817982 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo Change-Id: I2db298494e4f562ffac1f68b87c7a617e592f196 Reviewed-on: https://chromium-review.googlesource.com/963726Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589244}
-
Leonard Grey authored
- Changes a DCHECK to a CHECK to crash if a move loop starts when one is already in progress. - Adds a CHECK to ensure the event monitor's handler is running on the main thread. - Adds crash keys in CocoaWindowMoveLoop's destructor to capture its address and a stack trace, to test the hypothesis that crashes may be occurring on objects that have already been freed. Bug: 876493 Change-Id: Ic36703f08138daff88e46f02e7af3de61acedc4e Reviewed-on: https://chromium-review.googlesource.com/1205012 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Christian Fremerey authored
Patchset 1 is the reverted CL as previously reviewed. Patchset 2 is the fix. The reason for the revert was a linker error for component builds. The fix is to add a missing CONTENT_EXPORT. --- Original CL description: The video capture service requires GPU dependencies to be injected after startup in order to enable accelerated MJPEG decoding. This CL adds this injection call where the service is started from the media_perception_private extension. The injected dependencies use classes that used to live in content/browser/renderer_host/media. To be able to reuse them for the extension, this CL moves them to a location that is accessible to both usage sites, i.e. to content/browser/gpu with a public interface in content/public/browser. TBR=jam@chromium.org Bug: 877690 Change-Id: Ibeb29361c762d8366f1433d918e8abead0a39173 Reviewed-on: https://chromium-review.googlesource.com/1208821Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589242}
-
Roman Karasev authored
SetUpExtensionFunction loads "main.html" for each extension by default, but if an extension has "incognito: spanning" in its manifest, then "main.html" of that extension cannot be loaded because of restriction. You did not see failed tests because RenderFrameHost is destroyed after extension function is executed in test. There is a logical race in IO/UI threads and it is reproduced on some PCs with Windows (on these PCs RenderFrameHost is destroyed earlier then extension function is executed). R=dtrainor@chromium.org,qinmin@chromium.org TEST: if you will wait for navigation of chrome::AddSelectedTabWithURL (e.g. by adding TestNavigationObserver) you can see the broblem. Bug: None Change-Id: Ibf8fe519fd6d041fd52ec9aa697d220a55103b53 Reviewed-on: https://chromium-review.googlesource.com/1158070Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589241}
-
Alex Leung authored
Bug: b:113620998 Change-Id: I275050d25b33360ab0d020ea9679198a6fbc403a Reviewed-on: https://chromium-review.googlesource.com/1208824Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#589240}
-
Jialiu Lin authored
This feature has already been enabled by default. Bug: 853286 Change-Id: I1e047757d5da27133ce04188162552cc9d0cbbab Reviewed-on: https://chromium-review.googlesource.com/1182511Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#589239}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b9bb9e3f6683..bb081a62dc30 git log b9bb9e3f6683..bb081a62dc30 --date=short --no-merges --format='%ad %ae %s' 2018-09-06 ssilkin@webrtc.org Update sending resolution only on top spatial layer frame. 2018-09-06 andersc@webrtc.org Generate umbrella header for macOS framework. 2018-09-06 ssilkin@webrtc.org Frame rate controller per spatial layer. 2018-09-06 buildbot@webrtc.org Roll chromium_revision 87a4e8f8..fcd25fc0 (588971:589073) 2018-09-05 steveanton@webrtc.org Revert "Use AsyncInvoker in PeerConnection instead of MessageHandler" Created with: gclient setdep -r src/third_party/webrtc@bb081a62dc30 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5bcb0182c886838d5bec2a3ffbca953015b4087a Reviewed-on: https://chromium-review.googlesource.com/1209802Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589238}
-
Kurt Horimoto authored
The swipe to delete gesture for UITableView will throw an exception if the deleted row's section is removed before the animation finishes. This CL updates ReadingListTableViewController to defer removing empty sections until self.tableView.editing is reset to NO at the end of the swipe animation. Bug: 877425, 877423 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I74e29b761fc8458e8bb9a6dbe643a73b00a8b9a4 Reviewed-on: https://chromium-review.googlesource.com/1198104Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#589237}
-
Maks Orlovich authored
From leak reports, it seems like sometimes the pending operations queue just keeps growing and growing, but we still don't know why... so DumpWithoutCrashing (once per backend lifetime) if it seems ridiculously long. Thanks to mef@ for the idea. Bug: 809199 Change-Id: Ia949be30e50ddcd6f800c4c26268966b6e298bc0 Reviewed-on: https://chromium-review.googlesource.com/1210367 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#589236}
-
Joe Mason authored
R=csharp Bug: 830892 Change-Id: I821588099796a86a685bd85fa29456fd5d8bc705 Reviewed-on: https://chromium-review.googlesource.com/1197102 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589235}
-
James Cook authored
Workaround for an occasional crash we see in the autotest lab. I'm just skipping the code so we can put MashLogin in the CQ. Bug: 869385 Change-Id: I1267922036d3ab88276a2315dc9d3bb7d2ed2020 Reviewed-on: https://chromium-review.googlesource.com/1210683Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#589234}
-
Justin Donnelly authored
This reverts commit 8eed4853. Reason for revert: Suspected of breaking the following test: org.chromium.chrome.browser.browseractions.BrowserActionActivityTest.testOpenSingleTabInBackgroundWhenChromeAvailable On the Android CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI Original change's description: > Reland: Remove SeparateTaskCustomTabActivity for Android version > L. > > Cause of revert: > =============== > A few MediaLauncherActivityTest don't run on the CQ. They were waiting > on SeparateTaskCustomTabActivity to finish, but it is no more used. > > Original description: > ===================== > Remove SeparateTaskcustomTabActivity for Android version > L. > > Make SeparateTaskcustomTabActivity to be used only for Android version > pre L. The part used for Android version >= L is merged into > CustomTabActivity. > > This is a prerequisite for skipping the ChromeLauncherActivity and > directly launch the CustomTabActivity. > > TBR=tedchoc@chromium.org > R=lizeb@chromium.org > > Bug: 681559 > Change-Id: I121241a2f43f62c346a24adb153649bec3b80af3 > Reviewed-on: https://chromium-review.googlesource.com/1201845 > Reviewed-by: Benoit L <lizeb@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588788} TBR=lizeb@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 681559 Change-Id: I002cddd65d1fc326c5a212671d4f7d07355689a6 Reviewed-on: https://chromium-review.googlesource.com/1211242Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#589233}
-
Takumi Fujimoto authored
The stop button and the issue icon share the same space in sink item UI, so when both are present (i.e. when a sink has both a route and an issue) we must ensure that the stop button is shown, so that the user can stop the route. Bug: 879627 Change-Id: I73751190dec2cde98b9568e7ebb4b2cea8516dea Reviewed-on: https://chromium-review.googlesource.com/1208818Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#589232}
-
Li Lin authored
Will follow up on displaying proper message for managed account. Bug: b:113579103 Change-Id: I279937f8f3d622e7fd7cf947b4f261b64cd320ff Reviewed-on: https://chromium-review.googlesource.com/1198002Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589231}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b27d084b0112..21bcb9d8b9db git log b27d084b0112..21bcb9d8b9db --date=short --no-merges --format='%ad %ae %s' 2018-09-06 corentin@wallez.net BUILD.gn: Make a better interface with dependents. (#1877) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@21bcb9d8b9db The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I465fc82d319a94b2494428efc1b057b258645b60 Reviewed-on: https://chromium-review.googlesource.com/1210442Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589230}
-
Weilun Shi authored
Implementing the intant theme test in a non-flaky way. Instead of using OnThemeChange event to determine whether the theme has applied on existing tab/current tab/new tab, we directly check the css setting is equal to the new theme or not. Bug: 335297 Change-Id: Ic366e180281b23ccdffcbcd9e4b2144485591607 Reviewed-on: https://chromium-review.googlesource.com/1208939 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#589229}
-
Kevin Bailey authored
The current URL generated from a Calculator suggestion searches for the result e.g. "4", not the calculation e.g. "2+2". This CL swaps the terms (actually, it clears the original query) and, further, treats the suggestions as distinct from non-calculator suggestions, so that they don't dupe against other WYT suggestions. Bug: 873666 Change-Id: I006f9754ee7e48d0a21a1f149c4ef76b3ca509fd Reviewed-on: https://chromium-review.googlesource.com/1197342 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#589228}
-
Esmael El-Moslimany authored
Bug: 877571 Change-Id: I981008a53c0a88aa98027f5fa56697ba410917ab Reviewed-on: https://chromium-review.googlesource.com/1204511Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#589227}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/upgrade_detector. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=grt@chromium.org Bug: 874080 Change-Id: I902becb0feb9bf1e0464c2dd507b734fb5e16508 Reviewed-on: https://chromium-review.googlesource.com/1190932Reviewed-by:Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#589226}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/chromeos. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=satorux@chromium.org Bug: 874080 Change-Id: Ic87ecc4c25a20a2dea3053249c03dafded46db27 Reviewed-on: https://chromium-review.googlesource.com/1191236Reviewed-by:Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#589225}
-
liberato@chromium.org authored
This CL moves all work that runs on the video decoder's thread into D3D11VideoDecoder, and all GPU main thread work into Impl. It does not actually move decoding to a different thread, nor does it remove all of the threading assumptions from the code. For example, D3D11PictureBuffers still assume that they're created and destroyed on the GPU main thread. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4ee52d84c77c57127d26803153c043959f7429ef Reviewed-on: https://chromium-review.googlesource.com/1197165 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#589224}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/printing. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=dpapad@chromium.org Bug: 874080 Change-Id: I23d9583ee267f5d88fb8c2e708fd7055d9f05951 Reviewed-on: https://chromium-review.googlesource.com/1191184Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#589223}
-
Daniel Nicoara authored
Some video paths go through the V4L2 decoder, so need to whitelist it to work with the early sandbox. Bug: b/113126106 Test: Compiled Change-Id: Iae5f144efa2b2017d8a6c0e55dfc4128bbd65ce4 Reviewed-on: https://chromium-review.googlesource.com/1199708Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#589222}
-
Sammie Quon authored
This gives users a way to reach apps when the overflow is beyond filled on tablet mode. Also fix a bug with the shelf layout manager handling events on the overflow. Test: manual Bug: 808237 Change-Id: Ia3d4a14c8c1a15f7c991a201bdad94d6657f4e6d Reviewed-on: https://chromium-review.googlesource.com/1208826Reviewed-by:
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /components/printing. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=dpapad@chromium.org Bug: 874080 Change-Id: If905506e78f47d3a2524a4d574184def19f3ce54 Reviewed-on: https://chromium-review.googlesource.com/1191786Reviewed-by: -
Fredrik Söderquist authored
This implements initial values for SVGAnimatedNumber properties (which includes SVGAnimatedNumberOptionalNumber since it is a reverse proxy to the former.) Bug: 225807 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icb62d7383cacf7df122fc56af0977015b5adf9b7 Reviewed-on: https://chromium-review.googlesource.com/1209705 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589219}
-
Justin Donnelly authored
This reverts commit 6d6b6173. Reason for revert: Suspected of breaking the Mac builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20Builder/89748 This code doesn't seem obviously related to the webui failure there, but there are no other webui CLs in the blame list. Original change's description: > Add the ability for AndroidSmsAppHelperDelegate to launch the PWA. > > Also actually use this ability when the "Set Up" button in multidevice > settings is clicked. > > R=khorimoto@chromium.org > > Bug: 870093 > Change-Id: I3dd5bcd9c8e3946e1ae42a5db69f2bb7ed3ea586 > Reviewed-on: https://chromium-review.googlesource.com/1185498 > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589196} TBR=khorimoto@chromium.org,tommycli@chromium.org,jlklein@chromium.org Change-Id: I855abd7c530600362082c83ee155aaa3d713415f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870093 Reviewed-on: https://chromium-review.googlesource.com/1211382Reviewed-by:
-
Fredrik Söderquist authored
This implements initial values for SVGAnimatedEnumeration properties. Bug: 225807, 523685 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I857dd5d6a52b2e3c4e866c2b589be3373449fc24 Reviewed-on: https://chromium-review.googlesource.com/1209683Reviewed-by:
-
Doug Arnett authored
This is needed to support a server provided blacklist (via Cacao) for HTTPS Server Previews. Details are specified in https://docs.google.com/document/d/13Pj85rq3aUfVxxMe4Dad9uqz54n0GgD8iPqUowdsD-c/edit?usp=sharing Bug: 864640 Change-Id: Ie9b4a56dd0edc97df48f2d6e066ad2a0b1104458 Reviewed-on: https://chromium-review.googlesource.com/1207574 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#589216}
-
John Budorick authored
This reverts commit d9183af5. Reason for revert: suspected of causing https://bugs.chromium.org/p/chromium/issues/detail?id=881420 Original change's description: > [Autofill] Populate ChromeUserContext in Payments requests > > This change adds |chrome_user_context| and |full_sync_enabled| values to > Unmask, GetDetails, Upload, and MigrateCards requests, as long as either > of the appropriate flags are enabled. > > Bug: 840703 > Change-Id: Ieb3baf980b68add43a3111c0902a03b574b1adcf > Reviewed-on: https://chromium-review.googlesource.com/1208434 > Commit-Queue: Jared Saul <jsaul@google.com> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589060} TBR=sebsg@chromium.org,jsaul@google.com,dlkumar@google.com Change-Id: Id88b0a194dad400be5ba95a36f11d8ebb5ccd1ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840703 Reviewed-on: https://chromium-review.googlesource.com/1211282Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#589215}
-
Dominik Röttsches authored
Preparation for adding a postscript and full font name unique matching function to WebSandboxSupport, in which a similar return type is needed, but the use case is not fallback. BUG=880832 Change-Id: Ibb66f3fe0007c517d74f56ba10096141b702676e Reviewed-on: https://chromium-review.googlesource.com/1209842Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#589214}
-
Xiangjun Zhang authored
Add the mojo interface to start an OffscreenTab mirroring with the mirroring service. Bug: 734672 Change-Id: I3b9edbdccffdfb06b0a325170ed6108be81a6975 Reviewed-on: https://chromium-review.googlesource.com/1195821Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589213}
-
Lukasz Anforowicz authored
This CL makes sure that tests for cross-origin fetches from content scripts cover both 1) programmatic content scripts (i.e. ones triggered by chrome.tabs.executeScript) and 2) declarative content scripts (i.e. ones listed under "content_scripts" entry in an extension manifest). The extra test coverage is desirable to ensure that the future work to provide a separate URLLoaderFactory for content scripts gives correct results both for programmatic and declarative content scripts. For example - providing the URLLoaderFactory in ExtensionMsg_ExecuteCode would be wrong because it would not cover declarative content scripts. Bug: 846346 Change-Id: Ibe3f32fd69d502e0a0874fde7636629e5b6693fa Reviewed-on: https://chromium-review.googlesource.com/1208816Reviewed-by:
-
