- 24 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1580d53b7bc..4005bb741040 2020-09-24 mark@chromium.org mac-arm64: Provide an arm64-native ninja-mac for builds in ¼ of the time If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103315 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I017d9bd55ea916819944b2db3f4338cde653ee53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427963Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810138}
-
Kent Tamura authored
Bug: 1040826 Change-Id: I4ed8de1d903563808985cea91aa13f125d06a275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426212 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#810137}
-
Zufeng Wang authored
Make help app use message pipe instead postMessage directly. Copies a lot of how media app does it: - The changes in help_app_ui/resources are based on the files in media_app_ui/resources/js - browser_proxy.js copies from launch.js - The externs file is the same as the externs file in cl/333229584 - Add a mock app in app_bin.js - Changes in help_app_ui/test to switch to message pipe are mostly copied from media app: - Move runTestInGuest out of GuestDriver like media app - Delete GuestDriver because help app doesn't use it - Delete actionQuery because help app doesn't use it - Delete the tests for open feedback dialog and show parental controls. Test them in help_app_integration_browsertest.cc instead. Using message pipe and the externs file gives more type safety. Bug: b/166043485 Change-Id: Ifa155537505a8b3456cde0c1be4d8f1a8ca4c90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405044 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810136}
-
Kenichi Ishibashi authored
This CL changes the implementation of ServiceWorkerResourceReader not to depend on AppCacheResponseReader by effectively porting AppCacheResponseReader into ServiceWorkerResourceReaderImpl. See [1] for the reasoning of code duplication. This CL should not have behavior changes. Existing tests such as ServiceWorkerInstalledScriptsSenderTest and ServiceWorkerResourceStorageTest cover this change. [1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/edit?usp=sharing Bug: 1117369 Change-Id: I38edd39b4073e9c8f3922a8c638def2e60a972b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367310 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810135}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5e85c8bc3139..0ed7f1fab2e9 2020-09-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision adce4958..532b3f34 (809911:810021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I584db4201b52332cfc60d90ff4fc2562531c2d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427965Reviewed-by:
-
Andreea Costinas authored
This CL reverts the change in CL:2367042. The privacy team revisited the initial decision to show the "Network may be monitored" warning for enterprise networks and concluded it's confusing and not helpful. Bug: 1130566, 1119754, 919691 Change-Id: Ie25dd43a61a25c0e332eda5ebcec9c08b4c59c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426611Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#810133}
-
Koji Ishii authored
This patch renames: EmHeightAscent to NormalizedTypoAscent EmHeightDescent to NormalizedTypoDescent It was once discussed at whatwg to use normalized sTypo metrics as the definition of "em-height", but the plan was abondaned due to the lack of consensus. The algorithm is still useful for other purposes that this patch renames it and use the same way. We may want to switch this to other algorithms in future, as the standard evolves, and as we retrieve better metrics (e.g., BASE table) from fonts. This patch has no behavior changes. Change-Id: I6bbbaabb1b54795bf88a85730364581254066464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425995 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#810132}
-
Rohit Agarwal authored
This CL adds integration tests to verify the incognito interstitial methods are invoked correctly when navigating from the account picker dialog to the Incognito interstitial. Bug: 1125979 Change-Id: Ieb41f23e8ca79a7006e20ce8ae7d16acb60f2231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424255 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810131}
-
Yutaka Hirano authored
- Fix WindowOrWorketGlobalScope.crossOriginIsolated behavior for workers. - For SharedWorkers and ServiceWorkers it always return false. See https://crbug.com/1131403 and https://crbug.com/1131404. - Rename ExecutionContext::IsCrossOriginIsolated to CrossOriginCapability. This is aligned with https://html.spec.whatwg.org/C/#concept-settings-object-cross-origin-isolated-capability. - Fix wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html. I originally planned to do that in https://github.com/web-platform-tests/wpt/pull/24600 but I couldn't do that due to some flakiness. - Add more tests for workers in wpt/html/cross-origin-embedder-policy/cross-origin-isolated-permission.https.html. Bug: 1115379, 1018680, 1131403, 1131404 Change-Id: I2afcb01403f67a11fd06aefde1238aba16b68f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416428 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:Domenic Denicola <domenic@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#810130}
-
Mohamed Amir Yosef authored
This is a reland of 670197a4 After the base CL has been fixed, I am relanding this again. PatchSet 1 is the same as the original CL. I just added the missing initialization of may_use_prefilled_placeholder_ in PatchSet 3. Original change's description: > [Autofill] Parse the new proto in FormStructure > > Before this patch: > The new protos were converted to the old protos before being > parse by the FormStructure. > > After this patch: > The new protos are parsed directly. > > Bug: 1114655 > Change-Id: Ieb7d71c573e3010067aba250ab161be7946d203e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404584 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809279} Bug: 1114655 Change-Id: Ie66fc03fa39443f14a243312fd991eec51192c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426432 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#810129}
-
Kent Tamura authored
This CL ports LayoutSliderTrack::UpdateLayout() to LayoutNG. * Add NGLayoutInputNode::IsSliderThumb() - Add blink::IsSliderThumb() to shadow_element_utils.*. - Add two shadow pseudo names to shadow_element_names.json5. * In NGBlockLayoutAlgorithm, if a child is a slider thumb, apply positioning logic dedicated to slider thumbs. This CL has no behavior changes because input[type=range] still use the legacy layout. Bug: 1040826 Change-Id: Ie92272df888b063755a4686cd40f910e528d802d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418136 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#810128}
-
Joel Hockey authored
Convert should only be called with expected VmType. Add DCHECKs, and remove unneeded conditional. TBR=nancylingwang@chromium.org Change-Id: I0b921d1b1db82c213eda1ad2cb8dcd5596156ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426151 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#810127}
-
Tamer Tas authored
R=johnchen@chromium.org CC=cbruni@chromium.org, jdecaires@twitter.com Bug: 1114635 Change-Id: I224fd77a89e316ba982c958ca9227ebb45db6eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345308 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810126}
-
Alex Rudenko authored
This CL creates AXContext instances lazily when InspectorHighlight instances that fetch accessibility attributes are created. It relies on the GC for cleanup instead of DOM agent's DOM listener API. Bug: 1112066 Change-Id: I737204c2bbcd97b00c17cff989587d5d71d40184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416456 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#810125}
-
Antonio Sartori authored
RenderFrameHostImpl::DidCommitNavigation is called either by (1) DidCommitPerNavigationMojoInterfaceNavigation or (2) DidCommitProvisionalLoad. (1) always passes a committing_navigation_request (there is a CHECK just before calling DidCommitNavigation that the navigation has been found in the map navigation_requests_). (2) moves into committing_navigation_request the navigation_request_ of the RFH, hence making navigation_request_ null. Hence this if statement is a no-op and can be eliminated. Change-Id: Iae99e84c4d127c679001598ead84a061a16cf515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426615 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810124}
-
Tanmoy Mollik authored
Extend the expiry to M87 Bug: 1089518 Change-Id: I459afc4e82b81196b30a45dacc680d8056d3ab01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426504 Auto-Submit: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810123}
-
Rouslan Solomakhin authored
Before this patch, a website could create a PaymentRequest object with a payment method that pointed to a >5MB manifest file, which would cause a crash in DownloadToStringOfUnboundedSizeUntilCrashAndDie() method. This patch replaces the DownloadToStringOfUnboundedSizeUntilCrashAndDie() method with DownloadToString() with an upper bound of 1MB file size for both payment method manifest and web app manifest. After this patch, if the payment method manifest or web app manifest are larger than 1MB, then PaymentRequest.canMakePayment() and PaymentRequest.hasEnrolledInstrument() will return false, PaymentRequest.show() will reject with NotSupportedError. Bug: 1025336 Change-Id: I209116d3c1ec1721148e94992adfa2a20a7beaa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426966 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#810122}
-
Morten Stenshorne authored
TBR=ikilpatrick@chromium.org Change-Id: I8a0303a05bed8a4e9d1856cc71b47d402237f227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428324Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#810121}
-
Henrique Ferreiro authored
SetCursorNative is only called from WindowTreeHost::SetCursor, which guarantees that the platform cursor has been set. Bug: 1097556 Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#810120}
-
Leo Lai authored
This reverts commit 6ab3c894. Reason for revert: the project dependency, platform-side proxy, is currently only enabled with device policy and not universally available until M88. Original change's description: > remove cryptohome client from EnrollmentCertificateUploaderImpl > > The new attestation flow doesn't rely on cryptohome client anymore. > > as for testing, EnrollmentCertificateUploaderTest.* are passed. > > Change-Id: Id289cdc1b2e2d4a27179f048c0d6e3d4d968cd88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303743 > Commit-Queue: Leo Lai <cylai@google.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789865} TBR=emaxx@chromium.org,cylai@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ief64848511e08db9b9b6385c03d15f227a6cd2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425685Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Sergey Poromov authored
Add Data Leak Prevention features that restricts printing of DLP sensitive content. Bug: 1124651 Test: Browsertest added. Change-Id: I0d653f3ea2518882f3cce8a96195247152fe45fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390651Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810118}
-
Karandeep Bhatia authored
registration. Manifest-only schemas don't need to go through api_registration (which generates api function registration) and generated_api_json_strings (which generates api schema strings) build steps. Exclude them from the same. This also helps ensure we don't redundantly generated schema strings for these apis. BUG=1113513 Change-Id: I69c39cda6a6ac78fd47e6bf01e44110e221bb76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380614 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810117}
-
Victor Hugo Vianna Silva authored
Problem: AndroidSyncSettings (ASS) will soon depend on ProfileSyncService (PSS), particularly in its constructor. Although this is is fine in production code, SyncTestRule poses two issues for this setup on test code. - ASS is created before a fake PSS provided by tests can be injected. This is a problem because the initial state of PSS will be relevant to the constructor logic of ASS, so we need to be able to fake this initial state to write good tests. - ASS is created before the JNI loads in startMainActivityForSyncTest(). For tests that don't provide a fake PSS, ASS will then attempt to talk to the real PSS before JNI is loaded, causing an error. Solution: When SyncTestRule creates an ASS, the goal is actually just to fake one of its internal dependencies, SyncContentResolverDelegate. In this CL, we convert SyncContentResolverDelegate into a singleton. In this way, a fake for this object can be injected without needing to early construct ASS*. Furthermore, JNI is loaded earlier so that the rule can safely use tools like FakeServer and FakeProfileSyncService. * Note that constructing after startMainActivityForSyncTest() is not an option because there's already code talking to ASS when this function is running. Bug: 1125622 Change-Id: I9dd938fd5d8211d58a97adb6d484c1a21a3b67db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424150 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#810116}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600905490-263a31e7c986c96eb226e442771660364e68ddae.profdata to chrome-linux-master-1600927122-8b2948f1592bbc4f5258707765d485dd2b5e6892.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4195af499da913cf707b10f35eff715d0b639b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428192Reviewed-by:
-
Monica Basta authored
The sync setup frienldy settings has been fully launched. This CL removes the flag and cleans the code accordingly. Bug: 1045423 Change-Id: I32eb5123b6cd473b7b5dc73fb8c99f445afae369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418954Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#810114}
-
Tanmoy Mollik authored
The sync row icons have a border which is white is light mode and black in dark mode. This cl removes the border. Screenshot: https://crbug.com/1131438#c1 Bug: 1131438 Change-Id: I6c16e4fc3ebec0ce971db8e191231c04585c22fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426425Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810113}
-
Dominik Röttsches authored
Use the list of candidates for available fonts implemented in [1], lazily retrieve it and check the list before making IPC calls for requesting a font. After retrieving the list once, this avoids making IPC calls for font retrieval for fonts that are not available through the Android Downloadable Fonts API implemented on the Java side of the IPC interface. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2414514 Bug: 1115064 Change-Id: I0c9bee08082f522cbd00fbf85df0c2f4e806cbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425049 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#810112}
-
Clemens Arbesser authored
For flows that are triggered by a lite script and show the onboarding, no initial status message should be shown. Details are in the bug, but the tldr; is that we don't want to confuse users by showing the default 'opening' message (since the target site is already loaded). A video of the new behavior is also in the linked bug. Bug: b/166590955 Change-Id: I73fcf1dc2dd32db64d5452d039681f46783d30c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424193Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#810111}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5031f041244ebf3bcae8b157123bd16a8ce2d73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428184Reviewed-by:
-
My Nguyen authored
Use google-grey-600 which is the same color as the disabled text. View: http://screen/QCzfch2vrvgJjuy Bug: 1113439 Change-Id: I1cb748b864cc72e919a997b80a395dfeee670350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423813 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810109}
-
Martin Kreichgauer authored
WebAuthn L2 adds an extension called credProps that is meant to convey additional attributes about a WebAuthn credential at registration time back to the RP. Currently, the only such attribute is an (optional) boolean 'rk' that indicates whether the registered credential was client-side discoverable (aka 'resident key'). This is useful in combination with another L2 feature, the ResidentKeyRequirement enum, which adds a middle value ("preferred") to the previously boolean resident key requirement in a WebAuthn registration request. The 'rk' boolean in the extension output is optional because there are authenticators that may create a discoverable credential, even though the browser didn't request one. In particular, the CTAP2.0 authenticator spec allows for this, but the CTAP2.1 spec doesn't. Hence, if resident key creation was not requested, Chrome will not set the 'rk' field if the responding authenticator is a CTAP2.0 device; but it will set 'rk' to false for CTAP2.1 authenticators. Bug: 1117630 Change-Id: Ide483fc9d597b3658197646f07e174b85d9984cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410419 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#810108}
-
Colin Blundell authored
Currently WebLayer/WebView's shared autofill implementation doesn't properly reset state on webpage reload. This results in buggy behavior as the implementation treats the user's session after reload as a continuation of the before-reload session rather than a new session (see [1] for details). This CL fixes the problem by having AutofillProviderAndroid reset its state on receiving a notification to do so from ContentAutofillDriver. This notification is made when a different-documentation navigation is made. As detailed in [1], a reload is always treated as a different-document navigation by //content. We also add a test of that autofill starts a new session in this case, which fails without the change made in this CL. To manually verify: Go to accounts.google.com in WebLayer Shell, focus on the username field to trigger the autofill popup, reload the page, focus on the username field again, and verify that the autofill popup triggers again. [1] https://docs.google.com/document/d/1tyQ5XQLssIoa1AIPJ9WjOnW6-lPZpmpSrxkf5-6HYgc/edit#heading=h.u1hpn0gmjp2e (internal-only, apologies) Bug: 1117563 Change-Id: If6f95aa1fea9dccf0f24a860758fd323d9714c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409492Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#810107}
-
Hiroshige Hayashizaki authored
This CL runs tests for module dedicated, shared, service workers and worklets with top-level await enabled. Issue 1111134 will touch module script evaluation code, so needs test coverage of worker/worklet evaluation under TLA. Bug: 1111134, 1022182 Change-Id: I876c94462ac0117c9c743442fe2e34333f86740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418494 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Christian Biesinger authored
..even if contain-intrinsic-size is specified. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1124922 Change-Id: If4c887a3536b65fbeb1c22a8a2e3a66896046ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423584 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
The feature toggle was enabled by default in M83. Change-Id: I9afb7659990af267540dcd044bafda3dc1c3d8bc Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426426Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#810104}
-
Morten Stenshorne authored
When attempting to clamp the scroll offset during printing, save the scroll offset before clamping, so that it can be restored after printing. Note that there are still issues to fix here. Right now, this CL doesn't fix anything at all, but it will prevent a regression that would otherwise be introduced by crrev.com/2362749. This is what's tested in PrintBrowserTest.NoScrollingVerticalRl PrintBrowserTest.NoScrolling tests scrolling of an iframe and a scrollable DIV, and another scrollable DIV that turns into a non-scrollable flexbox when printed. The iframe part also passes without this CL, and the scrollable DIV ones fail both without and with this CL (and is therefore disabled for now). Same problem for framesets - still not fixed. Added a test. The remaining known scrolling issues when printing are reported as bug 1131598. Based on WIP CL:2402190 by szager. Bug: 1125972 Change-Id: I6c3f5853d329e4731b02b33d67cbd4b016f2675f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418651Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#810103}
-
Charles Zhao authored
(1) calling HandwritingModelLoader(spec, receiver, callback).Load() is a bad idea because the .Load() is async and the temporal object could be released very soon. This Cl changes the whole class to be stateless, so that calling HandwritingModelLoader::Load(spec, receiver, callback) won't suffer the same problem. (2) unit tests are fixed accordingly. Bug: 1054628 Change-Id: I56459b14e1fc4a6608d5ed264e6c650d1e076f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415914 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#810102}
-
Dominic Farolino authored
This CL makes AgentSchedulingGroup and its host, implement the mojom::RouteProvider and blink::mojom::AssociatedInterface interfaces. This will make it possible in the future to register ASG-specific routes instead of process-global routes, as well as ASG-specific associated interfaces, as opposed to interfaces that are associated with the process-global IPC channel. Currently the implementations of these interfaces are not operational. Later CLs will flesh out this implementation so we can begin migrating interfaces over to the ASG scope. Bug: 1111231 Change-Id: I3da0a31d31018b18ab616e02f351d3d0876c7694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415949 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810101}
-
Mason Freed authored
Quirks mode layout is slower than no-quirks. This change should not affect the appearance of the image preview document. Bug: 1131185 Change-Id: I79e8b523fa518ddd7a230ea7f669df63e023b9e5 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425008 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#810100}
-
Samuel Huang authored
Previously, SaveDeltaSizeInfo() and LoadDeltaSizeInfo() take an optional |file_obj| parameter, and uses it in a "with" block. This causes the inject |file_obj| to get closed. This side-effect is undesirable for the usual usage pattern of callers lending |file_obj| to functions. This CL fixes the issue by using a one-level recursion to create |file_obj| if it's not provided. Change-Id: I2132aea64bb29edd49576dbaa4b0797a6afb80f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425224 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#810099}
-
