GitLab

dialog UI design paradigm [Mac/Views]:

- Add a title ("You're now signed in to Chromium!")
- Modify "OK" button to say "OK, got it!" instead
- Adjust margins and gaps according to spec.

XIB changes:
* Added a new NSTextField for the “You’re now signed in to Chromium” title.
* Made the entire bubble taller (167 height) and wider (350 width) to accommodate new UI spec and to make room for the title text field.
* Repositioned the Advanced link and the OK button in order to have 10 view units margin from the bottom and left/right edges (also for new UI spec).

Screenshots:
* Mac: http://i.imgur.com/qKWKwR4.png
* Views: http://i.imgur.com/6fYmi42.png

BUG=322593
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/107673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243744 0039d316-1c4b-4281-b951-d872f2087c98

In detail, this patch does the following things:
- Move the Blink SurfaceView on top of ContentVideoView
- Enable necessary bits on the compositor to make background transparent,
  and enables alpha blending.
- Introduce a new command-line flag to enable the new mode. The old-style
  Java media control are moved to ContentVideoViewLegacy, which is enabled
  by default.

To enable the blink-based media control, do the following:
adb shell
sudo echo chrome --enable-overlay-fullscreen-video-subtitle > /data/local/chrome-command-line

R=
BUG=262945

Review URL: https://codereview.chromium.org/25040002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243743 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305431
TEST=webgl got blacklisted on win machines with this GPU
R=kbr@chromium.org
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/127843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243741 0039d316-1c4b-4281-b951-d872f2087c98

Added implementation for the DesktopRootWindowHostX11::SetSize function.

BUG=330596
R=erg@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/127453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243740 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/129563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243738 0039d316-1c4b-4281-b951-d872f2087c98

Cursor prefetch caches must be reset when requests that could invalidate
the cache are made (i.e. puts, deletes), and to ensure that requests
are processed in order per spec (i.e. even gets). This doesn't apply
to requests that aren't scoped to a transaction, so some unnecessary
resets can be removed.

BUG=329950
R=dgrogan

Review URL: https://codereview.chromium.org/128623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313530
TEST=to be used by ServiceWorkerBrowserTest

Review URL: https://codereview.chromium.org/127713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243736 0039d316-1c4b-4281-b951-d872f2087c98

Only disable it if there's no indication the user might be interested in US addresses. App locale is not taken into account because many international users set theirs to en-US.

BUG=323641

Review URL: https://codereview.chromium.org/106033007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243735 0039d316-1c4b-4281-b951-d872f2087c98

Some entries are 64 bits wide, and will overflow on occasion.  In particular,
VM_STARTTIME will overflow a 32-bit int on long-running systems.

BUG=332491
TEST=local build, run on desktop Linux

Review URL: https://codereview.chromium.org/129353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243733 0039d316-1c4b-4281-b951-d872f2087c98

Two more tweaks to get compile further along.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/127043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243731 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284553

Review URL: https://codereview.chromium.org/98173009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243729 0039d316-1c4b-4281-b951-d872f2087c98

the chrome.sockets API and manifest key.

BUG=293756

Review URL: https://codereview.chromium.org/94093013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243728 0039d316-1c4b-4281-b951-d872f2087c98

This avoids it being visible when the user first runs the app if they are able
to expand the Me2Me section before the XHR to fetch the host list has completed.
Note that they will still see a blank entry in this case, but only if the local
host is registered. Since the name of the local host isn't known until the XHR
returns, there's no easy solution to that, and given how much a corner case it
is, I don't think it's worth fixing.

BUG=277168

Review URL: https://codereview.chromium.org/128323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243727 0039d316-1c4b-4281-b951-d872f2087c98

Speculative fix. This crash happens if we have pending
OnReadyToLaunch job after CleanUp is being called. The only
possible cause seems to be user manually cancels the launch
while the OnReadyToLaunch job is pending. Use timer for the
job and cancels it in CleanUp to fix the crash.

BUG=331105

Review URL: https://codereview.chromium.org/127183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243726 0039d316-1c4b-4281-b951-d872f2087c98

1. Set WindowType to "control" in RWHVAura::InitAsChild().  Previously, the window type was not being set, and this caused a NOTREACHED() crash at ash/wm/stacking_controller.cc:101.

2. Infinite loop freezing the browser when entering fullscreen: In WebView, AttachWebContents() and DetachWebContents() were being indirectly called from FOR_EACH_OBSERVER().  Because they were calling WebContentsObserver::Observe(), the FOR_EACH_OBSERVER loop would never terminate.

3. Clean-up: Eliminated WebView::web_contents_ member since WebView inherits from WebContentsObserver, which already has it.

TEST=Run chrome with and without --embed-flash-fullscreen command-line arg, and test switching tabs, flash fullscreen, keyboard focus, etc.  Tested on Win and Linux Aura builds.

Review URL: https://codereview.chromium.org/120503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243725 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330084

Review URL: https://codereview.chromium.org/111853012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243724 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/129573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243723 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an app-style widget called app-drawer to the Silk page set. The
app-drawer widget comes from https://github.com/abarth/app-widgets and is based
on Android's navigation drawer:

http://developer.android.com/design/patterns/navigation-drawer.html

R=nduca@chromium.org
TBR=boliu@chromium.org
BUG=332439

Review URL: https://codereview.chromium.org/120753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243722 0039d316-1c4b-4281-b951-d872f2087c98

It's unnecessary to gate solid-color scrollbar properties on whether
the root container masks to bounds, since the vertical adjust should
resolve to zero in this case anyway.  It's necessary to set VisibleToTotalLengthRatio
for desktop overlay scrollbars to be sized correctly.

BUG=331605
TEST=None
R=aelias

Review URL: https://codereview.chromium.org/106733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331459
TBR=sehr@chromium.org

Review URL: https://codereview.chromium.org/126823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243720 0039d316-1c4b-4281-b951-d872f2087c98

The rest of aura targets do not reference cc/, so they don't need to
explicit list cc/ as a dependency.

BUG=None
TEST=aura_bench, aura_demo, aura_unittests, all three still links
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/124343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332175
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/129693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243717 0039d316-1c4b-4281-b951-d872f2087c98

This UI currently only displays battery charge percentage over time.
Later iterations will add more plots.

BUG=312956

Review URL: https://codereview.chromium.org/123713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243716 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r243708  which is causing a build failure:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/50092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243476

Review URL: https://codereview.chromium.org/128893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302852,275611
TEST=ImmediateInputRouterTest.GestureTypesIgnoringAck

Review URL: https://codereview.chromium.org/84653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243713 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331805
TEST=No visible change. Existing unit tests.

Review URL: https://codereview.chromium.org/128513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243712 0039d316-1c4b-4281-b951-d872f2087c98

Implementation CHECKs, so this is only needed for tests and ash, which
we're not worrying about yet.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/128743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TBR=asvitkine@chromium.org
TEST=With the --new-profile-management flag, start Chrome. Select
"Browse as guest" from the avatar menu. From the guest browser, select
"View all people" from the avatar menu. This shouldn't crash and should
show the User Manager.

Review URL: https://codereview.chromium.org/129103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330843

Review URL: https://codereview.chromium.org/128453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243709 0039d316-1c4b-4281-b951-d872f2087c98

Add the vulcanize node script to tools which will be used to combine
polymer elements during the chrome build process. Polymer is used (for
example) with the PDF extension.

R=cmp@chromium.org

Review URL: https://codereview.chromium.org/125733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243708 0039d316-1c4b-4281-b951-d872f2087c98

Previously Desktop Capture API allowed requests only from non-incognitor
tabs. The API might be useful in incognito tabs in some scenarios.

R=joi@chromium.org

Review URL: https://codereview.chromium.org/126433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243706 0039d316-1c4b-4281-b951-d872f2087c98

Streamlined Hosted App windows were having their location bar truncated
when maximized. This was due to using the popup-style location bar to
get the omnibox to be read-only.

This CL changes streamlined hosted apps to use the normal location bar
and sets the omnibox to be read only at a deeper level.

BUG=318607

Review URL: https://codereview.chromium.org/110413007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243705 0039d316-1c4b-4281-b951-d872f2087c98

These methods should always return valid parameters, even if a device
doesn't exist.

Output code will automatically fall back to a fake path at a later time
if those parameters are used to open a stream.

Input code will fail because no input devices can be enumerated.

BUG=331675
TEST=no more crashes.

Review URL: https://codereview.chromium.org/127363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243704 0039d316-1c4b-4281-b951-d872f2087c98

This CL had the unintended side effect that Simulate Browser Restart no longer
works. Also, experimentation suggests that the original bug it was intended to
fix works without this change now.

> Make clicking the restart bubble for crashed apps work.
> 
> Previously AppLoadService listened for
> NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING before dispatching the
> onRestarted() event after a reload, but in the case of packaged apps, which use
> non-persistent background pages, that notification will never get fired. This
> is because reloading an app doesn't cause its background page to get loaded -
> only a relevant event causes the page to be woken up.
> 
> This patch fixes the issue by listening for NOTIFICATION_EXTENSION_LOADED
> instead, which is always fired after a reload. It also determines whether an
> extension is listening to an event by checking which events it has registered
> for, not which ones it currently has a listener for,
> NOTIFICATION_EXTENSION_LOADED is the notification that listeners get created
> on, and so to avoid raciness we check registered events (ie: the persisted
> list of events that an extension is interested in).
> 
> BUG=327964
> 
> Review URL: https://codereview.chromium.org/93593003

TBR=koz@chromium.org

Review URL: https://codereview.chromium.org/127843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243703 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332297

Review URL: https://codereview.chromium.org/127743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243702 0039d316-1c4b-4281-b951-d872f2087c98

WebMediaPlayerImpl needs to access the Decryptor object when a MediaKeys object is associated with a MediaElement (HTMLMediaElement.setMediaKeys()). These are the changes required on the Chromium side to WebMediaPlayerImpl to get a pointer to the Decryptor. Use of the Decryptor will come later.

BUG=329582
TEST=new layout test in the Blink side CL

Review URL: https://codereview.chromium.org/105143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243701 0039d316-1c4b-4281-b951-d872f2087c98

This adds a version of GrabWindowSnapshotAsync that behaves identically
to GrabWindowSnapshot except with a callback.  The snapshot aura unit
tests are updated to use this new async function instead of the sync
one.

In order to make the snapshot tests work properly, they also now have to
use a real gl context so that real drawing and readback can occur
through the compositor.

BUG=331410, 332167

Review URL: https://codereview.chromium.org/119753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297856

Review URL: https://codereview.chromium.org/24460002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243699 0039d316-1c4b-4281-b951-d872f2087c98

We already disable the artificial delaying of resources when connected
to a SPDY-capable host, this extends that to also include pages that are
served through a SPDY proxy.

As-implemented, as soon as any request for a given client completes and
was served using SPDY over a proxy connection, that client will be
treated as a SPDY-capable client.  Some resources will still be delayed
until the base page (or another request) completes but it is much better
than it was before.

BUG=324789

Review URL: https://codereview.chromium.org/99533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243698 0039d316-1c4b-4281-b951-d872f2087c98