- 28 Jan, 2020 40 commits
-
-
Wenbin Zhang authored
Windows has a limit of 32767 on a command line. When testing with field trails, the command to launch chrome.exe may exceed the limit if there're too many field trial configs passed as parameters. This was causing the chrome perf waterfall to completely fail on Windows. This CL added a presubmit check to see whether the configs under Windows will exceed the limit of 31000. Bug: chromium:1045530 Change-Id: I9d181783f1bdad58eeba802583c052bfd0321c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021468 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#735981}
-
Ian Prest authored
This reverts commit 0885c956. Reason for revert: Unfortunately, this change results in the notification of page-load-complete happening much later than it did previously. Since a11y events aren't fired when |user_is_navigating_away_|, the result is that some events that occur early in a page's lifetime are not emitted. This is most visible for programmatic 'focus' changes; if they're not emitted, any connected AT doesn't know the focus has changed. Original change's description: > Notify BrowserAccessibilityManager via WebContentsObserver > > This is the last of a series of CLs that remove manual notifications > BrowserAccessibilityManager, now that it implements WebContentsObserver. > This CL removes manual BAM::Navigation{Succeeded,Failed} notifications > in favor of WCO::DidFinishNavigation, and BAM::UserIsNavigatingAway in > favor of WCO::DidStartLoading. > > Bug: 981271 > Change-Id: Ieca6ce0b97f2a0267fd7f2582ab1e333deb11b95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938489 > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720102} TBR=falken@chromium.org,dmazzoni@chromium.org,dom@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 981271 Change-Id: I41d68985b964792083aa5b6628bb3bc0972c9790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024154Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#735980}
-
Thomas Guilbert authored
This CL moves the video.requestAnimationFrame tests to a new directory in the web platform tests, and makes small updates to resources used. Bug: 1044796 Change-Id: I0f07391695ef36b0631bd3e4986a69086bf16a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024036Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#735979}
-
Sahel Sharify authored
This is a Desktop only change to ensure that the "add card" button is shown in payment method window only when the "basic card" method is supported. Change-Id: Ibfc31141cf45595c0db216d017b5c8c484094424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024923 Commit-Queue: Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735978}
-
Avi Drissman authored
BUG=1044828 Change-Id: Ia2755553d937c547e458f3a7bb424485ce1b0ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020183Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735977}
-
Yuchen Liu authored
Support spatial rendering check for MediaCapabilities API. Bug: 139027108 Test: On device Change-Id: I796ad613b3513db88ee685bdbb0ab911b6c2fd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024417 Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735976}
-
Yi Gu authored
The test is also flaky on Linux TSAN and Win10: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWQsSBUZsYWtlIk5jaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BDb21tYW5kbGluZVN0YXJ0dXBUcmFjaW5nVGVzdC5UZXN0U3RhcnR1cFRyYWNpbmcM TBR=eseckler@chromium.org Bug: 1041392 Change-Id: Ifb9ee371de789ed8c0bab6eb5b87c728d91d9bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025487Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735975}
-
Rune Lillesveen authored
TestRunner.loadHTML() does not wait for the document to load or even fully parse before returning. When the html contains a parser blocking stylesheet in a link element, the parsing is typically not finished when loadHTML returns. When BlockHTMLParserOnStyleSheets is enabled, this test started failing because we were trying to find a node which were not yet parsed. Bug: 891767 Change-Id: I4d6012a732143baf93c67a5e6cc01a78da617d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023892 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#735974}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1b3441036a8f..97f1d485b763 git log 1b3441036a8f..97f1d485b763 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 stevenperron@google.com Dead branch elim fix (#3160) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@97f1d485b763 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com,syoussefi@google.com Change-Id: I430340156d45a6469814d5f69707b7b95f4dc7bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#735973}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f76da63fbdfc..89e678dea268 git log f76da63fbdfc..89e678dea268 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 jlavrova@google.com Skip vertical clipping in unclear case of font height=font size Created with: gclient setdep -r src/third_party/skia@89e678dea268 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I3966aeb6a338dcfc7a08f3d330695ab61eb1d970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025315Reviewed-by:
-
Chris Harrelson authored
Change-Id: I74af25c477dab6ee3024447fe4b0d34a71dd5a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021284Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735971}
-
Antonio Gomes authored
The CL allows us to clean up one of the respective legacy/plumbing IPC methods from content::RenderFrameProxy and blink::WebRemoteFrame{Impl}: OnDidStopLoading(). However, given that content::RenderFrameProxy::OnDidStartLoading() is still called directly by content::RenderFrameImpl::OnUnload(), it can't be removed now. RenderFrameHostManagerTestWithSiteIsolation.NewProxyReceivesLoadingState makes use of the newly added helper class StartStopLoadingRemoteFrame. It inherits from content::FakeRemoteFrame, and overrides two mojo methods it wants to track calling called: DidStartLoading() and DidStopLoading(). For this, the CL also adds a new hook to RenderFrameProxyHost that allows tests to install a callback to react to an instance being created. This way custom blink::mojom::RemoteFrame implementations can be injected accordingly. BUG=1044301 R=dtapuska@chromium.org Change-Id: I0f972236c63356a872f339dddaa623c2dde4fdf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017002 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#735970}
-
George Steel authored
Add DCHECK(this) to node::IsDescendantOf() to get better stack trace in ClusterFuzz when it is called on nullptr. Bug: 1035664 Change-Id: I09d66f770eac7c231a8f6ef9b4840a826caf7971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019469Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#735969}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/34e16df059f8..153a537a3f87 git log 34e16df059f8..153a537a3f87 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 bclayton@google.com SpirvShaderDebugger: Fix double nesting of struct members Created with: gclient setdep -r src/third_party/swiftshader@153a537a3f87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3e8ffcd30a3662a8a1eb364e2de7343b3153c15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025307Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f144b77bc846..7488a0964115 git log f144b77bc846..7488a0964115 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 syoussefi@chromium.org Add a test to expose location'ed varying link bug Created with: gclient setdep -r src/third_party/angle@7488a0964115 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I18934b48ce28ebb10b48ef53ed65fd59b5a30929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025309Reviewed-by:
-
haozhe authored
Currently, getAnimation sort the result by animation class and creation time. Sort composite order for animations of the same animation class by tree order of their owning element according to spec. (https://drafts.csswg.org/web-animations/#dom-document-getanimations). This patch align the implementation with the spec. Bug: 993365 Change-Id: I8478b2985c0ab473db33c176fc69516ea0222ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008325 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Lei Zhang authored
Change-Id: I97fe8c9fe453046d16e4b2efe4dd6d106df4b45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024416Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e750f450..36331312 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I53bc1182cee52c1c0ec349c45d9853b54c62e718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025327Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735964}
-
Scott Violet authored
Encryption is done at the command level. Specifically, when encrypted each command is written as a length (not encrypted) followed by the encrypted command-id and command-contents pair. BUG=1033924 TEST=component_unittests CommandStorageBackend* Change-Id: I4899b6daefba85ef3ae865262b375ad345341c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017981Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#735963}
-
Chan Li authored
This reverts commit 31f93aa2. Reason for revert: Findit found this CL as the culprit for failed wtf_unittests in builds: - https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/21982 - https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17513 Sample analysis: https://findit-for-me.appspot.com/waterfall/failure?redirect=1&url=https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/21982 Original change's description: > heap: Check empty or deleted keys on local copy > > Tracing an HashTable involves checking whether keys are empty or > deleted. This can result in data races with the mutator if the > HashTable is modified while it is traced. > To avoid such data races, we create a local copy of the key on the > concurrent thread and perform the check on the copy. > > Using the local copy on the mutator thread would result in significant > regressions. Measured locally on the facebook_infinite_scroll:2018 story > from v8.browsind_desktop benchmark, showed an increase ranging from 70% > to 110% in the time it takes to process ephemerons (this measurement > doesn't cover all HashTables, just the ephemeron HashTable). > To avoid these regressions, the local copy is used only for concurrent > visitors. > > For further details see > https://drive.google.com/open?id=13DTRcF3xfVjJ2QaKzAOYFzqvTfGRNiX6WWL3CCACSoM > > Bug: 986235 > Change-Id: Ie135c1076bd1834ae7f8b97ca6446890fc30a02c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012961 > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735833} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org Change-Id: I8f0e249f4db3326b38d774c9d718fdcd0a2566f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025324Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#735962}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f9e3ba14. With Chromium commits locally applied on WPT: 3157910d "SharedWorker: Add WPT for referrer-policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib81add7bdf3fe793117179e0b2f52797141fa8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025247Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735961}
-
Jacques Newman authored
UIA expects a focus event to be sent to the previously focused node after the context menu is closed. To do this, we relying on the menu_runner_impl to send a new event: "kFocusAfterMenuClose" directly on the previously focused node. Bug: 1022592 Change-Id: Id38a93d795f6a444d8e82fe4f7f3a2efa56bb101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903538Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/315382afa699..2e0a0cb9ad54 git log 315382afa699..2e0a0cb9ad54 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 skyostil@chromium.org Reland: timeline: Support new style slice ids ('id2') Created with: gclient setdep -r src/third_party/catapult@2e0a0cb9ad54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:639003 Tbr: skyostil@google.com Change-Id: Ic3dcc2b8acc9ac7e904d6013d9a79abf187a89e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025311Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. Most changes have landed by now via `git cl split`. This is what remains after two weeks. Bug: 1041419 Change-Id: Ia813d744e57e5647266a91d4f6c725bf921fb11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024471 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Stephan Hartmann authored
Add new targets to libxml.gn that were added in https://chromium-review.googlesource.com/c/chromium/src/+/1894877 Adjust includes to use system libxml headers too Bug: 1043042 Change-Id: I948c063e212e49b9e7f42fed2b8bf7f4af042ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007110Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#735957}
-
Mohamed Amir Yosef authored
Bug: 1044034 Change-Id: I1eb799a6c9cecb116132b023b756ae1b7cc88bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025387 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735956}
-
Wez authored
- Define non-zero native_keycode values under Fuchsia, derived from the USB Usage Code, for keys in the Keyboard Page. - Migrate the InputEventDispatcher for Fuchsia to use the native-to- DomCode conversion API. - Fix KeycodeConverter preprocessor checks around the DOM_CODE() definitions to #error on unsupported platforms. events_unittests will be enabled under Fuchsia in a follow-up CL. Bug: 829551 Change-Id: Ia34beec8b0376980e8f599266df233f6c27cc268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020771 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL uses new downcast helpers for below classes, - SVGAngle - SVGColorProperty - SVGInteger - SVGIntegerOptionalInteger - SVGLength - SVGLengthList - SVGNumber - SVGNumberList - SVGNumberOptionalNumber - SVGPath - SVGPointList - SVGRect Bug: 891908 Change-Id: I3463362c4de47115f8641a0ee294ddd8e8f11b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024234Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#735954}
-
Natalie Chouinard authored
Use OnDisplayPreferenceDialogListener on AutofillProfilesFragment to launch the Activity-dependent dialog for AutofillProfileEditorPreferences, rather than passing Activity through to the preference. Fixed: 982338 Change-Id: I4210f717cd3f240a632d79b8a2de881de91f57a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024072Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#735953}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I98b03a9458420711b4674d77239c98256cac6d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024541Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#735952}
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: I4bede74331ade6af2776fe665b4e682f031d45aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987070 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#735951}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a5dab00ae22..260c788d77ca git log 4a5dab00ae22..260c788d77ca --date=short --first-parent --format='%ad %ae %s' 2020-01-28 peah@webrtc.org AEC3: Added multi-channel support for the capture delay functionality Created with: gclient setdep -r src/third_party/webrtc@260c788d77ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1045910 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I806d1174dd8336643d28a1a1bfd6b0a559e7295d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025310Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 895776, 656015 Change-Id: I196ae815f631376f0ea6cbb26fdadf4e61e2a38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023791 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#735949}
-
Kevin Ellis authored
CommitStyles provides a convenient way to update the style of an element, avoiding the need to keep finished animations persistent in order to stack effects. A typical use case is: const anim = elem.animate(keyframes, {..., fill: 'forward'}); anim.finished.then(() => { anim.commitStyles(); anim.cancel(); }); Spec: https://drafts.csswg.org/web-animations-1/#dom-animation-commitstyles Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/H5sz_dg6fKc/1X7K7U4XCgAJ Bug: 981905 Change-Id: I37f61960480517e0a8f3427938cf799de4c6e9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017673 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#735948}
-
Maksim Ivanov authored
This relands the commit 8fd76b23 that got reverted in commit 319c9b41 due to failing on official trybots. The fix in the reland is to suppress the sync consent screen that is normally enabled on the "branded" builds and that was breaking test expectations (the test expected the user session to start straight away after the successful authentication without any extra screens). Original change's description: > Add browser tests for smart card SAML login > > Provide test coverage for the scenario where a new user authenticates > via SAML using a smart card (or, generally speaking, using a security > token via an extension using the chrome.certificateProvider API). > > This also provides some test coverage for the <security-token-pin> > Polymer element used on the Login Screen. > > Bug: 1033936 > Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968989 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734510} Bug: 1033936 Tbr: alemate@chromium.org, hendrich@chromium.org Test: run the test locally with is_chrome_branded=true Change-Id: I0e8394bb78030137c7570d58c2462a773c13ce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017430 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#735947}
-
Mustaq Ahmed authored
Bug: 1046256 Change-Id: If98bfe75ce859bd9b88c39923c740618129c8d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024915 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735946}
-
Nektarios Paisios authored
If the provided text marker is between lines, such as when on a soft line break or on an ignored position that separates lines, we return the previous line when VoiceOver asks for the line text marker range. This is the same to how the WebKit code in Safari works. See webcore/editing/VisibleUnits.cc::endOfLine(VisiblePosition&, LineEndpointComputationMode, bool) in the WebKit source code. Also, this patch temporarily switches to CreateNextLineStartPosition for computing the end of the line range. This should not have any drastic user visible behavior change, but it's important to do until CreatNextLineEndPosition is fixed to handle ignored positions. Failure to introduce this workaround would delay fixing of line navigation in Docs with VoiceOver. R=dmazzoni@chromium.org Bug: 1015408 Change-Id: Ifeb67d4de688fddace461568e064fc9768024fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023277 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This is a reland of fd84ab8a. This change: 1) Includes a new cipd package version that contains the 'size-classic' binary from the 10.15 SDK, missing in the original package 2) Can be coordinated with a re-land of the internal CL (https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/2404878) to keep the perf builders happy - they are stuck on the 10.14 SDK for reasons currently obscure. Original change's description: > mac: roll to 10.15 SDK > > This change rolls the hermetic Xcode to 11.2.1 aka 11B53, with the > 10.15 SDK. > > Bug: 1023913 > Change-Id: I072a57b5f9c93bc08984b05d0de3ea62886a59dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964531 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#725141} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993723 > Cr-Commit-Position: refs/heads/master@{#730238} Bug: 1023913 Change-Id: I62d9e82673b2d3f4993fbd08654fed85c2319cfb Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022257Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Add code to use the appropriate drag-data, drag-file and paste strings instead of just defaulting to the upload strings. Removes the optional part of the access point since it's used to determine the appropriate string now. Bug: 999145 Change-Id: I115cd567f94d9c4ca7a4befdff386ba76163ae20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016965 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#735943}
-
Gauthier Ambard authored
This CL fixes how the NavigationManager reloads the page with a different user agent when there is a redirect after opening a new tab. In that case the last committed item before the redirect is nil. The last committed item should be used. Fixed: 1046342 Change-Id: I18323b14fdc6a727163f25da36f5dacb4f13b6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023560 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#735942}
-
