GitLab

Script streaming is now on by default since M41 (because of this config turned
it always on). Blink side ignores the config since r189473.

R=jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/905683002

Cr-Commit-Position: refs/heads/master@{#315011}

The implementation of LineBreaker is mostly a straightforward
porting of RenderTextWin's implementation.

BUG=248597
R=ckocagil@chromium.org, msw@chromium.org
TEST=manually, customized ash_shell

Review URL: https://codereview.chromium.org/882643005

Cr-Commit-Position: refs/heads/master@{#315010}

BUG=442613

Review URL: https://codereview.chromium.org/884013007

Cr-Commit-Position: refs/heads/master@{#315009}

This makes the download request limiter test work with both permission
bubbles and infobars. The unit test is now parameterized so both types
of prompts are now tested.

Extra credit: if the user gesture policy changes in the future, look at
PS1 to see how to make the tests pass with a different user gesture
policy.

Supercedes parts of:
https://codereview.chromium.org/411503005/
https://codereview.chromium.org/341833004/

BUG=438758

Review URL: https://codereview.chromium.org/811163004

Cr-Commit-Position: refs/heads/master@{#315008}

BUG=455409
TEST=none

Review URL: https://codereview.chromium.org/887223009

Cr-Commit-Position: refs/heads/master@{#315007}

WebUIs were not properly being created when reusing the current
RenderFrameHost. But while doing that I found an issue in
RenderFrameHostManager::CreateSpeculativeRenderFrameHost where instead
of setting an instance member I was mistakenly shadowing it with a
same-named function member.

This last fix caused another test to crash because the WebUI reuse logic
was incorrect. Instead of checking if it should be reused when the
navigation SiteInstance matched the current one, it was being done when
they were different (what doesn't even makes sense).

Due to these changes I also had to update how RFHM::CleanUpNavigation
and UnsetSpeculativeRenderFrameHost work,so that the speculative WebUI
member is always cleaned up even if a speculative RFH does not exist.

Also renamed the speculative WebUI getter as it's not test-only anymore.

With these changes these tests were fixed when PlzNavigate is enabled:
    RenderFrameHostManagerTest.EnableWebUIWithSwappedOutOpener
    RenderFrameHostManagerTest.WebUIInNewTab

BUG=439423

Review URL: https://codereview.chromium.org/877343010

Cr-Commit-Position: refs/heads/master@{#315006}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/339cdbf..5245cb4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/901413002

Cr-Commit-Position: refs/heads/master@{#315005}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5c8a3fa..7a9fd74

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/881283005

Cr-Commit-Position: refs/heads/master@{#315004}

Move PageUsageData from the global namespace to the history namespace,
fix forward-declarations, removing old unused ones.

Remove unnecessary history:: prefix to refer to names in the history
namespace from the code in the history namespace itself.

Move anonymous namespace in implementation files as sub-namespace of
the history namespace so that they can refer to name in history without
using the history:: prefix.

BUG=None
TBR=dbeam@chromium.org
TBR=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/896093004

Cr-Commit-Position: refs/heads/master@{#315003}

The logic that this DCHECK checks is correct, but during hardware
teardown the tracking information is also reset, even though the sync
RequestDrawGL has not set up the tracking info that it is resetting,
leaving the tracker in an unexpected state.

Ideally we should be differentiating the DrawGL calls required for
hardware teardown from the normal kModeProcess DrawGL calls, but that
seems to require touching framework code, making it difficult to fix.

BUG=451955

Review URL: https://codereview.chromium.org/902813003

Cr-Commit-Position: refs/heads/master@{#315002}

This changes includes all the locale .pak files into the
WebView apk when building it from the chromium tree,
similarly to what we're doing when building it from the
Android tree, see android_webview/Android.mk.

BUG=405035

TESTED=Manual. Verified that the set of locales in the
downstream and upstream SystemWebViewGoogle.apk is the same.

Review URL: https://codereview.chromium.org/868673003

Cr-Commit-Position: refs/heads/master@{#315001}

and renaming DataReductionProxyAuthRequestHandler to
DataReductionProxyRequestOptions

BUG=449665

Review URL: https://codereview.chromium.org/791493015

Cr-Commit-Position: refs/heads/master@{#315000}

Cr-Commit-Position: refs/heads/master@{#314999}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/871293003

Cr-Commit-Position: refs/heads/master@{#314998}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/27f398f..339cdbf

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/903943003

Cr-Commit-Position: refs/heads/master@{#314997}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2fb8a57..5c8a3fa

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/897363003

Cr-Commit-Position: refs/heads/master@{#314996}

This CL adds following operations for select items.
- Clicking icons on list view toggles selection.
- Clicking checkmarks on grid view toggles selection.
- Clicking "Cancel selection" button on the toolbar unselects all selected items.

BUG=402344
TEST=run browser_tests

Review URL: https://codereview.chromium.org/884183006

Cr-Commit-Position: refs/heads/master@{#314995}

BUG=402344
TEST=Check that Google doc files don't have thumbnails on list view.

Review URL: https://codereview.chromium.org/899313002

Cr-Commit-Position: refs/heads/master@{#314994}

Previously new metadata related codes use FileEntry as an input type in the
annotation, but it should be Entry because they can take DirectoryEntry also.

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/897573003

Cr-Commit-Position: refs/heads/master@{#314993}

This CL changes default font size to comply with the design spec.

BUG=402344
TEST=none

Review URL: https://codereview.chromium.org/902663002

Cr-Commit-Position: refs/heads/master@{#314992}

BUG=161942

Review URL: https://codereview.chromium.org/894463003

Cr-Commit-Position: refs/heads/master@{#314991}

BUG=438050
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader

Review URL: https://codereview.chromium.org/886503006

Cr-Commit-Position: refs/heads/master@{#314990}

This change adds support for monitoring stashed handles for being
readable. This will be used to relaunch suspended extension processes
when a persistent service sends a message or data to its client in the
suspended extension process.

BUG=389016

Review URL: https://codereview.chromium.org/648853007

Cr-Commit-Position: refs/heads/master@{#314989}

The CL adds new metadata model to DirectoryModel, and let DirectoryModel call the new metadata model's method to notify change of Entry.

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/892083004

Cr-Commit-Position: refs/heads/master@{#314988}

Review URL: https://codereview.chromium.org/885733003

Cr-Commit-Position: refs/heads/master@{#314987}

The CL lets GesturePropertyProvider decide device types based
on a logic identical to the old inputcontrol script. This
solves some regressions we met on hybrid devices.

Contributed by sheckylin@chromium.org

BUG=454697
TEST=samus ChromeOS build

Review URL: https://codereview.chromium.org/902543002

Cr-Commit-Position: refs/heads/master@{#314986}

This is necessary so that layout tests can run with --site-per-process.  Layout tests run with --dump-render-tree, which also forces --process-per-tab, and the latter was conflicting with --site-per-process.

BUG=417518

Review URL: https://codereview.chromium.org/891063002

Cr-Commit-Position: refs/heads/master@{#314985}

This CL consolidates the SearchResultListView creation in ContentsView
into a single flow used by the classic and experimental app list. They
now both use SearchResultPageView with a SearchResultListView inside.

This change is being made to facilitate further refactoring.

BUG=455059

Review URL: https://codereview.chromium.org/896633005

Cr-Commit-Position: refs/heads/master@{#314984}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f05b633..2fb8a57

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/878043003

Cr-Commit-Position: refs/heads/master@{#314983}

81318c1 Correct cpu_arch value for x86 arch.

BUG=455167

Review URL: https://codereview.chromium.org/904563002

Cr-Commit-Position: refs/heads/master@{#314982}

WifiCredentialSyncableServiceFactory normally uses
chromeos::LoginState to associate a SyncableService with a Shill
profile. For this to work, LoginState must have been set properly,
before someone tries to use the Factory to create a SyncableService.

The precondition is met in production mode. However, in sync
integration tests, it is difficult to arrange for LoginState to be
configured properly. The problem is that the sync integration test
framework creates multiple SyncableServices, without providing the
test case the ability to change configuration between the construction
of the SyncableServices.

Acccomodate the way sync integration test work, by allowing the
WifiCredentialSyncableServiceFactory to ignore LoginState. When
LoginState is ignored, the factory will, instead, use the
BrowserContext to associate the new SyncableService with a Shill
profile. This works for sync integration tests, because each
SyncableService created by the test framework has a separate
BrowserContext.

BUG=chromium:431435
TEST=components_unittests --gtest_filter="Wifi*"

Review URL: https://codereview.chromium.org/876833002

Cr-Commit-Position: refs/heads/master@{#314981}

This CL fixes an issue where the experimental app list animation from
the start page to the custom launcher page was janky because the bounds
were being calculated incorrectly. This CL fixes the animation to use
the size of the view being animated rather than the entire contents
bounds.

BUG=None

Review URL: https://codereview.chromium.org/901133003

Cr-Commit-Position: refs/heads/master@{#314980}

SWRegistration.unregister() depends on WebSWProvider, but it's not available
in SWGlobalScope because the provider isn't supplied on the worker startup
sequence. This series of CLs make it available and support unregister() in
the service worker context.

This CL implements createServiceWorkerProvider() to supply a provider and
sets the document URL of its provider host to the worker script URL in
order to allow unregister() call on SWGlobalScope.

[1] Chromium: THIS PATCH
[2] Blink: https://codereview.chromium.org/900793002/

BUG=452910
TEST=compile

Review URL: https://codereview.chromium.org/893363003

Cr-Commit-Position: refs/heads/master@{#314979}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/66fcf2e..f05b633

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/906433002

Cr-Commit-Position: refs/heads/master@{#314978}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/901153008

Cr-Commit-Position: refs/heads/master@{#314977}

TBR=clamy@chromium.org
BUG=455994
NOTRY=true

Review URL: https://codereview.chromium.org/901393002

Cr-Commit-Position: refs/heads/master@{#314976}

BUG=
R=msw

Review URL: https://codereview.chromium.org/891183003

Cr-Commit-Position: refs/heads/master@{#314975}

BUG=304341,450799

Review URL: https://codereview.chromium.org/894843003

Cr-Commit-Position: refs/heads/master@{#314974}

This patch adds an additional function to the UsbService::Observer
interface that should be used to perform cleanup operations when a USB
device is disconnected. This is separate from the OnDeviceRemoved
function so that implementations of that function, which may depend on
other subsystems' knowledge of a connected device, can run before any
cleanup actions have taken place.

A browsertest for the chrome.usb.getUserSelectedDevices is included
which demonstrates the need for this 2-phase event handling.

BUG=452298

Review URL: https://codereview.chromium.org/891853002

Cr-Commit-Position: refs/heads/master@{#314973}

R=thakis@chromium.org
BUG=455342

Review URL: https://codereview.chromium.org/874163005

Cr-Commit-Position: refs/heads/master@{#314972}