- 29 Jan, 2020 40 commits
-
-
tby authored
Right now we're not loading saved files ranking models from disk on dev channel, for debugging reasons. We don't need this any more, so this CL removes the logic. Bug: 955893 Change-Id: I4159ca99c020f422861480a4c24b39db362ce242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010596Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736257}
-
Takuto Ikuta authored
Before renaming swarming builders for crbug.com/955013, let me fix build config so that each builder uses the same build config with typical builders. Bug: 943176 Change-Id: Ie203ee1ccd05491fe8332e1206d75ad6235b022c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026556 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#736256}
-
Luciano Pacheco authored
This makes easier to navigate in the DOM when using the DevTools, because the list of <cr-menu>'s is too long distracting from the main part of the Files app content. Bug: 992821 Change-Id: I1833a3742bfa6fd8329c27f43bfbf65bf318e649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026510 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736255}
-
yilkal authored
This CL updates SupervisedUserErrorPage html page so that users are notified when they have successfully request for permission. This CL updates SupervisedUserErrorPage javascript so that the focus moves away from the ghost button after request for permission. Bug: 1045154, 1045148 Change-Id: I0e5c554b92af68794c9a12e3f97fd2c5d368e8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024119 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#736254}
-
Rachel Sugrono authored
Add a public CommandHandler method to get a handler by name. Not used yet but required for Quick View to get hold of the delete handler. Bug: 803259 Change-Id: Iddca1284363d40de64629458b28a6d646636d859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026331Reviewed-by:
-
Yoichi Osato authored
ResourceRequestContainer is a wrapper class of ResourceRequest to keep the instance on heap since historycally ResourceRequest had been stated DISALLOW_NEW. However crrev.com/c/776407 has changed ResourceRequest to be newed. This CL refactors the structure simplify. Bug: 787704 Change-Id: I8cf85085d939e9053b84513bc0e23824991a98c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024392 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736252}
-
Koji Ishii authored
This patch matches text snap-to-pixel to the current behavior. Legacy and |NGPaintFragment| snaps the top of the padding box of the parent box. Before this patch, |NGFragmentItem| snaps the top of the content box. This makes different snapping behavior for fractional paddings. This patch adds |parent_offset| to compute the same snapping behavior, because |NGPaintFragment| has both the offset to parent and the offset to container block but |NGFragmentItem| only has the latter. Fixes ~12 tests. Note, the snapping behavior will need to be revisited. Bug: 982194 Change-Id: If2b52c3ae986d5ff06dc993016ad2eb0ff66de39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024133Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736251}
-
David Trainor authored
Remove the reference to the //chrome/android/java class GlobalDiscardabeReferencePool. Download home only needs the base class in //base, and we can pass in the global reference through the factory. Bug: 1046219 Change-Id: I18e084992ef82230d3d2f9ee40ce7460bd7d6480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024750 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736250}
-
matterchen authored
Port forwarding in Cros will allow users to add, activate, remove and deactivate ports. This CL includes the implementation of the remove and deactivate port utilities and unit tests. The tracking of the port forwarding preferences in the user's profile preferences has not been implemented yet. Bug: chromium:848127 Test: crostini_port_forwarder_unittest.cc and everything builds Change-Id: Ie7b5358813ca9cf454e0e216467c6d1ec8344c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015868Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#736249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e5460f07009..4d88bb065eda Created with: gclient setdep -r src-internal@4d88bb065eda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ieb5736b217a87dfe0da5b2b07e7049e98d955277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027001Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736248}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/74f5054ec925..7b6246a2ade8 git log 74f5054ec925..7b6246a2ade8 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 kainino@chromium.org Generators for Emscripten Created with: gclient setdep -r src/third_party/dawn@7b6246a2ade8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I29bd31538c448acd6565a5763348569bf8b227d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736247}
-
Rachel Sugrono authored
Add subroutines to compose the Delete command handler, so the it is easy for some special clients to access these subroutines, e.g. the QuickView dialog. Add an optional dialog argument to the deleteEntries_() subroutine. The default argument is null which shows the default delete confirm dialog, so no change in behavior. For Quick View, the delete confirm dialog is provided by Quick View when calling this helper. No change in behavior, no new tests. Bug: 803259 Change-Id: I4b2fe2d7cfd35a3c602bf7aa0b869b11a51bb691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026827Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e0a0cb9ad54..1fbc1b7f92be git log 2e0a0cb9ad54..1fbc1b7f92be --date=short --first-parent --format='%ad %ae %s' 2020-01-29 fancl@chromium.org Fix sheriff-config tests Created with: gclient setdep -r src/third_party/catapult@1fbc1b7f92be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Icce5d3cfad3bc69c4e81915b3acec850122f4034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027000Reviewed-by:
-
Luciano Pacheco authored
Set white background in the top level container and forces directory tree and file list to inherit it. Bug: 992821,992819 Change-Id: I610ec28fe06a092ada41ad268a18f3495d46b8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026552 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This CL adds the ability to sync in transport mode via SyncableServiceBasedModelTypeController. A follow-up CL converts SupervisedUserSyncModelTypeController to use transport mode. Bug: 1030454, 1043755 Change-Id: I6a49de5d8d5dd9c24422456fbdbc56683e64c002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016195 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#736243}
-
Abhijeet Kandalkar authored
This CL uses new downcast helpers for classes, - SVGInlineFlowBox - SVGRootInlineBox Bug: 891908 Change-Id: Ia211ffb55e77e299c333a8bfd2ed19c053d0536c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024987Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#736242}
-
Julie Jeongeun Kim authored
This CL changes ViewHostMsg_DocumentAvailableInMainFrame so that it is implemented in the LocalFrameHost interface and it moves DocumentAvailableInMainFrame() from RenderViewHostDelegate to RenderFrameHostDelegate. Bug: 1043758 Change-Id: I23d727cb39bf98b2b7412b92dc04d139fef3fa27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016762Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#736241}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a8fa19f0574..44c75073811b git log 4a8fa19f0574..44c75073811b --date=short --first-parent --format='%ad %ae %s' 2020-01-29 spang@chromium.org Fuchsia: Disable GLES3 testing on Fuchsia ARM 2020-01-29 syoussefi@chromium.org Vulkan: Fix handling of inactive fragment outputs 2020-01-29 spang@chromium.org Vulkan: Disable global merge for volk 2020-01-28 spang@chromium.org Fuchsia: Implement SystemInfo on Fuchsia 2020-01-28 ynovikov@chromium.org Disable 'nodiscard' warning on MSVC for dEQP. Created with: gclient setdep -r src/third_party/angle@44c75073811b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: Ie5e52fa26115c791aec39c2740dc72bc71a20da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026992Reviewed-by:
-
Khushal authored
If an image is greater than max texture size it can not be uploaded to the GPU and we keep a copy on the CPU instead for rasterization. While for GPU backed images adding mips requires re-allocating a new mipped texture, for these images it should be a no-op since its handled by skia internally. The existing code was erroneously trying to upload them. R=cblume@chromium.org Bug: 1046414 Change-Id: If88f76578dae99470991f7e4fb136107b94e23a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026227 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#736239}
-
Khushal authored
All workarounds have been removed, this removes the setup for applying these workarounds. This is the first step towards being able to assume SurfaceControl is turned on for all Q devices which will allow doing setup at app startup, before the native library is loaded and the GPU process is initialized. R=ericrk@chromium.org, vikassoni@chromium.org Bug: 1031636 Change-Id: Iecdfc335076089ba7887ba0d5111d4f70cf81c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015553 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736238}
-
Yutaka Hirano authored
Have Resource::CanReuse return false when the request method is not GET. This is harmless because currently all the preload requests and requests that can be served from the MemoryCache are GET requests, given that RawResources are not served from the MemoryCache. This change will allow us not to store the request body in Resource, which will be important when we introduce streaming upload because we do not want to copy a streaming request body. Bug: 688906 Change-Id: I5b1b01a6f003378f0ac33f528d209c610178fa29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024627Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#736237}
-
Hitoshi Yoshida authored
- Changes Create() and FillMember() argument types from v8::Object to v8::Value - Refactor make_fill_dict_members_def() - Replace v8_value->IsUndefinedOrNull() with v8_value->IsNullOrUndefined() Bug: 839389 Change-Id: Id2776176ae49e033c57bd0241981b60a1f2c0e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026908 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736236}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad9110026bee..dcc8c5431bcb git log ad9110026bee..dcc8c5431bcb --date=short --first-parent --format='%ad %ae %s' 2020-01-29 csmartdalton@google.com Convert the "bool antialias" param in GrTessellator to an enum 2020-01-29 egdaniel@google.com Store GrSurfaceProxyViews on SkSpecial*_Gpu. Created with: gclient setdep -r src/third_party/skia@dcc8c5431bcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ie3d186f938c5c91b0bbc899b4850076c4055e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026996Reviewed-by:
-
Hitoshi Yoshida authored
It is called from derived classes' FillMembersInternal. Bug: 839389 Change-Id: Icc214c548d8f02da13a594369c015043d4118593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026630Reviewed-by:
-
Jie Jiang authored
This change implements SendCachedDevices(), which should be called after Bluetooth service in Android starts, to make device cache synced between Chrome and Android. Here "cache devices" means devices that have been discovered (not necessarily paired or connected) but not yet expired. Some Android apps depend on this device cache, e.g., get info of paired devices. BUG=b:147401863 BUG=chromium:949918 TEST=Manually test with nRF: paired device can be seen in "BONDED" tab after reboot or restart Bluetooth. Change-Id: I80a813706770e9505b6b1db7a502739723e71f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000398 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736233}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8692a1901e0..1e5460f07009 Created with: gclient setdep -r src-internal@1e5460f07009 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034774,chromium:1044793 Tbr: jbudorick@google.com Change-Id: I76557832a9e4c4b21a39e5b3ff535b680fa02dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026998Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ad90d3c6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6cb70f31f7ed9b10d54402ce47cf35254399ee54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736231}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/821d564bc789..873d0470b40d git log 821d564bc789..873d0470b40d --date=short --first-parent --format='%ad %ae %s' 2020-01-29 kainino1@gmail.com Make a source_set for libshaderc_spvc (#976) Created with: gclient setdep -r src/third_party/shaderc/src@873d0470b40d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I2eb8ab67eacae0f4fa2e76ea9f6c42e3e218e48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026999Reviewed-by:
-
Eriko Kurimoto authored
This CL adds upgrade-indecure-requests web-platform-tests for module shared workers "sharedworker-module" is added to spec.src.json and it auto-generates tests. Bug: 824646 Change-Id: I3d75f4b7b1af93c12548331ad46e5f812205ea00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024249Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b6bf0b2546f3..5d3173be305d git log b6bf0b2546f3..5d3173be305d --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5146474c..fa85f826 (735951:736081) Created with: gclient setdep -r src/third_party/webrtc@5d3173be305d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8ef6f8a4feef338fd1764ebb6ef65f17d140316c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026927Reviewed-by:
-
Darren Shen authored
Extending by 3mths since we haven't launched the feature yet. Bug: 1043719 Change-Id: I28153a747b57918b73b13e4197fc7684beeaccd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023708 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#736227}
-
Alex Cooper authored
There are currently two separate implementations of the same code. Upcoming refactors to split the installation and consent flow logic from each other will make three implementations. Create a utils file so that the Android runtimes can share the implementation of this method. Fixed: 1046593 Change-Id: I55a20229f0150aea2f27df333245d31094cbee28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026651 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#736226}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I32c2947ce269b9bf83057cfe152b3794154b7147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026471Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736225}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e5e522c140a2..94294b48c239 git log e5e522c140a2..94294b48c239 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 tsepez@chromium.org Avoid including string_view_template.h directly. 2020-01-28 tsepez@chromium.org Remove CPDF_Dest::GetRemoteName(). 2020-01-28 thestig@chromium.org Change various CMap code to take a ByteStringView. Created with: gclient setdep -r src/third_party/pdfium@94294b48c239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3fdcbab40660e9deb754212d640c985e46fe3bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026410Reviewed-by:
-
Isabella Scalzi authored
Use |fakeMouseClick| instead of |simulateUiClick| and select the file to open the context menu on using |selectFile| rather than relying on right clicking. Also change |openQuickViewViaContextMenuCheckSelections| to use |fakeMouseClick| as well to see if |simulateUiClick| is the cause. Bug: 1038799 Change-Id: I7de92609e061b62bc351cfb4a5bef3eb0965a21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026548 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
sreejakshetty@chromium.org authored
Methods declared in content/public/common/navigation_policy.h |IsBackForwardCacheEnabled()|, |isProactivelySwapBrowsingInstanceEnabled()| are not used outside content/ are exposed in public. Moving these methods to content/common/ API to follow the policy: -> browser process only -> content/browser -> renderer process only -> content/renderer -> browser & renderer process -> content/common Change-Id: I42dd780646f7da832dba9067974ddbd9909fe1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019033 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736222}
-
yilkal authored
This CL prevents users from making multiple requests from the same tab for the same host address. The requests can be repeated by opening a new tab. The requests can be repeated in the next session. Bug: 1045155 Change-Id: If0a7549fe7509ff6ece8c1701e449294a85c56aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020543Reviewed-by:
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/2d483ad845f1..5ef4f21a9 $ git log 1dc01cf32..5ef4f21a9 --date=short --no-merges --format='%ad %ae %s' 2020-01-28 wub gfe-relnote: Introduce kDefaultUdpPacketControlBufferSize and use it in QuicPacketReader as the control buffer size. No behavior change, not protected. 2020-01-28 fayang gfe-relnote: In QUIC, remove largest_sent_packets_ from unacked_packet_map. This only affects QUIC versions with TLS handshake. Protected by disabled gfe2_reloadable_flag_quic_enable_version_t* flags. 2020-01-27 rch gfe-relnote: n/a - Remove the #if MMSG_MORE wrapper around kNumPacketsPerReadMmsgCall in quic_packet_reader.h 2020-01-27 vasilvv Remove quic_bbr2_sender. 2020-01-27 wub gfe-relnote: In QuicPacketReader, change the use of QuicSocketUtils to QuicUdpSocketApi. Protected by --gfe2_restart_flag_quic_remove_quic_socket_utils_from_packet_reader. 2020-01-27 dschinazi Update IETF QUIC to draft 25 2020-01-27 fayang gfe-relnote: In QUIC move NeuterUnencryptedPackets and NeuterHandshakePackets from quic_sent_packet_manager to unacked_packet_map. Refactoring only, no functional change expected, not protected. 2020-01-27 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_delete_send_rst_stream_inner 2020-01-27 renjietang Remove using_default_max_streams_ from QuicStreamIdManager because the manager now has initial stream limit 0. 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_version_negotiated_by_default_at_server 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_log_ack_aggregation_stats. 2020-01-27 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_exit_probe_bw_down_after_one_rtt. 2020-01-27 ianswett Deprecate gfe2_reloadable_flag_quic_use_common_stream_check 2020-01-26 bnc Buffer priority values in PRIORITY_UPDATE frames for not yet open streams. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I33f398b4add6b8c7fa86b08396cf4fb893ed41ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025569Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#736220}
-
Jie Jiang authored
Android use ReadRemoteRssi() to get the RSSI value for a connection. Currently we are using GetInquiryRSSI(), which cannot get the correct RSSI value for a connected device, and makes some Android apps unhappy. This change uses GetConnectionInfo() instead. BUG=b:147787450 TEST=Manually test with nRF and Fitbit. nRF can read RSSI value correctly; Firmware update of Fitbit works well now. Change-Id: I0dc13f58f430954772551165009d5ea7f26445c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004429 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
-
Gabriel Charette authored
TBR=fdoray@chromium.org Bug: 1026641 Change-Id: Id22f4e3e66ce2127e4cec8a9ceddcf63c107abbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026311Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#736218}
-
