- 21 Dec, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
Bug: 1156847 Change-Id: Ie15241942f1a22666ad2e9cf3a12927a8d18fc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597401Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#838665}
-
Robbie Gibson authored
When tapping Done on recent tabs, the tab grid shows a tab in the activePage, without changing the actual tab grid. However, when the tab grid is opened again, the tab grid still shows recent tabs. To fix this, this CL has the tab grid scroll without animation to the active page when the tab grid starts to appear. This also handles opening the tab grid after "Open in new incognito tab." The issue there was that before, the tab grid's active page was being set by the SceneController in -showTabSwitcher. However, when using the thumb strip, this method is not called. I swapped the data flow around where the tab grid now requests the page from the SceneController (via delegation) when it is about to open in the thumb strip. Fixed: 1155612 Change-Id: I791f7c0ca7fa7ada66241ab55411ac4daeb5c281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595051 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838664}
-
Thomas Lukaszewicz authored
This CL applies layer masking to fix layer hover effects of the manage extensions button clipping outside the bubble's bounds. Before: https://drive.google.com/file/d/1cmuKp4R_nVc7eAaljtIbFX2g0nwlIzKT/view?usp=sharing After: https://drive.google.com/file/d/1oa0lyapwxIGwtCpbxc61bJdPD03gfdVC/view?usp=sharing Bug: None Change-Id: Ieda2cbe46e554208e7cc2282f5b76468f36eff04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597959Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#838663}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012210600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/ArjDoksx4veFQalheiqMNhRYccNS84igngDuMSvLD-0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/175249082 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib8a592ba05a2fc900cae0ed4a759d6a158eda654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838662}
-
Sylvain Defresne authored
The shutdown of the application was failing with UAF during the destruction of ApplicationBreadcrumbsLogger because it tried to record a "Shutdown" event which was forwarded to all observers by BreadcrumbManager. The UAF was caused by BreadcrumbPersistentStorageManager that was owned by ApplicationContextImpl but registered as an observer by ApplicationBreadcrumbsLogger. As ApplicationBreadcrumbsLogger is destroyed after BreadcrumbPersistentStorageManager, thus the observer was only removed after the object was deleted. This UAF is fixed by moving the ownership of the instance of BreadcrumbPersistentStorageManager to ApplicationBreadcrumbsLogger. Fixing this revealed another issue regarding ordering of the events as BreadcrumbPersistentStorageManager uses a TaskRunner to persist the events. The TaskRunner are invalidated when WebMainLoop is destroyed which happens before ApplicationContextImpl destruction. To fix this, it is necessary to destroy ApplicationBreadcrumbsLogger before the thread pool is destroyed, thus in StartTearDown(). Bug: 1160669 Change-Id: I7957d0b15535e1ea9afe93e42791d680e1f3e153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599798 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#838661}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4122e6dd4796..00e1aac922ec 2020-12-21 mathias@chromium.org Support forcing the CSS :target state 2020-12-21 morlovich@chromium.org Emulation custom UA-Ch editor: fix some vertical alignment 2020-12-21 wolfi@chromium.org [FrameTree] Persist selection of top frame across reloads 2020-12-21 petermarshall@chromium.org Remove refresh button disabling in IndexedDB view 2020-12-21 bmeurer@chromium.org [debugger] Don't display stale information in the Scope view. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156519,chromium:1156628,chromium:1160227 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9af7f11d960be1a3d2e86f0b0faec94aa6497aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838660}
-
Sam Maier authored
This reverts commit 0de6ec1b. Reason for reland: Original change's description: > Revert "GMSCore API availability function for specific versions" > > This reverts commit 6a6c700a. > > Reason for revert: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8860631130980203728/+/steps/compile__with_patch_/0/stdout > > Original change's description: > > GMSCore API availability function for specific versions > > > > Change-Id: Ie431852d225659e8b24bfec9c09d7c043924660f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595929 > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Reviewed-by: David Van Cleve <davidvc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#838236} > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > Change-Id: Iac1a894b3d3adaa58c0fcfefd407cd8db82b3e56 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597817 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838253} TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org # Not skipping CQ checks because this is a reland. Change-Id: I5f677795de16199bf54804a60e8460ae160af4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597818Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#838659}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef9c4e07a351..1e98f9539164 2020-12-21 philipp.hancke@googlemail.com sdp: remove some unused x-google attributes 2020-12-21 nisse@webrtc.org Delete unneeded dependencies on the Module abstraction 2020-12-21 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2020-12-21T04:04:21). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:943975 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I824fc077c493cb8da0f9455467530413543d1cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599626Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/7bdf386e758c..0d5f1dd37c05 2020-12-19 ishitatsuyuki@gmail.com [autofit] Fix double division in stem darkening. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I20142c02959452d0f0ae0854053ded9c541217ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598818Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#838657}
-
kylechar authored
Add a feature to control if GpuVsync is enabled or not, in addition to the --disable-gpu-vsync flag. The feature is on by default so this should be a no-op change. This is intended to be used in a finch trial to see what the impact of disabling GPU vsync is after the feature freeze is over. Bug: 43611 Change-Id: I09715832b48e5ba9fe11e04404ed68fb441a5dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597637Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#838656}
-
Pavol Marko authored
When 'raw' signing (of pre-hashed data) is performed, report a designated error code when the input data is too long. Also add browser tests for 'raw' signing and clarify some docs. Bug: 1158363 Change-Id: Ica61543985068e57752060e95b1d28f4765bbfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595282 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#838655}
-
Andrew Grieve authored
Change-Id: I4c11e4c1dfa40c2294cccb98fff515fbd727526c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598629 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL adds a call to show the customization bubble at the end of the profile creation flow. Additionally, the CL adds logic for: - ThemeSyncableService to notify an observer about theme sync being completed; - ProfileCustomizationBubbleSyncController to delay showing the bubble until theme sync is completed (or until Chrome figures out theme sync will not complete any time soon). Bug: 1126913 Change-Id: I521d85c987dc2b78ad74b1239f645732e4e631e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587166 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#838653}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012210600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/JzkQbgu707ehmRMJSwGBX0gMotKpUKiewC8zdP_xHngC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/173338056,b/175635280,b/176052944 Tbr: media-app@grotations.appspotmail.com Change-Id: Iddf9c82f499763dae64167bfd59d65797cab9455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599819Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a96e7d90. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I512377ed64380c7406df30728ad70e49591aa827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595743Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838651}
-
Viktor Semeniuk authored
This change uses AddCompromisedCredentialsSync to add compromised credentials when the form is missing in the local password store. Bug: 1137775 Change-Id: Iaa569a714390fe1b58450119e3b41641b659fb91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586357Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#838650}
-
Pavol Marko authored
Support server-side hashing of the CertificationRequestInfo by not performing a hash client-side, just a signature. This is implemented in the protocol as StartCsrResponse.hashing_algorithm = HashingAlgorithm.NO_HASH Bug: 1158363 Change-Id: Id79302e3558e18bdbf8c1ceb61c6f059c6f74c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588934Reviewed-by:
-
Andrew Grieve authored
We don't record this in the spreadsheet. Bug: None Change-Id: I606338deb26037842f77b9a171f6a5183a7b1d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595843 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
David Roger authored
Shutdown() resets the delegate, and as a consequence, calling StartReconcile() after Shutdown() can trigger the: CHECK(delegate_); Fixed: 923094 Change-Id: I6d8acf40618f3341b1664fe9f9f028af9468076e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595534 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#838647}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cde5182f7aa4..4122e6dd4796 2020-12-21 petermarshall@chromium.org Fix link highlight 2020-12-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icd0e040c5541868ed893bc9c93943f8db2b450ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599816Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d23e521cc40..c65f224a7259 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If22d5329500b603a8fee145f37a8cd498e632bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598471Reviewed-by:
-
Rushan Suleymanov authored
The device info bridge should wait for all related data loaded before starting syncing. Otherwise the DeviceInfoSpecifics with some empty fields would be sent to the server on each browser startup. Bug: 1155030 Change-Id: I9ee4d5b2a1bb75c655b3ac183fc4c63fb1a19fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567922 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#838644}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d23e521cc40..c65f224a7259 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iea15e08cfe8be7559c2aff229ae350f5dcd5c07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599398Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608529993-82d6d40e289e60063d3bd5c2eebe97dc9bb53838.profdata to chrome-mac-master-1608551422-fc95b9f468d4d803d74a281f45985087ff3374a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I542a73c729ea580dbaf5fe10c574045917da8cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599624Reviewed-by:
-
Finnur Thorarinsson authored
This reverts commit b8af3c0a. Reason for revert: Consistent failure on MemorySanitizer: use-of-uninitialized-value. Example: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21799 Original change's description: > Oobe: Fix issue with metrics client id reset after sign in > > Issue is due to there's a small time difference between StatsReportingController::SetWithService and pref is properly set. We should only propagate the value from service until it is correctly set. > > Bug: 1154947 > Change-Id: I977249dd25e1402246b383401c9deef4ea8ebc56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587065 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#838606} TBR=stevenjb@chromium.org,rsorokin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yunkez@google.com Change-Id: I128949522d5c3cfd6ddbaf9f769034544af4bd62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599535Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d034512dc4d9..cde5182f7aa4 2020-12-21 bmeurer@chromium.org Update Emscripten dependency to 2.0.11 2020-12-21 alcastano@google.com Make Issue Message in Source Tab link to Issues tab 2020-12-21 wolfi@chromium.org Make toolbar dropdowns optionally shrinkable 2020-12-21 janscheffler@chromium.org [Recorder] Wait for elements 2020-12-21 szuend@chromium.org [issues] Migrate SameSite issues to markdown 1/* If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1125465,chromium:1150883,chromium:1153134 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iafe3cd2964bbd1f521a3d43a983b2895a4e049e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596647Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ddf384d1fb4..3974e6736435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC finnur@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: finnur@google.com Change-Id: I0e9cb1f8eabf5d302091d51ab53ab1762bed23a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598025Reviewed-by:
-
Henrik Boström authored
The SampleBufferTransformer CHECK-crashes if a sample buffer does not have a pixel buffer AND is not MJPEG. But the assumption that non-pixel buffer sample buffers most by MJPEG turns out not to hold, with the following consequences: In M89, this causes a CHECK-crash. In M88, this causes a DCHECK-crash, which in official builds means we don't crash but rather we most likely fail to decode the buffer and return null frames. This is believed to cause "no video" issues. This CL adds the workaround not to use the SampleBufferTransformer if "sampleBufferLacksPixelBufferAndIsNotMjpeg" is true. So in this edge case we fall back on the same code path that we run in M87 today. TBR=handellm@google.com Bug: chromium:1160647, chromium:1160315 Change-Id: I782a36cf38f5ce96a5010966c8b07aedf1b08efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599531Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#838638}
-
Finnur Thorarinsson authored
This reverts commit 9d0120f3. Reason for revert: Very close to 100% failure rate since check-in, on bot "WebKit Linux Leak": https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/21884 Error message: Retrying 19 unexpected failures, attempt 1 of 3... Sharding tests ... Starting 8 workers ... [18/19] external/wpt/css/selectors/focus-visible-006.html failed unexpectedly (leak detected: ({"numberOfLiveContextLifecycleStateObservers":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,40],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,5]})) stopping content_shell(pid 14917) timed out, killing it [19/19] external/wpt/referrer-policy/gen/worker-classic.http-rp/strict-origin-when-cross-origin/worker-classic.http.html failed unexpectedly (test timed out) Original change's description: > Simulate user inputs in focus-visible tests in css/selectors/ > > Use testdriver Action API to simulate mouse actions in > css/selectors/focus-visible-006.html and > css/selectors/focus-visible-008.html. > > Bug: 1145677 > Change-Id: Id25c6120f1dbd489d4c803ee979e67ad5ef49f8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551818 > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838271} TBR=lanwei@chromium.org,mustaq@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145677 Change-Id: Ie2e39aa960a80dd0ab5b9ec881ae9305c4294760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599530Reviewed-by:
-
Viktor Semeniuk authored
This change adds function to add compromised credentials. Later it will be used sync compromised credentials. Bug: 1137775 Change-Id: I44732583482ad5bf9e2a2bb1f85c907914c86352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580529 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
Jérôme Lebel authored
This reverts commit f061483a. Reason for revert: go/async-identityservice-api-issue Original change's description: > [iOS]Adding WaitUntilCacheIsPopulated calls to populate the identity cache > > Adding WaitUntilCacheIsPopulated() before calls: > * ChromeIdentityService::GetIdentityWithGaiaID() > * ChromeIdentityService::HasIdentities() > * ChromeIdentityService::GetAllIdentities() > * ChromeIdentityService::GetAllIdentitiesSortedForDisplay() > * AuthenticationService::GetAuthenticatedIdentity() > * AuthenticationService::IsAuthenticated() > > This patch also adds the following method as an helper: > AuthenticationService::WaitUntilCacheIsPopulated() > > This method should be temporary, and should be replace by > ChromeIdentityService::RunAfterCacheIsPopulated() (or a > AuthenticationService version). > > Design doc: > http://go/async-identityservice-api > > crrev.com/c/2489915 Adding methods in ChromeIdentityService > crrev.com/i/3353161 Implementing in ChromeIdentityServiceImpl > crrev.com/c/2490110 Adding metrics > crrev.com/i/3353162 Implementing the metrics > => crrev.com/c/2490010 Adding WaitUntilCacheIsPopulated calls > crrev.com/i/3354983 Adding DCHECK for cache state > > Bug: 897470 > Change-Id: Iced6e7e50d704091abfe7d5b705157fe71c50ac0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490010 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825492} TBR=sdefresne@chromium.org,jlebel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897470 Change-Id: I0f0d87fcca171c3d5f730f86805b89d22268deec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593615Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#838635}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/22dd28af0ab7..d034512dc4d9 2020-12-21 jacktfranklin@chromium.org Component docs can load test helpers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idb290a0c4efe64328ed9f276dde1d0c787f56d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599047Reviewed-by:
-
Pavol Marko authored
Move raw RSAPKCS1 signing code to its own function instead of an if-else in SignRSAOnWorkerThread. This should improve readability and unclutter the functions as special error handling for too long inputs will be added in a follow-up CL. Bug: 1158363 Change-Id: Id525119753f2d179e25846683778b42ee84253b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595422Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ed9213bca064..4ebcee3eb02f 2020-12-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from af73f1e9 to 4545fb53 (180 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I97950460c51ec538dce4194d8ad3477c4a264fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599696Reviewed-by:
-
Fredrik Söderqvist authored
This moves the resolution of an image's "computed orientation" to LayoutImageResource where have sufficient context information to determine it. This avoids having user of LayoutImageResource have to dig out and know things about the internal implementation and contents of said class. Change-Id: I1dbe62218d980be23344ad50f79435be41471ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596346Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#838631}
-
Henrique Ferreiro authored
This is a follow-up to https://crrev.com/c/2523334 where the last user of the WebCursor traits was ported to ui::Cursor. Bug: 1028080 Change-Id: Ie6ada4e408392177260de6dcd83dc43b467a62ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353252Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#838630}
-
Eugene Zemtsov authored
This flag doesn't appear to be affecting anything, it certainly doesn't stop OpenH264 from being used in media or RTC. All it does is control whether OpenH264 is included into artificial testonly target "gn_all". Its value is false by default, and nobody seems to set it to true. Bug: 1158845 Change-Id: I27bdf215743d81aa65b643e1d3340345e7e56910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599111Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sergey Silkin <ssilkin@google.com> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#838629}
-
Alice Wang authored
This CL makes the subtitle texts of web sign-in bottom sheet focusable in talkback mode. Video demo: crbug.com/1159940#c1 Bug: 1159940 Change-Id: I571faecd0f26500a2c9a39336767bf8071926118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595739Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838628}
-
David Jean authored
Bug: 1140990 Change-Id: I1ed3c06836d5dcedb40f8f9dde6c60f6ecffc671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594908 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#838627}
-
Yao Xiao authored
What: Introduce the kFlocIdFinchConfigVersion feature param. On browser start, invalidate floc and trigger an immediate recompute if the version mismatches with the one when computing the last floc. Why: This allows us to configure an immediate recompute when we feel it's necessary. How: - Add the finch_config_version to FlocId, that allows it to be saved to prefs at each computation along with other fields. On browser start, check for version mismatch and handle it accordingly. - In the InterestCohort string, this version replaces the position of the previous constant kChromeFlocIdVersion. We expect most params to go through finch in the near future so replacing the "chrome floc version" part for now. - Also move the compute_time to FlocId, as it's also logically fit there, and we can keep the load/save function to one place. - Move the floc features to //components as now the it's being checked by the components. Bug: 1159235 Change-Id: I0c80ed35ac5f181b18b860eb2f1a73acf6fd1432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595595Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
