- 26 Feb, 2020 40 commits
-
-
zhaoyangli authored
- Modified comments for |-ensureAppLaunchedWithConfiguration:| method of |AppLaunchManager| reminding users to choose suitable place to call this method for better efficiency. - Changed default value of |RelaunchPolicy| in |AppLaunchConfiguration| to |NoForceRelaunchAndResetState| which is more commonly used when user relaunches the app for different enabled features. Bug: 1009017 Change-Id: I523304d387d5f873a33cc0b72023d9eafe6e7c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073137Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#744820}
-
dpapad authored
This regressed in r744505 but apparently no test caught it, since they only run on official bots. Bug: 1026426 Change-Id: I22c44643527cde8cb618f1507974badf03d81cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075900 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744819}
-
Tom Anderson authored
BUG=914974 R=pkasting Change-Id: Ia017ddb1cb1314bea83c29b5dd9a313cf60e717b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076098 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#744818}
-
John Budorick authored
Should be a no-op when running against a single attached device, but should facilitate the upcoming multi-instance emulator case. Bug: 922145 Change-Id: I6ef32a592155d0ff248033f7c2d7bf3d531e113e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075047Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#744817}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ec13300cd6d..6422722cbaf6 git log 8ec13300cd6d..6422722cbaf6 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 bsalomon@google.com Reland "Remove GrDeviceSpaceTextureDecalFragmentProcessor." Created with: gclient setdep -r src/third_party/skia@6422722cbaf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I3379a6a3ded0ea03b8447f2300eab90cc7709940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744816}
-
Esmael El-Moslimany authored
The "dir" attribute for <html> is not being respected when the browser is using an RTL language. Bug: 1049541 Change-Id: I6530cba90b05a18be277937644c6188237b813dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042433Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#744815}
-
Toni Barzic authored
BUG=1008963 Change-Id: I1f40729b3338c12360be783c300bca3ac5c7d7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069438 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744814}
-
Michael Spang authored
This reverts commit 334077c8. Reason for revert: Breaks vulkan on fuchsia, see http://crbug.com/1056089 Original change's description: > Vulkan: support Android devices without Android hardware buffer > > Some Android P devices don't support vulkan extension > VK_ANDROID_external_memory_android_hardware_buffer. For those devices, > chrome will fallback to ExternalVkImageBacking which uses > VK_KHR_external_memory_fd extension or pixel copy for GL and Vulkan > inerop. > > Bug: 1049864 > Change-Id: I101a4c83a2dbfcfdbade29084a863e7563f631e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067290 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743931} TBR=penghuang@chromium.org,spang@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049864 Change-Id: Id57d5f42b65239d9e80ccfda8f373b0441f9a8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075050Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744813}
-
Nohemi Fernandez authored
SceneController calls AddAccountCoordinator from an ApplicationCommand. A user that directly triggers this command, for example by adding an account through accounts.google.com/addsession, will crash the app. Bug: 1054861 Change-Id: Id589d69fc3bd4332e9db827e814f52b62902da16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074504 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744812}
-
Gauthier Ambard authored
This enables the flag by default on Canary. The idea is to ship it to 100%, with a kill switch by Finch. Bug: 1038034 Change-Id: I0ea6097bd844db1940eff683d99d555f1654189d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062979 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744811}
-
Jeff Yoon authored
We don't guarantee that xcode installed and set before we use otool, so we want to ensure that it's installed first. This CL pulls this out of the constructor and into run.py, such that we don't need to pass xcode_build_version, xcode_path and mac_toolchain into the constructor of every single runner class. Change-Id: Id8f315645c22c07448ad6d0211511bc83a9af46e Bug: 1055330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044305 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#744810}
-
Mehran Mahmoudi authored
This employs post_task.h to make some operations in PlayerCompositorDelegate asynchronous. It also fixes an issue in CreateFileMapFromProto where an invalid file path resulted in an unexpected behaviour. Bug: 1034111 Change-Id: I2f29845766bd7bc339255b93845346ca41eff2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075957Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744809}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibe4b7b97204524b503871a75d1d2c5f30ff4cf3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075778 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Andrew Grieve authored
Change-Id: I457dd7e9cc616038b50122e1fc12266ca24df92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075037 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#744807}
-
Devlin Cronin authored
ExtensionInstallPrompt started out life as a prompt to install an extension, but has since grown into a franken-prompt used for many different pieces of extension functionality. This leads to technical debt and complexity, hard-to-reason about code, excessive redirection, etc, and a number of bugs have been filed about trying to simplify it (e.g. crbug.com/567839). Add a comment in ExtensionInstallPrompt discouraging the addition of any new types that don't actually prompt to install an extension. New code that needs a dialog should implement a new dialog, rather than piggy- backing on this class. Bug: None Change-Id: I00476b3d4cda8efbbe2b7cf4ae3c39935f004402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075083Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744806}
-
Parastoo Geranmayeh authored
flaky test. TBR="xiyuan@chromium.org, tbarzic@chromium.org" Bug: 1056302 Change-Id: I65cbd1acadb5e68e3394f7cfeb7fa491f8c0abf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076377Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#744805}
-
Kramer Ge authored
The purpose is to indicate where (0,0) is in an output surface. Originally boolean value flipped_output_surface was not descriptive. This CL adds SurfaceOrigin components/viz. Because GLSurface exposes FlipsVertically() this enum is expected to move to ui/gfx Bug: 1051970 Change-Id: I8ba63ea08c4bb6d0b8faf1a49c3d2e417f7c6ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067350 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744804}
-
Sammie Quon authored
The back gesture will now have special behaviour for ARC apps. The first swipe will animate in the shelf and hotseat, and the second swipe will send a back event. I changed the container the back affordance is in because: 1) AlwaysOnTop container is watched by the workspace, which means adding/removing/hiding/etc the affordance window will trigger backdrop/shelf/etc updates. 2) AlwaysOnTop container is underneath the shelf container, which would make it tricky the part with the second swipe without the shelf pre event handler eating the event and hiding the shelf. 3) AlwaysOnTop container is still underneath a lot of things. I spoke with Ben and he seems to want sometime that is even above the power menu button. I think maybe we'll have our own GesturesContainer but for now the OverlayContainer (autoclick, laser) should work fine. The affordance was also creating a renderpass at the end which I removed. It was small, but should help out with the large minimize animation that commonly follows. Test: manual Bug: 1031268 Change-Id: I4f3be651604ac91cf0d2a07a24aa0f51efd44023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073199Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#744803}
-
Mustaq Ahmed authored
A past fix for activation propagation from an extension button to extension script seems to have added additional user activation propagation path from tab-strip to all installed extensions: https://chromiumcodereview.appspot.com/10821120/ This crack caused every tab-switching to activate /all/ installed extensions, which seems bad. Because of this, we encountered a security issue with unintended top frame navigation from an iframe. (Luckily only tab switching was affected, not tab clicking.) A user interaction with the tab-strip is different from an interaction with extension buttons. Tab-strip interactions are similar to those on any browser-provided UI element like top menu: they don't at all indicate the user's intention to interact with any extension or website. Therefore, like clicks on top-menu and unlike clicks on extension buttons, tab-switching should suppress activating any background script thus prevent access to use user-activation gated APIs like popup, fullscreen, navigation, etc. Bug: 957633, 1035315 Change-Id: I8d56e02a3a2966521b7bbc4f4efadf67e1acc371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072654Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744802}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3621dca1542..4d40271e3f09 git log e3621dca1542..4d40271e3f09 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 amaiorano@google.com Subzero: add support for large stacks on Windows Created with: gclient setdep -r src/third_party/swiftshader@4d40271e3f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0261aea1960262f4018b31fb43eddf4341fa58fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075445Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1054935 Change-Id: I2da8e4c8240647614728c21e351a6b2e940aaae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074882Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL fixes the VaapiVideoDecodeAccelerator to advertise the visible size as the coded size for decoded video frames. Here's the background: CL:2011583 changed the VA-API decoding pipeline so that the EGLImage backing a VideoFrame's service-side texture is created using the visible size instead of the coded size. This is correct because the graphics API does not care about the non-visible area. This was done to avoid a green line error: making the size of the EGLImage equal to the visible size allows the texture sampler to not sample beyond the visible area, so the green line (part of the non-visible area) is avoided. The problem is that the coded size of the VideoFrame sent to the client still contained the non-visible area. This is arguably strange because as far as the client is concerned, this non-visible area does not exist. This was also causing problems when PaintCanvasVideoRenderer requested a copy from the VideoFrame's texture: the coded size was bigger than the visible size used to create the EGLImage. This caused black images to be displayed some times (e.g., thumbnails of videos in the Camera Capture App) because the GL commands sent from the client didn't pass validation in the service side (e.g., "GL ERROR :GL_INVALID_VALUE : glCopySubTextureCHROMIUM: source texture bad dimensions"). This CL changes VaapiVideoDecodeAccelerator so that the coded size of the VideoFrame only includes visible data. Additionally, it is possible for a decoded frame to end up as an overlay plane. In that case, the size of the DRM framebuffer should match the visible area of the frame. This is important so that the non-visible area doesn't appear in the overlay path. Therefore, this CL plumbs the desired framebuffer size all the way through Ozone. There is a caveat, however: there is an unusual corner case where an H.264 video includes information about a visible rectangle whose origin is not at (0, 0). Therefore some of the top and left parts of the video should not be displayed. However, Chrome does not currently deal well with this case, and this CL doesn't change that (i.e., those non-visible areas are still displayed). Note: follow-up CLs will deal with V4L2 and the VideoDecoder interface variations. Bug: 1045597 Test: Record video in nocturne's CCA and inspect thumbnail. Change-Id: I7076b66bfa7cb2284f6a5431968e98053f9b8103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056285 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#744799}
-
Mohamed Heikal authored
Change-Id: I654b012aa61ba9c782c22e2a8fe2ade32186a7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076100 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#744798}
-
James Cook authored
I missed a couple of references to identity service code when I migrated the assistant to the in-process IdentityManager. Original migration CL: https://chromium-review.googlesource.com/c/chromium/src/+/2033572 Bug: none Change-Id: Ic9226edf99e08657cdae6c4fd58cd4fd64abf933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071048Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#744797}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8995c0468a44..9bda3eea9509 git log 8995c0468a44..9bda3eea9509 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 rsavitski@google.com Merge "traced_perf: bump fd timeout and add more cts logging" Created with: gclient setdep -r src/third_party/perfetto@9bda3eea9509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie2e28bd8ae02712223d16b32a6d9d52fce1a906b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075447Reviewed-by:
-
Stefan Zager authored
The root cause of the linked bug is that IntersectionObserverController continues to track an observer after the observer's root element is deleted. This CL tightens up the conditions for which objects are tracked: - Explicit root observers with observations, if the root is connected - Implicit root observations, if the target is connected BUG=1046897 R=vmpstr@chromium.org Change-Id: Ib98a0dd3c948e61200cd270011cfe18b8776d7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068860Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#744795}
-
Xiao Yang authored
1. Added null check for submenu Host in RenderViewContextMenuViews:: Show() to avoid crash. Bug: 1054962 Change-Id: Iff52355a89c64038dd3f7828a638b804563d4ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070960Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Xiao Yang <yanxiao@google.com> Cr-Commit-Position: refs/heads/master@{#744794}
-
Evan Stade authored
The flake seems to occur when the touch is handled by selecting text on the page, so switch to a page that doesn't have text in the way of the touch. This also puts a timeout on each CountDownLatch since an unbounded await() leads to very unhelpful (i.e. non-existent) error output. Bug: 1052802 Change-Id: I44393c4a821413e626eb3a5ef4c2e16609022040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074812 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744793}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py 61f538d37b80eb589f8990f0b4513d702704ea38`. Bug: 1051578 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ibc750b521a92fe46f5298983d384f0f9670159b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074698Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#744792}
-
Shawn Gallea authored
This is needed for CastContentWindow to receive backgesture support notifications Merge-With: eureka-internal/367600 Bug: Internal b/149740737 Test: Build cast_shell Change-Id: Iacde9b0687106b1093572fa0b2f8339a2d7b5bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071015Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Ryan Daum <rdaum@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#744791}
-
Andrew Luo authored
Change-Id: I5d81e5569a061d0e4609449c49835e61a810bae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073120 Auto-Submit: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744790}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f9fdd5a2a7e..97edc4e61387 Created with: gclient setdep -r src-internal@97edc4e61387 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I98bd4cad411ad05182b07b596f1a2474b4993a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744789}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b9b4569b9b76..8aea6d5a87b8 git log b9b4569b9b76..8aea6d5a87b8 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 b.schade@samsung.com glslang: enforce initialize and release as once per process Created with: gclient setdep -r src/third_party/angle@8aea6d5a87b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I41d3e754757fe0eb61596d72247b1fe8eac3b97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075444Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/68e2a460..f8918f99 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I27224878ba8ac5ac61192513e613c062b21c77d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075638Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744787}
-
Andrey Kosyakov authored
Also, disable glib explicitly for headless. Change-Id: I10c4d46e623b9a5b563067e51ba9daf1646369a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075084Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#744786}
-
Sean Gilhuly authored
The new Dawn swapchain API is not implemented yet. Use the old swapchain path by passing a null wgpu::Surface to CreateSwapChain(). The bug for implementing the new API is https://crbug.com/dawn/269. Bug: 1021566 Change-Id: I76306856cca919a4e2ef131087163204f41f91ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075458Reviewed-by:
-
Will Harris authored
This is a reland of a8a9ff46 Only change from original CL is to remove the macOS sandbox changes. Original change's description: > Run v8 in proxy resolver in jitless mode. > > This allows MITIGATION_DYNAMIC_CODE_DISABLE to be enabled for the > process on Windows, and moves PAC resolver from the Renderer helper > variant to the Default helper variant on macOS. > > BUG=961831,961592 > > Change-Id: I90f9dc69fa5ebf43f71b0395d7d2217fc24181b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051153 > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741531} Bug: 961831, 961592, 1052853 Change-Id: I847f3987ca2c21cd4999bd9c226261223ef045d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064588Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744784}
-
Peng Huang authored
Bug: None Change-Id: Id4ef48633b81f575ff0fb863bbc34fdd929be880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075048Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744783}
-
Etienne Bergeron authored
This CL is fixing a source of flakiness we observed acrross different computer. The gfx_unittests are using SetGlyphWidth to avoid relying on the underlying font information for testing some API. Unfortunately, we often ovserved inconsistency accross different platform and blocked many CL on incorrect behavior based on the following bug: Within the ShapeRunWithFont(...) code, the x_offset may not be 0 even if the glyph size is zero. It can also be negative for some fonts. Looking to the failing bot, we got these values: Font: ".SF NS Text" Offset: is -0.0952148 Glyph: 1216 To fix the issue, we proposed to keep the x_offset to zero when a glyph_size is used. This only affects tests, otherwise no functionnal change. Bug: 1056220 Change-Id: I486722a5e64c1e4ee85aa373343a19c1a1ac1331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075079Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c310889ec791..9731a14ff8ec git log c310889ec791..9731a14ff8ec --date=short --first-parent --format='%ad %ae %s' 2020-02-26 brandtr@webrtc.org Improve logging for UpdateActiveSimulcastLayers. 2020-02-26 mirtad@webrtc.org Report available instead of encoding bitrate to VideoEncoderSelector. 2020-02-26 phoglund@webrtc.org Whitespace change to kick bots. 2020-02-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 159524df..0bba1cec (744393:744590) Created with: gclient setdep -r src/third_party/webrtc@9731a14ff8ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I061653cdaa571acf086f694f20ccece83b954e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075439Reviewed-by:
-
