GitLab

Bytes were being converted to kilobytes without a division.

BUG=707022

Review-Url: https://codereview.chromium.org/2914903002
Cr-Commit-Position: refs/heads/master@{#476241}

Firefox and Safari already shipped it.
This CL fixes 256 failing tests in external/wpt/.

Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0P4_WvNr1xY

Bug: 724906
Change-Id: Ic55ead1509afd3e631ed0251fa312bd5b4a7001f
Reviewed-on: https://chromium-review.googlesource.com/521002Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476240}

Use PolicyData::management_mode to determine whether the device has a
local owner and only fall back to DM token in case management_mode is
unset.  That way, the correct determination is guaranteed for both
cloud and Active Directory management.  (Currently, the code is not
broken because AD policy doesn't include a user name, but that might
change in the future.)

Also update the PolicyData::management_mode documentation to include
Active Directory.

BUG=722799

Review-Url: https://codereview.chromium.org/2902183002
Cr-Commit-Position: refs/heads/master@{#476239}

BUG=712963

Review-Url: https://codereview.chromium.org/2919593004
Cr-Commit-Position: refs/heads/master@{#476238}

Bug: 710184
Change-Id: I3d1d506888657c5bd60a114609247c5f92c0edd7
Reviewed-on: https://chromium-review.googlesource.com/520443
Commit-Queue: Dominic Cooney <dominicc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476237}

Replace the raw ptr returned by ContentSettingsPattern::CreateBuilder
with a unique_ptr.
Remove legacy_validate parameter and function because it isn't used
anywhere.

BUG=
TBR=msarda@chromium.org,finnur@chromium.org,stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2909273003
Cr-Commit-Position: refs/heads/master@{#476236}

Defer deleting view after calling OnAllNotificationsCleared(). Views are deleted before OnAllNotificationsCleared(), but it causes crash. This CL moves the deletion as a temporary solution. We need to refactor the code around more in near feature.

BUG=725299
TEST=none

Review-Url: https://codereview.chromium.org/2913993002
Cr-Commit-Position: refs/heads/master@{#476235}

This CL introduces CalcSelectionPaintRange() and minimize Commit().

BUG=708453

Review-Url: https://codereview.chromium.org/2916803003
Cr-Commit-Position: refs/heads/master@{#476234}

The users of WebNode::AccessiblityObject should all be outside of core/

Bug: 71532
Change-Id: I5ff7e8bb28657408394a529ac8fe77e400d26472
Reviewed-on: https://chromium-review.googlesource.com/520542
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476233}

BUG=728086

Change-Id: Ib15f1714abb30b029b6e89facb51343fbfaa96e3
Reviewed-on: https://chromium-review.googlesource.com/519247Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476232}

static attributes must not be "keep_alive_gc".  keep_alive_gc
is a mechanism to associate a returned object with the receiver
object, however static attributes must not use the receiver
object.

BUG=

Review-Url: https://codereview.chromium.org/2913403003
Cr-Commit-Position: refs/heads/master@{#476231}

This CL aims to drop the context menu feature entirely.
<menuitem> tag can be no longer used and <menu type='context'>, <menu label='...'> are no longer supported.

BUG=87553

Review-Url: https://codereview.chromium.org/2905763003
Cr-Commit-Position: refs/heads/master@{#476230}

This CL changes the operator returning appropriate string.

This is homework from:
[Make SelectionState enum class]
https://codereview.chromium.org/2916493002/

BUG=

Review-Url: https://codereview.chromium.org/2919713002
Cr-Commit-Position: refs/heads/master@{#476229}

Several background classes needs file metadata to perform their tasks.
However, Metadata cache was only available to foreground classes. Also,
lifetime of foreground metadata cache is tied to windows, so we have to
maintain separate Least Recently Used cache in the background.
As having separate cache for several background classes is inefficient,
we are going to have global cache class that is shared among them.
This has huge performance impact on slow storage devices such as MTP
conencted ones.

TEST=manually tested.
BUG=716309,712121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856533003
Cr-Commit-Position: refs/heads/master@{#476228}

See https://github.com/w3c/web-platform-tests/issues/5239 for an explanation.

R=domenic@chromium.org, kouhei@chromium.org

Bug: 
Change-Id: I7312e4d774eea1083d2283d8ccbad361bd974d0b
Reviewed-on: https://chromium-review.googlesource.com/519242Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476227}

BUG=728482

Review-Url: https://codereview.chromium.org/2913353003
Cr-Commit-Position: refs/heads/master@{#476226}

It feels strange that if a task is due to run at time t=1.0 and we gave
1s of virtual time budget that that task doesn't run.  This patch changes
that so the task will run by using a fence instead of disabling the queue.

BUG=696001

Review-Url: https://codereview.chromium.org/2909293002
Cr-Commit-Position: refs/heads/master@{#476225}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I124bb0161d23a65028b55c8fdf6a2a54be1793c8
Reviewed-on: https://chromium-review.googlesource.com/517281
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476224}

Previously, |getIconResId| returned 36dp |text| icon, when it was
supposed to return |file| icon. This CL fixes this.

Bug:726611

Change-Id: I8763d313185ae6bdc2854a776f831b4900e7310b
Reviewed-on: https://chromium-review.googlesource.com/517062Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Theresa Wellington <twellington@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476223}

The devices that have FRE enabled shouldn't be allowed to powerwash. This
CL makes the keyboard shortcut for powerwash available only if the device
doesn't have FRE enabled.

BUG=724332
TEST=Manually tested for FRE enabled and FRE disabled functionality.

Review-Url: https://codereview.chromium.org/2898003002
Cr-Commit-Position: refs/heads/master@{#476222}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/de3ade508f3f..861d4a174136

$ git log de3ade508..861d4a174 --date=short --no-merges --format='%ad %ae %s'
2017-05-31 benjhayden Add HistogramSet.createHistogram() syntactic sugar.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ifb7e85f46b6d3e3b28934be63bff20f90ed1a12b
Reviewed-on: https://chromium-review.googlesource.com/520847
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476221}

This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2908643002
Cr-Commit-Position: refs/heads/master@{#476220}

Remove code in LayoutTable and LayoutTableSection for computing outer
borders. Use cells' cached collapsed borders instead.

This is mostly a pure refactoring, except it affects some corner cases:
- Previously collapsed borders for colgroup were not included in table's
  border. See changes to results of
  paint/invalidation/table/cached-change-border-color.html.
- Previously when the row and the table were in different inline
  direction and the the width of some collapsed border was in odd
  number, the distribution of the 1 pixel into half outer and inner
  borders was inconsistent. Now we always give the 1 pixel in the
  same way defined in LayoutTableCell::CollapsedBOrderHalfXXX().
  See changes to results of fast/table/border-collapsing/002.html.

Change-Id: I74e6d9173e5d46933fa7456cb713c370e9e7d464
Reviewed-on: https://chromium-review.googlesource.com/515606
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476219}

BUG=728488
TBR=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2919593006
Cr-Commit-Position: refs/heads/master@{#476218}

I forgot to update this when renaming FrameView to LocalFrameView in
https://chromium-review.googlesource.com/c/516862/

Bug: 637460
Change-Id: I71e6b770746a58cde6e726fe6356c627c5b8d419
Reviewed-on: https://chromium-review.googlesource.com/520825Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476217}

We're adding DISALLOW_COPY_AND_ASSIGN to CompositionMarker in
https://codereview.chromium.org/2908643002 and to SpellingMarker and
GrammarMarker in https://codereview.chromium.org/2911723002, so we should add
it to TextMatchMarker as well for consistency.

BUG=707867

Review-Url: https://codereview.chromium.org/2916753003
Cr-Commit-Position: refs/heads/master@{#476216}

This patch removes the use of PassRefPtr in ComputedStyle where a
PassRefPtr is returned by a function.

BUG=494719

Review-Url: https://codereview.chromium.org/2912043002
Cr-Commit-Position: refs/heads/master@{#476215}

Network traffic annotation is added to network requests of
google_apis/gaia/gaia_oauth_client.cc
google_apis/gaia/oauth2_access_token_fetcher_impl.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2796293003
Cr-Commit-Position: refs/heads/master@{#476214}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3692957d..908a6304

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2916023002
Cr-Commit-Position: refs/heads/master@{#476213}

https://drafts.csswg.org/css-tables-3/#repeated-headers has been updated since
we first implemented them. Respect the new rules such as only repeating headers
if they fit on at most a quarter of the page. We also need to repeat headers
even if only part of a row fits on the page - respecting this rule requires us
to reintroduce allowing nested repeated headers, something that both Edge and
FF do and which is now supported by the spec.

BUG=720620, 675904

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2882043002
Cr-Commit-Position: refs/heads/master@{#476212}

This change is based on the discussion on a chormium-dev
thread titled "ScopedAllowIO ban isn't preventing usage,
it's just annoying people" where jam@ mentioned "Excluding
test files seems like a good change to me."

TEST=tested locally by adding ScopedAllowIO to a random browser test file with and without this change

Review-Url: https://codereview.chromium.org/2911153002
Cr-Commit-Position: refs/heads/master@{#476211}

BUG=727566
TEST=none
TBR=nharper,mattm

Change-Id: I2cc60aa1b3a15d4eb6a3c027a49e5b487dadb4c2
Reviewed-on: https://chromium-review.googlesource.com/520668Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476210}

R=scottmg@chromium.org
BUG=706592, 707029

Review-Url: https://codereview.chromium.org/2913263003
Cr-Commit-Position: refs/heads/master@{#476209}

Previously landed in r474253 but was still flaky. After attempting
various things, it seems impossible to guarantee the behaviour of
interactive_test_utils:: ClickOnView() on Mac when the target window is
inactive. BrowserActionInteractiveTest is just using ClickOnView to
activate the parent browser window anyway so, on mac, do that
explicitly.

Original message: These were never brought up since they were added in
r229777 (2013). How they are disabled is subtle:
BrowserActionInteractiveTest::ShouldRunPopupTest() returns false on Mac
and the test passes.

The linked bug indicates an error that an existing test extension
repros. This CL brings up the test harness (without changing non-test
code) since the tests may yet be flaky on Mac.

The original problem was,
  // TODO(justinlin): Browser window do not become active on Mac even when
  // Activate() is called on them. Enable when/if it's possible to fix.

Resolve this by invoking BringBrowserWindowToFront(browser()) at the
start of the test on mac and explicitly waiting for the popup window to
be reported as active by the OS.

BUG=428044, 726132

Review-Url: https://codereview.chromium.org/2908983002
Cr-Commit-Position: refs/heads/master@{#476208}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e6ad06342efb..de3ade508f3f

$ git log e6ad06342..de3ade508 --date=short --no-merges --format='%ad %ae %s'
2017-05-31 bpastene Revert of devil: Add physical port num to device_status.py (patchset #2 id:20001 of https://codereview.chromium.org/2914063002/ )
2017-05-31 sullivan Fix exception in presubmit when a change has not been uploaded.
2017-05-31 dtu [pinpoint] Rename isolated to isolate.
2017-05-31 bpastene devil: Add physical port num to device_status.py
2017-05-31 rnephew [Telemetry] Add ability to disable stories on android webview.

Created with:
  roll-dep src/third_party/catapult
BUG=719093,719093,713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ie60a7867d795a9b1dd42c9abc256f471a38783da
Reviewed-on: https://chromium-review.googlesource.com/520691
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476207}

This CL makes ScriptLoader use the Modulator of the context document
instead of the element document.
This is consistent with classic scripts for which we use context
document's ScriptController for execution.

BUG=721070

Change-Id: Ib5388e28e91d16b196bb579ee171ac8e0f48ddcc
Reviewed-on: https://chromium-review.googlesource.com/517766
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476206}

With the introduction of wm_public_export.h by commit 3b086a00:
("ui: extract ui/wm/public from aura target"), it now makes sense
to have a more specific name for this export file.

BUG=654078, 308710

Change-Id: I5ebbb50b09a7129b1ac23d1b0da877171551f3d3
Reviewed-on: https://chromium-review.googlesource.com/520762Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476205}

This change adds third_party/openvr so we can target OpenVR on desktop.

As said in README.chromium, this is a copy of files from the OpenVR git repository.

BUG=644793

Review-Url: https://codereview.chromium.org/2754253003
Cr-Commit-Position: refs/heads/master@{#476204}

When issuing raster invalidation, try to pair clients' old visual
rects and new visual rects. If paint invalidation reason is
kIncremental, issue raster invalidation for the difference between
the old visual rect and new visual rect.

BUG=644358

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0b4058a24b868b541b222e579ab093f6b6498631
Reviewed-on: https://chromium-review.googlesource.com/513589
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476203}

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2912273002
Cr-Commit-Position: refs/heads/master@{#476202}