- 06 Nov, 2020 40 commits
-
-
Nico Weber authored
The toolchain we rolled in on Wednesday fixes the underlying bugs. 1. Stop explicitly passing -mcpu=apple-a12. clang now passes this implicitly when handing it `-march arm64 -mmacosx-version=min=...`. (Note: Xcode clang also uses a `arm64-apple-macos` triple and hence apple-a12 with just `-march arm64`. Open-source clang currently defaults to `arm64-apple-ios` and hence apple-a7 with `-march arm64`. I asked about this at https://reviews.llvm.org/D82699#2379434 ). 2. Re-enable fatal linker warnings in arm64 component builds. The symbols that new clang emits no longer trigger ld64 warnings. No intended behavior change (except fewer build warnings in arm64 component builds). Bug: 1119249,1107955 Cq-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: If6a866456461613e46ade36da436991c9d617bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521213Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824991}
-
Kyle Horimoto authored
This function invokes the InjectEndpoint() API from the Nearby Connections library using the Bluetooth medium. It will be used by Phone Hub to inject a Bluetooth address synced via the DeviceSync v2 protocol. Bug: 1106937 Change-Id: I6f0cd533d2d0ed87df5d52394a3135b920329de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494445 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#824990}
-
Anne Lim authored
Bug: 1135847 Change-Id: I62aa52b043558bea86d8b3e481d34a4190dc96e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521697Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#824989}
-
Xiaocheng Hu authored
Bug: 1146543 Change-Id: Ibdc22d9244779fc2318121ab8910d7984453eb4d NoTry: True Tbr: vecore@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523537Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#824988}
-
rbpotter authored
chrome://settings/cloudPrinters is deprecated as of M88. In crrev.com/c/2520081 Print Preview's "Manage" button is being redirected to open the OS printer settings dialog, so keeping the link to that dialog in browser settings also is no longer necessary. Bug: 1144931 Change-Id: I7e84c82124077bd2ca71aea4c4293b633a579a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520331 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824987}
-
Meilin Wang authored
Removes the header status view on top for the onboarding dismiss prompt per spec. Screenshot: https://screenshot.googleplex.com/9a6EphBjLrfBRyP BUG=1106937 Change-Id: Icc66d781f2df91e7fb74cac1cbbd573225def2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522117Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#824986}
-
James Hawkins authored
Change-Id: I4ce4044cc2b8b6d45d67c549f03ebbd863b17730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523394Reviewed-by:
-
Tibor Goldschwendt authored
Otherwise, listener methods can be called on the destroyed new tab page handler object, which could lead to crashes. Bug: 1144317 Change-Id: Ibfc50c3e903377494be804dac2b05fdb57e3344d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522129 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824984}
-
Tanmoy Mollik authored
This string is a duplicate of IDS_SIGN_OUT_AND_TURN_OFF_SYNC. This cl removes it. Bug: 1120581 Change-Id: If797b2a876d51298e856a7ff0f82b22897150aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507810Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824983}
-
rbpotter authored
Bug: 1144931 Change-Id: Ia5822311a43935e2086613c5b2ff0470d342544e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520081 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Mustafa Kurtuldu authored
Original Icon Vector https://drive.google.com/file/d/1YXJbfbBgAlgiEYjNOZFapVcW3GJVbMzh/view?usp=sharing In context https://drive.google.com/file/d/1vlcuejXNc8J3cA3eWuycTL4KpI-QM_KB/view?usp=sharing Updated icon Vector https://drive.google.com/file/d/1lrQBPxEajaW-s8DdGjytduDvFMhrVmsc/view?usp=sharing In context https://drive.google.com/file/d/1I_Ot-Y720ARb37-WjAG70LTayxLyYpSV/view?usp=sharing Bug: 1145643 Change-Id: I07a697a1b7b4f8eec4eba638292501e769637db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518859 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#824981}
-
Patrick Monette authored
Bug: 971272 Change-Id: I9fcde3434c76f8c5529e5be8cca639207cca9eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519765 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#824980}
-
Daniel Murphy authored
This patch adds a check for |locally_installed| in the post-finalize step of the WebAppInstallTask callback chain. Instead of calling InstallOsHooks, it skips that (as the web app is not locally installed). This also updates the TestOsIntegrationManager to store a little more data, and make the TestWebAppProviderCreator take a RepeatingCallback to support multiple profiles. TBR: loyso@chromium.org Bug: 1143023 Change-Id: I18f3864e909980a892f6f669fa4029b098b43d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505685 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824979}
-
John Lee authored
Bug: 1142082 Change-Id: I87d4970e5e20e3f8950e6e5f25b843e9c8fa096c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511857Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#824978}
-
Xiaocheng Hu authored
Bug: 1146526 Change-Id: I336c6989e35b3b25cd9706a843b0d007152d647a NoTry: True Tbr: dominickn@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523480 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Charlie Hu authored
Bug: 1007635 Change-Id: I1664b1ae0e67df52b0553a13e310ea5d42c5d1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520623Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#824976}
-
Charlie Hu authored
|PerfMember::Init| accepts an instance of |base::RepeatingClosure| as its last parameter. Call sites should use |base::BindRepeating|. Bug: 1007635 Change-Id: I7be18e3614984c74767950b0239457be87499328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521777Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#824975}
-
Gavin Williams authored
Create a function for simulating changing a select element in tests. Bug: 1059779 Change-Id: Ia67242113682c12860a2b59bbf370ad0ebbcc21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522120 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#824974}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2cfcb1c1ee9a..876499b090ec 2020-11-06 jacktfranklin@chromium.org Fix triggering search when clearing box with enter key If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b344b8ff1ae71a81eaa65bb6fc54e064133a310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523393Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824973}
-
Etienne Bergeron authored
This reverts commit 8815502e. Reason for revert: The bug is fixed, this code is now useless Original change's description: > Add sanity checks to text properties bounds in RenderText > > This CL is adding sanity check to ensure no components in chrome are > using incorrectly the RenderText API. > > We recently observed a crash (crbug/1124118) that was caused by > setting a property outside of the text bounds. > > The RenderText API assume correct uses of these properties. With this > CL they will be reported as a crash reports. > > Bug: 1142020 > Change-Id: I58d19bbbfeca97ad8425706eb85a825105db9f21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518895 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823866} TBR=msw@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142020 Change-Id: Id5ddc6f9967c267ad6fe6e9be38395d469ff868a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523331Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#824972}
-
Kyle Horimoto authored
This field will be used by Phone Hub to start discovering a remote device for an "out-of-band" connection using a pre-synced Bluetooth address. This CL also makes the fast_advertisement_service_uuid field optional for out-of-band connections. Bug: 1106937 Change-Id: I35845fbf6a4626bfd18fd1e9451f4a18fdaabf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493427 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Avi Drissman authored
Bug: 1145672, 1145792, 1142017 Change-Id: Idfb5ddc8f64a4f55814c5cc67d6852ca2cf3af3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520521 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/973d145df865..16036cf206f1 2020-11-06 kainino@chromium.org Add WGPU_STRIDE_UNDEFINED and update bytesPerRow/rowsPerImage validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I40c0baed49dd1d0314e9cbe6781df7aec1185df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523288Reviewed-by:
-
Kartik Hegde authored
Add the CaptivePortal routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied CaptivePortal changes and successfully ran the CaptivePortal routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=captive_portal). Change-Id: I8eb98621bdfde9efc53357ba05f04affce614139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477523Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#824968}
-
David Black authored
This will make our terminology consistent with UX terminology in the spec and should hopefully clear up some amiguity/confusion that may have arisen due to using the term "item" in a context not directly referring to a holding space model item. Bug: 1142572 Change-Id: I59adbeebbd83f95c1bf377c7941f8b149d6f4448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523059 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824967}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia9fb19d396512f107316176662d08ac9e8f34289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523227Reviewed-by:
-
Ben Pastene authored
The doc includes a number of isolate links, but items in isolate expire after 90 days. So this updates these to a set of new isolate links. Hopefully by the time these new links expire, we'll be on RDB which will have a slightly different debugging flow. This also adds some tips on running the tests locally. Bug: None Change-Id: Ib6244f787d2a914b7c3a79aaba2a33b688d346c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522409Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#824965}
-
David Black authored
Previously finalization was not being handled. Bug: 1142572 Change-Id: I73b4ee49ab22a0326e877d71a0627fad046d8d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522682Reviewed-by:
-
cfredric authored
Bug: 1146217 Change-Id: I59fda9bb717fad0fe19dc557461b1ca763f436a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522895 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#824963}
-
Kyle Horimoto authored
Each Core object is meant to be used by a single client, so we will use one for Nearby Share and one for Phone Hub. Each Core instance uses the same underlying connectivity framework, so we instantiate a single OfflineServiceController and share it with all Cores. This CL also adds a service_id parameter to each mojom::NearbyConnections function so that we can decide which Core object to use to process each call. Bug: 1106937 Change-Id: Ibbf8378822862579b79321689dd00a61d204fb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495878Reviewed-by:
-
Koji Ishii authored
|Paint()| supported block fragmentation in r824316 <crrev.com/c/2515429> by assuming |LayoutNGBlockFlowMixin| functions cannot support block fragmented objects, but support block fragmentation by making sure we traverse only fragment tree. This patch applies the same pattern to |FirstLineBoxBaseline| and |InlineBlockBaseline|. Because these functions in |LayoutBlock| traverses |LayoutObject| tree, existing tests hit the DCHECK when the fragment does not have a baseline but |LayoutObject| has children. This patch copies the logic from |LayoutBlock| without checking |LayoutObject| tree. Already common code between |LayoutBlock| and |LayoutBlockFlow| is extracted to share. Bug: 1061423 Change-Id: Id4b9430c8c9ede00212664e80f305d2bb06b6563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515933Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#824961}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e6cf66ee522..62efc005477d 2020-11-06 vapier@chromium.org pylint: upgrade to 2.6.0 2020-11-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-05 vapier@chromium.org pylint: switch to standard wheels 2020-11-05 vapier@chromium.org pylint: stop forcing vpython interp 2020-11-05 morg@google.com Promote grunt-arc-r as critical in RVC PFQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I193c3c511a32ef3d6f3d0349ce6a4c4510b836cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523094Reviewed-by:
-
Andrew Grieve authored
This reverts commit 7f7b0e87. Reason for reland: Updated allow-list Original change's description: > Revert "Android: Check R8 output for references to missing symbols" > > This reverts commit 67f02bba. > > Reason for revert: The new check breaks the android build on perf waterfall, e.g.: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/240223 > > Original change's description: > > Android: Check R8 output for references to missing symbols > > > > javac prevents missing symbols via compiler errors, but they > > can still occur by including prebuilts with incomplete deps, > > or by using jar_excluded_patterns to remove a class that is > > actually used. > > > > Bug: 1142530 > > Change-Id: Idebb28c9e1133d9021d899c570e35a5ff16d5f14 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510236 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824739} > > TBR=agrieve@chromium.org,pkotwicz@chromium.org > > Change-Id: I20033723611ea07fcae98b7824402da89001dd8c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1142530 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523395 > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> > Cr-Commit-Position: refs/heads/master@{#824954} TBR=agrieve@chromium.org,pkotwicz@chromium.org,wenbinzhang@google.com NOTRY=true # Already went through CQ in different CL. Bug: 1142530 Change-Id: I52ccfacc28c38db741d08ba10d00bb133ca89004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523532 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824959}
-
Sajjad Mirza authored
Bug: 1090653 Change-Id: Ie233b9d9c6433a5e62d3f83177319132c937107e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523356Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Elizabeth Popova authored
Due to Focus/Keyboard Navigation Changes in Android P+ initial focus is no longer assigned which causes the keyboard not to be shown on Android P+. This behavior was fixed by: - triggering default focus programatically (no-op on pre Android P) - showing keyboard only after the focus is set Bug: 1144129 Change-Id: Ib7539ba307e62c7c00a66ae088e9ffe15a45a4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510211Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#824957}
-
Mohsen Izadi authored
Generally, event handling code that fully handles an event moves the metrics object to `EventsMetricsManager` as it does not need it anymore. However, `EventsMetricsManager` currently saves a copy of the object to be sent to `CompositorFrameReporter` to be reported. It can instead move the object in which case `cc::EventMetrics` does not need to be copyable anymore. Some tests that take advantage of copyability of `cc::EventMetrics` need to be updated, too. Bug: 1054009 Change-Id: Iafdb1346ea96a1e962de4c61e962bc1a51066a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518916Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824956}
-
Andrew Xu authored
This reverts commit 9e285c75. Reason for revert: The original CL does not cause the issue. So reland it. Original change's description: > Revert "[Multipaste] Speak a11y announcement when delete button is focused" > > This reverts commit a2c9272d. > > Reason for revert: suspect this cl causes build failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21195 > > Original change's description: > > [Multipaste] Speak a11y announcement when delete button is focused > > > > This CL does two things: > > (1) Ignore the MenuItemView instance in accessibility events handling. > > Then we can customize accessibility behaviors of the multipaste menu > > in ClipboardHistoryItemView class. > > > > (2) When the delete button gets the pseudo focus, the accessibility > > side is notified. > > > > Bug: 1145773 > > Change-Id: Ibd73b04637b89cc8200ca2f74721a10a44e857c4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513502 > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: Andrew Xu <andrewxu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824561} > > TBR=newcomer@chromium.org,andrewxu@chromium.org > > Change-Id: I999c30afd42fa4c703f506a536fd736bcbfb48df > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1146255 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523237 > Reviewed-by: Tina Wang <tinazwang@chromium.org> > Commit-Queue: Tina Wang <tinazwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824885} TBR=newcomer@chromium.org,andrewxu@chromium.org,tinazwang@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1146255 Change-Id: I66e9612bb47f5f3196d8f800e6221cb0a3a201fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523471Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824955}
-
Wenbin Zhang authored
This reverts commit 67f02bba. Reason for revert: The new check breaks the android build on perf waterfall, e.g.: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/240223 Original change's description: > Android: Check R8 output for references to missing symbols > > javac prevents missing symbols via compiler errors, but they > can still occur by including prebuilts with incomplete deps, > or by using jar_excluded_patterns to remove a class that is > actually used. > > Bug: 1142530 > Change-Id: Idebb28c9e1133d9021d899c570e35a5ff16d5f14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510236 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824739} TBR=agrieve@chromium.org,pkotwicz@chromium.org Change-Id: I20033723611ea07fcae98b7824402da89001dd8c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523395Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#824954}
-
Michael Bai authored
Bug: 1145964 Change-Id: I7cf1fbb239ec0a97e69e4d6ea2e15015ecb5fd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521972Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#824953}
-
Quinten Yearsley authored
This builder runs the tricium_simple recipe, which runs all simple legacy analyzers for chromium. In the future, adding or modifying simple legacy analyzers would involve a change to this recipe instead of a change to the tricium config. Bug: 1105239 Change-Id: I96e2846f57c859ac4d2ca142dbeb5ca69379bc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521848Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#824952}
-
