- 26 Jul, 2020 40 commits
-
-
Ian Kilpatrick authored
Bug: 958381 Change-Id: I702af63724bac4962258186b089940f3f397c9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295834 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791670}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e861108bc656..72837dd225e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I6787c81c64b9297b0d26c19485d27c53e8f4c1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319712Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791669}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bef908ee7878..8adc54693b70 2020-07-26 syoussefi@chromium.org Vulkan: Generate mipmap in compute If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I830aee8c4f2e8f8e756d7effec6df74e69043057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791668}
-
Xiyuan Xia authored
It turns out the problem is not with the display smoothness test itself. It is introduced by my CL:2132683 that attempts to fix acceleratorTest. It wraps chrome.test.succeed() in a setInterval callback. On slow bots, chrome.test.succeed() could be called more than once. As a result, tests could be invoked prematurely before the previous one finishes. This causes the problem for startSmoothnessTrackingExplicitDisplay because only one tracking per display is allowed hence it could only run after the previous startSmoothnessTracking finishes. This CL changes to setTimeout instead of setInterval to avoid checking test end condition multiple times during getAppWindowList call. It also moves chrome.test.succeed() out of timeout callback to ensure it is only called once. Bug: 1098886, 1108515 Change-Id: I8c04dc4d66f54bb28e8f3d407941083e89796b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316410Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791667}
-
Maxim Kolosovskiy authored
Bug: 1095627 Change-Id: If0b2ce840067480b4847a558b57b04c82ae8abff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310529 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#791666}
-
Ian Kilpatrick authored
As above - this only existed for modifying the baseline position on radio/checkbox for MacOS previously. With the form controls refresh launched this is no longer nessecery. Change-Id: I87091516980dec70287231045f1248bf1ce83aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225375 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#791665}
-
dpapad authored
Bug: 1101598 Change-Id: Ic83fc7e442158942a62feb8584471007447468c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309031 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791664}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595762871-f57a18dae0d23eb5476a17afe73c8569c909d4b4.profdata to chrome-mac-master-1595785360-983d9025ff958d5a15a6c9927ca675e304475be4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I948d15d4b2029df033244f1b810bda3e237dce06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319707Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed1310e11068..e861108bc656 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ifb870c572a2d846344b85528461d8c71a9bdb3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319264Reviewed-by:
-
Yuke Liao authored
Bug: 816629, 1104318 Change-Id: I1280691aa11ba42b39af2fcc1534173eada2ce69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315422 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#791661}
-
Daniel McArdle authored
The new fuzzer exercises content_settings::PatternParser::Parse and ToString, which previously had no fuzzer coverage. In addition to exercising the code, the fuzzer checks the "recanonicalization is idempotent" property. Coverage report: https://chromium-coverage.appspot.com/reports/789509_fuzzers_only/linux/chromium/src/components/content_settings/core/common/content_settings_pattern_parser.cc.html Change-Id: Id4c62f3851257b678f102f63cf4b80c63fe53a8b Bug: 1108821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308232 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791660}
-
Rushan Suleymanov authored
This change is needed to resolve possible cyclic dependency between sync/driver and gcm_driver components (for the new sync invalidations component). Most of changes are trivial and just rename included folders. Bug: 1102305 Change-Id: I05301274e06aa896fcb5646c58e11dabbc2101a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312416Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#791659}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/392da6ba3027..53453f76b5d0 2020-07-26 herb@google.com split transformed mask from SDFT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I0eb89a999cdde898db8fe7a99ff7189584587817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319263Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I5231aa8d22f658a01cb5d98fb58081e33bcc5202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319686Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791657}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595743199-2ae9238defd87beaa44a6caba317a80f7d0a5f76.profdata to chrome-win64-master-1595762871-f2fc22bdf1dd8f288d28123992fa5967a6d5fda0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie895fa360d19452f3a8c7e8feb6d200596560b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319261Reviewed-by:
-
Ian Kilpatrick authored
This patch improves the performance of lots of floats within a single formatting context. Previously when we built the DerivedGeometry (the data-structure used for querying information), we naively placed all floats into this data-structure (which is relatively expensive to build). This introduced a performance regression in the site within crbug.com/1081477 . This patch introduces a "ceiling" for the DerivedGeometry class, that is the highest block-offset it is used to answer queries for. It is extremely rare to go "backwards" and query for something higher than what we've just created. This is used to only all floats below this ceiling substantially reducing the cost of building the DerivedGeometry. Added floats_show_hide.html which has improved 50% locally. On the real world site there is approx. a 20x improvement. Bug: 1081477 Change-Id: I7b3ced903e2218f13a852bb6487271afd50d30d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313476 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#791655}
-
Gavin Williams authored
ChromeVox will announce the dropdown as a button and the numbered position of each destination in the dropdown. Bug: 1059607 Change-Id: I2cf48a9daaba4cf6099d0bef819b46bda7d89215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310840 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If3be2ddc9846b35888b5ac6174ff0eb9fe4ca9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319260Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0ffac8f25150..3b2cd31c7400 2020-07-26 capn@google.com Update Vulkan headers to version 1.2.148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4b8220aad62a2b2e8c889f6e78fa37cb00836bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319257Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0af0cc63711d..ed1310e11068 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Icfae6b93353be9239f1dc2aedfb0eae2bf12cc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319256Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595548091-fbf1089422fe94cc098aa428bb435f8d7f2c1e43.profdata to chrome-win64-master-1595743199-2ae9238defd87beaa44a6caba317a80f7d0a5f76.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I40625c8a60ae644000a5854500410a9359decfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319529Reviewed-by:
-
Chris Harrelson authored
This fixes a typo in the original patch that missed a negation of IsLayoutView. See diff with patchset 1: https://chromium-review.googlesource.com/c/chromium/src/+/2319409/1..3 Tests: paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html (on high-DPI) Bug: 1100711 Change-Id: I54f4e05494ee2fda4dafac74a92b67a8bc756c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319409 Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791649}
-
Yuki Shiino authored
Change-Id: I5e2f56fcad692d0a1b8c5cfaaeb7cdf824377c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313616 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#791648}
-
Aya ElAttar authored
Changed ClipboardDataEndpoint to support virtual machines, like Crostini, PluginVM, ARC++ as potential sources or destinations of the clipboard data. Bug: 1103217 Change-Id: I3ff721a8fbc685adfb5779b1edb579da4062ff24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315030 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791647}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4eaf6d79edfa..0ffac8f25150 2020-07-26 capn@google.com Refactor native instruction intrinsics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2515aab4ab065557300760d403ae60ad7024f89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319549Reviewed-by:
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 1106699 Change-Id: Id83d2e9bb3cb147da6363981cd7ac20a6daa956a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316207 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#791645}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595743199-22efd79a8f382cf756210a15cbf2b66a618fb4f9.profdata to chrome-mac-master-1595762871-f57a18dae0d23eb5476a17afe73c8569c909d4b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4361c7a0307867d7b3afd5c965f10ff229ade979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319254Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/257412e085dc..0af0cc63711d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Id872e624b022d7a3ffad35b8157d4f77a04c089f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319548Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74b3eb7a..374acd70 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I245af2fc69b8dc279b080a689c386512794f9af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318929Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791642}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b6b2984f40d..257412e085dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I27630f759753f7fad482b42a3284f82a7261f9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319530Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15292955fea1..392da6ba3027 2020-07-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I8ba7324050c31dffaac6244f1548f81cbf975f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319528Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibc03e36080ee24048ed47704f23095da334388a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319527Reviewed-by:
-
Lei Zhang authored
As explained by jdoerrie@ here: https://crrev.com/c/2253564/4/base/pickle.cc Change-Id: Ie36ac8f031d261819a9e9226f7226be1b6247898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315418 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791638}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cba20b21bdac..8b6b2984f40d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Id029875c2cd8fedffe891adb92f9574801b479a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319457Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595699927-ce7b3c1cfa4d0f0111933ec52963fcbdda760fdb.profdata to chrome-mac-master-1595743199-22efd79a8f382cf756210a15cbf2b66a618fb4f9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1840bd1c25a02956cb8076e5a4ab2651e71ee95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319458Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4ceefeb36e0e..e490afec61da 2020-07-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9735912fda1e9b4c57ec5d27f828a8cfd9065cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319451Reviewed-by:
-
Anupam Snigdha authored
Text service framework(TSF) on Windows platform already triggers a focus call to the top level HWND that should receive keyboard focus. This happens in |TSFBridgeImpl::OnTextInputTypeChanged| and |TSFBridgeImpl::UpdateAssociateFocus| where the thread input manager sets focus on the HWND by calling |SetFocus| and |AssociateFocus| respectively. |RenderWidgetHostViewEventHandler::SetKeyboardFocus| explicitly calls |::SetFocus| on the HWND that leads to side-effects when narrator is active as it intermittently switches focus to the legacy HWND that results in VK dismissal and also puts the state machine of the VK in a weird state. Calling |::SetFocus| also has perf implications as TSF listens to this API call and does a reentrant call to Chromium to fetch document states. I tested both hardware and virtual keyboard with this change and I don't see any obvious issues. Removing this call also fixed the accessibility issue where the VK was getting dismissed after first keystroke. Bug: 1106556 Change-Id: If8146d2b97a36799a8ade1c514fb238c67e76b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314980Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#791634}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie2f41726c302e5755445d3fab6418f06d4cd3eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319412Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61f247378358..cba20b21bdac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I053fbc0940d7567aa93c379d992188b12d1ba19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319449Reviewed-by:
-
Xing Liu authored
This CL fixes a bug that download may disappear on Android Q after they are completed. We query and cache the display names from media store only when there are more than 0 in progress downloads. So the cache might be empty and we use the cache for completed download as well, which result in missing display name and download history db recorded being removed. Also directly check Android version in c++. The current code loads Q API when loading Java static methods in DownloadCollectionBridge, which triggers disk read violation on Android P. Bug: 1106286 Change-Id: I2338a665a2147154ffd20df447fe74b84a8c8738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314299 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#791631}
-
