- 23 Apr, 2019 40 commits
-
-
Kurt Horimoto authored
This is done to clearly separate the public interface of OverlayManager from its internal implementation files. Setting the "public" gn variable for the target ensures that files that depend on overlays are only allowed to include those files. Bug: 941745 Change-Id: Ie9f905a857bd268c535804b3243321b6721d7c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562719 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#653409}
-
jonross authored
We are interested in coverage of SkiaRenderer. This change adds a SkiaRenderer variant of blink_web_tests. This will be ran on "GPU FYI Linux SkiaRenderer Vulkan (NVIDIA)" bot of the GPU.FYI. We will not be running the full test suite, due to capacity concerns raised in an earlier review: https://chromium-review.googlesource.com/c/chromium/src/+/1500784 Instead a subset of tests which have detected regressions in the past will be ran. Combined with a random selection of other tests from the folders most impacted by SkiaRenderer. Test = skia_renderer_blink_web_tests Bug: 946770 Change-Id: I6e1091af816a41798a3e62c24449ad5bbd4d0c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576332Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#653408}
-
Toni Barzic authored
Adds tests for assistant opt-in flow that's shown during in-session OOBE. The tests focus on interaction between assistant opt in flow UI and assistant settings service, which is faked for the purpose of this test. (In other words, main focus was logic in assistant_optin_flow_screen_handler). This adds logic to log in a user to LoginManagerMixin - assistant opt-in flow expects a regular user to be logged in. Each test first logs in a regular user, and then starts login wizard with assistant optin flow UI. Change-Id: I5305e6d2079099f35de899162433f2bd34f162d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574948 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653407}
-
Nina Satragno authored
This prevents a minor security issue where the hostname of the RP would have its tail end cut. Bug: 893258 Change-Id: Ib227f6be8f274a2ddf78917597c217807bba01ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579459 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#653406}
-
Sébastien Séguin-Gagnon authored
Bug: 946224 Change-Id: I2cc565d1e855190c62bdcce42217a8ca003194e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579421 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653405}
-
Kyle Milka authored
A few of these properties were only used on the remote NTP, so they can now be removed. Bug: 583289 Change-Id: I9b3270ec20ced7891796ca9d296e20a1f157f019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576032Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#653404}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9616947a9374..9b65a0c0b4b1 git log 9616947a9374..9b65a0c0b4b1 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9b65a0c0b4b1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2452dcd17feeea0c18eb631e35e89a6523720c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653403}
-
Vikas Soni authored
Update VideoBacking to account for gpu memory only when the backing is bound to a texture. This is because there can be video frames which gets created but the underlying backing/image never gets bound to a texture. Hence only creating a video frame/backing should not account for gpu memory tracking. Bug: 953727 Change-Id: I3eb5ff119e8fb3c1c598d43de3528c694e573fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576267Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#653402}
-
Bailey Berro authored
- Introduces a PrintersMap class to keep track of printers. Will replace the vector of vectors currently used by CupsPrintersManager. Change-Id: I2328eb2e8c2049b30036d4b599fb27c672c18225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572641Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#653401}
-
Pavel Yatsuk authored
******************************Resource Sizes Diff****************************** Specifics: +73,760 bytes main lib size +209,044 bytes main dex size +499,660 bytes secondary dex size +1,128,615 bytes normalized apk size InstallSize: +422,512 bytes APK size +1,251,695 bytes Estimated installed size (Android Go) +3,285,676 bytes Estimated installed size InstallBreakdown (+3,284,366 bytes): +4,010 bytes Native resources (no l10n) size +2,688 bytes unwind_cfi (dev and canary only) size +2,749 bytes Non-compiled Android resources size +73,760 bytes Native code size +736 bytes Package metadata size +3,172,315 bytes Java code size +28,108 bytes Compiled Android resources size Dex: +4,827 entries fields +6,819 entries methods +2,316 entries types +4,995 entries strings R=pnoland@chromium.org Change-Id: I529fa3f387880590824ca91da6cb827bf9f13757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579580Reviewed-by:Patrick Noland <pnoland@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#653400}
-
Ben Chan authored
WiMAX support is deprecated along with daisy. This CL removes the wimax-status entry under chrome://system and the corresponding debugd GetWiMaxStatus D-Bus binding. Bug: 954635 Test: Verify that chrome://system no longer fetches wimax-status from debugd. Change-Id: Iafa7900dcee718593ef7cbb223d51bec2986d32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577631 Auto-Submit: Ben Chan <benchan@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653399}
-
Alexei Filippov authored
ReceiverPipe is gone. Reenable the test. BUG=944429 Change-Id: I281c94bd276d00a6707ba6ff65b8c4cf0d2ebcb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579464Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#653398}
-
Matt Menke authored
We're working on removing SocketParams. Instead, pass the annotations directly to the SocketPool as part of a request. Bug: 955125 Change-Id: If124df4de192b6682119b570a33c61ebf18c9e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578059 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653397}
-
Peng Huang authored
Bug: None Change-Id: I0a5611aab2e7f198c361e2c7746192099d9bd54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579465Reviewed-by:
-
Kurt Horimoto authored
This CL adds the public interface for OverlayManager, which adds the OverlayRequests supplied to AddRequest() to the OverlayRequestQueue for that WebState. OverlayManagers are fetched based on their OverlayModality, which specifies the modality of the UI delegate's view controller presentation context. Bug: 941745 Change-Id: Idc71632131908814cabd5f5c4e7a787de13a41e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555335 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
WorkerClassicScriptLoader takes fetch client's ResourceFetcher that provides fetch client's AddressSpace, so it doesn't have to take AddressSpace as a param. Bug: 878274, 945215 Change-Id: I3ca0ccc7834522fc627f7af746fc6d632629d7eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578145 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653394}
-
John Lee authored
Bug: 955610 Change-Id: I29d2104b74682c458b741c2b771386528ff57d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579365Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#653393}
-
Tommy C. Li authored
Bug: 929477 Change-Id: I35ca181a114c5051dedad1843adf6bd15f4413bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579251Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#653392}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c3de1750970..8f48a01dffbb git log 0c3de1750970..8f48a01dffbb --date=short --no-merges --format='%ad %ae %s' 2019-04-23 simonhatch@chromium.org Dashboard - Remove bisect_report Created with: gclient setdep -r src/third_party/catapult@8f48a01dffbb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:876899 TBR=crouleau@chromium.org Change-Id: Ib4f378e9a4e687f049fc77c79e5c48728c4f19af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579679Reviewed-by:
-
Sebastien Marchand authored
The SessionRestore.BackgroundUseCaseTabCount.* histograms seems to indicate that more "background use case tabs" are restore than exist in general, which should never happen. It's not clear if it's caused by some noise in the metrics or if it's really an issue, this DCHECK will hopefully give us more data on this. Bug: 915714 Change-Id: I38abcb6252abc866064de1a9c48ed7cda9de4cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579425 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#653390}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/ffabb1ae86cc..3dc9202f78a3 $ git log ffabb1ae8..3dc9202f7 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 no-reply [leveldb] Specifically export the WriteBatch::Handler inner class for Windows link 2019-04-15 cmumford Check for possibly invalid offset in test. 2019-04-13 cmumford Changed Windows specific highlighting from bash to cmd. 2019-04-12 cmumford Initialize class members to default values in constructors. Created with: roll-dep src/third_party/leveldatabase/src Change-Id: I28ed8e909a29212465eab115a9617d9a5c5047bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578596 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#653389}
-
Leonard Grey authored
This gets tricky lifetime-wise when UIDevTools is re-enabled, depending on the exact ordering, whether any widgets were created or destroyed while disabled, etc. Let's just start with a clean slate every time. Change-Id: I7cb50c2219e0e5c62504791ad7b56bedfac45dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570647 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#653388}
-
Shakti Sahu authored
IPH bubbles should be dismissed when user opens the app menu. This wasn't previously happening as we missed adding it to AppMenuButtonHelper. Moved the logic to a more central place in AppMenuHandler. Bug: 954341 Change-Id: I36f171c6327047d9bca33a12567693adf09d81f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578186Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#653387}
-
Antoine Labour authored
- TestGLES2Interface has support for share groups, including on different threads. We haven't been using share groups in a very long time. - Remove support for storing state (including pixels) in TestTextures - we never read that state. Remove TestTextures altogether. - Remove many empty functions in TestGLES2Interface - Don't create "external texture" resources on a child context, as we never look at anything but the mailbox/sync token. Just generate those. Bug: None Change-Id: Ib7a29a1f177d8f9679620484f8b0e6adc8f81703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576226 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653386}
-
Yue Li authored
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome Bug: b/129156659 Test: Local build Change-Id: I603899c62a4c1e6aa4901442638a219d40d3229b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568686 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#653385}
-
Mike Klein authored
This reverts commit afbb99bf. Reason for revert: will break build Original change's description: > Roll src/third_party/skia 29c1c8029a52..1f4c2bdfa2c1 (7 commits) > > https://skia.googlesource.com/skia.git/+log/29c1c8029a52..1f4c2bdfa2c1 > > > git log 29c1c8029a52..1f4c2bdfa2c1 --date=short --no-merges --format='%ad %ae %s' > 2019-04-23 mtklein@google.com sort, dedup skia_public_includes > 2019-04-23 mtklein@google.com inject SkUserConfig.h with -DSK_USER_CONFIG_HEADER > 2019-04-23 mtklein@google.com another stray <include> -> "" > 2019-04-23 ethannicholas@google.com added support for interpreting generic SkSL functions > 2019-04-23 mtklein@google.com are these include paths no longer needed? > 2019-04-23 herb@google.com Only call findImage when needed > 2019-04-23 mtklein@google.com switch some idiosyncratic <includes> to "" > > > Created with: > gclient setdep -r src/third_party/skia@1f4c2bdfa2c1 > > The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=mtklein@chromium.org > > Change-Id: I6df4435268acbb8ddba0121ee6c397c85c95d284 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577574 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#653382} TBR=mtklein@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Ic2144340f24989ffc2b05b0523fcd1dfb3827e94 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580044Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#653384}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/652edcc30204..451cad2c0da4 git log 652edcc30204..451cad2c0da4 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 chrisforbes@google.com Only do centroid sampling if multisampling 2019-04-23 chrisforbes@google.com Remove more stale renderer plumbing 2019-04-23 chrisforbes@google.com Wire up alphaToCoverage support 2019-04-23 chrisforbes@google.com Unify template-based and classic descriptor writes 2019-04-23 chrisforbes@google.com Add support for indexing into arrays of image descriptors 2019-04-23 chrisforbes@google.com Clean up storage image descriptor access Created with: gclient setdep -r src/third_party/swiftshader@451cad2c0da4 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118386749,chromium:b/118386749,chromium:b/118386749,chromium:b/123244275,chromium:b/131082089,chromium:b/131082089 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4d84e339d929b09b3d47354d5e752ceba5e9bb30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579442Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/29c1c8029a52..1f4c2bdfa2c1 git log 29c1c8029a52..1f4c2bdfa2c1 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 mtklein@google.com sort, dedup skia_public_includes 2019-04-23 mtklein@google.com inject SkUserConfig.h with -DSK_USER_CONFIG_HEADER 2019-04-23 mtklein@google.com another stray <include> -> "" 2019-04-23 ethannicholas@google.com added support for interpreting generic SkSL functions 2019-04-23 mtklein@google.com are these include paths no longer needed? 2019-04-23 herb@google.com Only call findImage when needed 2019-04-23 mtklein@google.com switch some idiosyncratic <includes> to "" Created with: gclient setdep -r src/third_party/skia@1f4c2bdfa2c1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I6df4435268acbb8ddba0121ee6c397c85c95d284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577574Reviewed-by:
-
Jared Saul authored
I opted to use ".has_value() &&" instead of ".value_or(~)" in some places for generally readability reasons. We don't want to log certain metrics or strikes if the value was missing (which SHOULD almost never happen, but rare race conditions are possible) and I don't want to switch between _or(true) and _or(false) as necessary in those situations. Change-Id: Ieec56f5cdf9cae8855b17d49ed78a9850a2a8c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576107Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653381}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cff6f150eae1..83740f979584 git log cff6f150eae1..83740f979584 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 cnorthrop@google.com Android: Add ANGLE version to logcat Created with: gclient setdep -r src/third_party/angle@83740f979584 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I2f95c3689393ce5488e943f9e4a2f8f6fd9c9ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579440Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/643152926e86..d366d8c98e1b Created with: gclient setdep -r src-internal@d366d8c98e1b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I1c98deb6ca87dbd0d128f4fcc0f99cb8b25bdcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653379}
-
rajendrant authored
Warmup url fetch happens on startup and depending on whether it succeeds the http/https proxy should be enabled or disabled in the custom proxy config in network service. However the proxies are not getting disabled. This CL fixes that and also adds a feature flag to turn off this behavior. Bug: 954958 Change-Id: I22f0dc4cfb0ef58b4922ecfe9ba57009744aba8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579026Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#653378}
-
Yusuke Sato authored
BUG=921357 TEST=try Change-Id: I05b426832e5de4d1a2d5d340b408fdc06e9b97ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579560 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#653377}
-
Anastasia Helfinstein authored
Bug: 955201 Change-Id: Ib6a1d94d342696a370a17ed62852d8f7b7f39d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578119Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#653376}
-
Stephen McGruer authored
In the current, non-threaded design, the DocumentPaintDefinition is created in the global scope and passed to CSSPaintImageGeneratorImpl where it is used directly from main-thread call-points. This doesn't work for the threaded-worklet case, where the global scope runs on the worklet thread. Instead, the PaintWorkletProxyClient is responsible for gathering and detecting incompatible definitions. Once a valid set of definitions is received from all global scopes, a thread-safe version is created (MainThreadDocumentPaintDefinition) and passed cross-thread to the PaintWorklet instance on the main thread. That main thread version can then be used for main-thread call-points (not done in this CL). Bug: 946519 Change-Id: Ic150c42ae5d93610aec1e75ebf1117500441693b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576501Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653375}
-
Mike Wittman authored
Uses a separate V8Unwinder object for each profile collection. This is required because of the unwinder's use of the ModuleCache, which is also scoped to the profile collection. To support this change auxiliary unwinder ownership is moved from ThreadProfiler to StackSamplerImpl. Bug: 909957 Change-Id: Idc78d6be2bbff6bbb52240ee647b28b9915ac962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577787 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653374}
-
Joey Arhar authored
This patch also enables importing of the newly exported WebSocket messages Bug: 496006 Change-Id: I000468d266a570ca46eaa62ac9d7554713896acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574606Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#653373}
-
Edwin Joe authored
There are some cases where an elapsed timer that can be paused is useful. An example case is recording surface embedding time to UMA metric. Currently, the surface embedding time is recorded by simply taking the different between the TimeTicks of the surface id allocation time and the TimeTicks of when Surface::OnWillBeDrawn is called. However, it is possible that surface id is allocated when the Renderer is not visible, i.e. when the child changes size while hidden. In this case, the surface embedding time will be arbitrarily inflated since Surface::OnWillBeDrawn will not be called until it becomes visible. By using a pausable elapsed timer, the surface embedding time can be paused if the renderer is hidden, and resumed when it becomes visible again. Bug: 949967 Change-Id: Ide8e5b67a06bae7d3ca1352574c477f35e32369c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576331Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#653372}
-
Daniele Castagna authored
When the backdrop rect for a render pass is empty, gl_renderer currently sets use_shaders_for_blending to false, disregarding if the render pass blend mode is supported by the underlying graphics API. If it's not supported, a DCHECK is later hit when setting up alpha blending. This patch sets the blend function to kSrcOver in those cases where the backdrop rect is empty. The backdrop rect should be empty only in cases where the render pass draw quad is completely clipped. In the test case found by cluster fuzz the element has a clip-path: polygon(3px 0px, 35px 1px) that limits the render pass output rect. When computing the backdrop rect we intersect it with the render pass output rect resulting in an empty rect. Bug: 946464 Test: https://clusterfuzz.com/testcase?key=5140838366707712 Change-Id: Ie8a487a4f85c3a69ab4f809fc1ade1a71bdaaeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576233Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#653371}
-
Toni Barzic authored
Fixes a race where auto-enrollment screen would just hang if the auto-enrollment check triggered in posted EULA steps reported connection error, or server error before the auto enrollment check screen was started. The AutoEnrollmentController would report in complete state, but requests to (re) start auto-enrollment checks would be ignored due to client_ already being set. BUG=894384 Change-Id: Idd770f3e9d437a0a80df0e6243fc200dc6ae3e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576144 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#653370}
-
